Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLS Picker Swagger changes for Service Bus #17738

Closed
wants to merge 3 commits into from
Closed

TLS Picker Swagger changes for Service Bus #17738

wants to merge 3 commits into from

Conversation

v-Ajnava
Copy link
Member

@v-Ajnava v-Ajnava commented Feb 9, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @v-Ajnava Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 9, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/AuthorizationRules'
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L37
    ❌ R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/AuthorizationRules/{authorizationRuleName}'
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L85
    ❌ R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/AuthorizationRules/{authorizationRuleName}/listKeys'
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L234
    ❌ R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/AuthorizationRules/{authorizationRuleName}/regenerateKeys'
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L282
    ❌ R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/queues/{queueName}/authorizationRules/{authorizationRuleName}/ListKeys'
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L545
    ❌ R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/topics/{topicName}/authorizationRules/{authorizationRuleName}/ListKeys'
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L865
    ❌ R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.ServiceBus/CheckNameAvailability'
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/CheckNameAvailability.json#L37
    ❌ R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/disasterRecoveryConfigs/CheckNameAvailability'
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/CheckNameAvailability.json#L82
    ❌ R4037 - MissingTypeObject The schema 'SBAuthorizationRuleListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L1131
    ❌ R4037 - MissingTypeObject The schema 'properties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L1150
    ❌ R4037 - MissingTypeObject The schema 'properties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/DisasterRecoveryConfig.json#L323
    ❌ R4037 - MissingTypeObject The schema 'properties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/DisasterRecoveryConfig.json#L387
    ❌ R4037 - MissingTypeObject The schema 'properties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/migrationconfigs.json#L315
    ❌ R4037 - MissingTypeObject The schema 'properties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/networksets.json#L229
    ❌ R4037 - MissingTypeObject The schema 'SBSubscriptionListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/subscriptions.json#L254
    ❌ R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/namespace-preview.json#L921
    ❌ R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/networksets.json#L249
    ❌ R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/networksets.json#L256
    ❌ R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/operations.json#L79
    ⚠️ R1003 - ListInOperationName Since operation 'PrivateLinkResources_Get' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/namespace-preview.json#L552
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/Rules.json#L355
    ⚠️ R2007 - LongRunningOperationsWithLongRunningExtension The operation 'Namespaces_Update' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation.
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/namespace-preview.json#L281
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'PrivateLinkResources_Get' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/namespace-preview.json#L548
    ⚠️ R2064 - LROStatusCodesReturnTypeSchema 200/201 Responses of long running operations must have a schema definition for return type. OperationId: 'DisasterRecoveryConfigs_CreateOrUpdate', Response code: '201'
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/DisasterRecoveryConfig.json#L127
    ⚠️ R2064 - LROStatusCodesReturnTypeSchema 200/201 Responses of long running operations must have a schema definition for return type. OperationId: 'MigrationConfigs_CreateAndStartMigration', Response code: '201'
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/migrationconfigs.json#L127
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'upgrade' in:'MigrationConfigs_CompleteMigration'. Consider updating the operationId
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/migrationconfigs.json#L231
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'AuthorizationRules' with immediate parent 'SBNamespace', must have a list by immediate parent operation.
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L1147
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'authorizationRules' with immediate parent 'SBQueue', must have a list by immediate parent operation.
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L1147
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'authorizationRules' with immediate parent 'SBTopic', must have a list by immediate parent operation.
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L1147
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'authorizationRules' with immediate parent 'ArmDisasterRecovery', must have a list by immediate parent operation.
    Location: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L1147
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️❌~[Staging] ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ API Readiness check failed. Please make sure your service is deployed. "code: InvalidResourceType,
    message: The resource type 'operations' could not be found in the namespace 'Microsoft.ServiceBus' for api version '2022-01-01-preview'. The supported api-versions are '2014-09-01,
    2015-08-01,
    2017-04-01,
    2021-01-01-preview,
    2021-06-01-preview'."
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️⚠️Cross-Version Breaking Changes: 201 Warnings warning [Detail]
    The following breaking changes are detected by comparison with latest preview version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/disasterRecoveryConfigs/CheckNameAvailability' removed or restructured?
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/DisasterRecoveryConfig.json#L37:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/disasterRecoveryConfigs/{alias}/authorizationRules' removed or restructured?
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/DisasterRecoveryConfig.json#L366:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/disasterRecoveryConfigs/{alias}/authorizationRules/{authorizationRuleName}' removed or restructured?
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/DisasterRecoveryConfig.json#L417:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/disasterRecoveryConfigs/{alias}/authorizationRules/{authorizationRuleName}/listKeys' removed or restructured?
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/DisasterRecoveryConfig.json#L468:5
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'CheckNameAvailability' removed or renamed?
    New: Microsoft.ServiceBus/preview/2022-01-01-preview/DisasterRecoveryConfig.json#L319:3
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/DisasterRecoveryConfig.json#L520:3
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'AuthorizationRuleNameParameter' removed or renamed?
    New: Microsoft.ServiceBus/preview/2022-01-01-preview/DisasterRecoveryConfig.json#L419:3
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/DisasterRecoveryConfig.json#L783:3
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '204'.
    New: Microsoft.ServiceBus/preview/2022-01-01-preview/DisasterRecoveryConfig.json#L170:11
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L1135:11
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/AuthorizationRules.json#L982:11
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L114:13
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/AuthorizationRules.json#L114:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L129:13
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/AuthorizationRules.json#L129:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L221:13
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/AuthorizationRules.json#L221:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L269:13
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/AuthorizationRules.json#L269:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L311:13
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/AuthorizationRules.json#L311:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L326:13
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/AuthorizationRules.json#L326:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L419:13
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/AuthorizationRules.json#L419:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L434:13
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/AuthorizationRules.json#L434:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L532:13
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/AuthorizationRules.json#L532:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L583:13
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/AuthorizationRules.json#L583:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L628:13
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/AuthorizationRules.json#L628:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L643:13
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/AuthorizationRules.json#L643:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L739:13
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/AuthorizationRules.json#L739:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L754:13
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/AuthorizationRules.json#L754:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L803:13
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/AuthorizationRules.json#L803:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L903:13
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/AuthorizationRules.json#L903:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L948:13
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/AuthorizationRules.json#L948:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L963:13
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/AuthorizationRules.json#L963:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L1147:5
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/AuthorizationRules.json#L994:5
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L1188:5
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/AuthorizationRules.json#L1034:5
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L1229:5
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/AuthorizationRules.json#L1074:5
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.ServiceBus/preview/2022-01-01-preview/CheckNameAvailability.json#L60:13
    Old: Microsoft.ServiceBus/preview/2021-06-01-preview/CheckNameAvailability.json#L60:13
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 9, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-go-track2 - armservicebus - 0.4.0
    +	Function `ErrorResponseError.MarshalJSON` has been removed
+	Struct `ErrorAdditionalInfo` has been removed
+	Struct `ErrorResponseError` has been removed
+	Struct `ErrorResponse` has been removed
+	Type of `Operation.Properties` has been changed from `map[string]interface{}` to `interface{}`
    ❌azure-sdk-for-js - track2_@azure/arm-servicebus - Approved - 6.0.0
    ️✔️azure-sdk-for-go - servicebus/mgmt/2017-04-01/servicebus - v61.5.0
    ️✔️azure-sdk-for-go - servicebus/mgmt/2015-08-01/servicebus - v61.5.0
    ️✔️azure-sdk-for-go - preview/servicebus/mgmt/2022-01-01-preview/servicebus - v61.5.0
    ️✔️azure-sdk-for-go - preview/servicebus/mgmt/2021-06-01-preview/servicebus - v61.5.0
    ️✔️azure-sdk-for-go - preview/servicebus/mgmt/2018-01-01-preview/servicebus - v61.5.0
    ❌azure-sdk-for-python-track2 - track2_azure-mgmt-servicebus - Approved - 7.1.0
    +	Model SBNamespaceUpdateParameters no longer has parameter zone_redundant
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]  
  
    • ️✔️Succeeded [Logs] Generate from 46ff29329c11b113822fb5303aabc34f1f8eb6b4. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/servicebus/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.ServiceBus        [View full logs]         [Preview SDK Changes]      
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]   
  
    • ⚠️Warning [Logs] Generate from 46ff29329c11b113822fb5303aabc34f1f8eb6b4. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh]  New minor version of npm available! 8.3.1 -> 8.5.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.5.1` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-servicebus        [View full logs]         [Preview SDK Changes]        Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model ArmDisasterRecovery has a new parameter location
info	[Changelog]   - Model MigrationConfigProperties has a new parameter location
info	[Changelog]   - Model NetworkRuleSet has a new parameter location
info	[Changelog]   - Model Operation has a new parameter is_data_action
info	[Changelog]   - Model Operation has a new parameter origin
info	[Changelog]   - Model Operation has a new parameter properties
info	[Changelog]   - Model OperationDisplay has a new parameter description
info	[Changelog]   - Model PrivateEndpointConnection has a new parameter location
info	[Changelog]   - Model Rule has a new parameter location
info	[Changelog]   - Model SBAuthorizationRule has a new parameter location
info	[Changelog]   - Model SBNamespace has a new parameter alternate_name
info	[Changelog]   - Model SBNamespace has a new parameter minimum_tls_version
info	[Changelog]   - Model SBNamespaceUpdateParameters has a new parameter alternate_name
info	[Changelog]   - Model SBQueue has a new parameter location
info	[Changelog]   - Model SBSubscription has a new parameter location
info	[Changelog]   - Model SBTopic has a new parameter location
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model SBNamespaceUpdateParameters no longer has parameter zone_redundant
    ️⚠️ azure-sdk-for-java warning [Detail]   
  
    • ⚠️Warning [Logs] Generate from 46ff29329c11b113822fb5303aabc34f1f8eb6b4. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2022-02-19 06:57:55 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-servicebus-generated"
cmderr	[generate.py] 2022-02-19 06:57:55 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2022-02-19 06:57:55 INFO autorest --version=3.6.6 --use=@autorest/java@4.0.50 --java --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/servicebus/azure-resourcemanager-servicebus-generated --java.namespace=com.azure.resourcemanager.servicebus.generated   --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/servicebus/resource-manager/readme.md
cmderr	[generate.py] 2022-02-19 06:58:38 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2022-02-19 06:58:38 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2022-02-19 06:58:38 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2022-02-19 06:58:38 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2022-02-19 06:58:38 INFO [POM][Skip] pom already has module sdk/servicebus
cmderr	[generate.py] 2022-02-19 06:58:38 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-servicebus-generated        [View full logs]         [Preview SDK Changes]      
      cmderr	[Inst] 2022-02-19 07:00:03 DEBUG Got artifact_id: azure-resourcemanager-servicebus-generated
cmderr	[Inst] 2022-02-19 07:00:03 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2022-02-19 07:00:03 DEBUG Got artifact: azure-resourcemanager-servicebus-generated-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2022-02-19 07:00:03 DEBUG Got artifact: azure-resourcemanager-servicebus-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2022-02-19 07:00:03 DEBUG Match jar package: azure-resourcemanager-servicebus-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2022-02-19 07:00:03 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17738/azure-sdk-for-java/azure-resourcemanager-servicebus-generated/azure-resourcemanager-servicebus-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-servicebus-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-servicebus-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-servicebus-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]  
  
    • ️✔️Succeeded [Logs] Generate from 46ff29329c11b113822fb5303aabc34f1f8eb6b4. SDK Automation 14.0.0 
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️servicebus/mgmt/2017-04-01/servicebus        [View full logs]         [Preview SDK Changes]      
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️servicebus/mgmt/2015-08-01/servicebus        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/servicebus/mgmt/2022-01-01-preview/servicebus        [View full logs]       
      info	[Changelog] This is a new package
info	[Changelog]
    • ️✔️preview/servicebus/mgmt/2021-06-01-preview/servicebus        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/servicebus/mgmt/2018-01-01-preview/servicebus        [View full logs]       
            Only show 24 items here, please refer to log for details.
      info	[Changelog] - New function `NamespacesClient.ListNetworkRuleSetsResponder(*http.Response) (NetworkRuleSetListResult, error)`
info	[Changelog] - New function `NewNetworkRuleSetListResultPage(NetworkRuleSetListResult, func(context.Context, NetworkRuleSetListResult) (NetworkRuleSetListResult, error)) NetworkRuleSetListResultPage`
info	[Changelog] - New function `NetworkRuleSetListResult.IsEmpty() bool`
info	[Changelog] - New function `NetworkRuleSetListResultIterator.NotDone() bool`
info	[Changelog] - New function `NetworkRuleSetListResultPage.Values() []NetworkRuleSet`
info	[Changelog] - New function `NamespacesClient.ListNetworkRuleSetsPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `NamespacesClient.ListNetworkRuleSetsComplete(context.Context, string, string) (NetworkRuleSetListResultIterator, error)`
info	[Changelog] - New function `NewNetworkRuleSetListResultIterator(NetworkRuleSetListResultPage) NetworkRuleSetListResultIterator`
info	[Changelog] - New function `*NetworkRuleSetListResultIterator.Next() error`
info	[Changelog] - New function `*NetworkRuleSetListResultIterator.NextWithContext(context.Context) error`
info	[Changelog] - New function `NamespacesClient.ListNetworkRuleSets(context.Context, string, string) (NetworkRuleSetListResultPage, error)`
info	[Changelog] - New function `NetworkRuleSetListResultPage.Response() NetworkRuleSetListResult`
info	[Changelog] - New function `NamespacesClient.ListNetworkRuleSetsSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `NetworkRuleSetListResultIterator.Response() NetworkRuleSetListResult`
info	[Changelog] - New function `NetworkRuleSetListResultPage.NotDone() bool`
info	[Changelog] - New function `*NetworkRuleSetListResultPage.Next() error`
info	[Changelog] - New function `*NetworkRuleSetListResultPage.NextWithContext(context.Context) error`
info	[Changelog] - New function `NetworkRuleSetListResultIterator.Value() NetworkRuleSet`
info	[Changelog] - New struct `NetworkRuleSetListResult`
info	[Changelog] - New struct `NetworkRuleSetListResultIterator`
info	[Changelog] - New struct `NetworkRuleSetListResultPage`
info	[Changelog] - New field `Status` in struct `SBNamespaceProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 25 additive change(s).
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]  
  
    • ️✔️Succeeded [Logs] Generate from 46ff29329c11b113822fb5303aabc34f1f8eb6b4. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armservicebus        [View full logs]         [Preview SDK Changes]        Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `Operation.Properties` has been changed from `map[string]interface{}` to `interface{}`
info	[Changelog] - Function `ErrorResponseError.MarshalJSON` has been removed
info	[Changelog] - Struct `ErrorAdditionalInfo` has been removed
info	[Changelog] - Struct `ErrorResponse` has been removed
info	[Changelog] - Struct `ErrorResponseError` has been removed
info	[Changelog]
info	[Changelog] Total 8 breaking change(s), 0 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]   
  
    • ⚠️Warning [Logs] Generate from 46ff29329c11b113822fb5303aabc34f1f8eb6b4. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh]  created a lockfile as package-lock.json. You should commit this file.
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️track2_@azure/arm-servicebus        [View full logs]         [Preview SDK Changes]        Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface ProxyResource
info	[Changelog]   - Interface Operation has a new optional parameter isDataAction
info	[Changelog]   - Interface Operation has a new optional parameter origin
info	[Changelog]   - Interface Operation has a new optional parameter properties
info	[Changelog]   - Interface OperationDisplay has a new optional parameter description
info	[Changelog]   - Add parameters of ProxyResource to TypeAlias ArmDisasterRecovery
info	[Changelog]   - Add parameters of ProxyResource to TypeAlias MigrationConfigProperties
info	[Changelog]   - Add parameters of ProxyResource to TypeAlias NetworkRuleSet
info	[Changelog]   - Add parameters of ProxyResource to TypeAlias PrivateEndpointConnection
info	[Changelog]   - Add parameters of ProxyResource to TypeAlias Rule
info	[Changelog]   - Add parameters of ProxyResource to TypeAlias SBAuthorizationRule
info	[Changelog]   - Add parameters of ProxyResource to TypeAlias SBQueue
info	[Changelog]   - Add parameters of ProxyResource to TypeAlias SBSubscription
info	[Changelog]   - Add parameters of ProxyResource to TypeAlias SBTopic
info	[Changelog]   - Type Alias SBNamespace has a new parameter alternateName
info	[Changelog]   - Type Alias SBNamespaceUpdateParameters has a new parameter alternateName
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Delete parameters of Resource in TypeAlias ArmDisasterRecovery
info	[Changelog]   - Delete parameters of Resource in TypeAlias MigrationConfigProperties
info	[Changelog]   - Delete parameters of Resource in TypeAlias NetworkRuleSet
info	[Changelog]   - Delete parameters of Resource in TypeAlias PrivateEndpointConnection
info	[Changelog]   - Delete parameters of Resource in TypeAlias Rule
info	[Changelog]   - Delete parameters of Resource in TypeAlias SBAuthorizationRule
info	[Changelog]   - Delete parameters of Resource in TypeAlias SBQueue
info	[Changelog]   - Delete parameters of Resource in TypeAlias SBSubscription
info	[Changelog]   - Delete parameters of Resource in TypeAlias SBTopic
info	[Changelog]   - Type Alias SBNamespaceUpdateParameters no longer has parameter zoneRedundant
    ️⚠️ azure-resource-manager-schemas warning [Detail]   
  
    • ⚠️Warning [Logs] Generate from 46ff29329c11b113822fb5303aabc34f1f8eb6b4. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️servicebus        [View full logs]         [Preview Schema Changes]      
    Posted by Swagger Pipeline | How to fix these errors?
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
            
    
    
    
      
    
    
    
    

      

          @v-Ajnava
v-Ajnava




          added
  the 

  DoNotMerge

  <valid label in PR review process> use to hold merge after approval
 label


      Feb 9, 2022

    
    
  
    


    





    

      
    
  
      

    

  
    
  @openapi-workflow-bot


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      



      

  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    Hi @v-Ajnava, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.  
    TaskHow to fixPriority
     
    AvocadoFix-AvocadoHigh
     
    Semantic validationFix-SemanticValidation-ErrorHigh
     
    Model validationFix-ModelValidation-ErrorHigh
     
    LintDiffFix-LintDiffhigh
      If you need further help, please feedback via swagger feedback.
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
            


  
    
  
    
    
  
    

  
    
      
    
  This was referenced Feb 9, 2022

    


    
  


  
    
      
   Draft

  
    

    



      
    

    


    
  


  
    
      
   Draft

  
    

    



      
    

    


    
  


  
    
      
   Draft

  
    

    



  
    

    

    


  
    
  
    
    
  
    

  
    
      
    
    @openapi-sdkautomation
openapi-sdkautomation
bot


    mentioned this pull request
    
      Feb 9, 2022
    

    


    
  


  
    
      
   Draft

  
    

    




  
    

    

    
    
    
    
      
    
    
    
    

      

          @manojprasad-ms
manojprasad-ms




            added
      

  DoNotMerge

  <valid label in PR review process> use to hold merge after approval

    and removed
      

  DoNotMerge

  <valid label in PR review process> use to hold merge after approval

  labels


      Feb 10, 2022

    
    
  
    





    

      
    
  
        



    

      
    
  
          
    
  
    
    
  
    

  
    
      
    
  This was referenced Feb 11, 2022

    


    
  


  
    
      
   Draft

  
    

    



      
    

    


    
  


  
    
      
   Draft

  
    

    



  
    

    

    


    
    
    
    
      
    
    
    
    

      

          @manojprasad-ms
manojprasad-ms




          assigned     v-Ajnava   and unassigned     v-Ajnava

      Feb 14, 2022

    
    
  
    


  
    
  
  
    
  
          @manojprasad-ms
  manojprasad-ms


          self-requested a review


    February 14, 2022 21:18    
    

    

    



    



        
    
  
            





    

        
    
  
      

    

  
    
  @msyyc


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      

  
  Member


      

  
    

  
    
    
    
      

      
            msyyc
  

      

      

      commented


        Feb 15, 2022


      
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    /azp run
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


        
    
  
      

    

  
    
  @azure-pipelines


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      



      

  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
Azure Pipelines successfully started running 1 pipeline(s).
    
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


        
    
  
            





    

        
    
  
        



    

        
    
  
            
    
    
    
      
    
    
    
    

      

          @manojprasad-ms
manojprasad-ms




          added
  the 

  WaitForARMFeedback

  <valid label in PR review process> add this label when ARM review is required
 label


      Feb 17, 2022

    
    
  
    


    


    


    
    
    
    
      
    
    
    
    

      

          @msyyc
msyyc




            closed this


      Feb 18, 2022

    
    
  
    

    
    

    
    
    
    
      
    
    
    
    

      

          @msyyc
msyyc




        reopened this

      Feb 18, 2022

    
    
  
    





    

        
    
  
        



    

        
    
  
      

    

  
    
  @jorgecotillo


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      

  
    Contributor


      

  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    What is your base api-version? You have to follow the first bullet point from here:
    
https://armwiki.azurewebsites.net/rp_onboarding/process/api_review.html#introduction
    

    You need to:
    

      

    1. Create your new api-version folder
      2. 

    2. Copy the contents of your base api-version
      3. 

    3. Commit & push (this will be your first iteration)
      4. 

    4. Make changes to your spec
      5. 

    

    Failing to do so will delay your review aprox between 1 - 2 weeks, to expedite your review please abandon this PR and follow the steps mentioned above - following these steps allows us to focus on the updates only instead of reviewing the entire spec again and call out pieces already reviewed.
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


        
    
  
      

    

  
    
  @v-Ajnava


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      

  
  Member


      

  Author


  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    as the PR was not submitted as ARM recommendation, hence closing this PR and submitting a new one.
    
#17967
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


        
    
  
            
    
    
    
      
    
    
    
    

      

          @v-Ajnava
v-Ajnava




            closed this


      Feb 23, 2022

    
    
  
    

    
    




    



  
  
    
    
    
      

      
    



    
    

    
    
      
    
              
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  

    

      
    
    
    
  
    


    
  
              

    


      
    
  
    
    
    
    
    
  
    
    Reviewers
  
    

    


        
    
          

  
      @manojprasad-ms
  
    manojprasad-ms



          
            
              
            
          
          manojprasad-ms approved these changes

        
    
      
    
          

  
      @msyyc
  
    msyyc


                Awaiting requested review from msyyc

                    msyyc is a code owner

        
      
    
      
    
          

  
      @BigCat20196
  
    BigCat20196


                Awaiting requested review from BigCat20196


        
      
    
      
    
          

  
      @ArcturusZhang
  
    ArcturusZhang


                Awaiting requested review from ArcturusZhang


        
      
    
      
    
          

  
      @dsouzaarun
  
    dsouzaarun


                Awaiting requested review from dsouzaarun

                    dsouzaarun is a code owner

        
      
    
      
    
          

  
      @damodaravadhani
  
    damodaravadhani


                Awaiting requested review from damodaravadhani

                    damodaravadhani is a code owner

        
      
    

      
    


    


    
    
  
    

      
  
    
    Assignees
  
    


        

      
    
        

  
      @msyyc
  
    msyyc
    

      
    
    



    


      

    
  


  
    
    Labels
  
    


    
    
      

    Approved-SdkBreakingChange-Go-V2

  

    Approved-SdkBreakingChange-JavaScript

  

    Approved-SdkBreakingChange-Python

  

    CI-BreakingChange-Go-V2

  

    CI-BreakingChange-JavaScript

  

    CI-FixRequiredOnFailure

  

    DoNotMerge

  <valid label in PR review process> use to hold merge after approval
  

    WaitForARMFeedback

  <valid label in PR review process> add this label when ARM review is required


    


    


      

  
    
    
    
        
    
    Projects
  
    

        
    

    

    None yet




      
    


      

    
  
    
    
  
    
    Milestone
  
    

      No milestone


    


    
      
          

    
  
    
    
      
    
        
    
    
    Development
  
    


          


    Successfully merging this pull request may close these issues.
    


  


            
  
    

    

          

    

  
      
    
  
    
    
    
      6 participants
    
    
    
    
        
          @v-Ajnava 
        
          @msyyc 
        
          @jorgecotillo 
        
          @manojprasad-ms 
        
          @ArcturusZhang 
        
          @qiaozha