Add x-ms-identifiers to softwareplan/resource-manager. #17781

vukelich · 2022-02-10T21:14:11Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify:

EXPLANATION OF THIS CHANGE
APIs will need to start indicating item uniqueness in arrays. By default, uniqueness is the string property called "id" of items in an array. When that property does not exist, the x-ms-identifiers extension property must be used to specify the identifying property(s) or lack thereof. This pull request is my best guess effort to ease resource providers into the new requirement before it becomes enforced. Compliance and accuracy will need to be owned and maintained by the resource provider going forward.

See https://github.com/Azure/autorest/tree/main/docs/extensions#x-ms-identifiers.

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-02-10T21:14:13Z

Hi, @vukelich Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2022-02-10T21:14:14Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2022-02-10T21:14:15Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.9.1)
- current:stable/2019-12-01/softwareplan.json compared with base:stable/2019-12-01/softwareplan.json

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.1 )
- softwareplan/resource-manager/readme.md tag:package-2019-12-01
Linted configuring files (Based on target branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.1 )
- softwareplan/resource-manager/readme.md tag:package-2019-12-01

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` R4007 - DefaultErrorResponseSchema	the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.SoftwarePlan/stable/2019-12-01/softwareplan.json#L64
`❌` R4007 - DefaultErrorResponseSchema	the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.SoftwarePlan/stable/2019-12-01/softwareplan.json#L110
`❌` R4007 - DefaultErrorResponseSchema	the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.SoftwarePlan/stable/2019-12-01/softwareplan.json#L152
`❌` R4007 - DefaultErrorResponseSchema	the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.SoftwarePlan/stable/2019-12-01/softwareplan.json#L192
`❌` R4007 - DefaultErrorResponseSchema	the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.SoftwarePlan/stable/2019-12-01/softwareplan.json#L229
`❌` R4007 - DefaultErrorResponseSchema	the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.SoftwarePlan/stable/2019-12-01/softwareplan.json#L266
`❌` R4007 - DefaultErrorResponseSchema	the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.SoftwarePlan/stable/2019-12-01/softwareplan.json#L308
`❌` R4007 - DefaultErrorResponseSchema	the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.SoftwarePlan/stable/2019-12-01/softwareplan.json#L348
`❌` R4037 - MissingTypeObject	The schema 'HybridUseBenefitListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.SoftwarePlan/stable/2019-12-01/softwareplan.json#L408
`❌` R4037 - MissingTypeObject	The schema 'HybridUseBenefitModel' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.SoftwarePlan/stable/2019-12-01/softwareplan.json#L424
`❌` R4037 - MissingTypeObject	The schema 'HybridUseBenefitProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.SoftwarePlan/stable/2019-12-01/softwareplan.json#L452
⚠️ R4006 - DeprecatedXmsCodeGenerationSetting	The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation. Location: Microsoft.SoftwarePlan/stable/2019-12-01/softwareplan.json#L7
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: HybridUseBenefitListResult Location: Microsoft.SoftwarePlan/stable/2019-12-01/softwareplan.json#L80
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: HybridUseBenefit Location: Microsoft.SoftwarePlan/stable/2019-12-01/softwareplan.json#L166
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: HybridUseBenefit Location: Microsoft.SoftwarePlan/stable/2019-12-01/softwareplan.json#L206
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: HybridUseBenefit Location: Microsoft.SoftwarePlan/stable/2019-12-01/softwareplan.json#L243

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]

️❌ModelValidation: 2 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST	ReadOnly property "type" cannot be sent in the request Url: Microsoft.SoftwarePlan/stable/2019-12-01/softwareplan.json#L24:17 ExampleUrl: stable/2019-12-01/examples/PutHybridUseBenefit.json#L6:13
`❌` READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST	ReadOnly property "type" cannot be sent in the request Url: Microsoft.SoftwarePlan/stable/2019-12-01/softwareplan.json#L24:17 ExampleUrl: stable/2019-12-01/examples/PatchHybridUseBenefit.json#L6:13

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

softwareplan/resource-manager/readme.md#package-2019-12-01

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-02-10T21:14:16Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-go - softwareplan/mgmt/2019-12-01/softwareplan - v61.4.0
️✔️azure-sdk-for-go - preview/softwareplan/mgmt/2019-06-01-preview/softwareplan - v61.4.0

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 5aaf504. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/softwareplan/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.SoftwarePlan [View full logs] [Release SDK Changes]
```
warn	Skip artifact folder because it doesn't exist: artifacts/packages
```

️❌ azure-sdk-for-python failed [Detail]

❌Failed [Logs]Release - Generate from 5aaf504. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh]   ERROR: Command errored out with exit status 1:
cmderr	[automation_init.sh]    command: /home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/home/vsts/work/1/s/azure-sdk-for-python_tmp/pip-install-v5p2v1au/markupsafe_d432ec3e305b4c288200a63ffa2fe4f4/setup.py'"'"'; __file__='"'"'/home/vsts/work/1/s/azure-sdk-for-python_tmp/pip-install-v5p2v1au/markupsafe_d432ec3e305b4c288200a63ffa2fe4f4/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /home/vsts/work/1/s/azure-sdk-for-python_tmp/pip-pip-egg-info-mzz7br__
cmderr	[automation_init.sh]        cwd: /home/vsts/work/1/s/azure-sdk-for-python_tmp/pip-install-v5p2v1au/markupsafe_d432ec3e305b4c288200a63ffa2fe4f4/
cmderr	[automation_init.sh]   Complete output (30 lines):
cmderr	[automation_init.sh]   Traceback (most recent call last):
cmderr	[automation_init.sh]     File "<string>", line 1, in <module>
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/pip-install-v5p2v1au/markupsafe_d432ec3e305b4c288200a63ffa2fe4f4/setup.py", line 65, in <module>
cmderr	[automation_init.sh]       run_setup(True)
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/pip-install-v5p2v1au/markupsafe_d432ec3e305b4c288200a63ffa2fe4f4/setup.py", line 44, in run_setup
cmderr	[automation_init.sh]       ext_modules=ext_modules if with_binary else [],
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/lib/python3.6/site-packages/setuptools/__init__.py", line 129, in setup
cmderr	[automation_init.sh]       return distutils.core.setup(**attrs)
cmderr	[automation_init.sh]     File "/usr/lib/python3.6/distutils/core.py", line 121, in setup
cmderr	[automation_init.sh]       dist.parse_config_files()
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/lib/python3.6/site-packages/setuptools/dist.py", line 494, in parse_config_files
cmderr	[automation_init.sh]       ignore_option_errors=ignore_option_errors)
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/lib/python3.6/site-packages/setuptools/config.py", line 106, in parse_configuration
cmderr	[automation_init.sh]       meta.parse()
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/lib/python3.6/site-packages/setuptools/config.py", line 382, in parse
cmderr	[automation_init.sh]       section_parser_method(section_options)
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/lib/python3.6/site-packages/setuptools/config.py", line 355, in parse_section
cmderr	[automation_init.sh]       self[name] = value
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/lib/python3.6/site-packages/setuptools/config.py", line 173, in __setitem__
cmderr	[automation_init.sh]       value = parser(value)
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/lib/python3.6/site-packages/setuptools/config.py", line 430, in _parse_version
cmderr	[automation_init.sh]       version = self._parse_attr(value)
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/lib/python3.6/site-packages/setuptools/config.py", line 305, in _parse_attr
cmderr	[automation_init.sh]       module = import_module(module_name)
cmderr	[automation_init.sh]     File "/usr/lib/python3.6/importlib/__init__.py", line 126, in import_module
cmderr	[automation_init.sh]       return _bootstrap._gcd_import(name[level:], package, level)
cmderr	[automation_init.sh]     File "<frozen importlib._bootstrap>", line 994, in _gcd_import
cmderr	[automation_init.sh]     File "<frozen importlib._bootstrap>", line 971, in _find_and_load
cmderr	[automation_init.sh]     File "<frozen importlib._bootstrap>", line 953, in _find_and_load_unlocked
cmderr	[automation_init.sh]   ModuleNotFoundError: No module named 'markupsafe'
cmderr	[automation_init.sh]   ----------------------------------------
cmderr	[automation_init.sh] WARNING: Discarding https://files.pythonhosted.org/packages/62/0f/52c009332fdadd484e898dc8f2acca0663c1031b3517070fd34ad9c1b64e/MarkupSafe-2.1.0.tar.gz#sha256=80beaf63ddfbc64a0452b841d8036ca0611e049650e20afcb882f5d3c266d65f (from https://pypi.org/simple/markupsafe/) (requires-python:>=3.7). Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] opencensus-ext-azure 1.1.1 requires azure-core<2.0.0,>=1.12.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] azure-identity 1.7.1 requires azure-core<2.0.0,>=1.11.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.3.1 -> 8.5.2
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.2>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.5.2` to update!
cmderr	[automation_generate.sh] npm notice
cmdout	[automation_generate.sh] [Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
cmdout	[automation_generate.sh] [Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/softwareplan/resource-manager/Microsoft.SoftwarePlan/stable/2019-12-01/softwareplan.json:479:8 ($.definitions.OperationList.properties.value)
cmdout	[automation_generate.sh] [Autorest] FATAL: swagger-document/individual/schema-validator - FAILED
cmdout	[automation_generate.sh] [Autorest] FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
cmdout	[automation_generate.sh] [Autorest] Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.
cmdout	[automation_generate.sh] [Autorest]/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
warn	Skip package processing as generation is failed

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 5aaf504. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2022-02-25 00:12:37 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-softwareplan"
cmderr	[generate.py] 2022-02-25 00:12:37 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2022-02-25 00:12:37 INFO autorest --version=3.6.6 --use=@autorest/java@4.0.50 --java --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/softwareplan/azure-resourcemanager-softwareplan --java.namespace=com.azure.resourcemanager.softwareplan   --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/softwareplan/resource-manager/readme.md
cmderr	[generate.py] 2022-02-25 00:13:02 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2022-02-25 00:13:02 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2022-02-25 00:13:02 INFO [POM][Skip] pom already has module azure-resourcemanager-softwareplan
cmderr	[generate.py] 2022-02-25 00:13:02 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2022-02-25 00:13:02 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2022-02-25 00:13:02 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-softwareplan [View full logs] [Release SDK Changes]

cmderr	[Inst] 2022-02-25 00:14:20 DEBUG Got artifact_id: azure-resourcemanager-softwareplan
cmderr	[Inst] 2022-02-25 00:14:20 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2022-02-25 00:14:20 DEBUG Got artifact: azure-resourcemanager-softwareplan-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2022-02-25 00:14:20 DEBUG Got artifact: azure-resourcemanager-softwareplan-1.0.0-beta.1.jar
cmderr	[Inst] 2022-02-25 00:14:20 DEBUG Match jar package: azure-resourcemanager-softwareplan-1.0.0-beta.1.jar
cmderr	[Inst] 2022-02-25 00:14:20 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17781/azure-sdk-for-java/azure-resourcemanager-softwareplan/azure-resourcemanager-softwareplan-1.0.0-beta.1.jar\" -o azure-resourcemanager-softwareplan-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-softwareplan -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-softwareplan-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 5aaf504. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️softwareplan/mgmt/2019-12-01/softwareplan [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
info	[Changelog]
```

️✔️preview/softwareplan/mgmt/2019-06-01-preview/softwareplan [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 5aaf504. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh]  @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] notice created a lockfile as package-lock.json. You should commit this file.
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️track2_@azure/arm-softwareplan [View full logs] [Release SDK Changes]
- azure-arm-softwareplan-1.0.0.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 5aaf504. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️softwareplan [View full logs]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-02-10T21:34:39Z

Hi @vukelich, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

Co-authored-by: Steven Vukelich <svukel@microsoft.com>

Add x-ms-identifiers to softwareplan/resource-manager.

d5e6188

openapi-assignment-bot bot assigned ArcturusZhang Feb 10, 2022

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Feb 10, 2022

ArcturusZhang added the Approved-ModelValidation label Feb 24, 2022

ArcturusZhang approved these changes Feb 25, 2022

View reviewed changes

ArcturusZhang merged commit 5aaf504 into Azure:main Feb 25, 2022

FredericHeem pushed a commit to grucloud/azure-rest-api-specs that referenced this pull request Mar 7, 2022

Add x-ms-identifiers to softwareplan/resource-manager. (Azure#17781)

022532c

Co-authored-by: Steven Vukelich <svukel@microsoft.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add x-ms-identifiers to softwareplan/resource-manager. #17781

Add x-ms-identifiers to softwareplan/resource-manager. #17781

vukelich commented Feb 10, 2022

openapi-workflow-bot bot commented Feb 10, 2022

openapi-workflow-bot bot commented Feb 10, 2022

openapi-pipeline-app bot commented Feb 10, 2022 •

edited

Loading

openapi-pipeline-app bot commented Feb 10, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Feb 10, 2022

Add x-ms-identifiers to softwareplan/resource-manager. #17781

Add x-ms-identifiers to softwareplan/resource-manager. #17781

Conversation

vukelich commented Feb 10, 2022

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 10, 2022

openapi-workflow-bot bot commented Feb 10, 2022

openapi-pipeline-app bot commented Feb 10, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 10, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Feb 10, 2022

openapi-pipeline-app bot commented Feb 10, 2022 •

edited

Loading

openapi-pipeline-app bot commented Feb 10, 2022 •

edited

Loading