[Hub Generated] Review request for Microsoft.Cache to add version stable/2021-06-01 #17836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version is adding a path that was not found in the old version. New: Microsoft.Cache/stable/2021-06-01/redis.json#L1779:5 |
️⚠️LintDiff: 1 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.2 )
- Linted configuring files (Based on target branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.2 )
| Rule | Message |
|---|---|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2767 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/CheckNameAvailability' Location: Microsoft.Cache/stable/2021-06-01/redis.json#L68 |
|
The response of operation:'Redis_Create' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L172 |
|
The response of operation:'Redis_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L236 |
|
The response of operation:'Redis_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L345 |
|
The response of operation:'FirewallRules_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L828 |
|
The response of operation:'FirewallRules_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L899 |
|
The response of operation:'PatchSchedules_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L1067 |
|
The response of operation:'PatchSchedules_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L1208 |
|
The response of operation:'LinkedServer_Create' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L1273 |
|
The response of operation:'LinkedServer_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L1399 |
|
The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L1562 |
|
The response of operation:'PrivateEndpointConnections_Put' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L1613 |
|
The integer type does not have a format, please add it. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2393 |
|
The response schema of operations API '/providers/Microsoft.Cache/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L37 |
|
The schema 'Sku' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L1831 |
|
The schema 'RedisCommonProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L1871 |
|
The schema 'RedisCreateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2001 |
|
The schema 'RedisUpdateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2033 |
|
The schema 'RedisProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2048 |
|
The schema 'RedisCreateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2131 |
|
The schema 'RedisUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2171 |
|
The schema 'RedisAccessKeys' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2192 |
|
The schema 'RedisFirewallRule' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2207 |
|
The schema 'RedisFirewallRuleProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2233 |
|
The schema 'RedisFirewallRuleListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2250 |
|
The schema 'RedisResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2267 |
|
The schema 'RedisInstanceDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2296 |
|
The schema 'RedisListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2334 |
|
The schema 'RedisRegenerateKeyParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2351 |
|
The schema 'RedisRebootParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2371 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️❌ModelValidation: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
x-ms-example not found in Operations_List. Url: Microsoft.Cache/stable/2021-06-01/redis.json#L38:14 |
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
|
Hi, @priyankarking Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Generation Artifacts
|
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
|
Hi @priyankarking, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
priyankarking
force-pushed
the
priyankarking/dev-redis-Microsoft.Cache-2021-06-01_swagger_completeness_fix
branch
3 times, most recently
from
b96ffc3 to
ade6f1a
Compare
|
NewApiVersionRequired reason: |
This was referenced Feb 18, 2022
priyankarking
force-pushed
the
priyankarking/dev-redis-Microsoft.Cache-2021-06-01_swagger_completeness_fix
branch
from
ade6f1a to
417a0b3
Compare
priyankarking
force-pushed
the
priyankarking/dev-redis-Microsoft.Cache-2021-06-01_swagger_completeness_fix
branch
3 times, most recently
from
71c6546 to
f9e0c74
Compare
jianyexi
reviewed
Feb 21, 2022
| @@ -2693,6 +2743,20 @@ | |||
| } | |||
| }, | |||
| "description": "The response of listUpgradeNotifications." | |||
| }, | |||
| "OperationStatusResult": { | |||
There was a problem hiding this comment.
could you rename it , as it conflicts with the common types and caused circular reference
priyankarking
force-pushed
the
priyankarking/dev-redis-Microsoft.Cache-2021-06-01_swagger_completeness_fix
branch
from
f9e0c74 to
408bb29
Compare
|
/azp run |
priyankarking
force-pushed
the
priyankarking/dev-redis-Microsoft.Cache-2021-06-01_swagger_completeness_fix
branch
2 times, most recently
from
53d6b32 to
bc2f0ad
Compare
priyankarking
force-pushed
the
priyankarking/dev-redis-Microsoft.Cache-2021-06-01_swagger_completeness_fix
branch
from
bc2f0ad to
3ee7b32
Compare
|
@msyyc : the section for which required checks for "Model Validation" are failing aren't part of the changes in my PR. The same issue occurred in a previous PR as well #17447, but in that case it wasn't marked as required. Could you please help in ignoring the failing required check for 'Swagger ModelValidation' . I have already requested for the breaking change label and need to urgently merge in this change to meet the deadline for swagger issues. This failing check could be resolved later in another PR. |
JeffreyRichter
added
the
Approved-BreakingChange
25 tasks
[redis]Update readme.python.md
|
@msyyc , pls check this #17836 (comment) and add required label. |
|
The failure is not caused by this PR: |
msyyc
approved these changes
Feb 25, 2022
This was referenced Feb 25, 2022
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
Mar 7, 2022
…ble/2021-06-01 (Azure#17836) * swagger completeness fix for asyncOperations status. * Update readme.python.md Co-authored-by: Priyankar Gupta <priyagupta@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.