Add xms-ids for Privatedns #17975

LinglingTong · 2022-02-24T00:09:03Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify

About this Change

APIs will need to start indicating item uniqueness in arrays. By default, uniqueness is the string property called "id" of items in an array. When that property does not exist, the x-ms-identifiers extension property must be used to specify the identifying property(s) or lack thereof. This pull request is my best guess effort to ease resource providers into the new requirement before it becomes enforced. Compliance and accuracy will need to be owned and maintained by the resource provider going forward.

See https://github.com/Azure/autorest/tree/main/docs/extensions#x-ms-identifiers.

You can also make changes after this PR is checked in. At this point, this annotation is only used by Change Analysis for change computation, so making changes afterwards shouldn’t be a breaking change.

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-02-24T00:09:06Z

Hi, @LinglingTong Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-workflow-bot · 2022-02-24T00:09:06Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2022-02-24T00:09:07Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.9.5)
- current:stable/2020-06-01/privatedns.json compared with base:stable/2020-06-01/privatedns.json

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.13.0 , classic-openapi-validator v1.2.4 )
- privatedns/resource-manager/readme.md tag:package-2020-06
Linted configuring files (Based on target branch, openapi-validator v1.13.0 , classic-openapi-validator v1.2.4 )
- privatedns/resource-manager/readme.md tag:package-2020-06

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R3021 - PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/privateDnsZones/{privateZoneName}/ALL' Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L1301
`❌` R4037 - MissingTypeObject	The schema 'PrivateZoneProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L1371
`❌` R4037 - MissingTypeObject	The schema 'PrivateZone' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L1434
`❌` R4037 - MissingTypeObject	The schema 'PrivateZoneListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L1453
`❌` R4037 - MissingTypeObject	The schema 'VirtualNetworkLinkProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L1470
`❌` R4037 - MissingTypeObject	The schema 'VirtualNetworkLink' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L1513
`❌` R4037 - MissingTypeObject	The schema 'VirtualNetworkLinkListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L1532
`❌` R4037 - MissingTypeObject	The schema 'ARecord' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L1549
`❌` R4037 - MissingTypeObject	The schema 'AaaaRecord' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L1558
`❌` R4037 - MissingTypeObject	The schema 'CnameRecord' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L1567
`❌` R4037 - MissingTypeObject	The schema 'MxRecord' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L1576
`❌` R4037 - MissingTypeObject	The schema 'PtrRecord' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L1590
`❌` R4037 - MissingTypeObject	The schema 'SoaRecord' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L1599
`❌` R4037 - MissingTypeObject	The schema 'SrvRecord' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L1637
`❌` R4037 - MissingTypeObject	The schema 'TxtRecord' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L1661
`❌` R4037 - MissingTypeObject	The schema 'RecordSetProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L1673
`❌` R4037 - MissingTypeObject	The schema 'RecordSet' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L1760
`❌` R4037 - MissingTypeObject	The schema 'RecordSetListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L1794
`❌` R4037 - MissingTypeObject	The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L1811
`❌` R4037 - MissingTypeObject	The schema 'TrackedResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L1832
`❌` R4037 - MissingTypeObject	The schema 'SubResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L1870
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'virtualNetworkLinks' with immediate parent 'PrivateZone', must have a list by immediate parent operation. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L1513
⚠️ R4009 - RequiredReadOnlySystemData	The response of operation:'PrivateZones_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L31
⚠️ R4009 - RequiredReadOnlySystemData	The response of operation:'PrivateZones_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L114
⚠️ R4009 - RequiredReadOnlySystemData	The response of operation:'PrivateZones_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L243
⚠️ R4009 - RequiredReadOnlySystemData	The response of operation:'VirtualNetworkLinks_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L394
⚠️ R4009 - RequiredReadOnlySystemData	The response of operation:'VirtualNetworkLinks_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L484
⚠️ R4009 - RequiredReadOnlySystemData	The response of operation:'VirtualNetworkLinks_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L627
⚠️ R4009 - RequiredReadOnlySystemData	The response of operation:'RecordSets_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L745
⚠️ R4009 - RequiredReadOnlySystemData	The response of operation:'RecordSets_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2020-06-01/privatedns.json#L874

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️❌ModelValidation: 2 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` OBJECT_ADDITIONAL_PROPERTIES	Additional properties not allowed: minimumTTL Url: Microsoft.Network/stable/2020-06-01/privatedns.json#L1599:18 ExampleUrl: stable/2020-06-01/examples/RecordSetSOAPut.json#L9:19
`❌` OBJECT_ADDITIONAL_PROPERTIES	Additional properties not allowed: minimumTTL Url: Microsoft.Network/stable/2020-06-01/privatedns.json#L1599:18 ExampleUrl: stable/2020-06-01/examples/RecordSetSOAPut.json#L48:27

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

privatedns/resource-manager/readme.md#package-2020-06

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-02-24T00:09:08Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go-track2 - armprivatedns - 0.6.0

+	Function `*PrivateZonesClient.BeginCreateOrUpdate` return value(s) have been changed from `(*armruntime.Poller[PrivateZonesClientCreateOrUpdateResponse], error)` to `(*runtime.Poller[PrivateZonesClientCreateOrUpdateResponse], error)`
+	Function `*PrivateZonesClient.BeginDelete` return value(s) have been changed from `(*armruntime.Poller[PrivateZonesClientDeleteResponse], error)` to `(*runtime.Poller[PrivateZonesClientDeleteResponse], error)`
+	Function `*PrivateZonesClient.BeginUpdate` return value(s) have been changed from `(*armruntime.Poller[PrivateZonesClientUpdateResponse], error)` to `(*runtime.Poller[PrivateZonesClientUpdateResponse], error)`
+	Function `*VirtualNetworkLinksClient.BeginCreateOrUpdate` return value(s) have been changed from `(*armruntime.Poller[VirtualNetworkLinksClientCreateOrUpdateResponse], error)` to `(*runtime.Poller[VirtualNetworkLinksClientCreateOrUpdateResponse], error)`
+	Function `*VirtualNetworkLinksClient.BeginDelete` return value(s) have been changed from `(*armruntime.Poller[VirtualNetworkLinksClientDeleteResponse], error)` to `(*runtime.Poller[VirtualNetworkLinksClientDeleteResponse], error)`
+	Function `*VirtualNetworkLinksClient.BeginUpdate` return value(s) have been changed from `(*armruntime.Poller[VirtualNetworkLinksClientUpdateResponse], error)` to `(*runtime.Poller[VirtualNetworkLinksClientUpdateResponse], error)`
+	Function `CloudErrorBody.MarshalJSON` has been removed
+	Function `PrivateZoneListResult.MarshalJSON` has been removed
+	Function `RecordSetListResult.MarshalJSON` has been removed
+	Function `VirtualNetworkLinkListResult.MarshalJSON` has been removed

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-privatedns - 1.0.0
️✔️azure-sdk-for-go - privatedns/mgmt/2018-09-01/privatedns - v64.1.0

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from 2e2e427. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/privatedns/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] No usable version of the libssl was found
cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 2e2e427. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-privatedns [View full logs] [Release SDK Changes]
- azure_mgmt_privatedns-1.0.0b1-py3-none-any.whl
- azure-mgmt-privatedns-1.0.0b1.zip
```
info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model PrivateZone has a new parameter internal_id
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 2e2e427. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

️✔️azure-resourcemanager-privatedns-generated [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2e2e427. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️privatedns/mgmt/2018-09-01/privatedns [View full logs] [Release SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2e2e427. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armprivatedns [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*VirtualNetworkLinksClient.BeginCreateOrUpdate` return value(s) have been changed from `(*armruntime.Poller[VirtualNetworkLinksClientCreateOrUpdateResponse], error)` to `(*runtime.Poller[VirtualNetworkLinksClientCreateOrUpdateResponse], error)`
info	[Changelog] - Function `*PrivateZonesClient.BeginUpdate` return value(s) have been changed from `(*armruntime.Poller[PrivateZonesClientUpdateResponse], error)` to `(*runtime.Poller[PrivateZonesClientUpdateResponse], error)`
info	[Changelog] - Function `*VirtualNetworkLinksClient.BeginUpdate` return value(s) have been changed from `(*armruntime.Poller[VirtualNetworkLinksClientUpdateResponse], error)` to `(*runtime.Poller[VirtualNetworkLinksClientUpdateResponse], error)`
info	[Changelog] - Function `*VirtualNetworkLinksClient.BeginDelete` return value(s) have been changed from `(*armruntime.Poller[VirtualNetworkLinksClientDeleteResponse], error)` to `(*runtime.Poller[VirtualNetworkLinksClientDeleteResponse], error)`
info	[Changelog] - Function `*PrivateZonesClient.BeginDelete` return value(s) have been changed from `(*armruntime.Poller[PrivateZonesClientDeleteResponse], error)` to `(*runtime.Poller[PrivateZonesClientDeleteResponse], error)`
info	[Changelog] - Function `*PrivateZonesClient.BeginCreateOrUpdate` return value(s) have been changed from `(*armruntime.Poller[PrivateZonesClientCreateOrUpdateResponse], error)` to `(*runtime.Poller[PrivateZonesClientCreateOrUpdateResponse], error)`
info	[Changelog] - Function `CloudErrorBody.MarshalJSON` has been removed
info	[Changelog] - Function `PrivateZoneListResult.MarshalJSON` has been removed
info	[Changelog] - Function `RecordSetListResult.MarshalJSON` has been removed
info	[Changelog] - Function `VirtualNetworkLinkListResult.MarshalJSON` has been removed
info	[Changelog]
info	[Changelog] Total 10 breaking change(s), 0 additive change(s).

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 2e2e427. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh]  deprecated @azure/storage-blob@10.5.0: This version has been deprecated, please upgrade to the version tagged as latest
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-privatedns [View full logs] [Release SDK Changes]

azure-arm-privatedns-3.0.2.tgz

info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 2e2e427. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
warn	Skip detect changed packages

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2e2e427. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.PrivateDns [View full logs] [Release SDK Changes]
- Az.PrivateDns.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-02-24T00:11:11Z

Hi @LinglingTong, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

ghost · 2022-03-13T16:02:20Z

Hi, @LinglingTong. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

LinglingTong · 2022-03-13T16:42:00Z

@ruowan there are only a few lines of change in this PR and all the xms-ids look intuitive. Could you help with a code review and merging the PR? I also checked the model validation failures and they are not related to my changes. Thanks!

ghost · 2022-04-03T16:02:43Z

Hi, @LinglingTong. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

LinglingTong · 2022-04-04T02:41:46Z

@vladrai could you help to take a look at the code change? Thanks!

ghost · 2022-04-24T16:02:58Z

Hi, @LinglingTong. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

LinglingTong · 2022-04-25T13:53:21Z

@ruowan there are only a few places change in this PR and it should be fairly safe. I wonder maybe could you help me to take a look? Thanks!

ghost · 2022-05-15T16:03:10Z

Hi, @LinglingTong. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

LinglingTong · 2022-05-15T19:55:21Z

Ping @vladrai

vladrai

If changes can be done later looks good to me.

add xms-ids for Privatedns

1e770d8

openapi-assignment-bot bot assigned ruowan Feb 24, 2022

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Feb 24, 2022

openapi-pipeline-app bot added the CI-BreakingChange-Go-V2 label Feb 24, 2022

ghost added the no-recent-activity label Mar 13, 2022

ghost removed the no-recent-activity label Mar 13, 2022

ghost added no-recent-activity and removed no-recent-activity labels Apr 3, 2022

LinglingTong requested a review from vladrai April 4, 2022 02:40

ghost added the no-recent-activity label Apr 24, 2022

ghost removed the no-recent-activity label Apr 25, 2022

ghost added the no-recent-activity label May 15, 2022

ghost removed the no-recent-activity label May 15, 2022

vladrai approved these changes May 16, 2022

View reviewed changes

address code review comments

cde8b72

vladrai approved these changes May 16, 2022

View reviewed changes

ruowan approved these changes May 17, 2022

View reviewed changes

ruowan added the Approved-ModelValidation label May 17, 2022

ruowan merged commit 2e2e427 into Azure:main May 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add xms-ids for Privatedns #17975

Add xms-ids for Privatedns #17975

LinglingTong commented Feb 24, 2022

openapi-workflow-bot bot commented Feb 24, 2022

openapi-workflow-bot bot commented Feb 24, 2022

openapi-pipeline-app bot commented Feb 24, 2022 •

edited

Loading

openapi-pipeline-app bot commented Feb 24, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Feb 24, 2022

ghost commented Mar 13, 2022

LinglingTong commented Mar 13, 2022

ghost commented Apr 3, 2022

LinglingTong commented Apr 4, 2022

ghost commented Apr 24, 2022

LinglingTong commented Apr 25, 2022

ghost commented May 15, 2022

LinglingTong commented May 15, 2022

vladrai left a comment

Add xms-ids for Privatedns #17975

Add xms-ids for Privatedns #17975

Conversation

LinglingTong commented Feb 24, 2022

Changelog

About this Change

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 24, 2022

openapi-workflow-bot bot commented Feb 24, 2022

openapi-pipeline-app bot commented Feb 24, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 24, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Feb 24, 2022

ghost commented Mar 13, 2022

LinglingTong commented Mar 13, 2022

ghost commented Apr 3, 2022

LinglingTong commented Apr 4, 2022

ghost commented Apr 24, 2022

LinglingTong commented Apr 25, 2022

ghost commented May 15, 2022

LinglingTong commented May 15, 2022

vladrai left a comment

Choose a reason for hiding this comment

openapi-pipeline-app bot commented Feb 24, 2022 •

edited

Loading

openapi-pipeline-app bot commented Feb 24, 2022 •

edited

Loading