Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lztaggo #18047

Closed
wants to merge 188 commits into from
Closed

Lztaggo #18047

wants to merge 188 commits into from

Conversation

LarryZhang19
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

inballeibovitch and others added 30 commits September 13, 2021 15:04
….AlertsManagement-2021-02-01-preview' (Azure#15899)

* Adds base for updating Microsoft.AlertsManagement from version preview/2019-05-05-preview to version 2021-02-01-preview

* Updates readme

* Updates API version in new specs and examples

* update action rule schema to new api

* fix linter issues

* add alertsmanagement.json

* fix api version

* fix description in targetResource

* match description

* match severity description

* use systemdata type

* run prettier-fix

* change alertsmanagement to latest version

* add integer format

* add x-ms-discriminator-value

* remove summary

* make action polymorphic

* update readme

* prettier fix

* remove space

* add examples

* prettier fix

* fix validation errors

* fix validation errors

* change file name

* update monitor service names

* fix PR comments

* fix description

* change actions to array

* fix prettify issue

* fix lintDiff errors

* rename schedulingConfig to schedule

* fix response codes for put and delete

* fix prettier

* remove query params

* add enabled default value

* rename api version and add severity to conditions

* fix condition enum and remove Z from time in examples

* update conditions, schedule pattern and descriptions
* [Synapse] - split kqlScripts

* Run code style checker

* Split artifacts per operation groups

* Update readme and solve reference issues

* linkedservice to linkedService

* linkedservice to linkedService more

* Resolve conflicts

* Split 2020-12-01

* Fix syntax issue

* Remove operations.json from reamd

* readme Minor fix

* lenient-model-deduplication

Co-authored-by: Dongwei Wang <dongwwa@microsoft.com>
* Add ResetSkills To SDK

* Add custom words

* Address comments and fix schema

* Address comments and fix ModelValidation check

* make url aka.ms

* fix url
…Features to API version 2021-06-02 (Azure#15850)

* Add missing features, quotaLimist and Rotterdam networkFeatures

* Update quotaLimits get and add get list

* Update description for volume type

* S360 Add missing serviceSpecification and metricsSpecification properties

* Remove quotalimit response no longer used

* pagable

* Update to use common type proxy resource

* pretty

* systemdata

Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>
* Add June21 Swagger Api version, Updated Readme files

* adding abort and hnson migration swagger API

* swagger: marking requesttype as required parameter for hns onmigration

* Added new PublicNetworkAccess property to swagger spec

* Add enableNfsV3RootSquash and enableNfsV3AllSquash to June21 swagger

* Add Account Level VLW Swagger changes and example

* Update Blob Inventory Api comment to include AccessTierInferred and Tags

* Rename HnsOn to hierarchical namespace

* [Swagger] [June21] Added defaultToOAuthAuthentication to swagger spec

* Update Spell check custom words list. Correct incorrect spellings

* Add missing refrences to PublicNetworkAccess Examples

* Add required type:object, Add default return type for hns migration apis

* Prettier tool update to storage.json

* Add update account with immutability policy example

* Removed StorageFileDataSmbShareOwner as Server side does not support it

* Add AllowProtectedAppendWritesAll feature changes with example

* Updated enum values and description for PublicNetworkAccess

* Add type:object to ProtectedAppendWritesHistory ; Spellcheck
Co-authored-by: Zach Madsen <zachmadsen@microsoft.com>
…newer RP API version 2021-06-01 (Azure#14311)

* Adds base for updating Microsoft.IoTCentral from version stable/2018-09-01 to version 2021-06-01

* Updates readme

* Updates API version in new specs and examples

* remove legacy sku S1

* update template in example to use M3 template name

* add suppress for R4009 and R3018

* add state

* update

* should be read only

* update example

* Update iotcentral.json

temporary changing this for further testing in canary.

* removal of f1 and deleted state
… version stable/2021-07-01 (Azure#15721)

* Adds base for updating Microsoft.ContainerInstance from version stable/2021-03-01 to version 2021-07-01

* Updates readme

* Updates API version in new specs and examples

* Adding subnet IDs

* Adding fixes from pending 03-01 update

* Changing definition name to match convention

* Adding network dependencies API

* Adding MSI+ACR properties

* Removing network profile

* Updating example

* Fixing JSON error

* Removing network profile reference

* Adding Integer format where missing

* Removing comma

* Fixing example

* Fixing example

* Ran Prettier to resolve check failure

* Running prettier again for format
… preview (Azure#15913)

* Adds base for updating Microsoft.DesktopVirtualization from version preview/2021-04-01-preview to version 2021-09-03-preview

* Updates readme

* Updates API version in new specs and examples

* add scaling plan changes

* fix pagination

* system data for all

* add object type

* Trigger Build

* more object types

* more object types

* add description

* add error response

* int format
… version preview/2019-11-01-preview (Azure#15893)

* Adds base for updating Microsoft.DataLakeAnalytics from version stable/2016-11-01 to version 2019-11-01-preview

* Updates readme

* Updates API version in new specs and examples

* test validation patch

Co-authored-by: Jimmy Xie <jimmyxie@microsoft.com>
…s to be able to specify target storage account id when wanting to do restore using managed identities. (Azure#15933)
* test

* try1

* fixing services discriminator

* prettier and readme

* revert additional changes

* fixing model validation errors

* model validation fix

* nit

Co-authored-by: Meha Kaushik <mekaushi@microsoft.com>
…#15815)

* Just copied the existing version file into this new directory per to review change efficiently

* Support az, private link feature ,fix S360 R2026 and roundtrip error

* reuse private link resource in common type, and mark some properties as required, Add 201 schema for private endpoint connection put response, and modify resource definition

* Fix missing objec type in 2021-06-01'

* Update location get capability api: remove vmsizes and vmsizes_filter in the result and change some properties to CamelCase style

* Update readme.md to change 2021-06 to default tag

* Removed the non reference object ClusterListRuntimeScriptActionDetailResult

* Fix CI error

* revert the change in common-types/resource-management/v2/privatelinks.json and define PrivateLinkResource and PrivateLinkResourceResult in our own file

Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com>
…on stable/2021-05-01 (Azure#15648)

* Make changes based on s360

* Fix example errors

* Missed an instance of purchaseDate type

* No schema for 204

* Ran prettier

Co-authored-by: Alex Goldschmidt <algoldsc@microsoft.com>
Azure#16027)

Co-authored-by: Bhuvnesh kumar <bhukumar@microsoft.com>
…re#15731)

* add debug creation info

* add debug creation info

* push more fixs for other gaps

* update stable version as well

* fix examples

* Resolve conflicts

Co-authored-by: Dongwei Wang <dongwwa@microsoft.com>
Co-authored-by: Dongwei Wang <dongwwa@microsoft.com>
Co-authored-by: Liran Chen <lirche@microsoft.com>
…on preview/2021-10-01-preview (Azure#15939)

* Adds base for updating Microsoft.LabServices from version stable/2018-10-15 to version 2021-10-01-preview

* Updates readme

* Updates API version in new specs and examples

* remove 2018 api spec files

* add 2021-10-01-preview spec files from generation

* update preview api files in readme.md input

* update 2020 -> 2021 in new api version in readme

* spelling fixes

* fix object body mutability

* add type:object where missing

* added default error response

* tracker resource operation naming and description adding

* fix shutdownOnIdleEnabled in examples

* fix shutdownonIdle enum in examples

* examples update username to adminUser object and remove locations from vmprofile

* fix examples for vmprofile

* rest of model validaiton fixes

* prettier fix

* removed skus api from 2021-10-01 version since it's not finished

* fix operationresults

* small images fix

Co-authored-by: Nick Depinet <ndepinet@microsoft.com>
* Add commontypes/resource-management/v3/managedidentity which models managed identity for services supporting both SystemAssignedIdentity and UserAssignedIdentity.

* Add a canonical SystemAssignedServiceIdentityType type definition which supports 'None', since that is required going forward. Also make the 'type' property required, since omitting it from the request would not be clear in intent.

* Add principalId and tenantId.
* Add blockchain to latest profile

* Add additional types

* Resolving s360 workitems for private link/endpoint/dnszonegroups

* removing unneeded file

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Shane Baden <shbaden@microsoft.com>
…o-2021-08-27' (Azure#15905)

* Adds base for updating Microsoft.Kusto from version stable/2021-01-01 to version 2021-08-27

* Updates readme

* Updates API version in new specs and examples

* Swagger changes

* it1

* hh

* it2

* it3

* it5

* it6

* it7

* readme

* it10

* it11

* it11

* it 12

* it 13

* prettier

* python

* allowedIpRangeList - remove default

* bassel changes

* checkNameAvailability

* fix lint

* checkName

* fix

* managedPrivate check name

* prettier

* Update readme.python.md

* add attached enum

* Dor comments

* fix description

* readOnly

Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
* Adding 202 for deletion call

* Adding headers to suppress warnings
* add endpoint to webpubsub swaggers

* have endpoint not include connection string in swagger

* Update webpubsub.json

* Update webpubsub.json

Co-authored-by: Laurent Mazuel <lmazuel@microsoft.com>
This was referenced Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-BreakingChange-Python CI-FixRequiredOnFailure customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.