Dev/matyang/connection #18051
Closed
Dev/matyang/connection #18051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…agger (Azure#17458) * Adding totalCount to transactionList result * Adding BilingProfileInfo on agreements to GA version * Adding type object
Co-authored-by: ruowan <ruowan@ruowandeMacBook-Pro.local>
* Adding changes resource type * Changing date to march * Suppress system data * Minor change * Resolve swagger lintdiff * Swagger lint diff * Swagger lint diff * Minor change * Semantic Validation * Swagger LintDiff * Readme * Readme * Suppression
Co-authored-by: Priyankar Gupta <priyagupta@microsoft.com>
* update example * external
…le (Azure#17279) * Added new datacenter codes to databox rest-api-specs preview repo * Removed YQB20 from the new additions
…#17541) * Specify some renames for the client SDKs * Fix typo in a description
…rsion stable/2021-10-01 (Azure#17549) * Removed NOT property * Removed NOT description
…version preview/2019-03-01-preview (Azure#17366) * add description and actionStatus to alert properties * prettier fix
…italTwins-2021-06-30-preview-merge-with-main' (Azure#17186) * Adds base for updating Microsoft.DigitalTwins from version stable/2020-12-01 to version 2021-06-30-preview * Updates readme * Updates API version in new specs and examples * Add RM API Version Microsoft.DigitalTwins 2021-06-30-preview (Azure#3404) * Add SDK Generation Options for new API Version (Azure#3179) * Add SDK generation for 2021-06-30-preview * The following fixes were done: * Fixed schema location: preview instead of stable * Updated go SDK generation to point to preview namespace * Remove Ruby support * add SystemData and update instance and endpoints definitions * added systemdata to all examples * fix typo * fix prettier issues * added experimental operations fix * fixed some errors * addressed lint and model errors * fixed type issues with endpoints examples * Fixed autorest error * removed unnecessary _allOf_s * Add Time Series Database Connection Resource and CRUD API Endpoints (Azure#3180) * Added basic time series integration resource CRUD and resource description * Add list call for TSDB integration resources * Modify naming for adx endpoint * Rename document names and paths from integration resources to time series database connections; also clean up descriptions, and make more specific to time series database connections (rather than general integrations) * Update operation names * Resolve review comments * Add examples for time series database connection CRUD * Add example for missing status code 200 to DELETE * Run prettier and fix formatting issues * Align tags, solve issue in Python SDK generation * Align python readme * Fix linter error * Fix linter error 2 * Fix linter error * Made privateEndpointConnections readonly, added additional documentation for keybased and entitybased authenticationType (Azure#3358) * Address major lintdiff warnings * Fix more linter warnings * Address remaining lintdiff warnings and errors * Remove property flattening to avoid issues with polymorphism, edit suppression directives to point to new location * Address lintdiff error * Add systemData property to private endpoint connection resource * Address breaking change warnings * Fix inheritance * Update suppressions to point to new locations in document * Updated TSDB connection parameter set * Fix issue in property set * Revert readOnly=true from private endpoint connections property * Revert change to TopicEndpoint * Back to camelcase... * Revert change in old API version * Revert TopicEndpoint back to camelCase * Revert allOf addition * Change capitalization of TopicEndpoint back to original from previous version * Add approved suppression * Fix $.definitions path in suppression rules Co-authored-by: Nate Lehman <nalehman@microsoft.com> Co-authored-by: Nate Lehman <njlehman1@gmail.com> * Align with repo (Azure#5658) Co-authored-by: Nate Lehman <nalehman@microsoft.com> Co-authored-by: Nate Lehman <njlehman1@gmail.com>
…sion preview/2021-12-10-preview (Azure#17047) * Adds base for updating Microsoft.HybridCompute from version preview/2021-06-10-preview to version 2021-12-10-preview * Updates readme * Updates API version in new specs and examples * added CloudMetadata to the swagger and updated cli/az config files * added code 200 to examples * fixed Linter issue * ran npm prettier * added patchMode to the API * reverted the accidental change of package-lock.json * addressed code reviews && added justin's agentConfiguration * ran npm prettier * added words to the ./custom-words.txt and fixed a type error in .json * Change readonly to readOnly * changed enum True to true, False to false. Added descriptions for new definitions * moved the agentConfiguration description to the right place * renamed agentConfiguration properties * added type object ot defintions * changed the agentConfiguration properties namings in examples * added operations list example * shortened the example and ran npm prettier * removed lastupdatedby and lastupdatedtimestamp * reverted enum true/false to boolean * removed extra coloumns * fixed examples * fixed examples
…ors (Azure#17319) * Add GET all methods for resource group and subscription * Fix Linter Validation issue * Fix Swagger Correctness S360 items * Fix swagger validation comments * Fix model validaiton * Fix Lint errors * Fix model validation for examples * IoT Central Public API 1.1-preview Oct Release (Azure#16514) * Add new 2.0-preview.1 version for IoT Central * fix typo on enum value * rollback 1.0 changes, applied 2.0-preview.1 * fix typo * remove non-used examples * fix style * update version from 2.0-preview.1 to 1.1-preview * update code review comments, fix patch consumes with json-patch support, fix examples for fileupload * add nextLink to collection of orgs * fix typo * fix wrong position of paging * fix the paging * add . to description * update default to use enum for api-version * add oct release with query, cde v2, device filter, device template filter, relationship, edge template, simplified template patching * update examples * fix lint error, model validation * fix missing type in examples, remove url format * fix ID case * fix id case * fix ID case * add iotc query language reference * fix typo * Make ConfigurationSetting read-only property * Fix Swagger S360 issues * Remove the unknown file * Fix prettier check * Changing the vmssResourceId to camelCasing * Revert the readOnly tag on name property Co-authored-by: Aashish Rajaram Salokhe <aasalokh@microsoft.com> Co-authored-by: Johnson Yang <hayang@microsoft.com>
Co-authored-by: Priyankar Gupta <priyagupta@microsoft.com>
… header (Azure#17606) * Update EventGrid data-plane Swagger to include aeg-channel-name in header * Update EventGrid data-plane SDK with aeg-channel-name header requirement * Addressed review comments * Prettier fix * Encoding single quote in description * Fix apostrophe * Remove apos for simplicity Co-authored-by: Laurent Mazuel <lmazuel@microsoft.com>
* WIP for language api spec for TA * Updated preview version number; finished up async definitions * Finished first draft of full spec * Finished first draft of full spec, minus FHIR structuring in HC output * Removed features not included in 2021-11-01 preview * Update custom text tasks TODOs * Moved common definitions to TA-specific definitions * Added custom text tasks to JobManifest * Addressing feedback from PR comments and internal review * Addressed some PR comments * Updated some remaining references to documents * PR comments * Updated a previous change * Reverted references to 'records' back to 'documents' * A few small updates to examples; removed base Task type to simplify structure * PR comments * Addressed TODO items; removed LD-related objects (will be added in another preview) * Fixed anonymous types * Removed required field for body in POST request * Fix prettier check * Added a few more details; experimental change for documents property * Ran prettier * Correction to AnalysisInput object * Merged changes from 2021-11-01-preview and moved new changes to 2022-02-01 * PR comments * Updates to the design for tasks * Added custom entities task to examples * Updates * Finished implementation of discriminator pattern and added some exmaples * Updates * Prettier * Fixed semantic validation errors * Fixed model validation * Another model validation fix * Debugging model validation errors * Using a different discriminator enum for output schemas * Fixed some missing discriminator updates * More semantic validation fixes * Fixed model validation errors; updated sample names * Fixed linting errors and addressed some warnings in the linter output * Ran prettier on examples * PR comments and some minor restructuring * Ran prettier * Removed a duplicate schema from CustomEntitiesTaskParameters * PR comments * PR comments * PR comments * Added missing job task status 'partiallySucceeded' * PR comments * Fix typo causing spell check error * Using common skip and top parameters * Using common StringIndexType definition * Reverted changes to taskName * Updated example * Description update * Description update * PR comments * Updated examples * Fixed issues in examples Co-authored-by: Abigail Hartman <Abigail.Hartman@microsoft.com> Co-authored-by: Kareem Yousef <kayousef@microsoft.com> Co-authored-by: Abby Hartman <abhahn@microsoft.com>
* Check in public swagger for managed resolver * Addressed code review suggestions * Fixed lint errors * Fixed empty space issue * Comment out all-tags-version * Fixed staging lint warnings * Removed the unreferenced file * Suppressed the rules * Modified the reasons for suppressions * Exact same files as the private repo * New changes on the top of private repo Co-authored-by: Arpit Gagneja <argagnej@microsoft.com>
This was referenced Mar 2, 2022
Draft
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- [ ] SDK of .NET (need service team to ensure code readiness)
- [ ] SDK of Python
- [ ] SDK of Java
- [ ] SDK of Js
- [ ] SDK of Go
- [ ] PowerShell
- [ ] CLI
- [ ] Terraform
- [x] No refresh required for updates in this PR
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.