-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Note: We are creating a new api-version with this change. Watchlists.json 2022-01-01-preview parameter name changes" #18064
Revert "Note: We are creating a new api-version with this change. Watchlists.json 2022-01-01-preview parameter name changes" #18064
Conversation
…chlists.json 2022-01-01-preview parameter name changes (Azure#17848)" This reverts commit c206825.
Hi, @anat-gilenson Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
The child tracked resource, 'watchlistItems' with immediate parent 'Watchlist', must have a list by immediate parent operation. Location: Microsoft.SecurityInsights/preview/2022-01-01-preview/Watchlists.json#L596 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDeleted Location: Microsoft.SecurityInsights/preview/2022-01-01-preview/Watchlists.json#L520 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDeleted Location: Microsoft.SecurityInsights/preview/2022-01-01-preview/Watchlists.json#L627 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌
Cross-Version Breaking Changes: 1 Errors, 2 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.9.3)
- current:preview/2022-01-01-preview/Watchlists.json compared with base:stable/2021-10-01/Watchlists.json
- current:preview/2022-01-01-preview/Watchlists.json compared with base:preview/2021-10-01-preview/Watchlists.json
Rule | Message |
---|---|
1007 - RemovedClientParameter |
The new version is missing a client parameter that was found in the old version. Was 'ODataSkipToken' removed or renamed? New: Microsoft.SecurityInsights/preview/2022-01-01-preview/Watchlists.json#L665:3 Old: Microsoft.SecurityInsights/stable/2021-10-01/Watchlists.json#L667:3 |
The optional parameter '$skipToken' was removed in the new version. Old: Microsoft.SecurityInsights/stable/2021-10-01/Watchlists.json#L49:9 |
|
The optional parameter '$skipToken' was removed in the new version. Old: Microsoft.SecurityInsights/stable/2021-10-01/Watchlists.json#L240:9 |
️️✔️
SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
Reverts #17848