Gargankit/azure cli test #18100

gargankit-microsoft · 2022-03-04T11:04:41Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-03-04T11:04:44Z

Hi, @gargankit-microsoft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-workflow-bot · 2022-03-04T11:04:45Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2022-03-04T11:04:46Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️LintDiff: 21 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.2 )
- workloads/resource-manager/readme.md tag:package-2021-12-01-preview
Linted configuring files (Based on target branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.2 )
- workloads/resource-manager/readme.md tag:default

The following errors/warnings are introduced by current PR:

Rule	Message
⚠️ R1003 - ListInOperationName	Since operation 'SAPSupportedSku' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L99
⚠️ R1003 - ListInOperationName	Since operation 'SAPDiskConfigurations' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L155
⚠️ R1003 - ListInOperationName	Since operation 'SAPAvailabilityZoneDetails' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L205
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1699
⚠️ R2066 - PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'getsizingrecommendations' in:'SAPSizingRecommendations'. Consider updating the operationId Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L43
⚠️ R2066 - PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'getsapsupportedsku' in:'SAPSupportedSku'. Consider updating the operationId Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L99
⚠️ R2066 - PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'getdiskconfigurations' in:'SAPDiskConfigurations'. Consider updating the operationId Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L155
⚠️ R2066 - PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'getavailabilityzonedetails' in:'SAPAvailabilityZoneDetails'. Consider updating the operationId Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L205
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'applicationInstances' with immediate parent 'SAPVirtualInstance', must have a list by immediate parent operation. Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2859
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'centralInstances' with immediate parent 'SAPVirtualInstance', must have a list by immediate parent operation. Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3033
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'databaseInstances' with immediate parent 'SAPVirtualInstance', must have a list by immediate parent operation. Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3100
⚠️ R3017 - GuidUsage	Guid used in model definition 'UserAssignedIdentity' for property 'principalId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Workloads/preview/2021-12-01-preview/managedidentity.json#L21
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disablePasswordAuthentication Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1841
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isAppServerCertified Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2059
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDatabaseCertified Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2063
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: hardStop Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2510
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.Workloads/preview/2021-12-01-preview/types.json#L373
⚠️ R4021 - DescriptionAndTitleMissing	'identity' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1718
⚠️ R4021 - DescriptionAndTitleMissing	'virtualMachineId' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2592
⚠️ R4021 - DescriptionAndTitleMissing	'virtualMachineId' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2602
⚠️ R4021 - DescriptionAndTitleMissing	'identity' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2688

️❌Avocado: 2 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` INCONSISTENT_API_VERSION	The API version of the swagger is inconsistent with its file path. readme: specification/workloads/resource-manager/readme.md json: Microsoft.Workloads/preview/2021-12-01-preview/types.json
`❌` INCONSISTENT_API_VERSION	The API version of the swagger is inconsistent with its file path. readme: specification/workloads/resource-manager/readme.md json: Microsoft.Workloads/preview/2021-12-01-preview/managedidentity.json

️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

workloads/resource-manager/readme.md#package-2021-12-01-preview

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-03-04T11:04:46Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-workloads - first release
️✔️azure-sdk-for-go - preview/workloads/mgmt/2021-12-01-preview/workloads - v62.1.0

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from b059f0e384ac0cb386e76517ec09f8c7a776642f. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/workloads/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
warn	No package detected after generation

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from b059f0e384ac0cb386e76517ec09f8c7a776642f. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.3.1 -> 8.5.4
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.4>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.5.4` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-workloads [View full logs] [Preview SDK Changes]
- azure_mgmt_workloads-1.0.0b1-py3-none-any.whl
- azure-mgmt-workloads-1.0.0b1.zip
```
info	[Changelog]   - Initial Release
```

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from b059f0e384ac0cb386e76517ec09f8c7a776642f. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️preview/workloads/mgmt/2021-12-01-preview/workloads [View full logs] [Preview SDK Changes]
```
info	[Changelog] This is a new package
info	[Changelog]
```

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs] Generate from b059f0e384ac0cb386e76517ec09f8c7a776642f. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh]  WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] notice created a lockfile as package-lock.json. You should commit this file.
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-workloads [View full logs] [Preview SDK Changes]
- azure-arm-workloads-1.0.0-beta.1.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from b059f0e384ac0cb386e76517ec09f8c7a776642f. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️workloads [View full logs] [Preview Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

…s-identifiers

openapi-workflow-bot · 2022-03-04T15:16:38Z

Hi @gargankit-microsoft, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

This reverts commit d1cbdd3.

This reverts commit 7fe885a.

…wed: x-ms-identifiers" This reverts commit 8ff859f.

openapi-workflow-bot · 2022-03-07T14:29:52Z

Hi, @gargankit-microsoft your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

…ree/master/specification/logic/resource-manager

ghost · 2022-03-27T16:02:05Z

Hi, @gargankit-microsoft. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

ghost · 2022-04-11T05:01:55Z

Hi, @gargankit-microsoft. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

JackTn · 2022-06-16T03:29:14Z

Hi, @gargankit-microsoft. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

gargankit-microsoft added 2 commits March 4, 2022 14:11

added Initial swagger and examples for Microsoft.workloads

b45c08f

Merge remote-tracking branch 'origin/main' into gargankit/azureCliTest

0133fcb

gargankit-microsoft added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Mar 4, 2022

gargankit-microsoft requested review from msyyc, BigCat20196, ArcturusZhang, jsntcy and qiaozha as code owners March 4, 2022 11:04

openapi-assignment-bot bot assigned jianyexi Mar 4, 2022

gargankit-microsoft removed request for ArcturusZhang, jsntcy, BigCat20196, qiaozha and msyyc March 4, 2022 11:05

gargankit-microsoft unassigned jianyexi Mar 4, 2022

gargankit-microsoft added 3 commits March 4, 2022 19:20

updated CLI for extension generation

7fe885a

updated for CLI

d1cbdd3

fixed ERROR: Schema violation: Additional properties not allowed: x-m…

8ff859f

…s-identifiers

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Mar 4, 2022

gargankit-microsoft added 2 commits March 4, 2022 20:54

Revert "updated for CLI"

fde617a

This reverts commit d1cbdd3.

Revert "updated CLI for extension generation"

ab6eb85

This reverts commit 7fe885a.

Revert "fixed ERROR: Schema violation: Additional properties not allo…

74ddd80

…wed: x-ms-identifiers" This reverts commit 8ff859f.

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Mar 4, 2022

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 7, 2022

gargankit-microsoft removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 7, 2022

gargankit-microsoft added 3 commits March 7, 2022 20:40

updated readme as per https://github.com/Azure/azure-rest-api-specs/t…

d4600ee

…ree/master/specification/logic/resource-manager

Merge remote-tracking branch 'origin/main' into gargankit/azureCliTest

836ced9

updated dependencies to local

3d28630

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Mar 11, 2022

ghost added the no-recent-activity label Mar 27, 2022

ghost closed this Apr 11, 2022

JackTn deleted the gargankit/azureCliTest branch July 5, 2022 01:20

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gargankit/azure cli test #18100

Gargankit/azure cli test #18100

gargankit-microsoft commented Mar 4, 2022 •

edited

Loading

openapi-workflow-bot bot commented Mar 4, 2022

openapi-workflow-bot bot commented Mar 4, 2022

openapi-pipeline-app bot commented Mar 4, 2022 •

edited

Loading

openapi-pipeline-app bot commented Mar 4, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Mar 4, 2022

openapi-workflow-bot bot commented Mar 7, 2022

ghost commented Mar 27, 2022

ghost commented Apr 11, 2022

JackTn commented Jun 16, 2022

Gargankit/azure cli test #18100

Gargankit/azure cli test #18100

Conversation

gargankit-microsoft commented Mar 4, 2022 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Mar 4, 2022

openapi-workflow-bot bot commented Mar 4, 2022

openapi-pipeline-app bot commented Mar 4, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Mar 4, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Mar 4, 2022

openapi-workflow-bot bot commented Mar 7, 2022

ghost commented Mar 27, 2022

ghost commented Apr 11, 2022

JackTn commented Jun 16, 2022

gargankit-microsoft commented Mar 4, 2022 •

edited

Loading

openapi-pipeline-app bot commented Mar 4, 2022 •

edited

Loading

openapi-pipeline-app bot commented Mar 4, 2022 •

edited

Loading