[Microsoft.DeviceUpdate] (Internal only) Added Private Endpoint Proxy Private Endpoint Update #18281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
@raych1 the checks are not starting, nor is the PR assigned to anyone. Do I need to do anything else? |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 18281 in repo Azure/azure-rest-api-specs |
|
/azp run |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
Missing identifier id in array item property Location: Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json#L1386 |
|
Missing identifier id in array item property Location: Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json#L1650 |
|
Missing identifier id in array item property Location: Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json#L1657 |
|
Missing identifier id in array item property Location: Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json#L1747 |
| The API version:2020-03-01-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json#L6 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️❌Lint(RPaaS): 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
[RPaaS] The resource PrivateEndpointConnectionProxy is defined without 'provisioningState' in properties bag, consider adding the provisioningState for it. Location: Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json#L1590 |
Swagger Generation Artifacts
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @darkoa-msft, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
These are Network RP required changes. No one else is using this API. It is in the public swagger because we are behind RPaaS and cannot have internal API. |
raych1
approved these changes
Mar 18, 2022
Approved breaking change for the reason above and same change for network RP was approved in previous PR. |
openapi-pipeline-app
bot
removed
BreakingChangeReviewRequired
CI-BreakingChange-Go-V2
labels
raych1
reviewed
Mar 18, 2022
| ] | ||
| ], | ||
| "properties": { | ||
| "properties": { |
There was a problem hiding this comment.
Pls remove line#1602,corresponding '}', and line#1605.
raych1
reviewed
Mar 18, 2022
| "x-ms-client-flatten": true, | ||
| "description": "The provisioning state of the private endpoint connection proxy resource." | ||
| } | ||
| "provisioningState": { |
There was a problem hiding this comment.
replace provisioningState by properties to clean up the errors.
raych1
added
the
Approved-BreakingChange
This was referenced Mar 19, 2022
25 tasks
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
May 16, 2022
… Private Endpoint Update (Azure#18281) * (Internal only) Added Private Endpoint Proxy Private Endpoint Update * The existing resource also needs a change * Renamed example * Fixing more copy and paste errors * Removed read only, formatted new file * Move provisioning state inside proxy properties * Revert "Move provisioning state inside proxy properties" This reverts commit 414d0c6. * Moved proxy provisioning state into properties, try Azure#2 * Moved proxy provisioning state into properties, try number 3 * Moved proxy provisioning state into properties, try number 4 * Moved Proxy provisioningState to top level, removed property bag * Fixed a naming error * Linter fixes * Removed flatten in Proxy properties * Reverted all provisioningState changes * Swapped properties to match the old swagger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.