Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataFactory] Fix Expression mode for SqlServerStoredProcedureActivity #18419

Merged
merged 3 commits into from
Mar 29, 2022

Conversation

seanwang051
Copy link
Contributor

@seanwang051 seanwang051 commented Mar 28, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@seanwang051 seanwang051 requested review from JeffreyRichter and MushMal and removed request for a team March 28, 2022 01:52
@openapi-workflow-bot
Copy link

Hi, @seanwang051 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 28, 2022

    Swagger Validation Report

    ️❌BreakingChange: 3 Errors, 0 Warnings failed [Detail]
    Rule Message
    1022 - RemovedAdditionalProperties The new version removes the 'additionalProperties' element.
    New: stable/2018-06-01/entityTypes/Pipeline.json#L6023:9
    Old: stable/2018-06-01/entityTypes/Pipeline.json#L6023:9
    1022 - RemovedAdditionalProperties The new version removes the 'additionalProperties' element.
    New: preview/2021-06-01-preview/entityTypes/Pipeline.json#L5720:9
    Old: preview/2021-06-01-preview/entityTypes/Pipeline.json#L5720:9
    1022 - RemovedAdditionalProperties The new version removes the 'additionalProperties' element.
    New: stable/2020-12-01/entityTypes/Pipeline.json#L5750:9
    Old: stable/2020-12-01/entityTypes/Pipeline.json#L5750:9
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L46
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L46
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L238
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L238
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L5263
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L5263
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L6097
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L6097
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L6517
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L6517
    R4037 - MissingTypeObject The schema 'ControlActivity' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L197
    R4037 - MissingTypeObject The schema 'ControlActivity' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L197
    R4037 - MissingTypeObject The schema 'ExecutionActivity' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L207
    R4037 - MissingTypeObject The schema 'ExecutionActivity' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L207
    R4037 - MissingTypeObject The schema 'CopyActivity' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L1536
    R4037 - MissingTypeObject The schema 'CopyActivity' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L1536
    R4037 - MissingTypeObject The schema 'CopyActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L1575
    R4037 - MissingTypeObject The schema 'CopyActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L1575
    R4037 - MissingTypeObject The schema 'HDInsightHiveActivity' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L5193
    R4037 - MissingTypeObject The schema 'HDInsightHiveActivity' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L5193
    R4037 - MissingTypeObject The schema 'HDInsightHiveActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L5212
    R4037 - MissingTypeObject The schema 'HDInsightHiveActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L5212
    R4037 - MissingTypeObject The schema 'HDInsightPigActivity' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L5282
    R4037 - MissingTypeObject The schema 'HDInsightPigActivity' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L5282
    R4037 - MissingTypeObject The schema 'HDInsightPigActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L5301
    R4037 - MissingTypeObject The schema 'HDInsightPigActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L5301
    R4037 - MissingTypeObject The schema 'HDInsightMapReduceActivity' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L5340
    R4037 - MissingTypeObject The schema 'HDInsightMapReduceActivity' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L5340
    R4037 - MissingTypeObject The schema 'HDInsightMapReduceActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L5359
    R4037 - MissingTypeObject The schema 'HDInsightMapReduceActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2018-06-01/entityTypes/Pipeline.json#L5359
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Mar 28, 2022
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 28, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go-track2 - armdatafactory - 0.4.0
    +	Function `SQLServerStoredProcedureActivityTypeProperties.MarshalJSON` has been removed
    +	Type of `SQLServerStoredProcedureActivityTypeProperties.StoredProcedureParameters` has been changed from `map[string]*StoredProcedureParameter` to `interface{}`
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-datafactory - 2.3.0
    azure-sdk-for-go - datafactory/mgmt/2018-06-01/datafactory - v62.3.0
    +	Function `SQLServerStoredProcedureActivityTypeProperties.MarshalJSON` has been removed
    +	Type of `SQLServerStoredProcedureActivityTypeProperties.StoredProcedureParameters` has been changed from `map[string]*StoredProcedureParameter` to `interface{}`
    azure-sdk-for-go - preview/datafactory/mgmt/2017-09-01-preview/datafactory - v62.3.0
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 29398c4. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      warn		specification/synapse/data-plane/readme.md skipped due to azure-sdk-for-net not found in swagger-to-sdk
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/datafactory/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.DataFactory [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 29398c4. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      warn		specification/synapse/data-plane/readme.md skipped due to azure-sdk-for-python-track2 not found in swagger-to-sdk
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New patch version of npm available! 8.5.0 -> 8.5.5
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.5>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.5.5` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-datafactory [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model WebActivity has a new parameter disable_cert_validation
    ️⚠️ azure-sdk-for-java warning [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 29398c4. SDK Automation 14.0.0
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      warn		specification/synapse/data-plane/readme.md skipped due to azure-sdk-for-go not found in swagger-to-sdk
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️datafactory/mgmt/2018-06-01/datafactory [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `SQLServerStoredProcedureActivityTypeProperties.StoredProcedureParameters` has been changed from `map[string]*StoredProcedureParameter` to `interface{}`
      info	[Changelog] - Function `SQLServerStoredProcedureActivityTypeProperties.MarshalJSON` has been removed
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 0 additive change(s).
    • ️✔️preview/datafactory/mgmt/2017-09-01-preview/datafactory [View full logs
      Only show 60 items here, please refer to log for details.
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `Insert`
      info	[Changelog] - New const `Percentage`
      info	[Changelog] - New const `Unavailable`
      info	[Changelog] - New const `SERIAL`
      info	[Changelog] - New const `QUORUM`
      info	[Changelog] - New const `Date`
      info	[Changelog] - New const `ALL`
      info	[Changelog] - New const `GUID`
      info	[Changelog] - New const `Decimal`
      info	[Changelog] - New const `IntegrationRuntimeStateOffline`
      info	[Changelog] - New const `Int64`
      info	[Changelog] - New const `Value`
      info	[Changelog] - New const `OnPremisesWithIfd`
      info	[Changelog] - New const `IntegrationRuntimeStateNeedRegistration`
      info	[Changelog] - New const `ONE`
      info	[Changelog] - New const `TWO`
      info	[Changelog] - New const `SapCloudForCustomerSinkWriteBehaviorUpdate`
      info	[Changelog] - New const `IntegrationRuntimeStateStopping`
      info	[Changelog] - New const `IntegrationRuntimeStateOnline`
      info	[Changelog] - New const `LOCALONE`
      info	[Changelog] - New const `Query`
      info	[Changelog] - New const `Office365`
      info	[Changelog] - New const `IntegrationRuntimeStateLimited`
      info	[Changelog] - New const `Int`
      info	[Changelog] - New const `Recycling`
      info	[Changelog] - New const `THREE`
      info	[Changelog] - New const `Ifd`
      info	[Changelog] - New const `LOCALSERIAL`
      info	[Changelog] - New const `SapCloudForCustomerSinkWriteBehaviorInsert`
      info	[Changelog] - New const `EACHQUORUM`
      info	[Changelog] - New const `IntegrationRuntimeStateStarting`
      info	[Changelog] - New const `QueryAll`
      info	[Changelog] - New const `Disabled`
      info	[Changelog] - New const `IntegrationRuntimeStateInitial`
      info	[Changelog] - New const `LOCALQUORUM`
      info	[Changelog] - New const `Upload`
      info	[Changelog] - New const `Merge`
      info	[Changelog] - New const `Optimal`
      info	[Changelog] - New const `Available`
      info	[Changelog] - New const `Boolean`
      info	[Changelog] - New const `String`
      info	[Changelog] - New const `Upsert`
      info	[Changelog] - New const `IntegrationRuntimeStateStopped`
      info	[Changelog] - New const `Fastest`
      info	[Changelog] - New const `IntegrationRuntimeStateStarted`
      info	[Changelog] - New function `PossibleSapCloudForCustomerSinkWriteBehaviorValues() []SapCloudForCustomerSinkWriteBehavior`
      info	[Changelog] - New function `PossibleSalesforceSinkWriteBehaviorValues() []SalesforceSinkWriteBehavior`
      info	[Changelog] - New function `PossibleCassandraSourceReadConsistencyLevelsValues() []CassandraSourceReadConsistencyLevels`
      info	[Changelog] - New function `PossibleAzureSearchIndexWriteBehaviorTypeValues() []AzureSearchIndexWriteBehaviorType`
      info	[Changelog] - New function `PossibleDynamicsAuthenticationTypeValues() []DynamicsAuthenticationType`
      info	[Changelog] - New function `PossiblePolybaseSettingsRejectTypeValues() []PolybaseSettingsRejectType`
      info	[Changelog] - New function `PossibleDynamicsDeploymentTypeValues() []DynamicsDeploymentType`
      info	[Changelog] - New function `PossibleStoredProcedureParameterTypeValues() []StoredProcedureParameterType`
      info	[Changelog] - New function `PossibleSalesforceSourceReadBehaviorValues() []SalesforceSourceReadBehavior`
      info	[Changelog] - New function `PossibleDatasetCompressionLevelValues() []DatasetCompressionLevel`
      info	[Changelog] - New field `DisableCertValidation` in struct `WebActivityTypeProperties`
      info	[Changelog]
      info	[Changelog] Total 28 breaking change(s), 56 additive change(s).
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 29398c4. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      warn		specification/synapse/data-plane/readme.md skipped due to azure-sdk-for-go-track2 not found in swagger-to-sdk
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armdatafactory [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `SQLServerStoredProcedureActivityTypeProperties.StoredProcedureParameters` has been changed from `map[string]*StoredProcedureParameter` to `interface{}`
      info	[Changelog] - Function `SQLServerStoredProcedureActivityTypeProperties.MarshalJSON` has been removed
      info	[Changelog] - Struct `TypeConversionSettings` has been removed
      info	[Changelog]
      info	[Changelog] Total 4 breaking change(s), 0 additive change(s).
    ️❌ azure-sdk-for-js failed [Detail]
    • Failed [Logs]Release - Generate from 29398c4. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh]  deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
      cmderr	[automation_init.sh]  uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh]  @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh] WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-datafactory [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added Type Alias CredentialReferenceType
      info	[Changelog]   - Added Type Alias DataFlowReferenceType
      info	[Changelog]   - Added Type Alias ManagedVirtualNetworkReferenceType
      info	[Changelog]   - Added Type Alias TriggerReferenceType
      info	[Changelog]   - Type Alias SqlServerStoredProcedureActivity has a new parameter storedProcedureParameters
      info	[Changelog]   - Type Alias WebActivity has a new parameter disableCertValidation
      info	[Changelog]   - Added Enum KnownCredentialReferenceType
      info	[Changelog]   - Added Enum KnownDataFlowReferenceType
      info	[Changelog]   - Added Enum KnownManagedVirtualNetworkReferenceType
      info	[Changelog]   - Added Enum KnownTriggerReferenceType
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 29398c4. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️datafactory [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost
    Copy link

    ghost commented Mar 28, 2022

    Thank you for your contribution seanwang051! We will review the pull request and get back to you soon.

    @openapi-workflow-bot
    Copy link

    Hi @seanwang051, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Mar 28, 2022
    @JeffreyRichter JeffreyRichter removed their request for review March 28, 2022 18:25
    @lmazuel lmazuel merged commit 29398c4 into Azure:main Mar 29, 2022
    visingl pushed a commit that referenced this pull request Mar 30, 2022
    #18419)
    
    * update
    
    * update
    
    * fix
    
    Co-authored-by: xiaojwan <xiaojwan@microsoft.com>
    FredericHeem pushed a commit to grucloud/azure-rest-api-specs that referenced this pull request May 16, 2022
    Azure#18419)
    
    * update
    
    * update
    
    * fix
    
    Co-authored-by: xiaojwan <xiaojwan@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Go-V2 customer-reported Issues that are reported by GitHub users external to the Azure organization.
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants