Afd Migration swagger changes #18738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gubalasu
requested review from
jorinmejia,
yunheMsft and
t-bzhan
as code owners
|
Hi, @gubalasu Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: canMigrate Location: Microsoft.Cdn/preview/2022-05-01-preview/cdn.json#L2716 |
|
| 'errors' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Cdn/preview/2022-05-01-preview/cdn.json#L2746 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/afdx.json#L5494 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/afdx.json#L5510 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/afdx.json#L5719 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/afdx.json#L5735 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/cdn.json#L3534 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/cdn.json#L3534 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/cdn.json#L3534 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/cdn.json#L3580 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/cdn.json#L3580 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/cdn.json#L3580 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/cdn.json#L3611 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/cdn.json#L3611 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/cdn.json#L3611 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/cdn.json#L3633 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/cdn.json#L3633 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/cdn.json#L3633 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/cdn.json#L3686 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/cdn.json#L3686 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/cdn.json#L3686 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/cdn.json#L3743 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/cdn.json#L3743 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/cdn.json#L3743 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/cdn.json#L3796 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/cdn.json#L3796 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/cdn.json#L3796 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/cdn.json#L3853 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/cdn.json#L3853 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/cdn.json#L3853 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/cdn.json#L3906 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-05-01-preview/cdn.json#L3906 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️Cross-Version Breaking Changes: 221 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.9.3)
- current:preview/2022-05-01-preview/afdx.json compared with base:stable/2021-06-01/afdx.json
- current:preview/2022-05-01-preview/cdn.json compared with base:stable/2021-06-01/cdn.json
- current:preview/2022-05-01-preview/cdn.json compared with base:preview/2019-06-15-preview/cdn.json
- current:preview/2022-05-01-preview/cdnwebapplicationfirewall.json compared with base:stable/2021-06-01/cdnwebapplicationfirewall.json
- current:preview/2022-05-01-preview/cdnwebapplicationfirewall.json compared with base:preview/2019-06-15-preview/cdnwebapplicationfirewall.json
Only 30 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @gubalasu your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
|
Hi @gubalasu, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Apr 19, 2022
Closed
Closed
|
@gubalasu - Couple of things required before your change is ready for ARM review:
|
mentat9
added
the
ARMChangesRequested
Created this PR with the steps mentioned above: #18760 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.