Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Gateway Routing Rule priority changes #19019

Merged
merged 1 commit into from
May 20, 2022

Conversation

vinaymundada27
Copy link
Contributor

@vinaymundada27 vinaymundada27 commented May 11, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @vinaymundada27 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 11, 2022

    Swagger Validation Report

    ️❌BreakingChange: 4 Errors, 0 Warnings failed [Detail]
    Rule Message
    1034 - AddedRequiredProperty The new version has new required property 'priority' that was not found in the old version.
    New: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L2432:7
    Old: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L2432:7
    1034 - AddedRequiredProperty The new version has new required property 'priority' that was not found in the old version.
    New: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L2480:9
    Old: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L2468:9
    1034 - AddedRequiredProperty The new version has new required property 'priority' that was not found in the old version.
    New: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L2430:5
    Old: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L2430:5
    1041 - AddedPropertyInResponse The new version has a new property 'priority' in response that was not found in the old version.
    New: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L2432:7
    Old: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L2432:7
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L919
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L955
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L991
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L2554
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L2554
    R4037 - MissingTypeObject The schema 'ApplicationGatewayOnDemandProbe' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1156
    R4037 - MissingTypeObject The schema 'ApplicationGatewayBackendHealthOnDemand' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1194
    R4037 - MissingTypeObject The schema 'ApplicationGatewayBackendHealth' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1207
    R4037 - MissingTypeObject The schema 'ApplicationGatewayBackendHealthPool' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1219
    R4037 - MissingTypeObject The schema 'ApplicationGatewayBackendHealthHttpSettings' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1235
    R4037 - MissingTypeObject The schema 'ApplicationGatewayBackendHealthServer' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1251
    R4037 - MissingTypeObject The schema 'ApplicationGatewaySku' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1283
    R4037 - MissingTypeObject The schema 'ApplicationGatewaySku' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1283
    R4037 - MissingTypeObject The schema 'ApplicationGatewaySslPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1324
    R4037 - MissingTypeObject The schema 'ApplicationGatewaySslPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1324
    R4037 - MissingTypeObject The schema 'ApplicationGatewayClientAuthConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1364
    R4037 - MissingTypeObject The schema 'ApplicationGatewayClientAuthConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1364
    R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1373
    R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1373
    R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1373
    R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1373
    R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1373
    R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1373
    R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1373
    R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1373
    R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1373
    R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1373
    R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1373
    R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1373
    R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1373
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the Network label May 11, 2022
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 11, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go-track2 - armnetwork - 0.6.0
    azure-sdk-for-js - @azure/arm-network - 28.0.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-network - 20.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2021-08-01/network - v64.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2021-05-01/network - v64.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2021-03-01/network - v64.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2021-02-01/network - v64.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2020-11-01/network - v64.0.0
    azure-sdk-for-go - network/mgmt/2020-08-01/network - v64.0.0
    azure-sdk-for-go - network/mgmt/2020-07-01/network - v64.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2020-06-01/network - v64.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2020-05-01/network - v64.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2020-04-01/network - v64.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2020-03-01/network - v64.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-12-01/network - v64.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-11-01/network - v64.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-09-01/network - v64.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-08-01/network - v64.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-07-01/network - v64.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-06-01/network - v64.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-04-01/network - v64.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-02-01/network - v64.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-12-01/network - v64.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-11-01/network - v64.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-10-01/network - v64.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-08-01/network - v64.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-07-01/network - v64.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-06-01/network - v64.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-04-01/network - v64.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-02-01/network - v64.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-01-01/network - v64.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2017-11-01/network - v64.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2017-10-01/network - v64.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2015-06-15/network - v64.0.0
    ️✔️azure-sdk-for-go - preview/network/mgmt/2021-03-01-preview/network - v64.0.0
    ️✔️azure-sdk-for-go - preview/network/mgmt/2021-02-01-preview/network - v64.0.0
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from a8a52b9. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-network [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model ApplicationGatewayRoutingRule has a new parameter priority
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from a8a52b9. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
      cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
      cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
      cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
      cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
      cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
    • ️✔️azure-resourcemanager-network-generated [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from a8a52b9. SDK Automation 14.0.0
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️network/mgmt/2021-08-01/network [View full logs]  [Release SDK Changes]
      Only show 4 items here, please refer to log for details.
      info	[Changelog]
      info	[Changelog] - New field `Priority` in struct `ApplicationGatewayRoutingRulePropertiesFormat`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
    • ️✔️network/mgmt/2021-05-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2021-03-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2021-02-01/network [View full logs
      Only show 4 items here, please refer to log for details.
      info	[Changelog] - New field `ID` in struct `PrivateDNSZoneConfig`
      info	[Changelog] - New field `Type` in struct `PrivateDNSZoneConfig`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 6 additive change(s).
    • ️✔️network/mgmt/2020-11-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2020-08-01/network [View full logs
      Only show 4 items here, please refer to log for details.
      info	[Changelog] - New field `ServicePublicIPAddress` in struct `PublicIPAddressPropertiesFormat`
      info	[Changelog] - New field `MigrationPhase` in struct `PublicIPAddressPropertiesFormat`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 35 additive change(s).
    • ️✔️network/mgmt/2020-07-01/network [View full logs
      Only show 4 items here, please refer to log for details.
      info	[Changelog] - New field `NatGateway` in struct `PublicIPPrefixPropertiesFormat`
      info	[Changelog] - New field `State` in struct `ServiceTagInformationPropertiesFormat`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 27 additive change(s).
    • ️✔️network/mgmt/2020-06-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2020-05-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2020-04-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2020-03-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-12-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-11-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-09-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-08-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-07-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-06-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-04-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-02-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-12-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-11-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-10-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-08-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-07-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-06-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-04-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-02-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-01-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2017-11-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2017-10-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2015-06-15/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/network/mgmt/2021-03-01-preview/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/network/mgmt/2021-02-01-preview/network [View full logs
      info	[Changelog] This is a new package
      info	[Changelog]
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from a8a52b9. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armnetwork [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New field `Priority` in struct `ApplicationGatewayRoutingRulePropertiesFormat`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from a8a52b9. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh]  deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
      cmderr	[automation_init.sh]  uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh] deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh]  @azure/storage-blob@10.5.0: This version has been deprecated, please upgrade to the version tagged as latest
      cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-network [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Type Alias ApplicationGatewayRoutingRule has a new parameter priority
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from a8a52b9. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	Skip detect changed packages
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from a8a52b9. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.network [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @vinaymundada27, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @lirenhe
    Copy link
    Member

    lirenhe commented May 16, 2022

    @vinaymundada27, as this PR contains breaking change, please follow the process to get it reviewed.

    Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

    @lirenhe lirenhe added Reviewed-FeedbackProvided Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 and removed Reviewed-FeedbackProvided labels May 16, 2022
    @lirenhe
    Copy link
    Member

    lirenhe commented May 20, 2022

    Breaking change approved by Jeffrey.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Network
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants