Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ProviderHub] S360 linter issue #19067

Merged
merged 3 commits into from
May 24, 2022
Merged

[ProviderHub] S360 linter issue #19067

merged 3 commits into from
May 24, 2022

Conversation

wwendyc
Copy link
Contributor

@wwendyc wwendyc commented May 13, 2022 •
edited
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented May 13, 2022 •
edited
Loading

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand] 
There are no breaking changes.

️⚠️LintDiff: 0 Warnings warning [Detail]
The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L2317
⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L2585
⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L3538
⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L3630
⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L3966
⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L4408
⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L4679
⚠️ R2017 - PutRequestResponseScheme A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Operations_CreateOrUpdate' Request Model: 'OperationsPutContent' Response Model: 'OperationsContent'
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L769
⚠️ R2064 - LROStatusCodesReturnTypeSchema 200/201 Responses of long running operations must have a schema definition for return type. OperationId: 'ProviderRegistrations_CreateOrUpdate', Response code: '201'
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L941
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L2825
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L3318
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isCheckedIn
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L3436
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L3597
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: preflightSupported
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L3806
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L4034
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableDefaultValidation
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L4141
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: validationRequired
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L4155
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: crossResourceGroupMoveEnabled
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L4158
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: crossSubscriptionMoveEnabled
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L4161
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableAsyncOperation
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L4286
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableThirdPartyS2S
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L4311
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isPureProxy
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L4321
⚠️ R4006 - DeprecatedXmsCodeGenerationSetting The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation.
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L7
⚠️ R4021 - DescriptionAndTitleMissing 'TrafficRegions' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L2141
⚠️ R4021 - DescriptionAndTitleMissing 'regions' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L2144
⚠️ R4021 - DescriptionAndTitleMissing 'CustomRolloutSpecification' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L2152
⚠️ R4021 - DescriptionAndTitleMissing 'canary' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L2158
⚠️ R4021 - DescriptionAndTitleMissing 'providerRegistration' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L2165
⚠️ R4021 - DescriptionAndTitleMissing 'resourceTypeRegistrations' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L2172
⚠️ R4021 - DescriptionAndTitleMissing 'TypedErrorInfo' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L2180
️️✔️Avocado succeeded [Detail] [Expand] 
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand] 
There is no credential detected.
️️✔️PoliCheck succeeded [Detail] [Expand] 
Validation passed for PoliCheck.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
Validation passes for SDKTrack2Validation

️️✔️PrettierCheck succeeded [Detail] [Expand] 
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand] 
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
Validation passes for Lint(RPaaS).
Posted by Swagger Pipeline | How to fix these errors?

@openapi-workflow-bot
Copy link

Hi @wwendyc, this service has enabled Shift Left. All spec updates MUST be initiated from service ADO project repo, so that to guarantee it to be the source of truth.

  • You can refer to Shift Left Solution Introduction for details.
  • Please contact service focal @wwendyc contacts or Shift Left Support Channel if need further help.

    		•

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 13, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-go-track2 - armproviderhub - 2.0.0
    +	Const `OperationsDefinitionActionTypeInternal` has been removed
+	Const `OperationsDefinitionActionTypeNotSpecified` has been removed
+	Const `OperationsDefinitionOriginNotSpecified` has been removed
+	Const `OperationsDefinitionOriginSystem` has been removed
+	Const `OperationsDefinitionOriginUser` has been removed
+	Const `ResourceProviderManagementResourceAccessPolicyAcisActionAllowed` has been removed
+	Const `ResourceProviderManagementResourceAccessPolicyAcisReadAllowed` has been removed
+	Const `ResourceProviderManagementResourceAccessPolicyNotSpecified` has been removed
+	Const `ResourceTypeMarketplaceTypeAddOn` has been removed
+	Const `ResourceTypeMarketplaceTypeBypass` has been removed
+	Const `ResourceTypeMarketplaceTypeNotSpecified` has been removed
+	Const `ResourceTypeMarketplaceTypeStore` has been removed
+	Const `ResourceTypeRegistrationPropertiesMarketplaceTypeAddOn` has been removed
+	Const `ResourceTypeRegistrationPropertiesMarketplaceTypeBypass` has been removed
+	Const `ResourceTypeRegistrationPropertiesMarketplaceTypeNotSpecified` has been removed
+	Const `ResourceTypeRegistrationPropertiesMarketplaceTypeStore` has been removed
+	Const `SKULocationInfoTypeArcZone` has been removed
+	Const `SKULocationInfoTypeEdgeZone` has been removed
+	Const `SKULocationInfoTypeNotSpecified` has been removed
+	Function `PossibleOperationsDefinitionActionTypeValues` has been removed
+	Function `PossibleOperationsDefinitionOriginValues` has been removed
+	Function `PossibleResourceProviderManagementResourceAccessPolicyValues` has been removed
+	Function `PossibleResourceTypeMarketplaceTypeValues` has been removed
+	Function `PossibleResourceTypeRegistrationPropertiesMarketplaceTypeValues` has been removed
+	Function `PossibleSKULocationInfoTypeValues` has been removed
+	Type of `OperationsDefinition.ActionType` has been changed from `*OperationsDefinitionActionType` to `*OperationActionType`
+	Type of `OperationsDefinition.Origin` has been changed from `*OperationsDefinitionOrigin` to `*OperationOrigins`
+	Type of `ResourceProviderManagement.ResourceAccessPolicy` has been changed from `*ResourceProviderManagementResourceAccessPolicy` to `*ResourceAccessPolicy`
+	Type of `ResourceProviderManifestManagement.ResourceAccessPolicy` has been changed from `*ResourceProviderManagementResourceAccessPolicy` to `*ResourceAccessPolicy`
+	Type of `ResourceProviderManifestPropertiesManagement.ResourceAccessPolicy` has been changed from `*ResourceProviderManagementResourceAccessPolicy` to `*ResourceAccessPolicy`
+	Type of `ResourceType.MarketplaceType` has been changed from `*ResourceTypeMarketplaceType` to `*MarketplaceType`
+	Type of `ResourceTypeRegistrationProperties.MarketplaceType` has been changed from `*ResourceTypeRegistrationPropertiesMarketplaceType` to `*MarketplaceType`
+	Type of `ResourceTypeRegistrationPropertiesAutoGenerated.MarketplaceType` has been changed from `*ResourceTypeRegistrationPropertiesMarketplaceType` to `*MarketplaceType`
+	Type of `SKULocationInfo.Type` has been changed from `*SKULocationInfoType` to `*ExtendedLocationType`
    ️✔️azure-sdk-for-go - providerhub/mgmt/2020-11-20/providerhub - v65.0.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-providerhub - first release
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 836a8c6. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.5.5 -> 8.10.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.10.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.10.0` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-providerhub [View full logs]  [Release SDK Changes] 
      info	[Changelog]   - Initial Release
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 836a8c6. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
    • ️✔️azure-resourcemanager-providerhub [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 836a8c6. SDK Automation 14.0.0 
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️providerhub/mgmt/2020-11-20/providerhub [View full logs]  [Release SDK Changes] 
      info	[Changelog] This is a new package
info	[Changelog]
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 836a8c6. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armproviderhub [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `ResourceProviderManifestManagement.ResourceAccessPolicy` has been changed from `*ResourceProviderManagementResourceAccessPolicy` to `*ResourceAccessPolicy`
info	[Changelog] - Type of `ResourceProviderManagement.ResourceAccessPolicy` has been changed from `*ResourceProviderManagementResourceAccessPolicy` to `*ResourceAccessPolicy`
info	[Changelog] - Type of `ResourceProviderManifestPropertiesManagement.ResourceAccessPolicy` has been changed from `*ResourceProviderManagementResourceAccessPolicy` to `*ResourceAccessPolicy`
info	[Changelog] - Type of `ResourceTypeRegistrationPropertiesAutoGenerated.MarketplaceType` has been changed from `*ResourceTypeRegistrationPropertiesMarketplaceType` to `*MarketplaceType`
info	[Changelog] - Type of `ResourceType.MarketplaceType` has been changed from `*ResourceTypeMarketplaceType` to `*MarketplaceType`
info	[Changelog] - Type of `SKULocationInfo.Type` has been changed from `*SKULocationInfoType` to `*ExtendedLocationType`
info	[Changelog] - Type of `OperationsDefinition.ActionType` has been changed from `*OperationsDefinitionActionType` to `*OperationActionType`
info	[Changelog] - Type of `OperationsDefinition.Origin` has been changed from `*OperationsDefinitionOrigin` to `*OperationOrigins`
info	[Changelog] - Type of `ResourceTypeRegistrationProperties.MarketplaceType` has been changed from `*ResourceTypeRegistrationPropertiesMarketplaceType` to `*MarketplaceType`
info	[Changelog] - Const `SKULocationInfoTypeNotSpecified` has been removed
info	[Changelog] - Const `OperationsDefinitionActionTypeNotSpecified` has been removed
info	[Changelog] - Const `ResourceTypeMarketplaceTypeStore` has been removed
info	[Changelog] - Const `ResourceTypeRegistrationPropertiesMarketplaceTypeAddOn` has been removed
info	[Changelog] - Const `OperationsDefinitionOriginUser` has been removed
info	[Changelog] - Const `ResourceTypeMarketplaceTypeAddOn` has been removed
info	[Changelog] - Const `SKULocationInfoTypeEdgeZone` has been removed
info	[Changelog] - Const `ResourceTypeMarketplaceTypeNotSpecified` has been removed
info	[Changelog] - Const `OperationsDefinitionActionTypeInternal` has been removed
info	[Changelog] - Const `ResourceProviderManagementResourceAccessPolicyAcisReadAllowed` has been removed
info	[Changelog] - Const `ResourceTypeRegistrationPropertiesMarketplaceTypeStore` has been removed
info	[Changelog] - Const `OperationsDefinitionOriginSystem` has been removed
info	[Changelog] - Const `ResourceProviderManagementResourceAccessPolicyAcisActionAllowed` has been removed
info	[Changelog] - Const `ResourceTypeMarketplaceTypeBypass` has been removed
info	[Changelog] - Const `ResourceTypeRegistrationPropertiesMarketplaceTypeBypass` has been removed
info	[Changelog] - Const `SKULocationInfoTypeArcZone` has been removed
info	[Changelog] - Const `ResourceProviderManagementResourceAccessPolicyNotSpecified` has been removed
info	[Changelog] - Const `OperationsDefinitionOriginNotSpecified` has been removed
info	[Changelog] - Const `ResourceTypeRegistrationPropertiesMarketplaceTypeNotSpecified` has been removed
info	[Changelog] - Function `PossibleResourceTypeMarketplaceTypeValues` has been removed
info	[Changelog] - Function `PossibleResourceTypeRegistrationPropertiesMarketplaceTypeValues` has been removed
info	[Changelog] - Function `PossibleOperationsDefinitionActionTypeValues` has been removed
info	[Changelog] - Function `PossibleResourceProviderManagementResourceAccessPolicyValues` has been removed
info	[Changelog] - Function `PossibleOperationsDefinitionOriginValues` has been removed
info	[Changelog] - Function `PossibleSKULocationInfoTypeValues` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `OperationActionTypeInternal`
info	[Changelog] - New const `MarketplaceTypeBypass`
info	[Changelog] - New const `ExtendedLocationTypeArcZone`
info	[Changelog] - New const `OperationOriginsUser`
info	[Changelog] - New const `OperationOriginsSystem`
info	[Changelog] - New const `ExtendedLocationTypeNotSpecified`
info	[Changelog] - New const `ExtendedLocationTypeEdgeZone`
info	[Changelog] - New const `OperationActionTypeNotSpecified`
info	[Changelog] - New const `MarketplaceTypeNotSpecified`
info	[Changelog] - New const `ResourceAccessPolicyNotSpecified`
info	[Changelog] - New const `OperationOriginsNotSpecified`
info	[Changelog] - New const `ResourceAccessPolicyAcisReadAllowed`
info	[Changelog] - New const `ResourceAccessPolicyAcisActionAllowed`
info	[Changelog] - New const `MarketplaceTypeStore`
info	[Changelog] - New const `MarketplaceTypeAddOn`
info	[Changelog] - New function `PossibleExtendedLocationTypeValues() []ExtendedLocationType`
info	[Changelog] - New function `PossibleOperationOriginsValues() []OperationOrigins`
info	[Changelog] - New function `PossibleResourceAccessPolicyValues() []ResourceAccessPolicy`
info	[Changelog] - New function `PossibleMarketplaceTypeValues() []MarketplaceType`
info	[Changelog] - New function `PossibleOperationActionTypeValues() []OperationActionType`
info	[Changelog]
info	[Changelog] Total 33 breaking change(s), 20 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 836a8c6. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh]  deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh]  WARN deprecated @azure/storage-blob@10.5.0: This version has been deprecated, please upgrade to the version tagged as latest
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
warn	No file changes detected after generation
warn	No package detected after generation
    ️❌ azure-sdk-for-net failed [Detail]
    • ❌Failed [Logs]Release - Generate from 836a8c6. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/providerhub/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] No usable version of the libssl was found
cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed
    ️❌ azure-powershell failed [Detail]
    • ❌Failed [Logs]Release - Generate from 836a8c6. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ❌Az.providerhub [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi, @wwendyc Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @wwendyc wwendyc changed the title [ProviderHub] x-ms-enum linter and prettier formatting [ProviderHub] S360 linter issue May 13, 2022
    @azure-sdk azure-sdk mentioned this pull request May 13, 2022
    Closed
    This was referenced May 13, 2022
    Closed
    Closed
    Closed
    Closed
    raych1
    raych1 requested changes May 16, 2022
    View reviewed changes
    Copy link
    Member

    @raych1 raych1 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Indent should be 2 spaces. Can you revert it? It's hard to see the diff against previous version.~

    @raych1
    Copy link
    Member

    raych1 commented May 17, 2022

    Pls follow the ci fix instructions to fix prettier errors.

    @raych1
    Copy link
    Member

    raych1 commented May 20, 2022

    As synced offline to publish this change by shift left pipeline.

    @raych1 raych1 closed this May 20, 2022
    @raych1 raych1 reopened this May 24, 2022
    @raych1 raych1 merged commit 836a8c6 into Azure:main May 24, 2022
    This was referenced May 24, 2022
    Closed
    Closed
    Closed
    Closed
    Closed
    gargankit-microsoft pushed a commit that referenced this pull request May 26, 2022
    @wwendyc @gargankit-microsoft
    [ProviderHub] S360 linter issue (#19067)
    974dd5e 
    * x-ms-enum linter and prettier formatting

* formatting

* prettier

Co-authored-by: Wendy Chang <wendychang@gmail.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @raych1 raych1 raych1 approved these changes

    Assignees

    @raych1 raych1

    Labels
    CI-BreakingChange-Go-V2 FixS360 ShiftLeftViolation
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @wwendyc @raych1