Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACI: Correct the type of httpHeaders object->array of object #19103

Merged
merged 2 commits into from
May 27, 2022
Merged

ACI: Correct the type of httpHeaders object->array of object #19103

merged 2 commits into from
May 27, 2022

Conversation

magodo
Copy link
Contributor

@magodo magodo commented May 17, 2022 •
edited
Loading

Fixes #18965

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @magodo Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 17, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 4 Errors, 2 Warnings failed [Detail]
    Rule Message
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'name' renamed or removed?
    Old: Microsoft.ContainerInstance/stable/2020-11-01/containerInstance.json#L1783:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'value' renamed or removed?
    Old: Microsoft.ContainerInstance/stable/2020-11-01/containerInstance.json#L1783:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'name' renamed or removed?
    Old: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L1783:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'value' renamed or removed?
    Old: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L1783:7
    ⚠️ 1026 - TypeChanged The new version has a different type 'array' than the previous one 'object'.
    New: Microsoft.ContainerInstance/stable/2020-11-01/containerInstance.json#L1146:9
    Old: Microsoft.ContainerInstance/stable/2020-11-01/containerInstance.json#L1146:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'array' than the previous one 'object'.
    New: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L1146:9
    Old: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L1146:9
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.ContainerInstance/stable/2020-11-01/containerInstance.json#L1206
    ❌ R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.ContainerInstance/stable/2020-11-01/containerInstance.json#L1363
    ❌ R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L1206
    ❌ R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L1363
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.ContainerInstance/stable/2020-11-01/containerInstance.json#L520
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.ContainerInstance/stable/2020-11-01/containerInstance.json#L791
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.ContainerInstance/stable/2020-11-01/containerInstance.json#L853
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.ContainerInstance/stable/2020-11-01/containerInstance.json#L876
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.ContainerInstance/stable/2020-11-01/containerInstance.json#L1678
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.ContainerInstance/stable/2020-11-01/containerInstance.json#L1683
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.ContainerInstance/stable/2020-11-01/containerInstance.json#L1746
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.ContainerInstance/stable/2020-11-01/containerInstance.json#L1750
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.ContainerInstance/stable/2020-11-01/containerInstance.json#L2043
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L520
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L791
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L853
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L876
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L1678
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L1683
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L1746
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L1750
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L2043
    ❌ R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.ContainerInstance/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.ContainerInstance/stable/2020-11-01/containerInstance.json#L415
    ❌ R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.ContainerInstance/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L415
    ❌ R4037 - MissingTypeObject The schema 'GitRepoVolume' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ContainerInstance/stable/2020-11-01/containerInstance.json#L1037
    ❌ R4037 - MissingTypeObject The schema 'ContainerGroupIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ContainerInstance/stable/2020-11-01/containerInstance.json#L1333
    ❌ R4037 - MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ContainerInstance/stable/2020-11-01/containerInstance.json#L2077
    ❌ R4037 - MissingTypeObject The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ContainerInstance/stable/2020-11-01/containerInstance.json#L2086
    ❌ R4037 - MissingTypeObject The schema 'GitRepoVolume' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L1037
    ❌ R4037 - MissingTypeObject The schema 'ContainerGroupIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L1333
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 17, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go-track2 - armcontainerinstance - 1.0.1
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-containerinstance - 9.2.0
    ️✔️azure-sdk-for-go - containerinstance/mgmt/2021-10-01/containerinstance - v64.2.0
    ️✔️azure-sdk-for-go - containerinstance/mgmt/2021-09-01/containerinstance - v64.2.0
    ️✔️azure-sdk-for-go - containerinstance/mgmt/2021-07-01/containerinstance - v64.2.0
    ❌azure-sdk-for-go - containerinstance/mgmt/2021-03-01/containerinstance - v64.2.0
    +	Struct `HTTPHeaders` has been removed
+	Type of `ContainerHTTPGet.HTTPHeaders` has been changed from `*HTTPHeaders` to `*[]HTTPHeader`
    ❌azure-sdk-for-go - containerinstance/mgmt/2020-11-01/containerinstance - v64.2.0
    +	Struct `HTTPHeaders` has been removed
+	Type of `ContainerHTTPGet.HTTPHeaders` has been changed from `*HTTPHeaders` to `*[]HTTPHeader`
    ️✔️azure-sdk-for-go - containerinstance/mgmt/2019-12-01/containerinstance - v64.2.0
    ️✔️azure-sdk-for-go - containerinstance/mgmt/2018-10-01/containerinstance - v64.2.0
    ️✔️azure-sdk-for-go - containerinstance/mgmt/2018-09-01/containerinstance - v64.2.0
    ️✔️azure-sdk-for-go - containerinstance/mgmt/2018-06-01/containerinstance - v64.2.0
    ️✔️azure-sdk-for-go - containerinstance/mgmt/2018-04-01/containerinstance - v64.2.0
    ️✔️azure-sdk-for-go - preview/containerinstance/mgmt/2018-02-01-preview/containerinstance - v64.2.0
    ️✔️azure-sdk-for-go - preview/containerinstance/mgmt/2017-12-01-preview/containerinstance - v64.2.0
    ️✔️azure-sdk-for-go - preview/containerinstance/mgmt/2017-10-01-preview/containerinstance - v64.2.0
    ️✔️azure-sdk-for-go - preview/containerinstance/mgmt/2017-08-01-preview/containerinstance - v64.2.0
    ️❌ azure-sdk-for-net failed [Detail]
    • ❌Failed [Logs]Release - Generate from 4e9b657. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/containerinstance/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] No usable version of the libssl was found
cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 4e9b657. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.5.5 -> 8.11.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.11.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.11.0` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-containerinstance [View full logs]  [Release SDK Changes] 
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 4e9b657. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
    • ️✔️azure-resourcemanager-containerinstance-generated [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 4e9b657. SDK Automation 14.0.0 
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️containerinstance/mgmt/2021-10-01/containerinstance [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️containerinstance/mgmt/2021-09-01/containerinstance [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️containerinstance/mgmt/2021-07-01/containerinstance [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️containerinstance/mgmt/2021-03-01/containerinstance [View full logs] 
      Only show 9 items here, please refer to log for details.
      info	[Changelog]
info	[Changelog] - Type of `ContainerHTTPGet.HTTPHeaders` has been changed from `*HTTPHeaders` to `*[]HTTPHeader`
info	[Changelog] - Struct `HTTPHeaders` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New struct `HTTPHeader`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 2 additive change(s).
    • ️✔️containerinstance/mgmt/2020-11-01/containerinstance [View full logs] 
      Only show 9 items here, please refer to log for details.
      info	[Changelog]
info	[Changelog] - Type of `ContainerHTTPGet.HTTPHeaders` has been changed from `*HTTPHeaders` to `*[]HTTPHeader`
info	[Changelog] - Struct `HTTPHeaders` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New struct `HTTPHeader`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 2 additive change(s).
    • ️✔️containerinstance/mgmt/2019-12-01/containerinstance [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️containerinstance/mgmt/2018-10-01/containerinstance [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️containerinstance/mgmt/2018-09-01/containerinstance [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️containerinstance/mgmt/2018-06-01/containerinstance [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️containerinstance/mgmt/2018-04-01/containerinstance [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/containerinstance/mgmt/2018-02-01-preview/containerinstance [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/containerinstance/mgmt/2017-12-01-preview/containerinstance [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/containerinstance/mgmt/2017-10-01-preview/containerinstance [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/containerinstance/mgmt/2017-08-01-preview/containerinstance [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 4e9b657. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armcontainerinstance [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 4e9b657. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] WARN deprecated @azure/storage-blob@10.5.0: This version has been deprecated, please upgrade to the version tagged as latest
cmderr	[automation_init.sh]  @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-containerinstance [View full logs]  [Release SDK Changes] 
      info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 4e9b657. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️containerinstance [View full logs]  [Release Schema Changes]
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 4e9b657. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.ContainerInstance [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @magodo, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @openapi-workflow-bot
    Copy link

    Hi @magodo, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    This was referenced May 17, 2022
    Closed
    Closed
    This was referenced May 17, 2022
    Closed
    Closed
    Closed
    Closed
    Closed
    @chunyu3
    Copy link
    Member

    chunyu3 commented May 20, 2022

    Hi @magodo Please resolve the CI check failures and acquire ''breaking change' approval. Thanks

    @magodo
    Copy link
    Contributor Author

    magodo commented May 20, 2022

    @chunyu3 I'm just copy-paste this part from a newer API version, for the breaking changes, how to get approval, as these are actually swagger issues.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 23, 2022
    @magodo
    Copy link
    Contributor Author

    magodo commented May 24, 2022

    @chunyu3 Can you please take another look at this? I think all the required checks are now passing, also the breaking change is now approved.

    @chunyu3 chunyu3 merged commit 4e9b657 into Azure:main May 27, 2022
    This was referenced May 27, 2022
    Closed
    Merged
    Closed
    Closed
    This was referenced May 27, 2022
    Closed
    Closed
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request May 27, 2022
    [ReleasePR containerinstance] ACI: Correct the type of httpHeaders ob…
    b3d546e 
    …ject->array of object (#2392)

Create to sync Azure/azure-rest-api-specs#19103
[ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/containerinstance?expand=1)
    @azure-sdk azure-sdk mentioned this pull request May 27, 2022
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @joseph-porter joseph-porter joseph-porter approved these changes

    @mostafaez mostafaez mostafaez approved these changes

    Assignees

    @chunyu3 chunyu3

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 FixS360
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Azure Container Instance: Incorrect type of ContainerHttpGet.httpHeaders
    5 participants
    @magodo @chunyu3 @mostafaez @joseph-porter @JeffreyRichter