Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route Server Integration feature swagger changes #19215

Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,60 @@
"nextLinkName": "nextLink"
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/azureFirewalls/{azureFirewallName}/learnedIPPrefixes": {
"post": {
"operationId": "AzureFirewalls_ListLearnedPrefixes",
"description": "Retrieves a list of all IP prefixes that azure firewall has learned to not SNAT.",
"parameters": [
{
"name": "resourceGroupName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the resource group."
},
anchalkpr marked this conversation as resolved.
Show resolved Hide resolved
{
"name": "azureFirewallName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the azure firewall."
},
{
"$ref": "./network.json#/parameters/ApiVersionParameter"
anchalkpr marked this conversation as resolved.
Show resolved Hide resolved
},
{
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
anchalkpr marked this conversation as resolved.
Show resolved Hide resolved
}
],
"responses": {
"200": {
"description": "List of learnt SNAT IP prefixes for no SNAT.",
"schema": {
"$ref": "#/definitions/IPPrefixesList"
}
},
"202": {
"description": "Accepted and the operation will complete asynchronously."
},
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "./network.json#/definitions/CloudError"
}
}
},
"x-ms-examples": {
"AzureFirewallListLearnedPrefixes": {
"$ref": "./examples/AzureFirewallListLearnedIPPrefixes.json"
}
},
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
}
}
}
},
"definitions": {
Expand Down Expand Up @@ -1081,6 +1135,15 @@
}
},
"description": "SKU of an Azure Firewall."
},
"IPPrefixesList": {
"properties": {
"ipPrefixes": {
"type": "string",
"description": "IP Prefix value."
}
},
"description": "List of SNAT IP Prefixes learnt by firewall to not SNAT"
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"parameters": {
"api-version": "2021-08-01",
anchalkpr marked this conversation as resolved.
Show resolved Hide resolved
"subscriptionId": "subid",
"resourceGroupName": "rg1",
"azureFirewallName": "azureFirewall1"
},
"responses": {
"202": {},
"200": {
"body": {
"value": [
{
"IPPrefixes": [
"10.101.0.0/16",
"10.101.0.0/16"
]
}
]
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -1587,6 +1587,10 @@
"items": {
"type": "string"
}
},
"autoLearnPrivateRanges": {
Copy link
Member

@mentat9 mentat9 Jun 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autoLearnPrivateRanges

Consider using string enum, instead of boolean (only true/false) something more like:

privateRangeHandling: { Fixed, LearnSnat }, or similar. #Resolved

Copy link
Contributor Author

@anchalkpr anchalkpr Jun 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mentat9 What is the benefit of having an enum here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

"type": "boolean",
"description": "The operation mode for automatically learning private ranges to not be SNAT"
}
}
},
Expand Down