dev containerservice microsoft.container service 2022 06 02 preview - fleets #19521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serbrech
requested review from
msyyc,
BigCat20196,
ArcturusZhang,
palma21 and
matthchr
as code owners
|
Hi, @serbrech Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
|
Hi, @serbrech your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| The child tracked resource, 'members' with immediate parent 'Fleet', must have a list by immediate parent operation. Location: Microsoft.ContainerService/preview/2022-06-02-preview/fleets.json#L644 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
serbrech
changed the base branch from
main
to
dev-containerservice-Microsoft.ContainerService-2022-06-02-preview
|
Note that these changes have been previously reviewed on the private fork here: |
This was referenced Jun 20, 2022
matthchr
approved these changes
Jun 20, 2022
| "schema": { | ||
| "$ref": "#/definitions/Fleet" | ||
| }, | ||
| "description": "The fleet to create or update." |
| "Fleets" | ||
| ], | ||
| "operationId": "Fleets_Update", | ||
| "summary": "Patches a fleet resource.", |
There was a problem hiding this comment.
might be worth checking the rest of the file for this. Obviously minor.
| "description": "Properties of a fleet.", | ||
| "properties": { | ||
| "hubProfile": { | ||
| "description": "The FleetHubProfile configures the fleet's hub. it is enabled by default and can be disabled by setting the hubMode property.", |
There was a problem hiding this comment.
Suggested change
| "description": "The FleetHubProfile configures the fleet's hub. it is enabled by default and can be disabled by setting the hubMode property.", | |
| "description": "The FleetHubProfile configures the fleet's hub. It is enabled by default and can be disabled by setting the hubMode property.", |
...erservice/resource-manager/Microsoft.ContainerService/preview/2022-06-02-preview/fleets.json
Show resolved
Hide resolved
| }, | ||
| "FleetHubProfile": { | ||
| "type": "object", | ||
| "description": "The FleetHubProfile configures the fleet hub. it is enabled by default and can be disabled by setting the hubMode property.", |
There was a problem hiding this comment.
I also don't see a hubMode property on this object? Or anywhere in this file acutally?
| }, | ||
| "FleetMember": { | ||
| "type": "object", | ||
| "description": "A member of the fleet. It contains a reference to an existing Kubernetes cluster on Azure, which is a member of the fleet.", |
There was a problem hiding this comment.
This is phrased sorta weird. Maybe just drop the "which is a member of the fleet" at the end? Feels like that's just repeating "A member of the fleet" at the beginning.
|
Why can't I push to my own branch? It targets another dev branch... |
created another PR that does not use a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[x] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.