Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM ID annotations for Cosmos DB #19593

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

matthchr
Copy link
Member

Uses the new arm-id format to describe fields which are references to other ARM resources.

This was split off from #18318

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @matthchr Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 24, 2022

    Swagger Validation Report

    ️❌BreakingChange: 8 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.9.6)] new version base version
    cosmos-db.json 2021-05-15(b6f9915) 2021-05-15(main)
    cosmos-db.json 2021-06-15(b6f9915) 2021-06-15(main)
    cosmos-db.json 2021-10-15(b6f9915) 2021-10-15(main)
    cosmos-db.json 2022-05-15(b6f9915) 2022-05-15(main)
    Rule Message
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DocumentDB/stable/2021-05-15/cosmos-db.json#L7849:9
    Old: Microsoft.DocumentDB/stable/2021-05-15/cosmos-db.json#L7848:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DocumentDB/stable/2021-05-15/cosmos-db.json#L6138:11
    Old: Microsoft.DocumentDB/stable/2021-05-15/cosmos-db.json#L6138:11
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DocumentDB/stable/2021-06-15/cosmos-db.json#L7896:9
    Old: Microsoft.DocumentDB/stable/2021-06-15/cosmos-db.json#L7895:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DocumentDB/stable/2021-06-15/cosmos-db.json#L6162:11
    Old: Microsoft.DocumentDB/stable/2021-06-15/cosmos-db.json#L6162:11
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DocumentDB/stable/2021-10-15/cosmos-db.json#L7995:9
    Old: Microsoft.DocumentDB/stable/2021-10-15/cosmos-db.json#L7994:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DocumentDB/stable/2021-10-15/cosmos-db.json#L6234:11
    Old: Microsoft.DocumentDB/stable/2021-10-15/cosmos-db.json#L6234:11
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DocumentDB/stable/2022-05-15/cosmos-db.json#L8000:9
    Old: Microsoft.DocumentDB/stable/2022-05-15/cosmos-db.json#L7999:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DocumentDB/stable/2022-05-15/cosmos-db.json#L6234:11
    Old: Microsoft.DocumentDB/stable/2022-05-15/cosmos-db.json#L6234:11
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️🔄LintDiff inProgress [Detail]
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️⚠️SDK Track2 Validation: 0 Warnings warning [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/b6f991504f134b62d975bff0dc13cbbbfd2145ff/specification/cosmos-db/resource-manager/readme.md#tag-package-2022-05">cosmos-db/resource-manager/readme.md#package-2022-05
      • "https://github.com/Azure/azure-rest-api-specs/blob/b6f991504f134b62d975bff0dc13cbbbfd2145ff/specification/cosmos-db/resource-manager/readme.md#tag-package-2021-10">cosmos-db/resource-manager/readme.md#package-2021-10
      • "https://github.com/Azure/azure-rest-api-specs/blob/b6f991504f134b62d975bff0dc13cbbbfd2145ff/specification/cosmos-db/resource-manager/readme.md#tag-package-2021-06">cosmos-db/resource-manager/readme.md#package-2021-06
      • "https://github.com/Azure/azure-rest-api-specs/blob/b6f991504f134b62d975bff0dc13cbbbfd2145ff/specification/cosmos-db/resource-manager/readme.md#tag-package-2021-05">cosmos-db/resource-manager/readme.md#package-2021-05
    The following errors/warnings exist before current PR submission:
    Rule Message
    ⚠️ UnkownSecurityScheme "readme":"cosmos-db/resource-manager/readme.md",
    "tag":"package-2022-05",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"cosmos-db/resource-manager/readme.md",
    "tag":"package-2021-10",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"cosmos-db/resource-manager/readme.md",
    "tag":"package-2021-06",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"cosmos-db/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 24, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go - armcosmos - 2.1.0-beta.1
    azure-sdk-for-python-track2 - track2_azure-mgmt-cosmosdb - 7.0.0
    +	Operation RestorableMongodbCollectionsOperations.list has a new parameter end_time
    +	Operation RestorableMongodbCollectionsOperations.list has a new parameter start_time
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from cdcdc28. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  config global `--global`, `--local` are deprecated. Use `--location=global` instead.
    • ️✔️track2_azure-mgmt-cosmosdb [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from cdcdc28. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.CosmosDB [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from cdcdc28. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armcosmos [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from cdcdc28. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-cosmosdb [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Interface PhysicalPartitionStorageInfo
      info	[Changelog]   - Added Interface PhysicalPartitionStorageInfoCollection
      info	[Changelog]   - Added Interface PhysicalPartitionThroughputInfoProperties
      info	[Changelog]   - Added Interface PhysicalPartitionThroughputInfoResource
      info	[Changelog]   - Added Interface PhysicalPartitionThroughputInfoResult
      info	[Changelog]   - Added Interface PhysicalPartitionThroughputInfoResultPropertiesResource
      info	[Changelog]   - Added Interface Privilege
      info	[Changelog]   - Added Interface PrivilegeResource
      info	[Changelog]   - Added Interface RedistributeThroughputParameters
      info	[Changelog]   - Added Interface RedistributeThroughputPropertiesResource
      info	[Changelog]   - Added Interface RestorableGremlinDatabaseGetResult
      info	[Changelog]   - Added Interface RestorableGremlinDatabasePropertiesResource
      info	[Changelog]   - Added Interface RestorableGremlinDatabasesListOptionalParams
      info	[Changelog]   - Added Interface RestorableGremlinDatabasesListResult
      info	[Changelog]   - Added Interface RestorableGremlinGraphGetResult
      info	[Changelog]   - Added Interface RestorableGremlinGraphPropertiesResource
      info	[Changelog]   - Added Interface RestorableGremlinGraphsListOptionalParams
      info	[Changelog]   - Added Interface RestorableGremlinGraphsListResult
      info	[Changelog]   - Added Interface RestorableGremlinResourcesGetResult
      info	[Changelog]   - Added Interface RestorableGremlinResourcesListOptionalParams
      info	[Changelog]   - Added Interface RestorableGremlinResourcesListResult
      info	[Changelog]   - Added Interface RestorableTableGetResult
      info	[Changelog]   - Added Interface RestorableTablePropertiesResource
      info	[Changelog]   - Added Interface RestorableTableResourcesGetResult
      info	[Changelog]   - Added Interface RestorableTableResourcesListOptionalParams
      info	[Changelog]   - Added Interface RestorableTableResourcesListResult
      info	[Changelog]   - Added Interface RestorableTablesListOptionalParams
      info	[Changelog]   - Added Interface RestorableTablesListResult
      info	[Changelog]   - Added Interface RetrieveThroughputParameters
      info	[Changelog]   - Added Interface RetrieveThroughputPropertiesResource
      info	[Changelog]   - Added Interface Role
      info	[Changelog]   - Added Interface SqlResourcesCreateUpdateClientEncryptionKeyOptionalParams
      info	[Changelog]   - Added Interface SqlResourcesGetClientEncryptionKeyOptionalParams
      info	[Changelog]   - Added Interface SqlResourcesListClientEncryptionKeysOptionalParams
      info	[Changelog]   - Added Interface SqlResourcesListSqlContainerPartitionMergeOptionalParams
      info	[Changelog]   - Added Interface SqlResourcesSqlContainerRedistributeThroughputOptionalParams
      info	[Changelog]   - Added Interface SqlResourcesSqlContainerRetrieveThroughputDistributionOptionalParams
      info	[Changelog]   - Added Interface TableResourcesRetrieveContinuousBackupInformationOptionalParams
      info	[Changelog]   - Added Type Alias CassandraClustersGetBackupResponse
      info	[Changelog]   - Added Type Alias CassandraClustersListBackupsResponse
      info	[Changelog]   - Added Type Alias CassandraResourcesCreateUpdateCassandraViewResponse
      info	[Changelog]   - Added Type Alias CassandraResourcesGetCassandraViewResponse
      info	[Changelog]   - Added Type Alias CassandraResourcesGetCassandraViewThroughputResponse
      info	[Changelog]   - Added Type Alias CassandraResourcesListCassandraViewsResponse
      info	[Changelog]   - Added Type Alias CassandraResourcesMigrateCassandraViewToAutoscaleResponse
      info	[Changelog]   - Added Type Alias CassandraResourcesMigrateCassandraViewToManualThroughputResponse
      info	[Changelog]   - Added Type Alias CassandraResourcesUpdateCassandraViewThroughputResponse
      info	[Changelog]   - Added Type Alias ContinuousTier
      info	[Changelog]   - Added Type Alias DataTransferComponent
      info	[Changelog]   - Added Type Alias DataTransferDataSourceSinkUnion
      info	[Changelog]   - Added Type Alias DataTransferJobsCancelResponse
      info	[Changelog]   - Added Type Alias DataTransferJobsCreateResponse
      info	[Changelog]   - Added Type Alias DataTransferJobsGetResponse
      info	[Changelog]   - Added Type Alias DataTransferJobsListByDatabaseAccountNextResponse
      info	[Changelog]   - Added Type Alias DataTransferJobsListByDatabaseAccountResponse
      info	[Changelog]   - Added Type Alias DataTransferJobsPauseResponse
      info	[Changelog]   - Added Type Alias DataTransferJobsResumeResponse
      info	[Changelog]   - Added Type Alias EnableFullTextQuery
      info	[Changelog]   - Added Type Alias GraphResourcesCreateUpdateGraphResponse
      info	[Changelog]   - Added Type Alias GraphResourcesGetGraphResponse
      info	[Changelog]   - Added Type Alias GraphResourcesListGraphsResponse
      info	[Changelog]   - Added Type Alias GremlinResourcesRetrieveContinuousBackupInformationResponse
      info	[Changelog]   - Added Type Alias MongoDBResourcesCreateUpdateMongoRoleDefinitionResponse
      info	[Changelog]   - Added Type Alias MongoDBResourcesCreateUpdateMongoUserDefinitionResponse
      info	[Changelog]   - Added Type Alias MongoDBResourcesGetMongoRoleDefinitionResponse
      info	[Changelog]   - Added Type Alias MongoDBResourcesGetMongoUserDefinitionResponse
      info	[Changelog]   - Added Type Alias MongoDBResourcesListMongoDBCollectionPartitionMergeResponse
      info	[Changelog]   - Added Type Alias MongoDBResourcesListMongoRoleDefinitionsResponse
      info	[Changelog]   - Added Type Alias MongoDBResourcesListMongoUserDefinitionsResponse
      info	[Changelog]   - Added Type Alias MongoDBResourcesMongoDBContainerRedistributeThroughputResponse
      info	[Changelog]   - Added Type Alias MongoDBResourcesMongoDBContainerRetrieveThroughputDistributionResponse
      info	[Changelog]   - Added Type Alias MongoRoleDefinitionType
      info	[Changelog]   - Added Type Alias RestorableGremlinDatabasesListResponse
      info	[Changelog]   - Added Type Alias RestorableGremlinGraphsListResponse
      info	[Changelog]   - Added Type Alias RestorableGremlinResourcesListResponse
      info	[Changelog]   - Added Type Alias RestorableTableResourcesListResponse
      info	[Changelog]   - Added Type Alias RestorableTablesListResponse
      info	[Changelog]   - Added Type Alias SqlResourcesCreateUpdateClientEncryptionKeyResponse
      info	[Changelog]   - Added Type Alias SqlResourcesGetClientEncryptionKeyResponse
      info	[Changelog]   - Added Type Alias SqlResourcesListClientEncryptionKeysResponse
      info	[Changelog]   - Added Type Alias SqlResourcesListSqlContainerPartitionMergeResponse
      info	[Changelog]   - Added Type Alias SqlResourcesSqlContainerRedistributeThroughputResponse
      info	[Changelog]   - Added Type Alias SqlResourcesSqlContainerRetrieveThroughputDistributionResponse
      info	[Changelog]   - Added Type Alias TableResourcesRetrieveContinuousBackupInformationResponse
      info	[Changelog]   - Added Type Alias ThroughputPolicyType
      info	[Changelog]   - Interface ARMResourceProperties has a new optional parameter identity
      info	[Changelog]   - Interface ContinuousModeBackupPolicy has a new optional parameter continuousModeProperties
      info	[Changelog]   - Interface DatabaseAccountCreateUpdateParameters has a new optional parameter diagnosticLogSettings
      info	[Changelog]   - Interface DatabaseAccountCreateUpdateParameters has a new optional parameter enableMaterializedViews
      info	[Changelog]   - Interface DatabaseAccountCreateUpdateParameters has a new optional parameter keysMetadata
      info	[Changelog]   - Interface DatabaseAccountGetResults has a new optional parameter diagnosticLogSettings
      info	[Changelog]   - Interface DatabaseAccountGetResults has a new optional parameter enableMaterializedViews
      info	[Changelog]   - Interface DatabaseAccountGetResults has a new optional parameter keysMetadata
      info	[Changelog]   - Interface DatabaseAccountUpdateParameters has a new optional parameter diagnosticLogSettings
      info	[Changelog]   - Interface DatabaseAccountUpdateParameters has a new optional parameter enableMaterializedViews
      info	[Changelog]   - Interface DatabaseAccountUpdateParameters has a new optional parameter keysMetadata
      info	[Changelog]   - Interface DataCenterResourceProperties has a new optional parameter authenticationMethodLdapProperties
      info	[Changelog]   - Interface LocationProperties has a new optional parameter status
      info	[Changelog]   - Interface RestorableDatabaseAccountGetResult has a new optional parameter oldestRestorableTime
      info	[Changelog]   - Interface RestorableMongodbCollectionsListOptionalParams has a new optional parameter endTime
      info	[Changelog]   - Interface RestorableMongodbCollectionsListOptionalParams has a new optional parameter startTime
      info	[Changelog]   - Interface RestoreParameters has a new optional parameter gremlinDatabasesToRestore
      info	[Changelog]   - Interface RestoreParameters has a new optional parameter tablesToRestore
      info	[Changelog]   - Interface SqlContainerResource has a new optional parameter clientEncryptionPolicy
      info	[Changelog]   - Class CosmosDBManagementClient has a new parameter dataTransferJobs
      info	[Changelog]   - Class CosmosDBManagementClient has a new parameter graphResources
      info	[Changelog]   - Class CosmosDBManagementClient has a new parameter restorableGremlinDatabases
      info	[Changelog]   - Class CosmosDBManagementClient has a new parameter restorableGremlinGraphs
      info	[Changelog]   - Class CosmosDBManagementClient has a new parameter restorableGremlinResources
      info	[Changelog]   - Class CosmosDBManagementClient has a new parameter restorableTableResources
      info	[Changelog]   - Class CosmosDBManagementClient has a new parameter restorableTables
      info	[Changelog]   - Added Enum KnownContinuousTier
      info	[Changelog]   - Added Enum KnownDataTransferComponent
      info	[Changelog]   - Added Enum KnownThroughputPolicyType
      info	[Changelog]   - Enum KnownAuthenticationMethod has a new value Ldap
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Interface DatabaseAccountCreateUpdateParameters no longer has parameter identity
      info	[Changelog]   - Interface DatabaseAccountGetResults no longer has parameter identity
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from cdcdc28. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️cosmos-db [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from cdcdc28. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.cosmos-db [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @matthchr, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @matthchr matthchr force-pushed the feature/cosmosdb-arm-ids branch from 8a10cd1 to b6f9915 Compare July 22, 2022 21:00
    @matthchr
    Copy link
    Member Author

    .NET SDK for reference.

    This PR covers all of the ARM IDs in the cosmos-db.json file. There are some other ARM IDs in other files that will need to be added in a future PR.

    @ArcturusZhang ArcturusZhang added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Aug 5, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-JavaScript
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants