Mobile Network API version 2022-04-01-preview #19681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @satravi Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| compared swaggers (via Oad v0.9.6)] | new version | base version |
|---|---|---|
| attachedDataNetwork.json | 2022-04-01(28fc4d6) | 2022-03-01(main) |
| common.json | 2022-04-01(28fc4d6) | 2022-03-01(main) |
| dataNetwork.json | 2022-04-01(28fc4d6) | 2022-03-01(main) |
| mobileNetwork.json | 2022-04-01(28fc4d6) | 2022-03-01(main) |
| operation.json | 2022-04-01(28fc4d6) | 2022-03-01(main) |
| packetCoreControlPlane.json | 2022-04-01(28fc4d6) | 2022-03-01(main) |
| packetCoreDataPlane.json | 2022-04-01(28fc4d6) | 2022-03-01(main) |
| service.json | 2022-04-01(28fc4d6) | 2022-03-01(main) |
| simPolicy.json | 2022-04-01(28fc4d6) | 2022-03-01(main) |
| slice.json | 2022-04-01(28fc4d6) | 2022-03-01(main) |
| ts29571.json | 2022-04-01(28fc4d6) | 2022-03-01(main) |
The following breaking changes are detected by comparison with the latest preview version:
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 1 Warnings warning [Detail]
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-2022-04-01-preview | package-2022-04-01-preview(28fc4d6) | default(main) |
The following errors/warnings are introduced by current PR:
| Rule | Message |
|---|---|
| Per the Noun_Verb convention for Operation Ids, the noun 'Sims' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1061 |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
| Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.MobileNetwork/preview/2022-04-01-preview/common.json#L354 |
|
| Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.MobileNetwork/preview/2022-04-01-preview/ts29571.json#L1 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.MobileNetwork/preview/2022-04-01-preview/operation.json#L77 |
️❌Avocado: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The default tag does not contain all APIs in this RP. Please make sure the missing API swaggers are in the default tag. readme: specification/mobilenetwork/resource-manager/readme.md json: Microsoft.MobileNetwork/preview/2022-03-01-preview/mobileNetwork.json |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️SDK Track2 Validation: 12 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/28fc4d6b3a69b1e23046ea8be7a82942f8b8abb7/specification/mobilenetwork/resource-manager/readme.md#tag-package-2022-04-01-preview">mobilenetwork/resource-manager/readme.md#package-2022-04-01-preview
| Rule | Message |
|---|---|
| "readme":"mobilenetwork/resource-manager/readme.md", "tag":"package-2022-04-01-preview", "details":"Schema 'AttachedDataNetwork' has a property 'systemData' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from AttachedDataNetwork" |
|
| "readme":"mobilenetwork/resource-manager/readme.md", "tag":"package-2022-04-01-preview", "details":"Schema 'DataNetwork' has a property 'systemData' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from DataNetwork" |
|
| "readme":"mobilenetwork/resource-manager/readme.md", "tag":"package-2022-04-01-preview", "details":"Schema 'MobileNetwork' has a property 'systemData' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from MobileNetwork" |
|
| "readme":"mobilenetwork/resource-manager/readme.md", "tag":"package-2022-04-01-preview", "details":"Schema 'SimGroup' has a property 'systemData' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from SimGroup" |
|
| "readme":"mobilenetwork/resource-manager/readme.md", "tag":"package-2022-04-01-preview", "details":"Schema 'Sim' has a property 'systemData' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from Sim" |
|
| "readme":"mobilenetwork/resource-manager/readme.md", "tag":"package-2022-04-01-preview", "details":"Schema 'Site' has a property 'systemData' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from Site" |
|
| "readme":"mobilenetwork/resource-manager/readme.md", "tag":"package-2022-04-01-preview", "details":"Schema 'PacketCoreControlPlane' has a property 'systemData' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from PacketCoreControlPlane" |
|
| "readme":"mobilenetwork/resource-manager/readme.md", "tag":"package-2022-04-01-preview", "details":"Schema 'PacketCoreDataPlane' has a property 'systemData' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from PacketCoreDataPlane" |
|
| "readme":"mobilenetwork/resource-manager/readme.md", "tag":"package-2022-04-01-preview", "details":"Schema 'Service' has a property 'systemData' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from Service" |
|
| "readme":"mobilenetwork/resource-manager/readme.md", "tag":"package-2022-04-01-preview", "details":"Schema 'SimPolicy' has a property 'systemData' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from SimPolicy" |
|
| "readme":"mobilenetwork/resource-manager/readme.md", "tag":"package-2022-04-01-preview", "details":"Schema 'Slice' has a property 'systemData' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from Slice" |
|
| "readme":"mobilenetwork/resource-manager/readme.md", "tag":"package-2022-04-01-preview", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Swagger Generation Artifacts
|
|
Hi @satravi, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Jul 6, 2022
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
|
Hi, @satravi your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
|
This API has already passed ARM review. The relevant PRs are: |
mentat9
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @satravi, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
@live1206 Breaking changes has been already approved. Please find the PR details in the previous comment from @sathiyan-sivathas. |
|
@qiaozha Could you help check the SDK breaking change for js? |
|
@ArcturusZhang Could you help check the SDK breaking change for go? |
|
@msyyc Could you help check the SDK breaking change for python? |
|
approved for python breaking change |
ArcturusZhang
added
the
Approved-SdkBreakingChange-Go
live1206
approved these changes
Jul 19, 2022
This was referenced Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.