Dev botservice microsoft.bot service 2022 06 15 preview #19687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-05-01-preview to version 2022-06-15-preview
|
Hi, @thatChang Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
|
Hi, @thatChang your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
Swagger Validation Report
|
| compared swaggers (via Oad v0.9.6)] | new version | base version |
|---|---|---|
| botservice.json | 2022-06-15-preview(6398a96) | 2021-03-01(main) |
| botservice.json | 2022-06-15-preview(6398a96) | 2021-05-01-preview(main) |
| privatelinks.json | 2022-06-15-preview(6398a96) | 2021-05-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
The following breaking changes are detected by comparison with the latest preview version:
️⌛CredScan pending [Detail]
️⚠️LintDiff: 3 Warnings warning [Detail]
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-preview-2022-06 | package-preview-2022-06(6398a96) | default(main) |
The following errors/warnings are introduced by current PR:
| Rule | Message |
|---|---|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L1874 |
|
| OperationId should contain the verb: 'createemailsigninurl' in:'Email_CreateSignInUrl'. Consider updating the operationId Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L709 |
|
| OperationId should contain the verb: 'listqnamakerendpointkeys' in:'QnAMakerEndpointKeys_Get'. Consider updating the operationId Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L866 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L1513 |
|
The schema 'Sku' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L1566 |
|
The schema 'BotProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L1633 |
|
The schema 'BotResponseList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L1844 |
|
The schema 'AlexaChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L2028 |
|
The schema 'FacebookChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L2071 |
|
The schema 'FacebookPage' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L2111 |
|
The schema 'EmailChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L2144 |
|
The schema 'MsTeamsChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L2223 |
|
The schema 'SkypeChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L2275 |
|
The schema 'KikChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L2340 |
|
The schema 'WebChatChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L2381 |
|
The schema 'DirectLineChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L2417 |
|
The schema 'TelegramChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L2459 |
|
The schema 'SmsChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L2496 |
|
The schema 'SlackChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L2543 |
|
The schema 'LineChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L2617 |
|
The schema 'LineRegistration' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L2642 |
|
The schema 'DirectLineSpeechChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L2681 |
|
The schema 'ChannelResponseList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L2717 |
|
The schema 'ConnectionItemName' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L2880 |
|
The schema 'ConnectionSettingParameter' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L2890 |
|
The schema 'ConnectionSettingProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L2904 |
|
The schema 'ConnectionSettingResponseList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L2969 |
|
The schema 'ServiceProviderResponseList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L2986 |
|
The schema 'ServiceProviderParameter' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L3003 |
|
The schema 'ServiceProviderProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L3055 |
|
The schema 'Error' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L3102 |
|
The schema 'ErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L3111 |
|
The schema 'PrivateEndpoint' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2022-06-15-preview/privatelinks.json#L9 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
"code: InvalidResourceType, message: The resource type 'operations' could not be found in the namespace 'Microsoft.BotService' for api version '2022-06-15-preview'. The supported api-versions are '2017-12-01, 2018-07-12, 2020-06-02, 2021-03-01, 2021-05-01-preview'." |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⌛PoliCheck pending [Detail]
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/6398a96c9707337cbeaa06e33286abe8023b9248/specification/botservice/resource-manager/readme.md#tag-package-preview-2022-06">botservice/resource-manager/readme.md#package-preview-2022-06
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Swagger Generation Artifacts
|
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=308768&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 128 " |
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-go - armbotservice - Approved - 0.6.0+ Field `CallingWebHook` of struct `MsTeamsChannelProperties` has been removed
❌azure-sdk-for-python-track2 - track2_azure-mgmt-botservice - Approved - 2.0.0b3+ Model MsTeamsChannelProperties no longer has parameter calling_web_hook
❌azure-sdk-for-python - track2_azure-mgmt-botservice - Approved - 2.0.0b3+ Model MsTeamsChannelProperties no longer has parameter calling_web_hook
️❌ azure-sdk-for-net failed [Detail]
warn Skip initScript due to not configured command sudo apt-get install -y dotnet-sdk-6.0 command autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/botservice/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] No usable version of the libssl was found cmderr [Autorest] FATAL: csharp/simplifier - FAILED cmderr [Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated. cmderr [Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated. error Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest warn Skip package processing as generation is failed
️⚠️ azure-sdk-for-python warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] config global `--global`, `--local` are deprecated. Use `--location=global` instead.
️✔️track2_azure-mgmt-botservice [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Added operation group EmailOperations info [Changelog] - Added operation group QnAMakerEndpointKeysOperations info [Changelog] - Model BotProperties has a new parameter tenant_id info [Changelog] - Model DirectLineChannelProperties has a new parameter extension_key1 info [Changelog] - Model DirectLineChannelProperties has a new parameter extension_key2 info [Changelog] - Model DirectLineSpeechChannelProperties has a new parameter cognitive_service_resource_id info [Changelog] - Model EmailChannelProperties has a new parameter auth_method info [Changelog] - Model EmailChannelProperties has a new parameter magic_code info [Changelog] - Model MsTeamsChannelProperties has a new parameter calling_webhook info [Changelog] info [Changelog] **Breaking changes** info [Changelog] info [Changelog] - Model MsTeamsChannelProperties no longer has parameter calling_web_hook
️⚠️ azure-sdk-for-python-track2 warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] config global `--global`, `--local` are deprecated. Use `--location=global` instead.
️✔️track2_azure-mgmt-botservice [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Added operation group EmailOperations info [Changelog] - Added operation group QnAMakerEndpointKeysOperations info [Changelog] - Model BotProperties has a new parameter tenant_id info [Changelog] - Model DirectLineChannelProperties has a new parameter extension_key1 info [Changelog] - Model DirectLineChannelProperties has a new parameter extension_key2 info [Changelog] - Model DirectLineSpeechChannelProperties has a new parameter cognitive_service_resource_id info [Changelog] - Model EmailChannelProperties has a new parameter auth_method info [Changelog] - Model EmailChannelProperties has a new parameter magic_code info [Changelog] - Model MsTeamsChannelProperties has a new parameter calling_webhook info [Changelog] info [Changelog] **Breaking changes** info [Changelog] info [Changelog] - Model MsTeamsChannelProperties no longer has parameter calling_web_hook
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️armbotservice [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Field `CallingWebHook` of struct `MsTeamsChannelProperties` has been removed info [Changelog] info [Changelog] ### Features Added info [Changelog] info [Changelog] - New const `ChannelNameTelephonyChannel` info [Changelog] - New const `EmailChannelAuthMethodGraph` info [Changelog] - New const `ChannelNameOmnichannel` info [Changelog] - New const `EmailChannelAuthMethodPassword` info [Changelog] - New function `*QnAMakerEndpointKeysClient.Get(context.Context, QnAMakerEndpointKeysRequestBody, *QnAMakerEndpointKeysClientGetOptions) (QnAMakerEndpointKeysClientGetResponse, error)` info [Changelog] - New function `NewQnAMakerEndpointKeysClient(string, azcore.TokenCredential, *arm.ClientOptions) (*QnAMakerEndpointKeysClient, error)` info [Changelog] - New function `*OutlookChannel.GetChannel() *Channel` info [Changelog] - New function `*EmailClient.CreateSignInURL(context.Context, string, string, *EmailClientCreateSignInURLOptions) (EmailClientCreateSignInURLResponse, error)` info [Changelog] - New function `NewEmailClient(string, azcore.TokenCredential, *arm.ClientOptions) (*EmailClient, error)` info [Changelog] - New function `PossibleEmailChannelAuthMethodValues() []EmailChannelAuthMethod` info [Changelog] - New struct `CreateEmailSignInURLResponse` info [Changelog] - New struct `CreateEmailSignInURLResponseProperties` info [Changelog] - New struct `EmailClient` info [Changelog] - New struct `EmailClientCreateSignInURLOptions` info [Changelog] - New struct `EmailClientCreateSignInURLResponse` info [Changelog] - New struct `OutlookChannel` info [Changelog] - New struct `QnAMakerEndpointKeysClient` info [Changelog] - New struct `QnAMakerEndpointKeysClientGetOptions` info [Changelog] - New struct `QnAMakerEndpointKeysClientGetResponse` info [Changelog] - New struct `QnAMakerEndpointKeysRequestBody` info [Changelog] - New struct `QnAMakerEndpointKeysResponse` info [Changelog] - New field `AuthMethod` in struct `EmailChannelProperties` info [Changelog] - New field `MagicCode` in struct `EmailChannelProperties` info [Changelog] - New field `IsTokenEnabled` in struct `WebChatSite` info [Changelog] - New field `TrustedOrigins` in struct `WebChatSite` info [Changelog] - New field `IsSecureSiteEnabled` in struct `WebChatSite` info [Changelog] - New field `IsEndpointParametersEnabled` in struct `WebChatSite` info [Changelog] - New field `IsNoStorageEnabled` in struct `WebChatSite` info [Changelog] - New field `AppID` in struct `WebChatSite` info [Changelog] - New field `IsBlockUserUploadEnabled` in struct `WebChatSite` info [Changelog] - New field `IsDetailedLoggingEnabled` in struct `WebChatSite` info [Changelog] - New field `ETag` in struct `WebChatSite` info [Changelog] - New field `IsV1Enabled` in struct `WebChatSite` info [Changelog] - New field `IsV3Enabled` in struct `WebChatSite` info [Changelog] - New field `IsNoStorageEnabled` in struct `DirectLineSite` info [Changelog] - New field `IsDetailedLoggingEnabled` in struct `DirectLineSite` info [Changelog] - New field `IsWebchatPreviewEnabled` in struct `DirectLineSite` info [Changelog] - New field `IsTokenEnabled` in struct `DirectLineSite` info [Changelog] - New field `IsEndpointParametersEnabled` in struct `DirectLineSite` info [Changelog] - New field `ETag` in struct `DirectLineSite` info [Changelog] - New field `AppID` in struct `DirectLineSite` info [Changelog] - New field `ExtensionKey2` in struct `DirectLineChannelProperties` info [Changelog] - New field `ExtensionKey1` in struct `DirectLineChannelProperties` info [Changelog] - New field `CallingWebhook` in struct `MsTeamsChannelProperties` info [Changelog] - New field `TenantID` in struct `BotProperties` info [Changelog] - New field `CognitiveServiceResourceID` in struct `DirectLineSpeechChannelProperties` info [Changelog] - New field `AppID` in struct `Site` info [Changelog] - New field `IsDetailedLoggingEnabled` in struct `Site` info [Changelog] - New field `IsNoStorageEnabled` in struct `Site` info [Changelog] - New field `IsEndpointParametersEnabled` in struct `Site` info [Changelog] info [Changelog] Total 1 breaking change(s), 40 additive change(s).
️⚠️ azure-resource-manager-schemas warning [Detail]
command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️botservice [View full logs] [Release Schema Changes]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-botservice [View full logs] [Release SDK Changes]info [Changelog] error breakingChangeTracking is enabled, but version or changelogItem is not found in output.
️❌ azure-powershell failed [Detail]
command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
❌Az.botservice [View full logs] [Release SDK Changes]
tadelesh
added
the
Approved-SdkBreakingChange-Go
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @thatChang, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
JeffreyRichter
added
the
Approved-BreakingChange
Why are you removing x-ms-pageable from this method? The response already has a nextLink property. Even if you don't implement paging yet, it's good to have it in the contract so you can implement it later without changing the API version. Refers to: specification/botservice/resource-manager/Microsoft.BotService/preview/2022-06-15-preview/botservice.json:224 in 3b8aa83. [](commit_id = 3b8aa83, deletion_comment = False) |
|
@thatChang - I have a general comment about this API, even though it's probably not actionable as part of this PR (maybe for future PRs/APIs). In general ARM prefers to avoid populating APIs with many booleans that enable/disable individual capabilities. This kind of API tends to be harder to understand and use and makes discovery of valid combinations more complex and difficult. It also tends to create a situation that requires adding more and more booleans over time. The overall approach preferred by ARM is to use a small/smaller set of string enums that select different categories of behavior so the consumer of the SDK can select the behavior they want by setting one (or a small) number of) property value(s). |
mentat9
added
the
ARMChangesRequested
|
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove |
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
readded. |
thatChang
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
zizw123
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
Add QnAMakerEndpointKeys api
Generated ApiView
|
Fix the prettierCheck
xiaoxuqi-ms
approved these changes
Aug 9, 2022
thatChang
deleted the
dev-botservice-Microsoft.BotService-2022-06-15-preview
branch
This was referenced Aug 9, 2022
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
July/2022
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[X] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.