-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[Service Bus] - Adding status code 202 to Private endpoints PUT" #19755
Conversation
This reverts commit 5e7603d.
Hi, @ruowan Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
compared swaggers (via Oad v0.9.6)] | new version | base version |
---|---|---|
namespace-preview.json | 2022-01-01(0600d27) | 2022-01-01(main) |
Rule | Message |
---|---|
1012 - RemovedResponseCode |
The new version removes the response code '202' Old: Microsoft.ServiceBus/preview/2022-01-01-preview/namespace-preview.json#L442:11 |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v1.13.0) | new version | base version |
---|---|---|
package-2022-01-preview | package-2022-01-preview(0600d27) | package-2022-01-preview(main) |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
R4041 - XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.ServiceBus/preview/2022-01-01-preview/namespace-preview.json#L935 |
Since operation 'PrivateLinkResourcesGet' response has model definition 'array', it should be of the form 'list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.ServiceBus/preview/2022-01-01-preview/namespace-preview.json#L552 |
|
The operation 'Namespaces_Update' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.ServiceBus/preview/2022-01-01-preview/namespace-preview.json#L281 |
|
Based on the response model schema, operation 'PrivateLinkResources_Get' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.ServiceBus/preview/2022-01-01-preview/namespace-preview.json#L548 |
|
The child tracked resource, 'privateEndpointConnections' with immediate parent 'SBNamespace', must have a list by immediate parent operation. Location: Microsoft.ServiceBus/preview/2022-01-01-preview/namespace-preview.json#L983 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: zoneRedundant Location: Microsoft.ServiceBus/preview/2022-01-01-preview/namespace-preview.json#L734 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disableLocalAuth Location: Microsoft.ServiceBus/preview/2022-01-01-preview/namespace-preview.json#L753 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disableLocalAuth Location: Microsoft.ServiceBus/preview/2022-01-01-preview/namespace-preview.json#L824 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: requireInfrastructureEncryption Location: Microsoft.ServiceBus/preview/2022-01-01-preview/namespace-preview.json#L955 |
|
'groupId' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ServiceBus/preview/2022-01-01-preview/namespace-preview.json#L1112 |
|
'userAssignedIdentityProperties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ServiceBus/preview/2022-01-01-preview/namespace-preview.json#L1148 |
|
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: NameSpaceCreate Location: Microsoft.ServiceBus/preview/2022-01-01-preview/namespace-preview.json#L346 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️
SDK Track2 Validation: 0 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/0600d276d626cb9a46a9da663b28d4aafd9b77cb/specification/servicebus/resource-manager/readme.md#tag-package-2022-01-preview">servicebus/resource-manager/readme.md#package-2022-01-preview
Rule | Message |
---|---|
"readme":"servicebus/resource-manager/readme.md", "tag":"package-2022-01-preview", "details":"Schema 'SqlRuleAction' has a property 'sqlExpression' that is already declared the parent schema 'Action' but isn't significantly different. The property has been removed from SqlRuleAction" |
|
"readme":"servicebus/resource-manager/readme.md", "tag":"package-2022-01-preview", "details":"Schema 'SqlRuleAction' has a property 'compatibilityLevel' that is already declared the parent schema 'Action' but isn't significantly different. The property has been removed from SqlRuleAction" |
|
"readme":"servicebus/resource-manager/readme.md", "tag":"package-2022-01-preview", "details":"Schema 'SqlRuleAction' has a property 'requiresPreprocessing' that is already declared the parent schema 'Action' but isn't significantly different. The property has been removed from SqlRuleAction" |
|
"readme":"servicebus/resource-manager/readme.md", "tag":"package-2022-01-preview", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Swagger Generation Artifacts
|
NewApiVersionRequired reason: |
Hi @ruowan, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Reverts #19125