Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add x-ms-identifiers for iothub #19969

Merged
merged 3 commits into from
Sep 29, 2022
Merged

Conversation

j-zhong-ms
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
      About this Change
      APIs will need to start indicating item uniqueness in arrays. By default, uniqueness is the string property called "id" of items in an array. When that property does not exist, the x-ms-identifiers extension property must be used to specify the identifying property(s) or lack thereof. This pull request is my best guess effort to ease resource providers into the new requirement before it becomes enforced. Compliance and accuracy will need to be owned and maintained by the resource provider going forward.

See https://github.com/Azure/autorest/tree/main/docs/extensions#x-ms-identifiers.

You can also make changes after this PR is checked in. At this point, this annotation is only used by Change Analysis for change computation, so making changes afterwards shouldn’t be a breaking change.
2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- [ ] SDK of .NET (need service team to ensure code readiness)
- [ ] SDK of Python
- [ ] SDK of Java
- [ ] SDK of Js
- [ ] SDK of Go
- [ ] PowerShell
- [ ] CLI
- [ ] Terraform
- [x] No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@j-zhong-ms j-zhong-ms requested a review from rkmanda as a code owner July 26, 2022 20:24
@openapi-workflow-bot
Copy link

Hi, @j-zhong-ms Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 26, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    compared swaggers (via Oad v0.9.7)] new version base version
    iothub.json 2021-07-02(b29178d) 2021-07-02(main)
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-2021-07-02 package-2021-07-02(b29178d) package-2021-07-02(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L3156
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}'
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L76
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Devices/IotHubs'
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L302
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs'
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L343
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/IotHubStats'
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L387
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/skus'
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L431
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/eventHubEndpoints/{eventHubEndpointName}/ConsumerGroups'
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L478
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/eventHubEndpoints/{eventHubEndpointName}/ConsumerGroups/{name}'
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L532
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/jobs'
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L709
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/jobs/{jobId}'
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L756
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/quotaMetrics'
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L807
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{iotHubName}/routingEndpointsHealth'
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L854
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{iotHubName}/routing/routes/$testall'
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L1000
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{iotHubName}/routing/routes/$testnew'
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L1067
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/listkeys'
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L1134
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/IotHubKeys/{keyName}/listkeys'
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L1181
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/exportDevices'
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L1232
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/importDevices'
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L1285
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/certificates'
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L1338
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/certificates/{certificateName}'
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L1382
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/certificates/{certificateName}/generateVerificationCode'
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L1548
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/certificates/{certificateName}/verify'
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L1602
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{iotHubName}/failover'
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L1665
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L64
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L110
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L175
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L292
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L330
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L374
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/stable/2021-07-02/iothub.json#L421
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌~[Staging] ServiceAPIReadinessTest: 75 Errors, 0 Warnings failed [Detail] Test run on tag: package-2021-07-02, operation coverage: 38/38, failed operations: 28

    Service API Readiness Test failed. Check pipeline artifact for detail report.

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    OBJECT_ADDITIONAL_PROPERTIES "Additional properties not allowed: subscriptionid"
    OBJECT_ADDITIONAL_PROPERTIES "Additional properties not allowed: resourcegroup"
    OBJECT_ADDITIONAL_PROPERTIES "Additional properties not allowed: cosmosDBSqlCollections"
    OBJECT_ADDITIONAL_PROPERTIES "Additional properties not allowed: azureDigitalTwinsInstances"
    OBJECT_ADDITIONAL_PROPERTIES "Additional properties not allowed: subscriptionid"
    OBJECT_ADDITIONAL_PROPERTIES "Additional properties not allowed: resourcegroup"
    CLIENT_ERROR "statusCode: 404,
    errorCode: undefined,
    errorMessage: undefined"
    ASSERTION_ERROR "expected response code to be 2XX but found 404"
    INVALID_TYPE "Expected type string but found type integer"
    OBJECT_ADDITIONAL_PROPERTIES "Additional properties not allowed: subscriptionid"
    OBJECT_ADDITIONAL_PROPERTIES "Additional properties not allowed: resourcegroup"
    CLIENT_ERROR "statusCode: 404,
    errorCode: undefined,
    errorMessage: undefined"
    ASSERTION_ERROR "expected response code to be 2XX but found 404"
    INVALID_TYPE "Expected type string but found type integer"
    CLIENT_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Devices/IotHubs/iothubnamef2sg7n' under resource group 'apiTest-zbvxyc' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ASSERTION_ERROR "expected response code to be 2XX but found 404"
    INVALID_CONTENT_TYPE "Invalid Content-Type (application/json). These are supported: "
    OBJECT_ADDITIONAL_PROPERTIES "Additional properties not allowed: error"
    OBJECT_ADDITIONAL_PROPERTIES "Additional properties not allowed: subscriptionid"
    OBJECT_ADDITIONAL_PROPERTIES "Additional properties not allowed: resourcegroup"
    OBJECT_ADDITIONAL_PROPERTIES "Additional properties not allowed: subscriptionid"
    OBJECT_ADDITIONAL_PROPERTIES "Additional properties not allowed: resourcegroup"
    CLIENT_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Devices/IotHubs/iothubnamef2sg7n' under resource group 'apiTest-zbvxyc' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ASSERTION_ERROR "expected response code to be 2XX but found 404"
    OBJECT_ADDITIONAL_PROPERTIES "Additional properties not allowed: error"
    SERVER_ERROR "statusCode: 500,
    errorCode: undefined,
    errorMessage: undefined"
    ASSERTION_ERROR "expected response code to be 2XX but found 500"
    INVALID_TYPE "Expected type string but found type integer"
    CLIENT_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Devices/IotHubs/iothubnamef2sg7n' under resource group 'apiTest-zbvxyc' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ASSERTION_ERROR "expected response code to be 2XX but found 404"
    ️❌ModelValidation: 7 Errors, 0 Warnings failed [Detail]
    Rule Message
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Devices/stable/2021-07-02/iothub.json#L270:22
    ExampleUrl: stable/2021-07-02/examples/iothub_delete.json
    INVALID_FORMAT Object didn't pass validation for format date-time-rfc1123: 2020-03-26T21:20:57Z
    Url: Microsoft.Devices/stable/2021-07-02/iothub.json#L3534:42
    ExampleUrl: stable/2021-07-02/examples/iothub_routingendpointhealth.json#L15:46
    INVALID_FORMAT Object didn't pass validation for format date-time-rfc1123: 2020-03-26T21:20:57Z
    Url: Microsoft.Devices/stable/2021-07-02/iothub.json#L3534:42
    ExampleUrl: stable/2021-07-02/examples/iothub_routingendpointhealth.json#L27:46
    INVALID_FORMAT Object didn't pass validation for format date-time-rfc1123: 2020-03-26T21:24:57Z
    Url: Microsoft.Devices/stable/2021-07-02/iothub.json#L3539:32
    ExampleUrl: stable/2021-07-02/examples/iothub_routingendpointhealth.json#L16:36
    INVALID_FORMAT Object didn't pass validation for format date-time-rfc1123: 2020-03-26T21:24:57Z
    Url: Microsoft.Devices/stable/2021-07-02/iothub.json#L3539:32
    ExampleUrl: stable/2021-07-02/examples/iothub_routingendpointhealth.json#L28:36
    INVALID_FORMAT Object didn't pass validation for format date-time-rfc1123: 2020-03-26T21:24:57Z
    Url: Microsoft.Devices/stable/2021-07-02/iothub.json#L3529:31
    ExampleUrl: stable/2021-07-02/examples/iothub_routingendpointhealth.json#L26:35
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Devices/stable/2021-07-02/iothub.json#L2004:22
    ExampleUrl: stable/2021-07-02/examples/iothub_deleteprivateendpointconnection.json
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️⚠️SDK Track2 Validation: 1 Warnings warning [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/b29178dec655cc41f2d2b591d8acf2a9439ee5bf/specification/iothub/resource-manager/readme.md#tag-package-2021-07-02">iothub/resource-manager/readme.md#package-2021-07-02
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ Modeler/MissingType "readme":"iothub/resource-manager/readme.md",
    "tag":"package-2021-07-02",
    "details":"The schema 'components·11psznm·schemas·eventhubconsumergroupinfo·properties·properties·additionalproperties' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/iothub/resource-manager/Microsoft.Devices/stable/2021-07-02/iothub.json#/components/schemas/components·11psznm·schemas·eventhubconsumergroupinfo·properties·properties·additionalproperties"


    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ UnkownSecurityScheme "readme":"iothub/resource-manager/readme.md",
    "tag":"package-2021-07-02",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 26, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking




    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 73ca52b. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.IotHub [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 73ca52b. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-iothub [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 73ca52b. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/iothub/armiothub [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `RoutingSourceDigitalTwinChangeEvents`
      info	[Changelog] - New const `RoutingSourceMqttBrokerMessages`
      info	[Changelog] - New struct `EncryptionPropertiesDescription`
      info	[Changelog] - New struct `KeyVaultKeyProperties`
      info	[Changelog] - New struct `PropertiesDeviceStreams`
      info	[Changelog] - New struct `RootCertificateProperties`
      info	[Changelog] - New struct `RoutingCosmosDBSQLAPIProperties`
      info	[Changelog] - New field `CosmosDBSQLCollections` in struct `RoutingEndpoints`
      info	[Changelog] - New field `DeviceStreams` in struct `Properties`
      info	[Changelog] - New field `Encryption` in struct `Properties`
      info	[Changelog] - New field `RootCertificate` in struct `Properties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 14 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 73ca52b. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-iothub [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added Interface EncryptionPropertiesDescription
      info	[Changelog]   - Added Interface IotHubPropertiesDeviceStreams
      info	[Changelog]   - Added Interface IotHubResourceCreateOrUpdateHeaders
      info	[Changelog]   - Added Interface IotHubResourceDeleteHeaders
      info	[Changelog]   - Added Interface IotHubResourceUpdateHeaders
      info	[Changelog]   - Added Interface KeyVaultKeyProperties
      info	[Changelog]   - Added Interface PrivateEndpointConnectionsDeleteHeaders
      info	[Changelog]   - Added Interface PrivateEndpointConnectionsUpdateHeaders
      info	[Changelog]   - Added Interface RootCertificateProperties
      info	[Changelog]   - Added Interface RoutingCosmosDBSqlApiProperties
      info	[Changelog]   - Interface IotHubProperties has a new optional parameter deviceStreams
      info	[Changelog]   - Interface IotHubProperties has a new optional parameter encryption
      info	[Changelog]   - Interface IotHubProperties has a new optional parameter rootCertificate
      info	[Changelog]   - Interface RoutingEndpoints has a new optional parameter cosmosDBSqlCollections
      info	[Changelog]   - Add parameters of IotHubResourceUpdateHeaders to TypeAlias IotHubResourceUpdateResponse
      info	[Changelog]   - Enum KnownRoutingSource has a new value DigitalTwinChangeEvents
      info	[Changelog]   - Enum KnownRoutingSource has a new value MqttBrokerMessages
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 73ca52b. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️iothub [View full logs
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from 73ca52b. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @j-zhong-ms, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 4, 2022

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/iothub/armiothub Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Python track2_azure-mgmt-iothub Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    .Net Azure.ResourceManager.IotHub Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Java azure-resourcemanager-iothub Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-iothub Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @j-zhong-ms
    Copy link
    Contributor Author

    Hello @honghr Coud you please review this pr? This should not be a breaking change

    @j-zhong-ms
    Copy link
    Contributor Author

    Hi @rkmanda could you please review this pr? This code change is not breaking

    @honghr
    Copy link
    Contributor

    honghr commented Aug 16, 2022

    Hello @honghr Coud you please review this pr? This should not be a breaking change

    Could you resolve "Swagger ModelValidation" issue firstly?

    @j-zhong-ms
    Copy link
    Contributor Author

    Hello @honghr Coud you please review this pr? This should not be a breaking change

    Could you resolve "Swagger ModelValidation" issue firstly?

    Hi @honghr it seems the model validation errors are not from this change

    @j-zhong-ms
    Copy link
    Contributor Author

    Hi @honghr could you please help get this pr merged? Thanks! The error should not come from the code change

    @honghr
    Copy link
    Contributor

    honghr commented Aug 31, 2022

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @honghr
    Copy link
    Contributor

    honghr commented Sep 6, 2022

    Hi @honghr could you please help get this pr merged? Thanks! The error should not come from the code change

    Hi @j-zhong-ms You still have model validation error not fixed. Please resolve this issue and then I can merge it.

    @ghost
    Copy link

    ghost commented Sep 25, 2022

    Hi, @j-zhong-ms. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Sep 25, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants