Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding maximumFaultDomainCountSupported and currentCapacity property for the Capacity Reservation Resource in API Version 2022-08-01 #20076

Merged
merged 6 commits into from
Aug 31, 2022
Merged

Adding maximumFaultDomainCountSupported and currentCapacity property for the Capacity Reservation Resource in API Version 2022-08-01 #20076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1282ab8
updated swagger
hari-bodicherla Aug 2, 2022
975d536
updated code
hari-bodicherla Aug 9, 2022
54f1c50
swagger changes
hari-bodicherla Aug 12, 2022
67bfd04
udpated swagger
hari-bodicherla Aug 17, 2022
ea374a6
updated swagger
hari-bodicherla Aug 22, 2022
ac62b81
resolved
hari-bodicherla Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...e/resource-manager/Microsoft.Compute/ComputeRP/stable/2022-08-01/capacityReservation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -838,6 +838,12 @@
"CapacityReservationUtilization": {
"type": "object",
"properties": {
"currentCapacity": {
"readOnly": true,
"type": "integer",
"format": "int32",
"description": "The value provides the current capacity of the VM size which was reserved successfully and for which the customer is getting billed.<br><br>Minimum api-version: 2022-08-01."
},
"virtualMachinesAllocated": {
"type": "array",
"items": {
Expand Down Expand Up @@ -873,6 +879,12 @@
"type": "string",
"description": "A unique id generated and assigned to the capacity reservation by the platform which does not change throughout the lifetime of the resource."
},
"platformFaultDomainCount": {
"readOnly": true,
"type": "integer",
"format": "int32",
"description": "Specifies the value of fault domain count that Capacity Reservation supports for requested VM size.<br>NOTE: The fault domain count specified for a resource (like virtual machines scale set) must be less than or equal to this value if it deploys using capacity reservation.<br><br>Minimum api-version: 2022-08-01."
},
"virtualMachinesAssociated": {
"type": "array",
"items": {
Expand Down
4 changes: 3 additions & 1 deletion .../stable/2022-08-01/examples/capacityReservationExamples/CapacityReservationGroup_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"resourceGroupName": "myResourceGroup",
"api-version": "2022-08-01",
"capacityReservationGroupName": "myCapacityReservationGroup",
"expand": "instanceView"
"$expand": "instanceView"
},
"responses": {
"200": {
Expand All @@ -23,6 +23,7 @@
{
"name": "myCapacityReservation1",
"utilizationInfo": {
"currentCapacity": 5,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this and other example files for capacity reservation change expand parameter wherever specified to $expand.

"virtualMachinesAllocated": [
{
"id": "/subscriptions/{subscription-id}/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/myVM1"
Expand All @@ -43,6 +44,7 @@
{
"name": "myCapacityReservation2",
"utilizationInfo": {
"currentCapacity": 5,
"virtualMachinesAllocated": [
{
"id": "/subscriptions/{subscription-id}/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/myVM3"
Expand Down
2 changes: 2 additions & 0 deletions ...e/2022-08-01/examples/capacityReservationExamples/CapacityReservation_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
"1"
],
"properties": {
"platformFaultDomainCount": 3,
"reservationId": "{GUID}",
"provisioningState": "Creating",
"provisioningTime": "2021-06-27T01:02:38.3138469+00:00"
Expand All @@ -58,6 +59,7 @@
"1"
],
"properties": {
"platformFaultDomainCount": 3,
"reservationId": "{GUID}",
"provisioningState": "Creating",
"provisioningTime": "2021-06-27T01:02:38.3138469+00:00"
Expand Down
5 changes: 4 additions & 1 deletion ...uteRP/stable/2022-08-01/examples/capacityReservationExamples/CapacityReservation_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,14 @@
"resourceGroupName": "myResourceGroup",
"api-version": "2022-08-01",
"capacityReservationGroupName": "myCapacityReservationGroup",
"capacityReservationName": "myCapacityReservation"
"capacityReservationName": "myCapacityReservation",
"$expand": "instanceView"
},
"responses": {
"200": {
"body": {
"properties": {
"platformFaultDomainCount": 3,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls. add the $expand = instanceView parameter in the request parameters as this example is also returning the instance view in the response.

"reservationId": "{GUID}",
"provisioningTime": "2021-06-27T01:02:38.3138469+00:00",
"virtualMachinesAssociated": [
Expand All @@ -26,6 +28,7 @@
"provisioningState": "Succeeded",
"instanceView": {
"utilizationInfo": {
"currentCapacity": 5,
"virtualMachinesAllocated": [
{
"id": "/subscriptions/{subscription-id}/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/myVM1"
Expand Down
2 changes: 2 additions & 0 deletions ...8-01/examples/capacityReservationExamples/CapacityReservation_ListByReservationGroup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"type": "Microsoft.Compute/CapacityReservations",
"location": "West US",
"properties": {
"platformFaultDomainCount": 3,
"reservationId": "{GUID}",
"provisioningTime": "2021-06-27T01:02:38.3138469+00:00",
"virtualMachinesAssociated": [
Expand Down Expand Up @@ -48,6 +49,7 @@
"type": "Microsoft.Compute/CapacityReservations",
"location": "West US",
"properties": {
"platformFaultDomainCount": 3,
"reservationId": "{GUID}",
"provisioningTime": "2021-06-27T01:02:38.3138469+00:00",
"virtualMachinesAssociated": [
Expand Down
3 changes: 2 additions & 1 deletion ...08-01/examples/capacityReservationExamples/CapacityReservation_Update_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
}
},
"sku": {
"name": "DSv3-Type1",
"name": "Standard_DS1_v2",
"tier": "aaa",
"capacity": 7
},
Expand All @@ -44,6 +44,7 @@
"1"
],
"properties": {
"platformFaultDomainCount": 3,
"reservationId": "{GUID}",
"virtualMachinesAssociated": [
{
Expand Down