-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2022-08-01 #20246
Conversation
…w/2022-06-01-preview to version 2022-08-01
Hi, @cvarsh Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
compared swaggers (via Oad v0.9.7)] | new version | base version |
---|---|---|
bms.json | 2022-08-01(47b3f95) | 2022-03-01(main) |
bms.json | 2022-08-01(47b3f95) | 2022-06-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 30 items are listed, please refer to log for more details.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v1.13.0) | new version | base version |
---|---|---|
package-2022-08 | package-2022-08(47b3f95) | default(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
R3021 - PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig' Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L21 |
R3021 - PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupPreValidateProtection' Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L164 |
R3021 - PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupStatus' Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L209 |
R3021 - PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupValidateFeatures' Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L254 |
R3021 - PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/backupProtectionIntent/{intentObjectName}' Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L299 |
R3021 - PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupProtectionIntents' Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L460 |
R3021 - PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupUsageSummaries' Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L517 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L194 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L239 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L284 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L337 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L397 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L448 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L498 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L555 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L589 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L448 |
R4015 - NestedResourcesMustHaveListOperation |
The nested resource 'PrivateEndpointConnectionResource' does not have list operation, please add it. Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L4670 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.RecoveryServices/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L577 |
R4036 - ImplementPrivateEndpointAPIs |
The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateLinkResources is missing. Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L20 |
R4036 - ImplementPrivateEndpointAPIs |
The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateEndpointConnections is missing. Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L20 |
R4037 - MissingTypeObject |
The schema 'BackupResourceEncryptionConfigResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L4619 |
R4037 - MissingTypeObject |
The schema 'PrivateEndpointConnectionResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L4670 |
R4037 - MissingTypeObject |
The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L4712 |
R4037 - MissingTypeObject |
The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L4723 |
R4037 - MissingTypeObject |
The schema 'NewErrorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L4764 |
R4037 - MissingTypeObject |
The schema 'BackupResourceConfigResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L6686 |
R4037 - MissingTypeObject |
The schema 'JobResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L7592 |
R4037 - MissingTypeObject |
The schema 'OperationResultInfoBaseResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L8205 |
R4037 - MissingTypeObject |
The schema 'ProtectedItemResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RecoveryServices/stable/2022-08-01/bms.json#L8528 |
️❌
Avocado: 4 Errors, 0 Warnings failed [Detail]
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️❌
~[Staging] ServiceAPIReadinessTest: 162 Errors, 0 Warnings failed [Detail]
Test run on tag: package-2022-08, operation coverage: 76/76, failed operations: 76Service API Readiness Test failed. Check pipeline artifact for detail report.
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/vaultnamel7klc2' under resource group 'apiTest-OfAUPG' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/vaultnamel7klc2' under resource group 'apiTest-OfAUPG' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/vaultnamel7klc2' under resource group 'apiTest-OfAUPG' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/vaultnamel7klc2' under resource group 'apiTest-OfAUPG' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/vaultnamel7klc2' under resource group 'apiTest-OfAUPG' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/vaultnamel7klc2' under resource group 'apiTest-OfAUPG' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/vaultnamel7klc2' under resource group 'apiTest-OfAUPG' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/vaultnamel7klc2' under resource group 'apiTest-OfAUPG' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 403, errorCode: LinkedAuthorizationFailed, errorMessage: The client has permission to perform action 'Microsoft.DataProtection/resourceGuards/read' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-OfAUPG/providers/Microsoft.RecoveryServices/vaults/vaultnamel7klc2/backupResourceGuardProxies/resourceguahn40d', however the linked subscription 'c999d45b-944f-418c-a0d8-c3fcfd1802c8' was not found. " |
ASSERTION_ERROR |
"expected response code to be 2XX but found 403" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/vaultnamel7klc2' under resource group 'apiTest-OfAUPG' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 403, errorCode: LinkedAuthorizationFailed, errorMessage: The client has permission to perform action 'Microsoft.DataProtection/resourceGuards/deleteProtectedItemRequests/approve/action' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-OfAUPG/providers/Microsoft.RecoveryServices/vaults/vaultnamel7klc2/backupResourceGuardProxies/resourceguahn40d', however the linked subscription 'c999d45b-944f-418c-a0d8-c3fcfd1802c8' was not found. " |
ASSERTION_ERROR |
"expected response code to be 2XX but found 403" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/vaultnamel7klc2' under resource group 'apiTest-OfAUPG' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/vaultnamel7klc2' under resource group 'apiTest-OfAUPG' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/vaultnamel7klc2' under resource group 'apiTest-OfAUPG' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
DISCRIMINATOR_VALUE_NOT_FOUND |
"Discriminator value "fabricnameensb2wResourceItem" not found" |
INVALID_RESPONSE_CODE |
"The swagger file does not define '404' response code" |
️⚠️
~[Staging] TrafficValidation: 1 Warnings warning [Detail]
restlerResult:
Traffic validation failed. Check pipeline artifact for restler output and detail report.
Rule | Message |
---|---|
"Starting task Test...\nUsing python: 'python3' (Python 3.10.5) | |
ERROR: Restler engine failed. See logs in /swagger/restler_output/Test directory for more information. | |
Task Test failed.\nCollecting logs...\n" |
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️
SDK Track2 Validation: 3 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/47b3f95746b912f25c0cfa8ccd1cefb27a330c7a/specification/recoveryservicesbackup/resource-manager/readme.md#tag-package-2022-08">recoveryservicesbackup/resource-manager/readme.md#package-2022-08
Rule | Message |
---|---|
"readme":"recoveryservicesbackup/resource-manager/readme.md", "tag":"package-2022-08", "details":"Schema 'RecoveryPointTierInformationV2' has a property 'type' that is already declared the parent schema 'RecoveryPointTierInformation' but isn't significantly different. The property has been removed from RecoveryPointTierInformationV2" |
|
"readme":"recoveryservicesbackup/resource-manager/readme.md", "tag":"package-2022-08", "details":"Schema 'RecoveryPointTierInformationV2' has a property 'status' that is already declared the parent schema 'RecoveryPointTierInformation' but isn't significantly different. The property has been removed from RecoveryPointTierInformationV2" |
|
"readme":"recoveryservicesbackup/resource-manager/readme.md", "tag":"package-2022-08", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Swagger Generation Artifacts
|
Generated ApiView
|
Hi @cvarsh, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Hi @cvarsh, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
/azp run unifiedPipeline |
No pipelines are associated with this pull request. |
Updated new value of ProtectionState
Fixing Lintdiff issue
Fixed Avocado issue
Typo fix
Approved the breaking change as it's already approved in #19425 |
Hi, @cvarsh. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Hi, @cvarsh. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
/azp |
Supported commands
See additional documentation. |
Hi, @cvarsh. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Hi, @cvarsh. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee. |
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.