Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery 2022-03-03 API release #20396

Merged
merged 5 commits into from
Sep 29, 2022
Merged

Conversation

Sandido
Copy link
Member

@Sandido Sandido commented Aug 25, 2022

ARM API Information (Control Plane)

Swagger PR being merged to this branch is: #20398
This PR was signed off for the breaking changes in this PR because the functionality was broken for customers so these changes will not hurt customers.
The individual SDK owners have approved this breaking change as well.

.Net changes for this branch are here: https://github.com/Azure/azure-sdk-for-net/pull/29817/files
And the .Net changes for the new features are here: Azure/azure-sdk-for-net#30125

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

some new api ver

all api versions exs

move common
@openapi-workflow-bot
Copy link

Hi, @Sandido Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 25, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 2 Errors, 21 Warnings failed [Detail]
    compared swaggers (via Oad v0.9.7)] new version base version
    communityGallery.json 2022-03-03(af0c875) 2022-01-03(main)
    gallery.json 2022-03-03(af0c875) 2022-01-03(main)
    gallery.json 2022-03-03(af0c875) 2020-09-30(main)
    galleryRPCommon.json 2022-03-03(af0c875) 2022-01-03(main)
    sharedGallery.json 2022-03-03(af0c875) 2022-01-03(main)
    sharedGallery.json 2022-03-03(af0c875) 2020-09-30(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Rule Message
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'uri' renamed or removed?
    New: GalleryRP/stable/2022-03-03/gallery.json#L2740:7
    Old: GalleryRP/stable/2022-01-03/gallery.json#L2626:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'uri' renamed or removed?
    New: GalleryRP/stable/2022-03-03/gallery.json#L2754:7
    Old: GalleryRP/stable/2022-01-03/gallery.json#L2626:7
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: GalleryRP/stable/2022-03-03/gallery.json#L2719:9
    Old: GalleryRP/stable/2022-01-03/gallery.json#L2606:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: GalleryRP/stable/2022-03-03/gallery.json#L2809:9
    Old: GalleryRP/stable/2022-01-03/gallery.json#L2685:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: GalleryRP/stable/2022-03-03/gallery.json#L2809:9
    Old: GalleryRP/stable/2022-01-03/gallery.json#L2685:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: GalleryRP/stable/2022-03-03/gallery.json#L2809:9
    Old: GalleryRP/stable/2022-01-03/gallery.json#L2685:9
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: GalleryRP/stable/2022-03-03/gallery.json#L2719:9
    Old: GalleryRP/stable/2022-01-03/gallery.json#L2606:9
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: GalleryRP/stable/2022-03-03/gallery.json#L2809:9
    Old: GalleryRP/stable/2022-01-03/gallery.json#L2685:9
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: GalleryRP/stable/2022-03-03/gallery.json#L2809:9
    Old: GalleryRP/stable/2022-01-03/gallery.json#L2685:9
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: GalleryRP/stable/2022-03-03/gallery.json#L2809:9
    Old: GalleryRP/stable/2022-01-03/gallery.json#L2685:9


    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'LocationNameParamter' removed or renamed?
    New: azure-rest-api-specs/blob/af0c875c19f12d8e5f3f895380f91f1e35de40c6/revision#L1034:2
    Old: GalleryRP/preview/2020-09-30/sharedGallery.json#L762:3
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: GalleryRP/stable/2022-03-03/gallery.json#L2604:9
    Old: GalleryRP/preview/2020-09-30/gallery.json#L2358:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: GalleryRP/stable/2022-03-03/gallery.json#L2719:9
    Old: GalleryRP/preview/2020-09-30/gallery.json#L2439:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: GalleryRP/stable/2022-03-03/gallery.json#L2809:9
    Old: GalleryRP/preview/2020-09-30/gallery.json#L2515:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: GalleryRP/stable/2022-03-03/gallery.json#L2809:9
    Old: GalleryRP/preview/2020-09-30/gallery.json#L2515:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: GalleryRP/stable/2022-03-03/gallery.json#L2620:5
    Old: GalleryRP/preview/2020-09-30/gallery.json#L2371:5
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: GalleryRP/stable/2022-03-03/gallery.json#L2809:9
    Old: GalleryRP/preview/2020-09-30/gallery.json#L2515:9
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: GalleryRP/stable/2022-03-03/gallery.json#L2719:9
    Old: GalleryRP/preview/2020-09-30/gallery.json#L2439:9
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: GalleryRP/stable/2022-03-03/gallery.json#L2809:9
    Old: GalleryRP/preview/2020-09-30/gallery.json#L2515:9
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: GalleryRP/stable/2022-03-03/gallery.json#L2809:9
    Old: GalleryRP/preview/2020-09-30/gallery.json#L2515:9
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: GalleryRP/stable/2022-03-03/gallery.json#L2809:9
    Old: GalleryRP/preview/2020-09-30/gallery.json#L2515:9
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'uri' renamed or removed?
    New: GalleryRP/stable/2022-03-03/gallery.json#L2740:7
    Old: GalleryRP/preview/2020-09-30/gallery.json#L2456:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'uri' renamed or removed?
    New: GalleryRP/stable/2022-03-03/gallery.json#L2754:7
    Old: GalleryRP/preview/2020-09-30/gallery.json#L2456:7
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 4 Warnings warning [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-2022-03-03 package-2022-03-03(af0c875) default(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: required
    Location: GalleryRP/stable/2022-03-03/gallery.json#L2179
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: excludeFromLatest
    Location: GalleryRP/stable/2022-03-03/gallery.json#L2535
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: allowDeletionOfReplicatedLocations
    Location: GalleryRP/stable/2022-03-03/gallery.json#L2837
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: reportedForPolicyViolation
    Location: GalleryRP/stable/2022-03-03/gallery.json#L2847


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R4037 - MissingTypeObject The schema 'PirCommunityGalleryResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/communityGallery.json#L267
    R4037 - MissingTypeObject The schema 'CommunityGalleryIdentifier' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/communityGallery.json#L291
    R4037 - MissingTypeObject The schema 'CommunityGallery' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/communityGallery.json#L300
    R4037 - MissingTypeObject The schema 'CommunityGalleryImage' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/communityGallery.json#L330
    R4037 - MissingTypeObject The schema 'CommunityGalleryImageProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/communityGallery.json#L344
    R4037 - MissingTypeObject The schema 'CommunityGalleryImageVersion' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/communityGallery.json#L449
    R4037 - MissingTypeObject The schema 'CommunityGalleryImageVersionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/communityGallery.json#L463
    R4037 - MissingTypeObject The schema 'Gallery' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/gallery.json#L1738
    R4037 - MissingTypeObject The schema 'GalleryUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/gallery.json#L1752
    R4037 - MissingTypeObject The schema 'GalleryProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/gallery.json#L1766
    R4037 - MissingTypeObject The schema 'GalleryIdentifier' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/gallery.json#L1792
    R4037 - MissingTypeObject The schema 'SharingProfile' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/gallery.json#L1802
    R4037 - MissingTypeObject The schema 'SharingProfileGroup' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/gallery.json#L1833
    R4037 - MissingTypeObject The schema 'GalleryApplication' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/gallery.json#L1958
    R4037 - MissingTypeObject The schema 'GalleryApplicationUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/gallery.json#L1972
    R4037 - MissingTypeObject The schema 'GalleryApplicationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/gallery.json#L1986
    R4037 - MissingTypeObject The schema 'GalleryApplicationVersion' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/gallery.json#L2037
    R4037 - MissingTypeObject The schema 'GalleryApplicationVersionUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/gallery.json#L2051
    R4037 - MissingTypeObject The schema 'GalleryApplicationVersionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/gallery.json#L2065
    R4037 - MissingTypeObject The schema 'GalleryApplicationVersionPublishingProfile' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/gallery.json#L2087
    R4037 - MissingTypeObject The schema 'UserArtifactSource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/gallery.json#L2210
    R4037 - MissingTypeObject The schema 'UserArtifactManage' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/gallery.json#L2226
    R4037 - MissingTypeObject The schema 'GalleryImage' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/gallery.json#L2260
    R4037 - MissingTypeObject The schema 'GalleryImageUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/gallery.json#L2274
    R4037 - MissingTypeObject The schema 'GalleryImageProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/gallery.json#L2288
    R4037 - MissingTypeObject The schema 'GalleryImageVersion' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/gallery.json#L2384
    R4037 - MissingTypeObject The schema 'GalleryImageVersionUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/gallery.json#L2398
    R4037 - MissingTypeObject The schema 'GalleryImageVersionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/gallery.json#L2412
    R4037 - MissingTypeObject The schema 'GalleryArtifactPublishingProfileBase' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/gallery.json#L2437
    R4037 - MissingTypeObject The schema 'TargetRegion' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: GalleryRP/stable/2022-03-03/gallery.json#L2508
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/compute/resource-manager/readme.md
    tag: specification/compute/resource-manager/readme.md#tag-package-2022-03-03
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]
    Validation passes for ServiceAPIReadinessTest.
    ️️✔️~[Staging] TrafficValidation succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️❌SDK Track2 Validation: 2 Errors, 1 Warnings failed [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/af0c875c19f12d8e5f3f895380f91f1e35de40c6/specification/compute/resource-manager/readme.md#tag-package-2022-03-03">compute/resource-manager/readme.md#package-2022-03-03
      • "https://github.com/Azure/azure-rest-api-specs/blob/af0c875c19f12d8e5f3f895380f91f1e35de40c6/specification/compute/resource-manager/readme.md#tag-package-2022-03-03-only">compute/resource-manager/readme.md#package-2022-03-03-only
    The following errors/warnings are introduced by current PR:
    Rule Message
    PreCheck/DuplicateSchema "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-03-03",
    "details":"Duplicate Schema named 'PurchasePlan' (1 differences):\n - properties.promotionCode: => "$ref":"#/components/schemas/schemas:1405",
    "description":"The Offer Promotion Code."; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-03-03",
    "details":"Error: 1 errors occured -- cannot continue."
    ⚠️ UnkownSecurityScheme "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-03-03-only",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 25, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/compute/armcompute - Approved - 4.0.0
    +	Field `URI` of struct `GalleryArtifactVersionSource` has been removed
    +	Type of `GalleryDataDiskImage.Source` has been changed from `*GalleryArtifactVersionSource` to `*GalleryDiskImageSource`
    +	Type of `GalleryDiskImage.Source` has been changed from `*GalleryArtifactVersionSource` to `*GalleryDiskImageSource`
    +	Type of `GalleryImageVersionStorageProfile.Source` has been changed from `*GalleryArtifactVersionSource` to `*GalleryArtifactVersionFullSource`
    +	Type of `GalleryOSDiskImage.Source` has been changed from `*GalleryArtifactVersionSource` to `*GalleryDiskImageSource`

    azure-sdk-for-js - @azure/arm-compute - Approved - 20.0.0
    +	Interface GalleryArtifactVersionSource no longer has parameter uri
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from ddca448. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.Compute [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from ddca448. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-compute [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from ddca448. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-compute [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added Interface GalleryApplicationCustomAction
      info	[Changelog]   - Added Interface GalleryApplicationCustomActionParameter
      info	[Changelog]   - Added Interface GalleryApplicationVersionSafetyProfile
      info	[Changelog]   - Added Interface GalleryArtifactSafetyProfileBase
      info	[Changelog]   - Added Interface GalleryArtifactVersionFullSource
      info	[Changelog]   - Added Interface GalleryDiskImageSource
      info	[Changelog]   - Added Interface GalleryImageVersionSafetyProfile
      info	[Changelog]   - Added Interface LatestGalleryImageVersion
      info	[Changelog]   - Added Interface PolicyViolation
      info	[Changelog]   - Added Type Alias GalleryApplicationCustomActionParameterType
      info	[Changelog]   - Added Type Alias PolicyViolationCategory
      info	[Changelog]   - Interface GalleryApplication has a new optional parameter customActions
      info	[Changelog]   - Interface GalleryApplicationUpdate has a new optional parameter customActions
      info	[Changelog]   - Interface GalleryApplicationVersion has a new optional parameter safetyProfile
      info	[Changelog]   - Interface GalleryApplicationVersionPublishingProfile has a new optional parameter customActions
      info	[Changelog]   - Interface GalleryApplicationVersionUpdate has a new optional parameter safetyProfile
      info	[Changelog]   - Interface GalleryImageVersion has a new optional parameter safetyProfile
      info	[Changelog]   - Interface GalleryImageVersionUpdate has a new optional parameter safetyProfile
      info	[Changelog]   - Interface SharedGalleryImage has a new optional parameter eula
      info	[Changelog]   - Interface SharedGalleryImage has a new optional parameter privacyStatementUri
      info	[Changelog]   - Interface TargetRegion has a new optional parameter excludeFromLatest
      info	[Changelog]   - Added Enum KnownPolicyViolationCategory
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Interface GalleryArtifactVersionSource no longer has parameter uri
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from ddca448. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/compute/armcompute [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `*CloudServicesClient.BeginCreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, CloudService, *CloudServicesClientBeginCreateOrUpdateOptions)` to `(context.Context, string, string, *CloudServicesClientBeginCreateOrUpdateOptions)`
      info	[Changelog] - Function `*CloudServicesClient.BeginUpdate` parameter(s) have been changed from `(context.Context, string, string, CloudServiceUpdate, *CloudServicesClientBeginUpdateOptions)` to `(context.Context, string, string, *CloudServicesClientBeginUpdateOptions)`
      info	[Changelog] - Function `*CloudServicesUpdateDomainClient.BeginWalkUpdateDomain` parameter(s) have been changed from `(context.Context, string, string, int32, UpdateDomain, *CloudServicesUpdateDomainClientBeginWalkUpdateDomainOptions)` to `(context.Context, string, string, int32, *CloudServicesUpdateDomainClientBeginWalkUpdateDomainOptions)`
      info	[Changelog] - Type of `GalleryOSDiskImage.Source` has been changed from `*GalleryArtifactVersionSource` to `*GalleryDiskImageSource`
      info	[Changelog] - Type of `GalleryImageVersionStorageProfile.Source` has been changed from `*GalleryArtifactVersionSource` to `*GalleryArtifactVersionFullSource`
      info	[Changelog] - Type of `SharingProfile.CommunityGalleryInfo` has been changed from `interface{}` to `*CommunityGalleryInfo`
      info	[Changelog] - Type of `GalleryDataDiskImage.Source` has been changed from `*GalleryArtifactVersionSource` to `*GalleryDiskImageSource`
      info	[Changelog] - Type of `VirtualMachineExtensionUpdateProperties.ProtectedSettingsFromKeyVault` has been changed from `interface{}` to `*KeyVaultSecretReference`
      info	[Changelog] - Type of `VirtualMachineScaleSetExtensionProperties.ProtectedSettingsFromKeyVault` has been changed from `interface{}` to `*KeyVaultSecretReference`
      info	[Changelog] - Type of `GalleryDiskImage.Source` has been changed from `*GalleryArtifactVersionSource` to `*GalleryDiskImageSource`
      info	[Changelog] - Type of `VirtualMachineExtensionProperties.ProtectedSettingsFromKeyVault` has been changed from `interface{}` to `*KeyVaultSecretReference`
      info	[Changelog] - Struct `CloudError` has been removed
      info	[Changelog] - Field `URI` of struct `GalleryArtifactVersionSource` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `PolicyViolationCategoryOther`
      info	[Changelog] - New const `GalleryApplicationCustomActionParameterTypeConfigurationDataBlob`
      info	[Changelog] - New const `GalleryApplicationCustomActionParameterTypeString`
      info	[Changelog] - New const `GalleryApplicationCustomActionParameterTypeLogOutputBlob`
      info	[Changelog] - New const `DiskControllerTypesSCSI`
      info	[Changelog] - New const `PolicyViolationCategoryIPTheft`
      info	[Changelog] - New const `PolicyViolationCategoryImageFlaggedUnsafe`
      info	[Changelog] - New const `DiskControllerTypesNVMe`
      info	[Changelog] - New const `PolicyViolationCategoryCopyrightValidation`
      info	[Changelog] - New type alias `GalleryApplicationCustomActionParameterType`
      info	[Changelog] - New type alias `DiskControllerTypes`
      info	[Changelog] - New type alias `PolicyViolationCategory`
      info	[Changelog] - New function `PossibleGalleryApplicationCustomActionParameterTypeValues() []GalleryApplicationCustomActionParameterType`
      info	[Changelog] - New function `PossibleDiskControllerTypesValues() []DiskControllerTypes`
      info	[Changelog] - New function `PossiblePolicyViolationCategoryValues() []PolicyViolationCategory`
      info	[Changelog] - New struct `GalleryApplicationCustomAction`
      info	[Changelog] - New struct `GalleryApplicationCustomActionParameter`
      info	[Changelog] - New struct `GalleryApplicationVersionSafetyProfile`
      info	[Changelog] - New struct `GalleryArtifactSafetyProfileBase`
      info	[Changelog] - New struct `GalleryArtifactVersionFullSource`
      info	[Changelog] - New struct `GalleryDiskImageSource`
      info	[Changelog] - New struct `GalleryImageVersionSafetyProfile`
      info	[Changelog] - New struct `LatestGalleryImageVersion`
      info	[Changelog] - New struct `PolicyViolation`
      info	[Changelog] - New struct `PriorityMixPolicy`
      info	[Changelog] - New field `HardwareProfile` in struct `VirtualMachineScaleSetUpdateVMProfile`
      info	[Changelog] - New field `Parameters` in struct `CloudServicesClientBeginCreateOrUpdateOptions`
      info	[Changelog] - New field `DiskControllerType` in struct `VirtualMachineScaleSetUpdateStorageProfile`
      info	[Changelog] - New field `EnableVMAgentPlatformUpdates` in struct `WindowsConfiguration`
      info	[Changelog] - New field `ExcludeFromLatest` in struct `TargetRegion`
      info	[Changelog] - New field `OptimizedForFrequentAttach` in struct `DiskProperties`
      info	[Changelog] - New field `BurstingEnabledTime` in struct `DiskProperties`
      info	[Changelog] - New field `DiskControllerType` in struct `StorageProfile`
      info	[Changelog] - New field `SafetyProfile` in struct `GalleryApplicationVersionProperties`
      info	[Changelog] - New field `PriorityMixPolicy` in struct `VirtualMachineScaleSetProperties`
      info	[Changelog] - New field `IncrementalSnapshotFamilyID` in struct `SnapshotProperties`
      info	[Changelog] - New field `OptimizedForFrequentAttach` in struct `DiskUpdateProperties`
      info	[Changelog] - New field `CustomActions` in struct `GalleryApplicationVersionPublishingProfile`
      info	[Changelog] - New field `DisableTCPStateTracking` in struct `VirtualMachineScaleSetUpdateNetworkConfigurationProperties`
      info	[Changelog] - New field `Parameters` in struct `CloudServicesUpdateDomainClientBeginWalkUpdateDomainOptions`
      info	[Changelog] - New field `DiskControllerType` in struct `VirtualMachineScaleSetStorageProfile`
      info	[Changelog] - New field `SafetyProfile` in struct `GalleryImageVersionProperties`
      info	[Changelog] - New field `EnableVMAgentPlatformUpdates` in struct `LinuxConfiguration`
      info	[Changelog] - New field `PlatformFaultDomainCount` in struct `CapacityReservationProperties`
      info	[Changelog] - New field `CurrentCapacity` in struct `CapacityReservationUtilization`
      info	[Changelog] - New field `PerformancePlus` in struct `CreationData`
      info	[Changelog] - New field `CustomActions` in struct `GalleryApplicationProperties`
      info	[Changelog] - New field `DiskControllerTypes` in struct `SupportedCapabilities`
      info	[Changelog] - New field `Eula` in struct `SharedGalleryImageProperties`
      info	[Changelog] - New field `PrivacyStatementURI` in struct `SharedGalleryImageProperties`
      info	[Changelog] - New field `Parameters` in struct `CloudServicesClientBeginUpdateOptions`
      info	[Changelog] - New field `DisableTCPStateTracking` in struct `VirtualMachineScaleSetNetworkConfigurationProperties`
      info	[Changelog] - New field `DisableTCPStateTracking` in struct `VirtualMachineNetworkInterfaceConfigurationProperties`
      info	[Changelog]
      info	[Changelog] Total 14 breaking change(s), 61 additive change(s).
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from ddca448. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️compute [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from ddca448. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.compute [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 25, 2022

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/compute/armcompute https://apiview.dev/Assemblies/Review/33bf7ebc2020434cb6226993af13bc73
    JavaScript @azure/arm-compute https://apiview.dev/Assemblies/Review/998e400ff6114dfd95bb49e971d24c81
    Java azure-resourcemanager-compute-generated https://apiview.dev/Assemblies/Review/1665e66673bd41e38d22b04a57de826b
    .Net Azure.ResourceManager.Compute There is no API change compared with the previous version
    Python track2_azure-mgmt-compute Create ApiView timeout. Package is too large and we cannot create ApiView for it.

    @openapi-workflow-bot openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 1, 2022
    @openapi-workflow-bot
    Copy link

    Hi, @Sandido your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @Sandido Sandido marked this pull request as ready for review September 1, 2022 20:11
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 19, 2022
    @rkmanda
    Copy link
    Member

    rkmanda commented Sep 19, 2022

              "$ref": "../../../common-types/v1/common.json#/definitions/CloudError"
    

    change all these to v3


    Refers to: specification/compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2022-03-03/gallery.json:1160 in 77e5c9c. [](commit_id = 77e5c9c, deletion_comment = False)

    @rkmanda
    Copy link
    Member

    rkmanda commented Sep 20, 2022

    "GalleryArtifactVersionSource": {
    

    removing uri is a breaking change. Please revert this or get a breakingchanges approval


    Refers to: specification/compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2022-03-03/gallery.json:2753 in 77e5c9c. [](commit_id = 77e5c9c, deletion_comment = False)

    @rkmanda rkmanda added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 20, 2022
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 20, 2022
    @rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 21, 2022
    @openapi-workflow-bot openapi-workflow-bot bot removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 21, 2022
    @AzureRestAPISpecReview AzureRestAPISpecReview added ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test SuppressionReviewRequired WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 23, 2022
    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Sep 27, 2022
    @ArcturusZhang ArcturusZhang added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Sep 29, 2022
    @ArcturusZhang ArcturusZhang merged commit ddca448 into main Sep 29, 2022
    @ArcturusZhang ArcturusZhang deleted the feature/gallery-2022-03-03-9 branch September 29, 2022 02:23
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-JavaScript Compute ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.