[Hub Generated] Review request for Microsoft.RecoveryServices to add version preview/2022-09-01-preview #20567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w/2022-06-01-preview to version 2022-09-01-preview
|
Hi, @pratimaupadhyay02 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| compared swaggers (via Oad v0.9.7)] | new version | base version |
|---|---|---|
| bms.json | 2022-09-01-preview(178749d) | 2022-03-01(main) |
| bms.json | 2022-09-01-preview(178749d) | 2022-06-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 30 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 1 Warnings warning [Detail]
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-preview-2022-09 | package-preview-2022-09(178749d) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List Backup Protection Containers Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L4108 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig' Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L21 |
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupPreValidateProtection' Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L164 |
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupStatus' Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L209 |
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupValidateFeatures' Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L254 |
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/backupProtectionIntent/{intentObjectName}' Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L299 |
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupProtectionIntents' Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L460 |
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupUsageSummaries' Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L517 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L194 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L239 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L284 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L337 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L397 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L448 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L498 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L555 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L589 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L448 |
|
The nested resource 'PrivateEndpointConnectionResource' does not have list operation, please add it. Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L4726 |
|
The response schema of operations API '/providers/Microsoft.RecoveryServices/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L577 |
|
The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateLinkResources is missing. Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L20 |
|
The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateEndpointConnections is missing. Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L20 |
|
The schema 'BackupResourceEncryptionConfigResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L4675 |
|
The schema 'PrivateEndpointConnectionResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L4726 |
|
The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L4768 |
|
The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L4779 |
|
The schema 'NewErrorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L4820 |
|
The schema 'BackupResourceConfigResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L6738 |
|
The schema 'JobResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L7642 |
|
The schema 'OperationResultInfoBaseResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L8255 |
|
The schema 'ProtectedItemResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RecoveryServices/preview/2022-09-01-preview/bms.json#L8583 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌~[Staging] ServiceAPIReadinessTest: 160 Errors, 0 Warnings failed [Detail]
Tag package-preview-2022-09; Prod region: Deployed
Test run on region: westcentralus; Operation coverage: total: 77, untested: 0, failed: 76, passed: 1
Service API Readiness Test failed. Check pipeline artifact for detail report.
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/vaultnameh2pg4u' under resource group 'apiTest-slBaML-20567' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"expected response code to be 2XX but found 404" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/vaultnameh2pg4u' under resource group 'apiTest-slBaML-20567' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"expected response code to be 2XX but found 404" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/vaultnameh2pg4u' under resource group 'apiTest-slBaML-20567' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"expected response code to be 2XX but found 404" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/vaultnameh2pg4u' under resource group 'apiTest-slBaML-20567' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"expected response code to be 2XX but found 404" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/vaultnameh2pg4u' under resource group 'apiTest-slBaML-20567' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"expected response code to be 2XX but found 404" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/vaultnameh2pg4u' under resource group 'apiTest-slBaML-20567' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"expected response code to be 2XX but found 404" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/vaultnameh2pg4u' under resource group 'apiTest-slBaML-20567' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"expected response code to be 2XX but found 404" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/vaultnameh2pg4u' under resource group 'apiTest-slBaML-20567' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"expected response code to be 2XX but found 404" |
|
"statusCode: 403, errorCode: LinkedAuthorizationFailed, errorMessage: The client has permission to perform action 'Microsoft.DataProtection/resourceGuards/read' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-slBaML-20567/providers/Microsoft.RecoveryServices/vaults/vaultnameh2pg4u/backupResourceGuardProxies/resourcegutqd6zh', however the linked subscription 'c999d45b-944f-418c-a0d8-c3fcfd1802c8' was not found. " |
|
"expected response code to be 2XX but found 403" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/vaultnameh2pg4u' under resource group 'apiTest-slBaML-20567' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"expected response code to be 2XX but found 404" |
|
"statusCode: 403, errorCode: LinkedAuthorizationFailed, errorMessage: The client has permission to perform action 'Microsoft.DataProtection/resourceGuards/deleteProtectedItemRequests/approve/action' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-slBaML-20567/providers/Microsoft.RecoveryServices/vaults/vaultnameh2pg4u/backupResourceGuardProxies/resourcegutqd6zh', however the linked subscription 'c999d45b-944f-418c-a0d8-c3fcfd1802c8' was not found. " |
|
"expected response code to be 2XX but found 403" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/vaultnameh2pg4u' under resource group 'apiTest-slBaML-20567' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"expected response code to be 2XX but found 404" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/vaultnameh2pg4u' under resource group 'apiTest-slBaML-20567' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"expected response code to be 2XX but found 404" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/vaultnameh2pg4u' under resource group 'apiTest-slBaML-20567' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"expected response code to be 2XX but found 404" |
|
"The swagger file does not define '404' response code" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/vaultnameh2pg4u' under resource group 'apiTest-slBaML-20567' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
️❌~[Staging] TrafficValidation: 0 Errors, 0 Warnings failed [Detail]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️SDK Track2 Validation: 3 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/178749dd5b4b12ddd6085b816e563755dd82296d/specification/recoveryservicesbackup/resource-manager/readme.md#tag-package-preview-2022-09">recoveryservicesbackup/resource-manager/readme.md#package-preview-2022-09
| Rule | Message |
|---|---|
| "readme":"recoveryservicesbackup/resource-manager/readme.md", "tag":"package-preview-2022-09", "details":"Schema 'RecoveryPointTierInformationV2' has a property 'type' that is already declared the parent schema 'RecoveryPointTierInformation' but isn't significantly different. The property has been removed from RecoveryPointTierInformationV2" |
|
| "readme":"recoveryservicesbackup/resource-manager/readme.md", "tag":"package-preview-2022-09", "details":"Schema 'RecoveryPointTierInformationV2' has a property 'status' that is already declared the parent schema 'RecoveryPointTierInformation' but isn't significantly different. The property has been removed from RecoveryPointTierInformationV2" |
|
| "readme":"recoveryservicesbackup/resource-manager/readme.md", "tag":"package-preview-2022-09", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
ghost
added
the
|
Hi @pratimaupadhyay02, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This was referenced Sep 2, 2022
This was referenced Sep 2, 2022
|
Hi @pratimaupadhyay02, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
@pratimaupadhyay02 - Please carefully and completely fill out the submission form for your PR. It cannot be properly reviewed or routed without that information. Also, you will need to resolve the breaking change review label prior to getting ARM review (assuming it remains after you fill out the submission form). |
|
Hi @leni-msft , the Cross version breaking change is failing as the new swagger is compared with the previous base stable version as well, however, its supposed to be compared with the previous preview version. Do we need to get breaking change review for the same as the breaking change check is passing ? |
in this case you don't need |
|
@tadelesh please help check go sdk failure |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Resolved. |
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
|
Hi, @pratimaupadhyay02 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
rkmanda
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AzureRestAPISpecReview
added
the
ReadyForApiTest
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
leni-msft
added
BreakingChangeReviewRequired
leni-msft
approved these changes
Sep 30, 2022
|
Cross version breaking change were already approved in previous preview version PR. |
This was referenced Oct 3, 2022
Closed
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Oct 3, 2022
… Microsoft.RecoveryServices to add version preview/2022-09-01-preview (#2598) Create to sync Azure/azure-rest-api-specs#20567 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/recoveryservicesbackup?expand=1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.