Task 15517198: Update test button supported alert type document #20774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @thomasp98296 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
|
Swagger pipeline started successfully, please wait for status update in this comment. |
|
Swagger pipeline started successfully, please wait for status update in this comment. |
|
Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment. |
ghost
added
the
|
/azp run |
Swagger Validation Report
|
| compared swaggers (via Oad v0.9.7)] | new version | base version |
|---|---|---|
| actionGroups_API.json | 2022-06-01(9ad6967) | 2022-06-01(main) |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-composite-v1 | package-composite-v1(9ad6967) | package-composite-v1(main) |
| package-2022-10 | package-2022-10(9ad6967) | package-2022-10(main) |
| package-2022-06 | package-2022-06(9ad6967) | package-2022-06(main) |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/monitor/resource-manager/readme.md tag: specification/monitor/resource-manager/readme.md#tag-package-composite-v1 |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌~[Staging] ServiceAPIReadinessTest: 0 Errors, 0 Warnings failed [Detail]
Tag package-composite-v1; Prod region: Not deployed; Canary region: Not deployed
️❌~[Staging] TrafficValidation: 0 Errors, 0 Warnings failed [Detail]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️SDK Track2 Validation: 0 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/9ad6967605bf801a2500c658d5aee015c9204f3a/specification/monitor/resource-manager/readme.md#tag-package-composite-v1">monitor/resource-manager/readme.md#package-composite-v1
- "https://github.com/Azure/azure-rest-api-specs/blob/9ad6967605bf801a2500c658d5aee015c9204f3a/specification/monitor/resource-manager/readme.md#tag-package-2022-10">monitor/resource-manager/readme.md#package-2022-10
- "https://github.com/Azure/azure-rest-api-specs/blob/9ad6967605bf801a2500c658d5aee015c9204f3a/specification/monitor/resource-manager/readme.md#tag-package-2022-06">monitor/resource-manager/readme.md#package-2022-06
- "https://github.com/Azure/azure-rest-api-specs/blob/9ad6967605bf801a2500c658d5aee015c9204f3a/specification/monitor/resource-manager/readme.md#tag-package-2022-06-01-only">monitor/resource-manager/readme.md#package-2022-06-01-only
| Rule | Message |
|---|---|
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-composite-v1", "details":"Duplicate Schema named 'Resource' (2 differences):\n - properties.tags.description: "Gets or sets a list of key value pairs that describe the resource. These tags can be used in viewing and grouping this resource (across resource groups). A maximum of 15 tags can be provided for a resource. Each tag must have a key no greater in length than 128 characters and a value no greater in length than 256 characters." => "Resource tags"\n - properties.systemData: "readOnly":true, "description":"The system metadata related to the response.", "$ref":"#/components/schemas/schemas:1045" =>; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-composite-v1", "details":"Duplicate Schema named 'Resource' (8 differences):\n - properties.id.description: "Azure resource Id" => "Fully qualified resource ID for the resource. Ex - /subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/resourceProviderNamespace/resourceType/resourceName"\n - properties.name.description: "Azure resource name" => "The name of the resource"\n - properties.type.description: "Azure resource type" => "The type of the resource. E.g. \"Microsoft.Compute/virtualMachines\" or \"Microsoft.Storage/storageAccounts\""\n - properties.location: "x-ms-mutability":["create", "read"], "$ref":"#/components/schemas/schemas:58", "description":"Resource location" =>\n - properties.tags: "$ref":"#/components/schemas/schemas:59", "description":"Gets or sets a list of key value pairs that describe the resource. These tags can be used in viewing and grouping this resource (across resource groups). A maximum of 15 tags can be provided for a resource. Each tag must have a key no greater in length than 128 characters and a value no greater in length than 256 characters." =>\n - properties.systemData: "readOnly":true, "description":"The system metadata related to the response.", "$ref":"#/components/schemas/schemas:1045" =>\n - required: ["location"] =>\n - title: => "Resource"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-composite-v1", "details":"Duplicate Schema named 'ErrorResponse' (6 differences):\n - properties.code.$ref: "#/components/schemas/schemas:111" => "#/components/schemas/schemas:808"\n - properties.code.description: "Error code" => "The error code."\n - properties.code.readOnly: => true\n - properties.message.$ref: "#/components/schemas/schemas:112" => "#/components/schemas/schemas:809"\n - properties.message.description: "Error message indicating why the operation failed." => "The error message indicating why the operation failed."\n - properties.message.readOnly: => true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-composite-v1", "details":"Duplicate Schema named 'AzureResource' (9 differences):\n - properties.id.description: "Azure resource Id" => "The resource Id."\n - properties.name.description: "Azure resource name" => "The name of the resource."\n - properties.type.description: "Azure resource type" => "The type of the resource."\n - properties.location.x-ms-mutability.0: "create" => "read"\n - properties.location.x-ms-mutability.1: "read" => "create"\n - properties.location.$ref: "#/components/schemas/schemas:248" => "#/components/schemas/schemas:777"\n - properties.location.description: "Resource location" => "The location of the resource. Since Azure Activity Log Alerts is a global service, the location of the rules should always be 'global'."\n - properties.tags.description: "Resource tags" => "The tags of the resource."\n - required: ["location"] =>; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-composite-v1", "details":"Duplicate Schema named 'ActionGroup' (17 differences):\n - properties.groupShortName: "$ref":"#/components/schemas/schemas:284", "description":"The short name of the action group. This will be used in SMS messages." =>\n - properties.enabled: "type":"boolean", "default":true, "description":"Indicates whether this action group is enabled. If an action group is not enabled, then none of its receivers will receive communications." =>\n - properties.emailReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:285", "description":"The list of email receivers that are part of this action group." =>\n - properties.smsReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:286", "description":"The list of SMS receivers that are part of this action group." =>\n - properties.webhookReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:287", "description":"The list of webhook receivers that are part of this action group." =>\n - properties.itsmReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:288", "description":"The list of ITSM receivers that are part of this action group." =>\n - properties.azureAppPushReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:289", "description":"The list of AzureAppPush receivers that are part of this action group." =>\n - properties.automationRunbookReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:290", "description":"The list of AutomationRunbook receivers that are part of this action group." =>\n - properties.voiceReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:291", "description":"The list of voice receivers that are part of this action group." =>\n - properties.logicAppReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:292", "description":"The list of logic app receivers that are part of this action group." =>\n - properties.azureFunctionReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:293", "description":"The list of azure function receivers that are part of this action group." =>\n - properties.armRoleReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:294", "description":"The list of ARM role receivers that are part of this action group. Roles are Azure RBAC roles and only built-in roles are supported." =>\n - properties.eventHubReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:295", "description":"The list of event hub receivers that are part of this action group." =>\n - properties.actionGroupId: => "$ref":"#/components/schemas/schemas:800", "description":"The resource ID of the Action Group. This cannot be null or empty."\n - properties.webhookProperties: => "$ref":"#/components/schemas/schemas:801", "description":"the dictionary of custom properties to include with the post operation. These data are appended to the webhook payload."\n - required.0: "groupShortName" => "actionGroupId"\n - required.1: "enabled" =>; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-composite-v1", "details":"Duplicate Schema named 'ProxyResource' (4 differences):\n - properties: "id":"$ref":"#/components/schemas/schemas:715", "description":"Azure resource Id", "readOnly":true, "name":"$ref":"#/components/schemas/schemas:716", "description":"Azure resource name", "readOnly":true, "type":"$ref":"#/components/schemas/schemas:717", "description":"Azure resource type", "readOnly":true =>\n - x-ms-azure-resource: true =>\n - title: => "Proxy Resource"\n - allOf: => ["$ref":"#/components/schemas/schemas:970"]; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-composite-v1", "details":"Error: 6 errors occured -- cannot continue." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2022-10", "details":"Duplicate Schema named 'Resource' (2 differences):\n - properties.tags.description: "Gets or sets a list of key value pairs that describe the resource. These tags can be used in viewing and grouping this resource (across resource groups). A maximum of 15 tags can be provided for a resource. Each tag must have a key no greater in length than 128 characters and a value no greater in length than 256 characters." => "Resource tags"\n - properties.systemData: "readOnly":true, "description":"The system metadata related to the response.", "$ref":"#/components/schemas/schemas:1083" =>; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2022-10", "details":"Duplicate Schema named 'ErrorResponse' (6 differences):\n - properties.code.$ref: "#/components/schemas/schemas:111" => "#/components/schemas/schemas:846"\n - properties.code.description: "Error code" => "The error code."\n - properties.code.readOnly: => true\n - properties.message.$ref: "#/components/schemas/schemas:112" => "#/components/schemas/schemas:847"\n - properties.message.description: "Error message indicating why the operation failed." => "The error message indicating why the operation failed."\n - properties.message.readOnly: => true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2022-10", "details":"Duplicate Schema named 'AzureResource' (9 differences):\n - properties.id.description: "Azure resource Id" => "The resource Id."\n - properties.name.description: "Azure resource name" => "The name of the resource."\n - properties.type.description: "Azure resource type" => "The type of the resource."\n - properties.location.x-ms-mutability.0: "create" => "read"\n - properties.location.x-ms-mutability.1: "read" => "create"\n - properties.location.$ref: "#/components/schemas/schemas:252" => "#/components/schemas/schemas:815"\n - properties.location.description: "Resource location" => "The location of the resource. Since Azure Activity Log Alerts is a global service, the location of the rules should always be 'global'."\n - properties.tags.description: "Resource tags" => "The tags of the resource."\n - required: ["location"] =>; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2022-10", "details":"Duplicate Schema named 'ActionGroup' (17 differences):\n - properties.groupShortName: "$ref":"#/components/schemas/schemas:288", "description":"The short name of the action group. This will be used in SMS messages." =>\n - properties.enabled: "type":"boolean", "default":true, "description":"Indicates whether this action group is enabled. If an action group is not enabled, then none of its receivers will receive communications." =>\n - properties.emailReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:289", "description":"The list of email receivers that are part of this action group." =>\n - properties.smsReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:290", "description":"The list of SMS receivers that are part of this action group." =>\n - properties.webhookReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:291", "description":"The list of webhook receivers that are part of this action group." =>\n - properties.itsmReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:292", "description":"The list of ITSM receivers that are part of this action group." =>\n - properties.azureAppPushReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:293", "description":"The list of AzureAppPush receivers that are part of this action group." =>\n - properties.automationRunbookReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:294", "description":"The list of AutomationRunbook receivers that are part of this action group." =>\n - properties.voiceReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:295", "description":"The list of voice receivers that are part of this action group." =>\n - properties.logicAppReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:296", "description":"The list of logic app receivers that are part of this action group." =>\n - properties.azureFunctionReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:297", "description":"The list of azure function receivers that are part of this action group." =>\n - properties.armRoleReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:298", "description":"The list of ARM role receivers that are part of this action group. Roles are Azure RBAC roles and only built-in roles are supported." =>\n - properties.eventHubReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:299", "description":"The list of event hub receivers that are part of this action group." =>\n - properties.actionGroupId: => "$ref":"#/components/schemas/schemas:838", "description":"The resource ID of the Action Group. This cannot be null or empty."\n - properties.webhookProperties: => "$ref":"#/components/schemas/schemas:839", "description":"the dictionary of custom properties to include with the post operation. These data are appended to the webhook payload."\n - required.0: "groupShortName" => "actionGroupId"\n - required.1: "enabled" =>; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2022-10", "details":"Error: 4 errors occured -- cannot continue." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2022-06", "details":"Duplicate Schema named 'ErrorResponse' (6 differences):\n - properties.code.$ref: "#/components/schemas/schemas:66" => "#/components/schemas/schemas:826"\n - properties.code.description: "Error code" => "The error code."\n - properties.code.readOnly: => true\n - properties.message.$ref: "#/components/schemas/schemas:67" => "#/components/schemas/schemas:827"\n - properties.message.description: "Error message indicating why the operation failed." => "The error message indicating why the operation failed."\n - properties.message.readOnly: => true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2022-06", "details":"Duplicate Schema named 'AzureResource' (9 differences):\n - properties.id.description: "Azure resource Id" => "The resource Id."\n - properties.name.description: "Azure resource name" => "The name of the resource."\n - properties.type.description: "Azure resource type" => "The type of the resource."\n - properties.location.x-ms-mutability.0: "create" => "read"\n - properties.location.x-ms-mutability.1: "read" => "create"\n - properties.location.$ref: "#/components/schemas/schemas:232" => "#/components/schemas/schemas:795"\n - properties.location.description: "Resource location" => "The location of the resource. Since Azure Activity Log Alerts is a global service, the location of the rules should always be 'global'."\n - properties.tags.description: "Resource tags" => "The tags of the resource."\n - required: ["location"] =>; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2022-06", "details":"Duplicate Schema named 'ActionGroup' (17 differences):\n - properties.groupShortName: "$ref":"#/components/schemas/schemas:268", "description":"The short name of the action group. This will be used in SMS messages." =>\n - properties.enabled: "type":"boolean", "default":true, "description":"Indicates whether this action group is enabled. If an action group is not enabled, then none of its receivers will receive communications." =>\n - properties.emailReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:269", "description":"The list of email receivers that are part of this action group." =>\n - properties.smsReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:270", "description":"The list of SMS receivers that are part of this action group." =>\n - properties.webhookReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:271", "description":"The list of webhook receivers that are part of this action group." =>\n - properties.itsmReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:272", "description":"The list of ITSM receivers that are part of this action group." =>\n - properties.azureAppPushReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:273", "description":"The list of AzureAppPush receivers that are part of this action group." =>\n - properties.automationRunbookReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:274", "description":"The list of AutomationRunbook receivers that are part of this action group." =>\n - properties.voiceReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:275", "description":"The list of voice receivers that are part of this action group." =>\n - properties.logicAppReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:276", "description":"The list of logic app receivers that are part of this action group." =>\n - properties.azureFunctionReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:277", "description":"The list of azure function receivers that are part of this action group." =>\n - properties.armRoleReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:278", "description":"The list of ARM role receivers that are part of this action group. Roles are Azure RBAC roles and only built-in roles are supported." =>\n - properties.eventHubReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:279", "description":"The list of event hub receivers that are part of this action group." =>\n - properties.actionGroupId: => "$ref":"#/components/schemas/schemas:818", "description":"The resource ID of the Action Group. This cannot be null or empty."\n - properties.webhookProperties: => "$ref":"#/components/schemas/schemas:819", "description":"the dictionary of custom properties to include with the post operation. These data are appended to the webhook payload."\n - required.0: "groupShortName" => "actionGroupId"\n - required.1: "enabled" =>; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2022-06", "details":"Error: 3 errors occured -- cannot continue." |
| "readme":"monitor/resource-manager/readme.md", "tag":"package-2022-06-01-only", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
AzureRestAPISpecReview
added
ReadyForApiTest
This was referenced Sep 20, 2022
added 2 commits
September 20, 2022 08:58
ArcturusZhang
approved these changes
Sep 23, 2022
|
Will not approve the SDK breaking changes again since they have all been approved in #19652 |
This was referenced Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.