-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.KeyVault to add version stable/2022-11-01 #20839
Merged
tianxchen-ms
merged 21 commits into
Azure:main
from
riteshchitlangia1:release-keyvault-Microsoft.KeyVault-2022-11-01
Feb 3, 2023
+8,942
−2
Merged
Changes from 14 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
841dfd9
Adds base for updating Microsoft.KeyVault from version stable/2022-07…
riteshchitlangia1 eca9724
Updates readme
riteshchitlangia1 053dc78
Updates API version in new specs and examples
riteshchitlangia1 ee0e886
Adding specification for data plane Key operations through Managed HS…
riteshchitlangia 161677f
undo of change done to address R3006
riteshchitlangia ca561fa
Updating duplicate tags and operation id
riteshchitlangia 4557371
Addressing PR comments from ARM review
riteshchitlangia 27308d9
PR Feedback : update string.
riteshchitlangia 5f34fa8
Fixing lint errors and some PR feedback
riteshchitlangia 495694c
fixing prettier checks
riteshchitlangia ae5edab
fixing validation errors from lint diff
riteshchitlangia 1ac9092
Making ManagedHsmKey as proxy resource by removing 'Tags' and 'Locati…
riteshchitlangia b5fcaa9
Adding Tags
riteshchitlangia 7e7c3b9
removing additional property 'Location'
riteshchitlangia 232932c
Removed unreferenced parameter definitions.
riteshchitlangia 9e21bbc
Updating examples to have default value for enablePurgeProtection as …
riteshchitlangia e1fe15e
Merging changes made to version 2022-07-01 in PR https://github.com/A…
riteshchitlangia 09769af
Fixing validation errors from PR
riteshchitlangia 68d368f
Adding suppresion based on new rules described here: https://dev.azur…
riteshchitlangia 08245fe
Pulled a breaking change from 2022-07-01 api-version and Updated wher…
riteshchitlangia 4b0f04d
Merge branch 'main' into release-keyvault-Microsoft.KeyVault-2022-11-01
riteshchitlangia1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
94 changes: 94 additions & 0 deletions
94
specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2022-11-01/common.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| { | ||
| "swagger": "2.0", | ||
| "info": { | ||
| "version": "2022-11-01", | ||
| "title": "KeyVaultManagementClient", | ||
| "description": "The Azure management API provides a RESTful set of web services that interact with Azure Key Vault." | ||
| }, | ||
| "paths": {}, | ||
| "definitions": { | ||
| "CloudError": { | ||
| "description": "An error response from Key Vault resource provider", | ||
| "properties": { | ||
| "error": { | ||
| "$ref": "#/definitions/CloudErrorBody" | ||
| } | ||
| }, | ||
| "x-ms-external": true, | ||
| "type": "object" | ||
| }, | ||
| "CloudErrorBody": { | ||
| "description": "An error response from Key Vault resource provider", | ||
| "properties": { | ||
| "code": { | ||
| "type": "string", | ||
| "description": "Error code. This is a mnemonic that can be consumed programmatically." | ||
| }, | ||
| "message": { | ||
| "type": "string", | ||
| "description": "User friendly error message. The message is typically localized and may vary with service version." | ||
| } | ||
| }, | ||
| "x-ms-external": true, | ||
| "type": "object" | ||
| }, | ||
| "SystemData": { | ||
| "description": "Metadata pertaining to creation and last modification of the key vault resource.", | ||
| "readOnly": true, | ||
| "properties": { | ||
| "createdBy": { | ||
| "type": "string", | ||
| "description": "The identity that created the key vault resource." | ||
| }, | ||
| "createdByType": { | ||
| "description": "The type of identity that created the key vault resource.", | ||
| "$ref": "#/definitions/IdentityType" | ||
| }, | ||
| "createdAt": { | ||
| "type": "string", | ||
| "format": "date-time", | ||
| "description": "The timestamp of the key vault resource creation (UTC)." | ||
| }, | ||
| "lastModifiedBy": { | ||
| "type": "string", | ||
| "description": "The identity that last modified the key vault resource." | ||
| }, | ||
| "lastModifiedByType": { | ||
| "description": "The type of identity that last modified the key vault resource.", | ||
| "$ref": "#/definitions/IdentityType" | ||
| }, | ||
| "lastModifiedAt": { | ||
| "type": "string", | ||
| "format": "date-time", | ||
| "description": "The timestamp of the key vault resource last modification (UTC)." | ||
| } | ||
| }, | ||
| "type": "object" | ||
| }, | ||
| "IdentityType": { | ||
| "type": "string", | ||
| "description": "The type of identity.", | ||
| "enum": [ | ||
| "User", | ||
| "Application", | ||
| "ManagedIdentity", | ||
| "Key" | ||
| ], | ||
| "x-ms-enum": { | ||
| "name": "identityType", | ||
| "modelAsString": true | ||
| } | ||
| } | ||
| }, | ||
| "securityDefinitions": { | ||
| "azure_auth": { | ||
| "type": "oauth2", | ||
| "authorizationUrl": "https://login.microsoftonline.com/common/oauth2/authorize", | ||
| "flow": "implicit", | ||
| "description": "Azure Active Directory OAuth2 Flow", | ||
| "scopes": { | ||
| "user_impersonation": "impersonate your user account" | ||
| } | ||
| } | ||
| } | ||
| } | ||
28 changes: 28 additions & 0 deletions
28
...resource-manager/Microsoft.KeyVault/stable/2022-11-01/examples/DeletedManagedHsm_Get.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| { | ||
| "parameters": { | ||
| "name": "hsm1", | ||
| "location": "westus", | ||
| "subscriptionId": "00000000-0000-0000-0000-000000000000", | ||
| "api-version": "2022-11-01" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "id": "/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.KeyVault/locations/westus/deletedManagedHSMs/hsm1", | ||
| "name": "vault-agile-drawer-6404", | ||
| "type": "Microsoft.KeyVault/deletedManagedHSMs", | ||
| "properties": { | ||
| "mhsmId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1", | ||
| "location": "westus", | ||
| "deletionDate": "2021-04-01T00:00:59Z", | ||
| "scheduledPurgeDate": "2021-04-01T00:00:59Z", | ||
| "purgeProtectionEnabled": true, | ||
| "tags": { | ||
| "Dept": "hsm", | ||
| "Environment": "production" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
47 changes: 47 additions & 0 deletions
47
...esource-manager/Microsoft.KeyVault/stable/2022-11-01/examples/DeletedManagedHsm_List.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-0000-0000-0000-000000000000", | ||
| "api-version": "2022-11-01" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "id": "/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.KeyVault/locations/westus/deletedManagedHSMs/hsm1", | ||
| "name": "vault-agile-drawer-6404", | ||
| "type": "Microsoft.KeyVault/deletedManagedHSMs", | ||
| "properties": { | ||
| "mhsmId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1", | ||
| "location": "westus", | ||
| "deletionDate": "2021-04-01T00:00:59Z", | ||
| "scheduledPurgeDate": "2021-04-01T00:00:59Z", | ||
| "purgeProtectionEnabled": true, | ||
| "tags": { | ||
| "Dept": "hsm", | ||
| "Environment": "production" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id": "/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.KeyVault/locations/westus/deletedManagedHSMs/hsm2", | ||
| "name": "vault-agile-drawer-6404", | ||
| "type": "Microsoft.KeyVault/deletedManagedHSMs", | ||
| "properties": { | ||
| "mhsmId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm2", | ||
| "location": "westus", | ||
| "deletionDate": "2021-04-01T00:00:59Z", | ||
| "scheduledPurgeDate": "2021-04-01T00:00:59Z", | ||
| "purgeProtectionEnabled": true, | ||
| "tags": { | ||
| "Dept": "hsm", | ||
| "Environment": "production" | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "nextLink": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.KeyVault/deletedManagedHSMs?api-version=2022-11-01&$skiptoken=dmF1bHQtcGVza3ktanVyeS03MzA3Ng==" | ||
| } | ||
| } | ||
| } | ||
| } |
15 changes: 15 additions & 0 deletions
15
...source-manager/Microsoft.KeyVault/stable/2022-11-01/examples/DeletedManagedHsm_Purge.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "parameters": { | ||
| "name": "hsm1", | ||
| "location": "westus", | ||
| "subscriptionId": "00000000-0000-0000-0000-000000000000", | ||
| "api-version": "2022-11-01" | ||
| }, | ||
| "responses": { | ||
| "202": { | ||
| "headers": { | ||
| "Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-11-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9" | ||
| } | ||
| } | ||
| } | ||
| } |
89 changes: 89 additions & 0 deletions
89
...urce-manager/Microsoft.KeyVault/stable/2022-11-01/examples/ManagedHsm_CreateOrUpdate.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| { | ||
| "parameters": { | ||
| "resourceGroupName": "hsm-group", | ||
| "name": "hsm1", | ||
| "subscriptionId": "00000000-0000-0000-0000-000000000000", | ||
| "api-version": "2022-11-01", | ||
| "parameters": { | ||
| "properties": { | ||
| "tenantId": "00000000-0000-0000-0000-000000000000", | ||
| "initialAdminObjectIds": [ | ||
| "00000000-0000-0000-0000-000000000000" | ||
| ], | ||
| "enableSoftDelete": true, | ||
| "softDeleteRetentionInDays": 90, | ||
| "enablePurgeProtection": true | ||
riteshchitlangia1 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }, | ||
| "location": "westus", | ||
| "sku": { | ||
| "family": "B", | ||
| "name": "Standard_B1" | ||
| }, | ||
| "tags": { | ||
| "Dept": "hsm", | ||
| "Environment": "dogfood" | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "202": { | ||
| "headers": { | ||
| "Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-11-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9" | ||
| }, | ||
| "body": { | ||
| "properties": { | ||
| "tenantId": "00000000-0000-0000-0000-000000000000", | ||
| "initialAdminObjectIds": [ | ||
| "00000000-0000-0000-0000-000000000000" | ||
| ], | ||
| "enableSoftDelete": true, | ||
| "softDeleteRetentionInDays": 90, | ||
| "enablePurgeProtection": true, | ||
| "hsmUri": null, | ||
| "provisioningState": "Provisioning", | ||
| "statusMessage": "Allocating hardware" | ||
| }, | ||
| "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1", | ||
| "name": "hsm1", | ||
| "type": "Microsoft.KeyVault/managedHSMs", | ||
| "location": "westus", | ||
| "sku": { | ||
| "family": "B", | ||
| "name": "Standard_B1" | ||
| }, | ||
| "tags": { | ||
| "Dept": "hsm", | ||
| "Environment": "dogfood" | ||
| } | ||
| } | ||
| }, | ||
| "200": { | ||
| "body": { | ||
| "properties": { | ||
| "tenantId": "00000000-0000-0000-0000-000000000000", | ||
| "initialAdminObjectIds": [ | ||
| "00000000-0000-0000-0000-000000000000" | ||
| ], | ||
| "enableSoftDelete": true, | ||
| "softDeleteRetentionInDays": 90, | ||
| "enablePurgeProtection": true, | ||
| "hsmUri": "https://westus.hsm1.managedhsm.azure.net", | ||
| "provisioningState": "Succeeded", | ||
| "statusMessage": "ManagedHsm is functional." | ||
| }, | ||
| "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1", | ||
| "name": "hsm1", | ||
| "type": "Microsoft.KeyVault/managedHSMs", | ||
| "location": "westus", | ||
| "sku": { | ||
| "family": "B", | ||
| "name": "Standard_B1" | ||
| }, | ||
| "tags": { | ||
| "Dept": "hsm", | ||
| "Environment": "dogfood" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
17 changes: 17 additions & 0 deletions
17
...ult/resource-manager/Microsoft.KeyVault/stable/2022-11-01/examples/ManagedHsm_Delete.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "parameters": { | ||
| "resourceGroupName": "hsm-group", | ||
| "name": "hsm1", | ||
| "subscriptionId": "00000000-0000-0000-0000-000000000000", | ||
| "api-version": "2022-11-01" | ||
| }, | ||
| "responses": { | ||
| "200": {}, | ||
| "202": { | ||
| "headers": { | ||
| "Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-11-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9" | ||
| } | ||
| }, | ||
| "204": {} | ||
| } | ||
| } |
39 changes: 39 additions & 0 deletions
39
...yvault/resource-manager/Microsoft.KeyVault/stable/2022-11-01/examples/ManagedHsm_Get.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| { | ||
| "parameters": { | ||
| "resourceGroupName": "hsm-group", | ||
| "name": "hsm1", | ||
| "subscriptionId": "00000000-0000-0000-0000-000000000000", | ||
| "api-version": "2022-11-01" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "properties": { | ||
| "tenantId": "00000000-0000-0000-0000-000000000000", | ||
| "initialAdminObjectIds": [ | ||
| "00000000-0000-0000-0000-000000000000" | ||
| ], | ||
| "enableSoftDelete": true, | ||
| "softDeleteRetentionInDays": 90, | ||
| "enablePurgeProtection": true, | ||
| "hsmUri": "https://westus.hsm1.managedhsm.azure.net", | ||
| "provisioningState": "Succeeded", | ||
| "statusMessage": "ManagedHsm is functional." | ||
| }, | ||
| "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1", | ||
| "name": "hsm1", | ||
| "type": "Microsoft.KeyVault/managedHSMs", | ||
| "location": "westus", | ||
| "sku": { | ||
| "family": "B", | ||
| "name": "Standard_B1" | ||
| }, | ||
| "tags": { | ||
| "Dept": "hsm", | ||
| "Environment": "dogfood" | ||
| } | ||
| } | ||
| }, | ||
| "204": {} | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not reference the definition of SystemData from common-types/v3/types.json?