[service connector]add api version 2022-11-01-preview #21408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @qianwens, this service has enabled Service API Toolset. All spec updates MUST be initiated from service ADO project repo, so that to guarantee it to be the source of truth. @ChenTanyi , please review this pull request if it's intentional or reject it if it's not expected. Normally, all the specification or example changes should start with PR created in ADO. |
Swagger Generation Artifacts
|
Generated ApiView
|
openapi-workflow-bot
bot
added
the
DoNotMerge
|
Hi, @qianwens Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
This was referenced Nov 3, 2022
AzureRestAPISpecReview
added
ARMReview
CI-FixRequiredOnFailure
CI-MissingBaseCommit
new-api-version
resource-manager
RPaaS
WaitForARMFeedback
|
Hi @qianwens, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
Hi, @qianwens, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline |
This was referenced Nov 3, 2022
|
@qianwens , please fix CI check failures. I assume this version were all reviewed by ARM in private RPSaaSMaster branch, right? |
raych1
added
Reviewed-ChangesRequested
AzureRestAPISpecReview
added
ReadyForApiTest
rkmanda
reviewed
Nov 9, 2022
| "version": "2022-11-01-preview" | ||
| }, | ||
| "host": "management.azure.com", | ||
| "schemes": [ |
There was a problem hiding this comment.
Please provide a link to the PR from the private repo if this was already reviewed. Also submit any delta between the already reviewed PR and the current one as a separate commit so only those parts may be reviewed.
There was a problem hiding this comment.
Here are the pr reviewed in the private repo. There is no delta between the already reviewed PR and the current one.
https://github.com/Azure/azure-rest-api-specs-pr/pull/7823
https://github.com/Azure/azure-rest-api-specs-pr/pull/8424
https://github.com/Azure/azure-rest-api-specs-pr/pull/9590
https://github.com/Azure/azure-rest-api-specs-pr/pull/8996
rkmanda
added
the
ARMChangesRequested
|
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove |
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
qianwens
removed
the
DoNotMerge
openapi-pipeline-app
bot
added
the
DoNotMerge
raych1
removed
Reviewed-ChangesRequested
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
raych1
added
Approved-OkToMerge
raych1
approved these changes
Nov 18, 2022
openapi-pipeline-app
bot
added
the
Reviewed-ChangesRequested
This was referenced Nov 18, 2022
anandanthony
pushed a commit
to anandMicro/azure-rest-api-specs
that referenced
this pull request
Dec 16, 2022
* add api version 2022-11-01-preview * fix api versions in sample * fix sample * add dryrun to custom words * update configurationNames API Co-authored-by: xiaofanzhou <xiaofanzhou@microsoft.com>
kayousef-zz
pushed a commit
to kayousef-zz/azure-rest-api-specs
that referenced
this pull request
Dec 21, 2022
* add api version 2022-11-01-preview * fix api versions in sample * fix sample * add dryrun to custom words * update configurationNames API Co-authored-by: xiaofanzhou <xiaofanzhou@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.