Storage RP 2022-09-01 Swagger Api version #21500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HimanshuChhabra
requested review from
msyyc,
Wzb123456789,
ArcturusZhang and
JasonYang-MSFT
as code owners
|
Hi, @HimanshuChhabra Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
ghost
added
the
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
Swagger Generation Artifacts
|
Generated ApiView
|
11 tasks
AzureRestAPISpecReview
added
ARMReview
CI-FixRequiredOnFailure
CI-MissingBaseCommit
new-api-version
resource-manager
WaitForARMFeedback
|
Hi @HimanshuChhabra, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
Hi, @HimanshuChhabra, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi, @HimanshuChhabra your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
blueww
reviewed
Nov 11, 2022
specification/storage/resource-manager/Microsoft.Storage/stable/2022-09-01/storage.json
Outdated
Show resolved
Hide resolved
|
@blueww I've tried the SDK with the LCM changes and no issues are found so far |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.2)] | new version | base version |
|---|---|---|
| blob.json | 2022-09-01(fb7cb60) | 2022-05-01(main) |
| blob.json | 2022-09-01(fb7cb60) | 2020-08-01-preview(main) |
| common.json | 2022-09-01(fb7cb60) | 2022-05-01(main) |
| common.json | 2022-09-01(fb7cb60) | 2020-08-01-preview(main) |
| file.json | 2022-09-01(fb7cb60) | 2022-05-01(main) |
| file.json | 2022-09-01(fb7cb60) | 2020-08-01-preview(main) |
| privatelinks.json | 2022-09-01(fb7cb60) | 2022-05-01(main) |
| privatelinks.json | 2022-09-01(fb7cb60) | 2020-08-01-preview(main) |
| queue.json | 2022-09-01(fb7cb60) | 2022-05-01(main) |
| queue.json | 2022-09-01(fb7cb60) | 2020-08-01-preview(main) |
| storage.json | 2022-09-01(fb7cb60) | 2022-05-01(main) |
| storage.json | 2022-09-01(fb7cb60) | 2020-08-01-preview(main) |
| table.json | 2022-09-01(fb7cb60) | 2022-05-01(main) |
| table.json | 2022-09-01(fb7cb60) | 2020-08-01-preview(main) |
The following breaking changes are detected by comparison with the latest preview version:
Only 30 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| package-2022-09 | package-2022-09(fb7cb60) | default(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The resource name parameter 'accountName' should be defined with a 'pattern' restriction. Location: Microsoft.Storage/stable/2022-09-01/blob.json#L19 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Storage/stable/2022-09-01/blob.json#L45 |
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Storage/storageAccounts/{accountName}/blobServices/{BlobServicesName}' Location: Microsoft.Storage/stable/2022-09-01/blob.json#L58 |
|
The resource name parameter 'accountName' should be defined with a 'pattern' restriction. Location: Microsoft.Storage/stable/2022-09-01/blob.json#L58 |
|
The resource name parameter 'BlobServicesName' should be defined with a 'pattern' restriction. Location: Microsoft.Storage/stable/2022-09-01/blob.json#L58 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Storage/stable/2022-09-01/blob.json#L102 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Storage/stable/2022-09-01/blob.json#L139 |
|
The response in the GET collection operation 'BlobContainers_List' does not match the response definition in the individual GET operation 'BlobContainers_Get' . Location: Microsoft.Storage/stable/2022-09-01/blob.json#L149 |
|
The resource name parameter 'accountName' should be defined with a 'pattern' restriction. Location: Microsoft.Storage/stable/2022-09-01/blob.json#L149 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Storage/stable/2022-09-01/blob.json#L204 |
|
The resource name parameter 'accountName' should be defined with a 'pattern' restriction. Location: Microsoft.Storage/stable/2022-09-01/blob.json#L217 |
|
The resource name parameter 'containerName' should be defined with a 'pattern' restriction. Location: Microsoft.Storage/stable/2022-09-01/blob.json#L217 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Storage/stable/2022-09-01/blob.json#L261 |
|
The patch operation body parameter schema should not contains property name. Location: Microsoft.Storage/stable/2022-09-01/blob.json#L297 |
|
The patch operation body parameter schema should not contains property type. Location: Microsoft.Storage/stable/2022-09-01/blob.json#L297 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Storage/stable/2022-09-01/blob.json#L313 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Storage/stable/2022-09-01/blob.json#L354 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Storage/stable/2022-09-01/blob.json#L391 |
|
The resource name parameter 'accountName' should be defined with a 'pattern' restriction. Location: Microsoft.Storage/stable/2022-09-01/blob.json#L401 |
|
The resource name parameter 'containerName' should be defined with a 'pattern' restriction. Location: Microsoft.Storage/stable/2022-09-01/blob.json#L401 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Storage/stable/2022-09-01/blob.json#L442 |
|
The resource name parameter 'accountName' should be defined with a 'pattern' restriction. Location: Microsoft.Storage/stable/2022-09-01/blob.json#L452 |
|
The resource name parameter 'containerName' should be defined with a 'pattern' restriction. Location: Microsoft.Storage/stable/2022-09-01/blob.json#L452 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Storage/stable/2022-09-01/blob.json#L490 |
|
The resource name parameter 'accountName' should be defined with a 'pattern' restriction. Location: Microsoft.Storage/stable/2022-09-01/blob.json#L500 |
|
The resource name parameter 'containerName' should be defined with a 'pattern' restriction. Location: Microsoft.Storage/stable/2022-09-01/blob.json#L500 |
|
The resource name parameter 'immutabilityPolicyName' should be defined with a 'pattern' restriction. Location: Microsoft.Storage/stable/2022-09-01/blob.json#L500 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Storage/stable/2022-09-01/blob.json#L550 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Storage/stable/2022-09-01/blob.json#L603 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Storage/stable/2022-09-01/blob.json#L656 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌~[Staging] ServiceAPIReadinessTest: 137 Errors, 0 Warnings failed [Detail]
Tag package-2022-09; Prod region: Deployed
Test run on region: westcentralus; Operation coverage: total: 90, untested: 0, failed: 84, passed: 6
Service API Readiness Test failed. Check pipeline artifact for detail report.
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
"statusCode: 400, errorCode: UnsupportedEdgeZone, errorMessage: Edge zone 'losangeles001' not found. The available edge zones in location 'westcentralus' are ''." |
|
"The swagger file does not define '400' response code" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Storage/storageAccounts/accountnam6u178f' under resource group 'apiTest-YVXcVq-21500' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"The swagger file does not define '404' response code" |
|
"statusCode: 404, errorCode: PatchResourceNotFound, errorMessage: The resource '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-YVXcVq-21500/providers/Microsoft.Storage/storageAccounts/accountnam6u178f' was not found when evaluating policies for a PATCH operation." |
|
"The swagger file does not define '404' response code" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Storage/storageAccounts/accountnam6u178f' under resource group 'apiTest-YVXcVq-21500' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"The swagger file does not define '404' response code" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Storage/storageAccounts/accountnam6u178f' under resource group 'apiTest-YVXcVq-21500' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"The swagger file does not define '404' response code" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Storage/storageAccounts/accountnam6u178f' under resource group 'apiTest-YVXcVq-21500' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'accountnam6u178f' not found." |
|
"The swagger file does not define '404' response code" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Storage/storageAccounts/accountnam6u178f' under resource group 'apiTest-YVXcVq-21500' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"The swagger file does not define '404' response code" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Storage/storageAccounts/accountnam6u178f' under resource group 'apiTest-YVXcVq-21500' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"The swagger file does not define '404' response code" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Storage/storageAccounts/accountnam6u178f' under resource group 'apiTest-YVXcVq-21500' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"The swagger file does not define '404' response code" |
|
"statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'accountnam6u178f' not found." |
|
"The swagger file does not define '404' response code" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Storage/storageAccounts/accountnam6u178f' under resource group 'apiTest-YVXcVq-21500' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'accountnam6u178f' not found." |
|
"The swagger file does not define '404' response code" |
|
"statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'accountnam6u178f' not found." |
|
"The swagger file does not define '404' response code" |
|
"statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'accountnam6u178f' not found." |
|
"The swagger file does not define '404' response code" |
|
"statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'accountnam6u178f' not found." |
|
"The swagger file does not define '404' response code" |
️❌~[Staging] SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
rkmanda
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
evelyn-ys
approved these changes
Nov 14, 2022
blueww
approved these changes
Nov 14, 2022
ArcturusZhang
added
the
Approved-SdkBreakingChange-Go
This was referenced Nov 14, 2022
Closed
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Nov 14, 2022
anandanthony
pushed a commit
to anandMicro/azure-rest-api-specs
that referenced
this pull request
Dec 16, 2022
* Full copy from 2022-05-01 to 2022-09-01 without any changes * Update Swagger API version for each swagger and readme files * Update the API version for existing Test cases * Feature: Storage Account Soft Failover * Feature: List Encryption scopes, add OData Filter Conditions * Feature : Add TierToCold and TierToHot Support * Run Prettier check * Adding Location header to EXISTING Async API Examples. * Run Prettier check * Change $maxpagesize to integer type for ListEncryptionScope API
kayousef-zz
pushed a commit
to kayousef-zz/azure-rest-api-specs
that referenced
this pull request
Dec 21, 2022
* Full copy from 2022-05-01 to 2022-09-01 without any changes * Update Swagger API version for each swagger and readme files * Update the API version for existing Test cases * Feature: Storage Account Soft Failover * Feature: List Encryption scopes, add OData Filter Conditions * Feature : Add TierToCold and TierToHot Support * Run Prettier check * Adding Location header to EXISTING Async API Examples. * Run Prettier check * Change $maxpagesize to integer type for ListEncryptionScope API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.