[Don't Merge, Service rollout ~March/1/18 ] Swagger for new API changes 2017-12-01 #2207

revachauhan · 2018-01-02T22:53:14Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

Swagger for new business model changes API
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

anuchandy · 2018-01-03T02:05:15Z

@jhendrixMSFT do you mind if i take this PR? [Reva previously opened another PR with the same features and I requested him to close that PR and open new one]

jhendrixMSFT · 2018-01-03T16:54:10Z

@anuchandy Assigned to you.

anuchandy · 2018-01-05T20:12:34Z

Talked to Reva and learned that the service will take one month to land in production so team don't want to publish the new API swagger as of now. The estimated date is March 1. Hence adding 'DONT MERGE' prefix to title.

into swagger_2017

anuchandy · 2018-01-08T18:18:15Z

@revas89 it looks like you didn't add entry to readme file for the new api version, can you please do so?

revachauhan · 2018-01-08T21:20:36Z

@anuchandy Made changes to readme.md file

anuchandy · 2018-01-08T22:23:41Z

specification/postgresql/resource-manager/readme.md

+
+``` yaml $(tag) == 'package-2017-12-01'
+input-file:
+- Microsoft.DBforPostgreSQL/2017-12-01-preview/postgresql.json


should this be Microsoft.DBforPostgreSQL/2017-12-01/postgresql.json?

anuchandy · 2018-01-08T22:23:54Z

specification/postgresql/resource-manager/readme.md

+Please also specify `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`.
+
+``` yaml $(tag) == 'package-2017-12-01' && $(go)
+output-folder: $(go-sdk-folder)/services/postgresql/mgmt/2017-04-30-preview/postgresql


same comment as above

anuchandy · 2018-01-08T22:24:40Z

@revas89 thanks for readme update.. please see last two comments

rohit-joy

Do not merge until our team decides it is time.

anuchandy · 2018-01-09T04:59:45Z

@rohit-joy & @revas89 sure I've highlighted that in the PR title. Meantime please correct the readme file. Though there is new tag, it's still pointing to older preview api version.

anuchandy · 2018-01-09T22:47:33Z

@revas89 thanks for updating the readme. Can you take a look and fix linter and model validation errors?

yukozh · 2018-01-10T08:04:15Z

...ql/resource-manager/Microsoft.DBforPostgreSQL/2017-12-01/examples/CheckNameAvailability.json

@@ -0,0 +1,19 @@
+{


I did not see anything about Microsoft.DBforMySQL, will it be included in this PR?

i have added mysql.json and examples in this PR.

yukozh · 2018-01-10T08:05:35Z

Hi @revas89, I didn't see anything about Microsoft.DBforMySQL, will you add it in this PR?

yukozh · 2018-01-11T23:44:31Z

...ce-manager/Microsoft.DBforPostgreSQL/2017-12-01/examples/PerformanceTiersListByLocation.json

-                "dtu": 50,
-                "storageMB": 51200,
-                "id": "PGSQLB50"
+                "Edition": "Basic",


In my imagination, these fields are in lower case.

yukozh · 2018-01-11T23:45:30Z

...ce-manager/Microsoft.DBforPostgreSQL/2017-12-01/examples/PerformanceTiersListByLocation.json

-                "id": "PGSQLB100"
+                "Edition": "Basic",
+                "HardwareGeneration": "Gen4",
+                "Id": "PGSQL_B_Gen4_2",


I did not see the PGSQL_ prefix in our tier id. When I called the GetTiers API, it just returned B_Gen4_2

I am able to see that when I am running it on C# generated SDK

yes that is right, I will change in my example.

yukozh · 2018-01-11T23:46:19Z

specification/postgresql/resource-manager/Microsoft.DBforPostgreSQL/2017-12-01/postgresql.json

          "type": "integer",
-          "description": "Database throughput unit associated with the service level objective"
+          "description": "VCore associated with the service level objective"


Should it be vCore? Not VCore?

yukozh · 2018-01-11T23:52:44Z

specification/mysql/resource-manager/Microsoft.DBforMySQL/2017-12-01/examples/ServerUpdate.json

@@ -19,7 +19,7 @@
        "type": "Microsoft.DBforMySQL/servers",
        "location": "onebox",


Should onebox be other real region be better?

ravbhatnagar · 2018-01-12T01:03:22Z

review feedback from the in person meeting. @revas89 - Please incorporate and schedule a follow up to go over the remaining changes we could not cover.
-check camelCase for all properties
-storageMB - does it have max or min
-createMode to be an enum - i think it already is. Wasnt showing up in the commit we were first reviewing. please confirm
-performanceTier API being deprecated in GA api-version. Service will still support the API for a while and notify customers.
-sourceServerId needs to be the fully qualified ARm resource ID. Reva to check
-SKU contract not being followed. Sent link. Reva will check how SQL is doing it.

performancetier->storageinMBMax and min are two separate prop instead of one on the server resource. On the server resource is called storageinMB. Is there a case for having consistent experience?

azuresdkciprbot · 2018-01-12T01:27:06Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/mysql/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/postgresql/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

ravbhatnagar · 2018-01-16T22:49:53Z

Signing off as this was reviewed in person again after the changes were made based on feedback from earlier review.

azuresdkciprbot · 2018-01-17T10:46:03Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/mysql/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/postgresql/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

jhendrixMSFT · 2018-03-16T20:51:11Z

@AutorestCI rebuild azure-sdk-for-go

AutorestCI · 2018-03-16T20:55:24Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#1585

QingqingYuan · 2018-03-19T16:56:47Z

@revas89 Please abandon this PR. We've restructured our swagger files. This is not needed any more.

anuchandy · 2018-04-13T03:17:23Z

closing this based on @QingqingYuan comment.

AutorestCI · 2018-04-13T03:18:06Z

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

AutorestCI · 2018-04-13T03:18:08Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

AutorestCI · 2018-04-13T03:18:58Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#2396

Reva Chauhan added 4 commits December 27, 2017 14:22

Swagger changes for PGSQL new business model

fdd4ac5

Initial commit

af02fb1

Changes for new API version 2017-12-01

a9e6599

Nit changes

c7d19aa

azuresdkci assigned jhendrixMSFT Jan 2, 2018

jhendrixMSFT assigned anuchandy and unassigned jhendrixMSFT Jan 3, 2018

anuchandy added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 3, 2018

anuchandy requested a review from ravbhatnagar January 3, 2018 17:48

anuchandy changed the title ~~Swagger for new API changes 2017-12-01~~ [Don't Merge] Swagger for new API changes 2017-12-01 Jan 5, 2018

Merge branch 'master' of https://github.com/revas89/azure-rest-api-specs

bb306a1

into swagger_2017

Updating Readme.md

229f262

anuchandy requested changes Jan 8, 2018

View reviewed changes

rohit-joy suggested changes Jan 9, 2018

View reviewed changes

Rectifying readme file

222df72

yukozh suggested changes Jan 10, 2018

View reviewed changes

Reva Chauhan added 5 commits January 10, 2018 11:43

Merge remote-tracking branch 'upstream/master' into swagger_2017

fb74d30

readme.md

1f24618

Bug resolved for performace tier operation

2fa2c6f

GEO_Restore additions

2ab458c

Initial commit for MYSQL swagger

1efc51c

Reva Chauhan added 2 commits January 11, 2018 14:13

Removing files

9d24a83

MYSQL performace tier and geo restore additions

54f7c73

yukozh suggested changes Jan 11, 2018

View reviewed changes

MYSQL examples update

379789c

yukozh suggested changes Jan 11, 2018

View reviewed changes

Reva Chauhan added 3 commits January 11, 2018 17:05

deleting folder

d5035d5

Initial commit

56d2703

changes for swagger 2017-12-01

e4fa9b1

Reva Chauhan added 3 commits January 16, 2018 12:18

nit changes

1746ee8

nit mysql changes

a435402

nit PGSQL changes

485cbea

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 16, 2018

anuchandy changed the title ~~[Don't Merge] Swagger for new API changes 2017-12-01~~ [Don't Merge, Service rollout ~March/1/18 ] Swagger for new API changes 2017-12-01 Jan 19, 2018

QingqingYuan mentioned this pull request Feb 3, 2018

Swagger For new rdbms API change for new biz model #2414

Merged

10 tasks

AutorestCI mentioned this pull request Mar 16, 2018

[AutoPR postgresql/resource-manager/mysql/resource-manager] [Don't Merge, Service rollout ~March/1/18 ] Swagger for new API changes 2017-12-01 Azure/azure-sdk-for-go#1305

Closed

anuchandy closed this Apr 13, 2018

AutorestCI mentioned this pull request Apr 13, 2018

[AutoPR mysql/resource-manager/postgresql/resource-manager] [Don't Merge, Service rollout ~March/1/18 ] Swagger for new API changes 2017-12-01 Azure/azure-sdk-for-python#2396

Closed

AutorestCI mentioned this pull request Apr 13, 2018

[AutoPR mysql/resource-manager/postgresql/resource-manager] [Don't Merge, Service rollout ~March/1/18 ] Swagger for new API changes 2017-12-01 Azure/azure-sdk-for-go#1585

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Don't Merge, Service rollout ~March/1/18 ] Swagger for new API changes 2017-12-01 #2207

[Don't Merge, Service rollout ~March/1/18 ] Swagger for new API changes 2017-12-01 #2207

revachauhan commented Jan 2, 2018 •

edited by azuresdkci

Loading

anuchandy commented Jan 3, 2018

jhendrixMSFT commented Jan 3, 2018

anuchandy commented Jan 5, 2018

anuchandy commented Jan 8, 2018

revachauhan commented Jan 8, 2018

anuchandy Jan 8, 2018

anuchandy Jan 8, 2018

anuchandy commented Jan 8, 2018

rohit-joy left a comment

anuchandy commented Jan 9, 2018

anuchandy commented Jan 9, 2018

yukozh Jan 10, 2018

revachauhan Jan 16, 2018

yukozh commented Jan 10, 2018

yukozh Jan 11, 2018

yukozh Jan 11, 2018

revachauhan Jan 16, 2018

revachauhan Jan 16, 2018

yukozh Jan 11, 2018

revachauhan Jan 16, 2018

yukozh Jan 11, 2018

ravbhatnagar commented Jan 12, 2018

azuresdkciprbot commented Jan 12, 2018

ravbhatnagar commented Jan 16, 2018

azuresdkciprbot commented Jan 17, 2018

jhendrixMSFT commented Mar 16, 2018

AutorestCI commented Mar 16, 2018 •

edited

Loading

QingqingYuan commented Mar 19, 2018

anuchandy commented Apr 13, 2018

AutorestCI commented Apr 13, 2018 •

edited

Loading

AutorestCI commented Apr 13, 2018 •

edited

Loading

AutorestCI commented Apr 13, 2018 •

edited

Loading

		@@ -19,7 +19,7 @@
		"type": "Microsoft.DBforMySQL/servers",
		"location": "onebox",

[Don't Merge, Service rollout ~March/1/18 ] Swagger for new API changes 2017-12-01 #2207

[Don't Merge, Service rollout ~March/1/18 ] Swagger for new API changes 2017-12-01 #2207

Conversation

revachauhan commented Jan 2, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

anuchandy commented Jan 3, 2018

jhendrixMSFT commented Jan 3, 2018

anuchandy commented Jan 5, 2018

anuchandy commented Jan 8, 2018

revachauhan commented Jan 8, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anuchandy commented Jan 8, 2018

rohit-joy left a comment

Choose a reason for hiding this comment

anuchandy commented Jan 9, 2018

anuchandy commented Jan 9, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yukozh commented Jan 10, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ravbhatnagar commented Jan 12, 2018

azuresdkciprbot commented Jan 12, 2018

ravbhatnagar commented Jan 16, 2018

azuresdkciprbot commented Jan 17, 2018

jhendrixMSFT commented Mar 16, 2018

AutorestCI commented Mar 16, 2018 • edited Loading

Automation for azure-sdk-for-go

QingqingYuan commented Mar 19, 2018

anuchandy commented Apr 13, 2018

AutorestCI commented Apr 13, 2018 • edited Loading

Automation for azure-libraries-for-java

AutorestCI commented Apr 13, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Apr 13, 2018 • edited Loading

Automation for azure-sdk-for-python

revachauhan commented Jan 2, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Mar 16, 2018 •

edited

Loading

AutorestCI commented Apr 13, 2018 •

edited

Loading

AutorestCI commented Apr 13, 2018 •

edited

Loading

AutorestCI commented Apr 13, 2018 •

edited

Loading