Adding recoveryservicesbackup microsoft.recovery services 2022 09 30 preview #22194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @hiaga Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| bms.json | 2022-09-30-preview(d022d78) | 2022-04-01(main) |
| bms.json | 2022-09-30-preview(d022d78) | 2022-09-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 30 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| package-preview-2022-09 | package-preview-2022-09(d022d78) | default(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateLinkResources is missing. Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L20 |
|
The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateEndpointConnections is missing. Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L20 |
|
The resource BackupResourceConfigResource does not have a corresponding delete operation. Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L21 |
|
The path for nested resource doest not meet the valid resource pattern. Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L21 |
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig' Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L21 |
|
/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response. Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L21 |
|
The resource name parameter 'vaultName' should be defined with a 'pattern' restriction. Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L21 |
|
The path segment Subscriptions should be subscriptions. Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L21 |
|
The parameters:vaultName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L22 |
|
The parameters:vaultName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L65 |
|
The parameters:vaultName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L117 |
|
The patch operation body parameter schema should not contains property name. Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L136 |
|
The patch operation body parameter schema should not contains property type. Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L136 |
|
The patch operation body parameter schema should not contains property location. Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L136 |
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupPreValidateProtection' Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L164 |
|
The path segment Subscriptions should be subscriptions. Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L164 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L194 |
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupStatus' Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L209 |
|
The path segment Subscriptions should be subscriptions. Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L209 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L239 |
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupValidateFeatures' Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L254 |
|
The path segment Subscriptions should be subscriptions. Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L254 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L284 |
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/backupProtectionIntent/{intentObjectName}' Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L299 |
|
The resource name parameter 'vaultName' should be defined with a 'pattern' restriction. Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L299 |
|
The resource name parameter 'fabricName' should be defined with a 'pattern' restriction. Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L299 |
|
The resource name parameter 'intentObjectName' should be defined with a 'pattern' restriction. Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L299 |
|
The path segment Subscriptions should be subscriptions. Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L299 |
|
Tracked resource 'ProtectionIntentResource' must have patch operation that at least supports the update of tags. Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L299 |
|
The parameters:vaultName,resourceGroupName,fabricName,intentObjectName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L300 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
️️✔️~[Staging] CadlAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AzureRestAPISpecReview
added
ARMReview
BreakingChangeReviewRequired
|
Hi @hiaga, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
Hi, @hiaga, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline |
|
Hi @hiaga, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Jan 16, 2023
Hi, @hiaga, compare with the base commit, it seems only the api version and readme files are updated, is that correct? |
@lirenhe : yes I'm just copying 2022-09-30-preview from the latest stable 2022-10-01 to resolve completeness issues - https://portal.azure-devex-tools.com/amekpis/completeness/detail?errorId=6C87ADF4-A2C7-41DA-AA3C-128C086408CD |
…/2022-10-01 to version 2022-09-30-preview
hiaga
force-pushed
the
hiaga-recoveryservicesbackup-Microsoft.RecoveryServices-2022-09-30-preview
branch
from
3ce3159 to
d022d78
Compare
|
resolved Avocado |
AzureRestAPISpecReview
added
ReadyForApiTest
|
@hiaga, could you check the breaking changes in this PR? |
|
@lirenhe, yes confirming that this spec is exactly same as API version 2022-10-01. so no breaking change (in fact no change compared to 2022-10-01). This PR is just to resolve completeness issues |
lirenhe
added
the
Approved-BreakingChange
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
No breaking chage review needed and no need for ARM review based on the above comment. |
lirenhe
removed
the
WaitForARMFeedback
lirenhe
approved these changes
Feb 3, 2023
lirenhe
deleted the
hiaga-recoveryservicesbackup-Microsoft.RecoveryServices-2022-09-30-preview
branch
This was referenced Feb 3, 2023
Closed
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Feb 3, 2023
…osoft.recovery services 2022 09 30 preview (#2782) Create to sync Azure/azure-rest-api-specs#22194 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/recoveryservicesbackup?expand=1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.