Update Microsoft.Sql ARM API with "format: arm-id" where appropriate and x-ms-secret where appropriate #22292

matthchr · 2023-01-24T17:54:10Z

ARM API Information (Control Plane)

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify: Update existing version to fix Swagger quality issue. Not sure if it's actually flagged in S360 or not.
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2023-01-24T17:54:13Z

Hi, @matthchr Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2023-01-24T17:54:15Z

Swagger Validation Report

️❌BreakingChange: 37 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
DatabaseExtensions.json	2021-11-01(40deb8c)	2021-11-01(main)
DatabaseSecurityAlertPolicies.json	2021-11-01(40deb8c)	2021-11-01(main)
DatabaseVulnerabilityAssessments.json	2021-11-01(40deb8c)	2021-11-01(main)
Databases.json	2021-11-01(40deb8c)	2021-11-01(main)
FailoverGroups.json	2021-11-01(40deb8c)	2021-11-01(main)
JobAgents.json	2021-11-01(40deb8c)	2021-11-01(main)
ManagedDatabases.json	2021-11-01(40deb8c)	2021-11-01(main)
ManagedInstances.json	2021-11-01(40deb8c)	2021-11-01(main)
ServerSecurityAlertPolicies.json	2021-11-01(40deb8c)	2021-11-01(main)
ServerVulnerabilityAssessments.json	2021-11-01(40deb8c)	2021-11-01(main)
Servers.json	2021-11-01(40deb8c)	2021-11-01(main)
SyncAgents.json	2021-11-01(40deb8c)	2021-11-01(main)
SyncGroups.json	2021-11-01(40deb8c)	2021-11-01(main)
SyncMembers.json	2021-11-01(40deb8c)	2021-11-01(main)
VirtualNetworkRules.json	2021-11-01(40deb8c)	2021-11-01(main)

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/DatabaseExtensions.json#L399:9 Old: Microsoft.Sql/stable/2021-11-01/DatabaseExtensions.json#L399:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/DatabaseExtensions.json#L407:9 Old: Microsoft.Sql/stable/2021-11-01/DatabaseExtensions.json#L406:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/Databases.json#L927:9 Old: Microsoft.Sql/stable/2021-11-01/Databases.json#L927:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/Databases.json#L939:9 Old: Microsoft.Sql/stable/2021-11-01/Databases.json#L931:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/Databases.json#L1030:9 Old: Microsoft.Sql/stable/2021-11-01/Databases.json#L1021:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/Databases.json#L1038:9 Old: Microsoft.Sql/stable/2021-11-01/Databases.json#L1028:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/Databases.json#L1053:9 Old: Microsoft.Sql/stable/2021-11-01/Databases.json#L1035:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/Databases.json#L1061:9 Old: Microsoft.Sql/stable/2021-11-01/Databases.json#L1042:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/Databases.json#L1220:9 Old: Microsoft.Sql/stable/2021-11-01/Databases.json#L1200:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/Databases.json#L1312:9 Old: Microsoft.Sql/stable/2021-11-01/Databases.json#L1291:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/Databases.json#L1324:9 Old: Microsoft.Sql/stable/2021-11-01/Databases.json#L1295:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/Databases.json#L1415:9 Old: Microsoft.Sql/stable/2021-11-01/Databases.json#L1385:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/Databases.json#L1423:9 Old: Microsoft.Sql/stable/2021-11-01/Databases.json#L1392:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/Databases.json#L1445:9 Old: Microsoft.Sql/stable/2021-11-01/Databases.json#L1406:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/Databases.json#L1846:9 Old: Microsoft.Sql/stable/2021-11-01/Databases.json#L1806:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/Databases.json#L1854:9 Old: Microsoft.Sql/stable/2021-11-01/Databases.json#L1813:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/FailoverGroups.json#L604:9 Old: Microsoft.Sql/stable/2021-11-01/FailoverGroups.json#L596:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/FailoverGroups.json#L500:11 Old: Microsoft.Sql/stable/2021-11-01/FailoverGroups.json#L500:11
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/JobAgents.json#L326:9 Old: Microsoft.Sql/stable/2021-11-01/JobAgents.json#L326:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/ManagedDatabases.json#L693:9 Old: Microsoft.Sql/stable/2021-11-01/ManagedDatabases.json#L692:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/ManagedDatabases.json#L701:9 Old: Microsoft.Sql/stable/2021-11-01/ManagedDatabases.json#L699:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/ManagedDatabases.json#L721:9 Old: Microsoft.Sql/stable/2021-11-01/ManagedDatabases.json#L718:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/ManagedDatabases.json#L729:9 Old: Microsoft.Sql/stable/2021-11-01/ManagedDatabases.json#L725:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/ManagedDatabases.json#L590:9 Old: Microsoft.Sql/stable/2021-11-01/ManagedDatabases.json#L590:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/ManagedDatabases.json#L760:9 Old: Microsoft.Sql/stable/2021-11-01/ManagedDatabases.json#L755:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/ManagedInstances.json#L864:9 Old: Microsoft.Sql/stable/2021-11-01/ManagedInstances.json#L864:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/ManagedInstances.json#L916:9 Old: Microsoft.Sql/stable/2021-11-01/ManagedInstances.json#L908:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/ManagedInstances.json#L928:9 Old: Microsoft.Sql/stable/2021-11-01/ManagedInstances.json#L919:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/ManagedInstances.json#L1022:9 Old: Microsoft.Sql/stable/2021-11-01/ManagedInstances.json#L1012:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/stable/2021-11-01/Servers.json#L960:9 Old: Microsoft.Sql/stable/2021-11-01/Servers.json#L958:9

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

compared tags (via openapi-validator v2.0.0)	new version	base version
default	default(40deb8c)	default(main)

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/sql/resource-manager/readme.md tag: specification/sql/resource-manager/readme.md#tag-package-composite-v5

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️❌ModelValidation: 47 Errors, 0 Warnings failed [Detail]

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Sql/stable/2021-11-01/Databases.json#L229:22 ExampleUrl: stable/2021-11-01/examples/DeleteDatabase.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Sql/stable/2021-11-01/Databases.json#L282:22 ExampleUrl: stable/2021-11-01/examples/PatchVCoreDatabase.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Sql/stable/2021-11-01/Databases.json#L282:22 ExampleUrl: stable/2021-11-01/examples/PatchVCoreDatabaseAssignMaintenanceConfiguration.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Sql/stable/2021-11-01/Databases.json#L282:22 ExampleUrl: stable/2021-11-01/examples/PatchVCoreDatabaseResetMaintenanceConfiguration.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Sql/stable/2021-11-01/Databases.json#L343:22 ExampleUrl: stable/2021-11-01/examples/ExportDatabase.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Sql/stable/2021-11-01/Databases.json#L343:22 ExampleUrl: stable/2021-11-01/examples/ExportDatabaseWithNetworkIsolation.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Sql/stable/2021-11-01/Databases.json#L411:22 ExampleUrl: stable/2021-11-01/examples/FailoverDatabase.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Sql/stable/2021-11-01/Databases.json#L463:22 ExampleUrl: stable/2021-11-01/examples/ImportDatabase.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Sql/stable/2021-11-01/Databases.json#L463:22 ExampleUrl: stable/2021-11-01/examples/ImportDatabaseWithNetworkIsolation.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Sql/stable/2021-11-01/Databases.json#L568:22 ExampleUrl: stable/2021-11-01/examples/PauseDatabase.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Sql/stable/2021-11-01/Databases.json#L618:22 ExampleUrl: stable/2021-11-01/examples/ResumeDatabase.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Sql/stable/2021-11-01/Databases.json#L668:22 ExampleUrl: stable/2021-11-01/examples/UpgradeDataWarehouse.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Sql/stable/2021-11-01/FailoverGroups.json#L212:22 ExampleUrl: stable/2021-11-01/examples/FailoverGroupDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Sql/stable/2021-11-01/FailoverGroups.json#L273:22 ExampleUrl: stable/2021-11-01/examples/FailoverGroupUpdate.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Sql/stable/2021-11-01/FailoverGroups.json#L327:22 ExampleUrl: stable/2021-11-01/examples/FailoverGroupFailover.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Sql/stable/2021-11-01/FailoverGroups.json#L381:22 ExampleUrl: stable/2021-11-01/examples/FailoverGroupForceFailoverAllowDataLoss.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Sql/stable/2021-11-01/JobAgents.json#L196:22 ExampleUrl: stable/2021-11-01/examples/DeleteJobAgent.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Sql/stable/2021-11-01/JobAgents.json#L253:22 ExampleUrl: stable/2021-11-01/examples/UpdateJobAgent.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Sql/stable/2021-11-01/ManagedDatabases.json#L199:22 ExampleUrl: stable/2021-11-01/examples/ManagedDatabaseDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Sql/stable/2021-11-01/ManagedDatabases.json#L252:22 ExampleUrl: stable/2021-11-01/examples/ManagedDatabaseUpdateMin.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Sql/stable/2021-11-01/ManagedDatabases.json#L252:22 ExampleUrl: stable/2021-11-01/examples/ManagedDatabaseUpdateMax.json
`❌` INVALID_FORMAT	Object didn't pass validation for format arm-id: subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/group1/providers/Microsoft.Sql/managedInstances/testInstanceTgt/databases/testDatabase Url: Microsoft.Sql/stable/2021-11-01/ManagedDatabases.json#L590:41 ExampleUrl: stable/2021-11-01/examples/ManagedDatabaseCancelMove.json#L8:19
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Sql/stable/2021-11-01/ManagedDatabases.json#L310:22 ExampleUrl: stable/2021-11-01/examples/ManagedDatabaseCancelMove.json
`❌` INVALID_FORMAT	Object didn't pass validation for format arm-id: subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/group1/providers/Microsoft.Sql/managedInstances/testInstanceTgt/databases/testDatabase Url: Microsoft.Sql/stable/2021-11-01/ManagedDatabases.json#L590:41 ExampleUrl: stable/2021-11-01/examples/ManagedDatabaseCompleteMove.json#L8:19
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Sql/stable/2021-11-01/ManagedDatabases.json#L362:22 ExampleUrl: stable/2021-11-01/examples/ManagedDatabaseCompleteMove.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Sql/stable/2021-11-01/ManagedDatabases.json#L414:22 ExampleUrl: stable/2021-11-01/examples/ManagedDatabaseCompleteExternalRestore.json
`❌` INVALID_FORMAT	Object didn't pass validation for format arm-id: subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/group1/providers/Microsoft.Sql/managedInstances/testInstanceTgt/databases/testDatabase Url: Microsoft.Sql/stable/2021-11-01/ManagedDatabases.json#L760:41 ExampleUrl: stable/2021-11-01/examples/ManagedDatabaseStartMoveMin.json#L8:19
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Sql/stable/2021-11-01/ManagedDatabases.json#L466:22 ExampleUrl: stable/2021-11-01/examples/ManagedDatabaseStartMoveMin.json
`❌` INVALID_FORMAT	Object didn't pass validation for format arm-id: subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/group1/providers/Microsoft.Sql/managedInstances/testInstanceTgt/databases/testDatabase Url: Microsoft.Sql/stable/2021-11-01/ManagedDatabases.json#L760:41 ExampleUrl: stable/2021-11-01/examples/ManagedDatabaseStartMoveMax.json#L8:19
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Sql/stable/2021-11-01/ManagedDatabases.json#L466:22 ExampleUrl: stable/2021-11-01/examples/ManagedDatabaseStartMoveMax.json

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-01-24T17:54:15Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/sql/armsql - 2.0.0-beta.1

+	Field `Family` of struct `VirtualClusterProperties` has been removed
+	Field `MaintenanceConfigurationID` of struct `VirtualClusterProperties` has been removed
+	Function `*ServerDevOpsAuditSettingsClient.BeginCreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, ServerDevOpsAuditingSettings, *ServerDevOpsAuditSettingsClientBeginCreateOrUpdateOptions)` to `(context.Context, string, string, DevOpsAuditingSettingsName, ServerDevOpsAuditingSettings, *ServerDevOpsAuditSettingsClientBeginCreateOrUpdateOptions)`
+	Function `*ServerDevOpsAuditSettingsClient.Get` parameter(s) have been changed from `(context.Context, string, string, string, *ServerDevOpsAuditSettingsClientGetOptions)` to `(context.Context, string, string, DevOpsAuditingSettingsName, *ServerDevOpsAuditSettingsClientGetOptions)`
+	Operation `*ReplicationLinksClient.Delete` has been changed to LRO, use `*ReplicationLinksClient.BeginDelete` instead.
+	Operation `*TransparentDataEncryptionsClient.CreateOrUpdate` has been changed to LRO, use `*TransparentDataEncryptionsClient.BeginCreateOrUpdate` instead.
+	Operation `*VirtualClustersClient.UpdateDNSServers` has been changed to LRO, use `*VirtualClustersClient.BeginUpdateDNSServers` instead.
+	Struct `DNSRefreshConfigurationProperties` has been removed
+	Struct `UpdateManagedInstanceDNSServersOperation` has been removed
+	Type alias `DNSRefreshConfigurationPropertiesStatus` has been removed
+	Type of `ManagedDatabaseRestoreDetailsProperties.NumberOfFilesDetected` has been changed from `*int64` to `*int32`
+	Type of `ManagedDatabaseRestoreDetailsProperties.PercentCompleted` has been changed from `*float64` to `*int32`
+	Type of `ManagedDatabaseRestoreDetailsProperties.UnrestorableFiles` has been changed from `[]*string` to `[]*ManagedDatabaseRestoreDetailsUnrestorableFileProperties`
+	Type of `ServerPrivateEndpointConnection.Properties` has been changed from `*PrivateEndpointConnectionProperties` to `*PrivateEndpointConnectionPropertiesAutoGenerated`
+	Type of `ServerProperties.PublicNetworkAccess` has been changed from `*ServerNetworkAccessFlag` to `*ServerPublicNetworkAccessFlag`

❌azure-sdk-for-python-track2 - track2_azure-mgmt-sql - 4.0.0b7

+	Renamed operation TransparentDataEncryptionsOperations.create_or_update to TransparentDataEncryptionsOperations.begin_create_or_update

❌azure-sdk-for-js - @azure/arm-sql - 10.0.0-beta.1

+	Class SqlManagementClient no longer has parameter operationsHealthOperations
+	Interface Database no longer has parameter primaryDelegatedIdentityClientId
+	Interface DatabaseIdentity no longer has parameter delegatedResources
+	Interface DatabaseUpdate no longer has parameter primaryDelegatedIdentityClientId
+	Interface VirtualCluster no longer has parameter family
+	Interface VirtualCluster no longer has parameter maintenanceConfigurationId
+	Interface VirtualClusterUpdate no longer has parameter family
+	Interface VirtualClusterUpdate no longer has parameter maintenanceConfigurationId
+	Operation ServerDevOpsAuditSettings.beginCreateOrUpdate has a new signature
+	Operation ServerDevOpsAuditSettings.beginCreateOrUpdateAndWait has a new signature
+	Operation ServerDevOpsAuditSettings.get has a new signature
+	Operation SyncGroups.listLogs has a new signature
+	Removed Enum KnownDnsRefreshConfigurationPropertiesStatus
+	Removed Enum KnownEnum60
+	Removed operation ReplicationLinks.beginUnlink
+	Removed operation ReplicationLinks.beginUnlinkAndWait
+	Removed operation ReplicationLinks.delete
+	Removed operation TransparentDataEncryptions.createOrUpdate
+	Removed operation VirtualClusters.updateDnsServers
+	Removed operation group OperationsHealthOperations
+	Type of parameter publicNetworkAccess of interface Server is changed from ServerNetworkAccessFlag to ServerPublicNetworkAccessFlag
+	Type of parameter publicNetworkAccess of interface ServerUpdate is changed from ServerNetworkAccessFlag to ServerPublicNetworkAccessFlag
+	Type of parameter unrestorableFiles of interface ManagedDatabaseRestoreDetailsResult is changed from string[] to ManagedDatabaseRestoreDetailsUnrestorableFileProperties[]

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from c3daf5a. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.5.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.5.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.5.0` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-sql [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation ManagedInstancesOperations.begin_start
info	[Changelog]   - Added operation ManagedInstancesOperations.begin_stop
info	[Changelog]   - Added operation ManagedInstancesOperations.list_outbound_network_dependencies_by_managed_instance
info	[Changelog]   - Added operation ServersOperations.begin_refresh_status
info	[Changelog]   - Added operation group DatabaseEncryptionProtectorsOperations
info	[Changelog]   - Added operation group ManagedLedgerDigestUploadsOperations
info	[Changelog]   - Added operation group ServerConfigurationOptionsOperations
info	[Changelog]   - Added operation group StartStopManagedInstanceSchedulesOperations
info	[Changelog]   - Model Database has a new parameter availability_zone
info	[Changelog]   - Model Database has a new parameter encryption_protector
info	[Changelog]   - Model Database has a new parameter keys
info	[Changelog]   - Model Database has a new parameter manual_cutover
info	[Changelog]   - Model Database has a new parameter perform_cutover
info	[Changelog]   - Model DatabaseUpdate has a new parameter encryption_protector
info	[Changelog]   - Model DatabaseUpdate has a new parameter keys
info	[Changelog]   - Model DatabaseUpdate has a new parameter manual_cutover
info	[Changelog]   - Model DatabaseUpdate has a new parameter perform_cutover
info	[Changelog]   - Model PrivateEndpointConnectionProperties has a new parameter group_ids
info	[Changelog]   - Model RecoverableDatabase has a new parameter keys
info	[Changelog]   - Model RecoverableDatabaseListResult has a new parameter next_link
info	[Changelog]   - Model RestorableDroppedDatabase has a new parameter keys
info	[Changelog]   - Model Server has a new parameter external_governance_status
info	[Changelog]   - Model ServerUpdate has a new parameter external_governance_status
info	[Changelog]   - Operation DatabasesOperations.get has a new optional parameter expand
info	[Changelog]   - Operation DatabasesOperations.get has a new optional parameter filter
info	[Changelog]   - Operation RecoverableDatabasesOperations.get has a new optional parameter expand
info	[Changelog]   - Operation RecoverableDatabasesOperations.get has a new optional parameter filter
info	[Changelog]   - Operation RestorableDroppedDatabasesOperations.get has a new optional parameter expand
info	[Changelog]   - Operation RestorableDroppedDatabasesOperations.get has a new optional parameter filter
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Renamed operation TransparentDataEncryptionsOperations.create_or_update to TransparentDataEncryptionsOperations.begin_create_or_update

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from c3daf5a. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 672 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:760
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 760 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 672 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.Sql [View full logs] [Release SDK Changes]
```
info	[Changelog]
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from c3daf5a. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-sql-generated [View full logs] [Release SDK Changes]
- pom.xml

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from c3daf5a. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/sql/armsql [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 120 items here, please refer to log for details.

info	[Changelog] - New struct `DatabaseSQLVulnerabilityAssessmentScanResultClient`
info	[Changelog] - New struct `DatabaseSQLVulnerabilityAssessmentScansClient`
info	[Changelog] - New struct `DatabaseSQLVulnerabilityAssessmentsSettingsClient`
info	[Changelog] - New struct `EndpointDependency`
info	[Changelog] - New struct `EndpointDetail`
info	[Changelog] - New struct `ManagedDatabaseAdvancedThreatProtection`
info	[Changelog] - New struct `ManagedDatabaseAdvancedThreatProtectionListResult`
info	[Changelog] - New struct `ManagedDatabaseAdvancedThreatProtectionSettingsClient`
info	[Changelog] - New struct `ManagedDatabaseMoveDefinition`
info	[Changelog] - New struct `ManagedDatabaseMoveOperationListResult`
info	[Changelog] - New struct `ManagedDatabaseMoveOperationResult`
info	[Changelog] - New struct `ManagedDatabaseMoveOperationResultProperties`
info	[Changelog] - New struct `ManagedDatabaseMoveOperationsClient`
info	[Changelog] - New struct `ManagedDatabaseRestoreDetailsBackupSetProperties`
info	[Changelog] - New struct `ManagedDatabaseRestoreDetailsUnrestorableFileProperties`
info	[Changelog] - New struct `ManagedDatabaseStartMoveDefinition`
info	[Changelog] - New struct `ManagedInstanceAdvancedThreatProtection`
info	[Changelog] - New struct `ManagedInstanceAdvancedThreatProtectionListResult`
info	[Changelog] - New struct `ManagedInstanceAdvancedThreatProtectionSettingsClient`
info	[Changelog] - New struct `ManagedInstanceDtc`
info	[Changelog] - New struct `ManagedInstanceDtcListResult`
info	[Changelog] - New struct `ManagedInstanceDtcProperties`
info	[Changelog] - New struct `ManagedInstanceDtcSecuritySettings`
info	[Changelog] - New struct `ManagedInstanceDtcTransactionManagerCommunicationSettings`
info	[Changelog] - New struct `ManagedInstanceDtcsClient`
info	[Changelog] - New struct `ManagedLedgerDigestUploads`
info	[Changelog] - New struct `ManagedLedgerDigestUploadsClient`
info	[Changelog] - New struct `ManagedLedgerDigestUploadsListResult`
info	[Changelog] - New struct `ManagedLedgerDigestUploadsProperties`
info	[Changelog] - New struct `ManagedServerDNSAlias`
info	[Changelog] - New struct `ManagedServerDNSAliasAcquisition`
info	[Changelog] - New struct `ManagedServerDNSAliasCreation`
info	[Changelog] - New struct `ManagedServerDNSAliasListResult`
info	[Changelog] - New struct `ManagedServerDNSAliasProperties`
info	[Changelog] - New struct `ManagedServerDNSAliasesClient`
info	[Changelog] - New struct `OutboundEnvironmentEndpoint`
info	[Changelog] - New struct `OutboundEnvironmentEndpointCollection`
info	[Changelog] - New struct `PrivateEndpointConnectionPropertiesAutoGenerated`
info	[Changelog] - New struct `QueryCheck`
info	[Changelog] - New struct `RefreshExternalGovernanceStatusOperationResult`
info	[Changelog] - New struct `RefreshExternalGovernanceStatusOperationResultProperties`
info	[Changelog] - New struct `Remediation`
info	[Changelog] - New struct `ScheduleItem`
info	[Changelog] - New struct `ServerConfigurationOption`
info	[Changelog] - New struct `ServerConfigurationOptionListResult`
info	[Changelog] - New struct `ServerConfigurationOptionProperties`
info	[Changelog] - New struct `ServerConfigurationOptionsClient`
info	[Changelog] - New struct `StartStopManagedInstanceSchedule`
info	[Changelog] - New struct `StartStopManagedInstanceScheduleListResult`
info	[Changelog] - New struct `StartStopManagedInstanceScheduleProperties`
info	[Changelog] - New struct `StartStopManagedInstanceSchedulesClient`
info	[Changelog] - New struct `SynapseLinkWorkspace`
info	[Changelog] - New struct `SynapseLinkWorkspaceInfoProperties`
info	[Changelog] - New struct `SynapseLinkWorkspaceListResult`
info	[Changelog] - New struct `SynapseLinkWorkspaceProperties`
info	[Changelog] - New struct `SynapseLinkWorkspacesClient`
info	[Changelog] - New struct `UpdateVirtualClusterDNSServersOperation`
info	[Changelog] - New struct `VaRule`
info	[Changelog] - New struct `VirtualClusterDNSServersProperties`
info	[Changelog] - New struct `VulnerabilityAssessment`
info	[Changelog] - New struct `VulnerabilityAssessmentBaselineClient`
info	[Changelog] - New struct `VulnerabilityAssessmentBaselinesClient`
info	[Changelog] - New struct `VulnerabilityAssessmentExecuteScanClient`
info	[Changelog] - New struct `VulnerabilityAssessmentListResult`
info	[Changelog] - New struct `VulnerabilityAssessmentPolicyProperties`
info	[Changelog] - New struct `VulnerabilityAssessmentRuleBaselineClient`
info	[Changelog] - New struct `VulnerabilityAssessmentRuleBaselinesClient`
info	[Changelog] - New struct `VulnerabilityAssessmentScanForSQLError`
info	[Changelog] - New struct `VulnerabilityAssessmentScanListResult`
info	[Changelog] - New struct `VulnerabilityAssessmentScanRecordForSQL`
info	[Changelog] - New struct `VulnerabilityAssessmentScanRecordForSQLListResult`
info	[Changelog] - New struct `VulnerabilityAssessmentScanRecordForSQLProperties`
info	[Changelog] - New struct `VulnerabilityAssessmentScanResultClient`
info	[Changelog] - New struct `VulnerabilityAssessmentScanResultProperties`
info	[Changelog] - New struct `VulnerabilityAssessmentScanResults`
info	[Changelog] - New struct `VulnerabilityAssessmentScansClient`
info	[Changelog] - New struct `VulnerabilityAssessmentsClient`
info	[Changelog] - New struct `VulnerabilityAssessmentsSettingsClient`
info	[Changelog] - New field `AvailabilityZone` in struct `DatabaseProperties`
info	[Changelog] - New field `EncryptionProtector` in struct `DatabaseProperties`
info	[Changelog] - New field `Keys` in struct `DatabaseProperties`
info	[Changelog] - New field `ManualCutover` in struct `DatabaseProperties`
info	[Changelog] - New field `PerformCutover` in struct `DatabaseProperties`
info	[Changelog] - New field `PreferredEnclaveType` in struct `DatabaseProperties`
info	[Changelog] - New field `EncryptionProtector` in struct `DatabaseUpdateProperties`
info	[Changelog] - New field `Keys` in struct `DatabaseUpdateProperties`
info	[Changelog] - New field `ManualCutover` in struct `DatabaseUpdateProperties`
info	[Changelog] - New field `PerformCutover` in struct `DatabaseUpdateProperties`
info	[Changelog] - New field `PreferredEnclaveType` in struct `DatabaseUpdateProperties`
info	[Changelog] - New field `Expand` in struct `DatabasesClientGetOptions`
info	[Changelog] - New field `Filter` in struct `DatabasesClientGetOptions`
info	[Changelog] - New field `SecondaryType` in struct `InstanceFailoverGroupProperties`
info	[Changelog] - New field `CrossSubscriptionRestorableDroppedDatabaseID` in struct `ManagedDatabaseProperties`
info	[Changelog] - New field `CrossSubscriptionSourceDatabaseID` in struct `ManagedDatabaseProperties`
info	[Changelog] - New field `CrossSubscriptionTargetManagedInstanceID` in struct `ManagedDatabaseProperties`
info	[Changelog] - New field `StorageContainerIdentity` in struct `ManagedDatabaseProperties`
info	[Changelog] - New field `CurrentBackupType` in struct `ManagedDatabaseRestoreDetailsProperties`
info	[Changelog] - New field `CurrentRestorePlanSizeMB` in struct `ManagedDatabaseRestoreDetailsProperties`
info	[Changelog] - New field `CurrentRestoredSizeMB` in struct `ManagedDatabaseRestoreDetailsProperties`
info	[Changelog] - New field `DiffBackupSets` in struct `ManagedDatabaseRestoreDetailsProperties`
info	[Changelog] - New field `FullBackupSets` in struct `ManagedDatabaseRestoreDetailsProperties`
info	[Changelog] - New field `LogBackupSets` in struct `ManagedDatabaseRestoreDetailsProperties`
info	[Changelog] - New field `NumberOfFilesQueued` in struct `ManagedDatabaseRestoreDetailsProperties`
info	[Changelog] - New field `NumberOfFilesRestored` in struct `ManagedDatabaseRestoreDetailsProperties`
info	[Changelog] - New field `NumberOfFilesRestoring` in struct `ManagedDatabaseRestoreDetailsProperties`
info	[Changelog] - New field `NumberOfFilesSkipped` in struct `ManagedDatabaseRestoreDetailsProperties`
info	[Changelog] - New field `NumberOfFilesUnrestorable` in struct `ManagedDatabaseRestoreDetailsProperties`
info	[Changelog] - New field `Type` in struct `ManagedDatabaseRestoreDetailsProperties`
info	[Changelog] - New field `NextLink` in struct `RecoverableDatabaseListResult`
info	[Changelog] - New field `Keys` in struct `RecoverableDatabaseProperties`
info	[Changelog] - New field `Expand` in struct `RecoverableDatabasesClientGetOptions`
info	[Changelog] - New field `Filter` in struct `RecoverableDatabasesClientGetOptions`
info	[Changelog] - New field `Keys` in struct `RestorableDroppedDatabaseProperties`
info	[Changelog] - New field `Expand` in struct `RestorableDroppedDatabasesClientGetOptions`
info	[Changelog] - New field `Filter` in struct `RestorableDroppedDatabasesClientGetOptions`
info	[Changelog] - New field `IsManagedIdentityInUse` in struct `ServerDevOpsAuditSettingsProperties`
info	[Changelog] - New field `ExternalGovernanceStatus` in struct `ServerProperties`
info	[Changelog] - New field `Version` in struct `VirtualClusterProperties`
info	[Changelog]
info	[Changelog] Total 14 breaking change(s), 367 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from c3daf5a. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-sql [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-sql-10.0.0-beta.1.tgz

Only show 120 items here, please refer to log for details.

info	[Changelog]   - Added Type Alias StartStopScheduleName
info	[Changelog]   - Added Type Alias SynapseLinkWorkspacesListByDatabaseNextResponse
info	[Changelog]   - Added Type Alias SynapseLinkWorkspacesListByDatabaseResponse
info	[Changelog]   - Added Type Alias SyncGroupsType
info	[Changelog]   - Interface Database has a new optional parameter availabilityZone
info	[Changelog]   - Interface Database has a new optional parameter encryptionProtector
info	[Changelog]   - Interface Database has a new optional parameter keys
info	[Changelog]   - Interface Database has a new optional parameter manualCutover
info	[Changelog]   - Interface Database has a new optional parameter performCutover
info	[Changelog]   - Interface Database has a new optional parameter preferredEnclaveType
info	[Changelog]   - Interface Database has a new optional parameter sourceResourceId
info	[Changelog]   - Interface DatabaseBlobAuditingPolicy has a new optional parameter isManagedIdentityInUse
info	[Changelog]   - Interface DatabasesGetOptionalParams has a new optional parameter expand
info	[Changelog]   - Interface DatabasesGetOptionalParams has a new optional parameter filter
info	[Changelog]   - Interface DatabaseUpdate has a new optional parameter encryptionProtector
info	[Changelog]   - Interface DatabaseUpdate has a new optional parameter keys
info	[Changelog]   - Interface DatabaseUpdate has a new optional parameter manualCutover
info	[Changelog]   - Interface DatabaseUpdate has a new optional parameter performCutover
info	[Changelog]   - Interface DatabaseUpdate has a new optional parameter preferredEnclaveType
info	[Changelog]   - Interface ElasticPool has a new optional parameter highAvailabilityReplicaCount
info	[Changelog]   - Interface ElasticPoolUpdate has a new optional parameter highAvailabilityReplicaCount
info	[Changelog]   - Interface ExtendedDatabaseBlobAuditingPolicy has a new optional parameter isManagedIdentityInUse
info	[Changelog]   - Interface ExtendedServerBlobAuditingPolicy has a new optional parameter isManagedIdentityInUse
info	[Changelog]   - Interface InstanceFailoverGroup has a new optional parameter secondaryType
info	[Changelog]   - Interface ManagedDatabase has a new optional parameter crossSubscriptionRestorableDroppedDatabaseId
info	[Changelog]   - Interface ManagedDatabase has a new optional parameter crossSubscriptionSourceDatabaseId
info	[Changelog]   - Interface ManagedDatabase has a new optional parameter crossSubscriptionTargetManagedInstanceId
info	[Changelog]   - Interface ManagedDatabase has a new optional parameter storageContainerIdentity
info	[Changelog]   - Interface ManagedDatabaseRestoreDetailsResult has a new optional parameter currentBackupType
info	[Changelog]   - Interface ManagedDatabaseRestoreDetailsResult has a new optional parameter currentRestoredSizeMB
info	[Changelog]   - Interface ManagedDatabaseRestoreDetailsResult has a new optional parameter currentRestorePlanSizeMB
info	[Changelog]   - Interface ManagedDatabaseRestoreDetailsResult has a new optional parameter diffBackupSets
info	[Changelog]   - Interface ManagedDatabaseRestoreDetailsResult has a new optional parameter fullBackupSets
info	[Changelog]   - Interface ManagedDatabaseRestoreDetailsResult has a new optional parameter logBackupSets
info	[Changelog]   - Interface ManagedDatabaseRestoreDetailsResult has a new optional parameter numberOfFilesQueued
info	[Changelog]   - Interface ManagedDatabaseRestoreDetailsResult has a new optional parameter numberOfFilesRestored
info	[Changelog]   - Interface ManagedDatabaseRestoreDetailsResult has a new optional parameter numberOfFilesRestoring
info	[Changelog]   - Interface ManagedDatabaseRestoreDetailsResult has a new optional parameter numberOfFilesSkipped
info	[Changelog]   - Interface ManagedDatabaseRestoreDetailsResult has a new optional parameter numberOfFilesUnrestorable
info	[Changelog]   - Interface ManagedDatabaseRestoreDetailsResult has a new optional parameter typePropertiesType
info	[Changelog]   - Interface ManagedDatabaseUpdate has a new optional parameter crossSubscriptionRestorableDroppedDatabaseId
info	[Changelog]   - Interface ManagedDatabaseUpdate has a new optional parameter crossSubscriptionSourceDatabaseId
info	[Changelog]   - Interface ManagedDatabaseUpdate has a new optional parameter crossSubscriptionTargetManagedInstanceId
info	[Changelog]   - Interface ManagedDatabaseUpdate has a new optional parameter storageContainerIdentity
info	[Changelog]   - Interface PrivateEndpointConnectionProperties has a new optional parameter groupIds
info	[Changelog]   - Interface RecoverableDatabase has a new optional parameter keys
info	[Changelog]   - Interface RecoverableDatabaseListResult has a new optional parameter nextLink
info	[Changelog]   - Interface RecoverableDatabasesGetOptionalParams has a new optional parameter expand
info	[Changelog]   - Interface RecoverableDatabasesGetOptionalParams has a new optional parameter filter
info	[Changelog]   - Interface ReplicationLinksDeleteOptionalParams has a new optional parameter resumeFrom
info	[Changelog]   - Interface ReplicationLinksDeleteOptionalParams has a new optional parameter updateIntervalInMs
info	[Changelog]   - Interface RestorableDroppedDatabase has a new optional parameter keys
info	[Changelog]   - Interface RestorableDroppedDatabasesGetOptionalParams has a new optional parameter expand
info	[Changelog]   - Interface RestorableDroppedDatabasesGetOptionalParams has a new optional parameter filter
info	[Changelog]   - Interface Server has a new optional parameter externalGovernanceStatus
info	[Changelog]   - Interface ServerBlobAuditingPolicy has a new optional parameter isManagedIdentityInUse
info	[Changelog]   - Interface ServerDevOpsAuditingSettings has a new optional parameter isManagedIdentityInUse
info	[Changelog]   - Interface ServerUpdate has a new optional parameter externalGovernanceStatus
info	[Changelog]   - Interface TransparentDataEncryptionsCreateOrUpdateOptionalParams has a new optional parameter resumeFrom
info	[Changelog]   - Interface TransparentDataEncryptionsCreateOrUpdateOptionalParams has a new optional parameter updateIntervalInMs
info	[Changelog]   - Interface VirtualCluster has a new optional parameter version
info	[Changelog]   - Interface VirtualClustersUpdateDnsServersOptionalParams has a new optional parameter resumeFrom
info	[Changelog]   - Interface VirtualClustersUpdateDnsServersOptionalParams has a new optional parameter updateIntervalInMs
info	[Changelog]   - Interface VirtualClusterUpdate has a new optional parameter version
info	[Changelog]   - Added Enum KnownAdvancedThreatProtectionName
info	[Changelog]   - Added Enum KnownAlwaysEncryptedEnclaveType
info	[Changelog]   - Added Enum KnownAvailabilityZoneType
info	[Changelog]   - Added Enum KnownBaselineName
info	[Changelog]   - Added Enum KnownDatabaseKeyType
info	[Changelog]   - Added Enum KnownDevOpsAuditingSettingsName
info	[Changelog]   - Added Enum KnownDNSRefreshOperationStatus
info	[Changelog]   - Added Enum KnownDtcName
info	[Changelog]   - Added Enum KnownExternalGovernanceStatus
info	[Changelog]   - Added Enum KnownManagedLedgerDigestUploadsName
info	[Changelog]   - Added Enum KnownManagedLedgerDigestUploadsState
info	[Changelog]   - Added Enum KnownMoveOperationMode
info	[Changelog]   - Added Enum KnownReplicationMode
info	[Changelog]   - Added Enum KnownRuleSeverity
info	[Changelog]   - Added Enum KnownRuleStatus
info	[Changelog]   - Added Enum KnownRuleType
info	[Changelog]   - Added Enum KnownSecondaryInstanceType
info	[Changelog]   - Added Enum KnownServerConfigurationOptionName
info	[Changelog]   - Added Enum KnownServerPublicNetworkAccessFlag
info	[Changelog]   - Added Enum KnownSQLVulnerabilityAssessmentName
info	[Changelog]   - Added Enum KnownSqlVulnerabilityAssessmentName
info	[Changelog]   - Added Enum KnownStartStopScheduleName
info	[Changelog]   - Added Enum KnownSyncGroupsType
info	[Changelog]   - Enum KnownManagedDatabaseStatus has a new value DbCopying
info	[Changelog]   - Enum KnownManagedDatabaseStatus has a new value DbMoving
info	[Changelog]   - Enum KnownManagedDatabaseStatus has a new value Starting
info	[Changelog]   - Enum KnownManagedDatabaseStatus has a new value Stopped
info	[Changelog]   - Enum KnownManagedDatabaseStatus has a new value Stopping
info	[Changelog]   - Enum KnownReplicationLinkType has a new value Standby
info	[Changelog]   - Enum KnownSecondaryType has a new value Standby
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Removed operation group OperationsHealthOperations
info	[Changelog]   - Removed operation ReplicationLinks.beginUnlink
info	[Changelog]   - Removed operation ReplicationLinks.beginUnlinkAndWait
info	[Changelog]   - Removed operation ReplicationLinks.delete
info	[Changelog]   - Removed operation TransparentDataEncryptions.createOrUpdate
info	[Changelog]   - Removed operation VirtualClusters.updateDnsServers
info	[Changelog]   - Operation ServerDevOpsAuditSettings.beginCreateOrUpdate has a new signature
info	[Changelog]   - Operation ServerDevOpsAuditSettings.beginCreateOrUpdateAndWait has a new signature
info	[Changelog]   - Operation ServerDevOpsAuditSettings.get has a new signature
info	[Changelog]   - Operation SyncGroups.listLogs has a new signature
info	[Changelog]   - Interface Database no longer has parameter primaryDelegatedIdentityClientId
info	[Changelog]   - Interface DatabaseIdentity no longer has parameter delegatedResources
info	[Changelog]   - Interface DatabaseUpdate no longer has parameter primaryDelegatedIdentityClientId
info	[Changelog]   - Interface VirtualCluster no longer has parameter family
info	[Changelog]   - Interface VirtualCluster no longer has parameter maintenanceConfigurationId
info	[Changelog]   - Interface VirtualClusterUpdate no longer has parameter family
info	[Changelog]   - Interface VirtualClusterUpdate no longer has parameter maintenanceConfigurationId
info	[Changelog]   - Type of parameter unrestorableFiles of interface ManagedDatabaseRestoreDetailsResult is changed from string[] to ManagedDatabaseRestoreDetailsUnrestorableFileProperties[]
info	[Changelog]   - Type of parameter publicNetworkAccess of interface Server is changed from ServerNetworkAccessFlag to ServerPublicNetworkAccessFlag
info	[Changelog]   - Type of parameter publicNetworkAccess of interface ServerUpdate is changed from ServerNetworkAccessFlag to ServerPublicNetworkAccessFlag
info	[Changelog]   - Class SqlManagementClient no longer has parameter operationsHealthOperations
info	[Changelog]   - Removed Enum KnownDnsRefreshConfigurationPropertiesStatus
info	[Changelog]   - Removed Enum KnownEnum60

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from c3daf5a. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️sql [View full logs] [Release Schema Changes]

️❌ azure-powershell failed [Detail]

❌Failed [Logs]Release - Generate from c3daf5a. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

❌Az.sql [View full logs] [Release SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-01-24T17:54:16Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/sql/armsql	https://apiview.dev/Assemblies/Review/7f8fbfe7159345809cfae998d1568a0e
JavaScript	@azure/arm-sql	Create ApiView failed. Please ask PR assignee for help

openapi-workflow-bot · 2023-01-24T18:02:45Z

Hi @matthchr, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

openapi-workflow-bot · 2023-01-24T18:02:46Z

Hi @matthchr, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

matthchr · 2023-01-24T18:02:56Z

@ericshape can you review this?

matthchr · 2023-01-24T18:04:17Z

Note that the breaking change tool incorrectly classifies string with no format to string with format: "arm-id" as breaking, but it is not actually breaking.

matthchr · 2023-01-24T18:16:29Z

I investigated the ModelValidation failures and they are either:

Issues with LROs which I didn't change.
Issues with samples being flagged as returning a secret when the GET returns "storageAccountAccessKey":"". This is the real behavior of the API so I believe the sample is correct. Technically the key is not returned (it's always empty string), so possibly the ModelValidator is overly sensitive here? Or else possibly the SQL server should be updated in a future version to omit the storageAccountAccessKey entirely in the response body. In any case, the samples are currently correct so I didn't change them.

matthchr · 2023-01-25T00:24:32Z

@raych1 - can you confirm that the x-ms-secret annotation addition is safe, even in existing Swagger? I believe it is, as it doesn't change generated SDK types or anything like that. The breaking change detection seems fine with it, but just wanna triple check.

ericshape

LGTM

after @raych1 answer the question from the author, we could merge it to main branch.

ericshape · 2023-01-30T09:04:29Z

Interesting. Why do we meet this spelling error issue?

raych1

Can you fix spell check errors?

raych1 · 2023-01-31T02:44:36Z

I investigated the ModelValidation failures and they are either:

Issues with LROs which I didn't change.

Issues with samples being flagged as returning a secret when the GET returns "storageAccountAccessKey":"". This is the real behavior of the API so I believe the sample is correct. Technically the key is not returned (it's always empty string), so possibly the ModelValidator is overly sensitive here? Or else possibly the SQL server should be updated in a future version to omit the storageAccountAccessKey entirely in the response body. In any case, the samples are currently correct so I didn't change them.

If a property is annotated as x-ms-secret: true, then it should not return in response. If the response still has it even with empty value, please don't have it annotated as x-ms-secret: true.

raych1 · 2023-01-31T02:45:53Z

@ericshape , I saw you approved this PR but still want to confirm with you will these chagnes be overridden next time when swagger is re-generates?

matthchr · 2023-02-14T21:19:57Z

I have updated this PR and fixed the x-ms-secret model validation errors (fixed the samples).

The other model validation errors and spelling errors I believe are unrelated to this PR.

matthchr · 2023-02-14T21:20:40Z

@ericshape I will send a second PR targeting the new preview version once it merges and this PR is merged. Do you have any objection to this merging now?

raych1 · 2023-02-16T00:03:43Z

@matthchr , please fix spellCheck error. @ericshape , can you review again as some more commits made after you approved?

ericshape

LGTM

1023 - TypeFormatChanged are expected

ericshape · 2023-02-16T00:16:42Z

@matthchr , please fix spellCheck error. @ericshape , can you review again as some more commits made after you approved?

the spellCheck error could be fixed by rebase/sync with latest main branch

matthchr · 2023-02-16T01:00:34Z

I rebased which in theory should fix the spellcheck errors

…ere appropriate and x-ms-secret where appropriate (#2800) Create to sync Azure/azure-rest-api-specs#22292 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/sql?expand=1)

…and x-ms-secret where appropriate (Azure#22292) * Azure SQL ARM ID annotations * Fix secret annotations * Fix samples

matthchr requested review from jamestao and ericshape as code owners January 24, 2023 17:54

openapi-assignment-bot bot assigned raych1 Jan 24, 2023

ghost added the SQL label Jan 24, 2023

AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-FixRequiredOnFailure resource-manager labels Jan 24, 2023

azure-sdk mentioned this pull request Jan 24, 2023

[AutoPR sdk/resourcemanager/sql/armsql] Update Microsoft.Sql ARM API with "format: arm-id" where appropriate and x-ms-secret where appropriate azure-sdk/azure-sdk-for-go#4104

Closed

matthchr force-pushed the feature/sql-armid branch from 1952004 to 443669c Compare January 24, 2023 18:24

azure-sdk mentioned this pull request Jan 24, 2023

[AutoPR sql] Update Microsoft.Sql ARM API with "format: arm-id" where appropriate and x-ms-secret where appropriate azure-sdk/azure-resource-manager-schemas#1869

Closed

matthchr mentioned this pull request Jan 25, 2023

Add Azure SQL resources, tests, and samples Azure/azure-service-operator#2698

Merged

2 tasks

ericshape approved these changes Jan 30, 2023

View reviewed changes

raych1 requested changes Jan 31, 2023

View reviewed changes

raych1 approved these changes Feb 16, 2023

View reviewed changes

ericshape approved these changes Feb 16, 2023

View reviewed changes

matthchr added 3 commits February 15, 2023 16:47

Azure SQL ARM ID annotations

acc8adf

Fix secret annotations

e62b8f4

Fix samples

40deb8c

matthchr force-pushed the feature/sql-armid branch from 94e32bf to 40deb8c Compare February 16, 2023 00:47

openapi-pipeline-app bot added CI-BreakingChange-JavaScript CI-BreakingChange-Python-Track2 labels Feb 16, 2023

raych1 added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 FalsePositive-BreakingChange Approved-ModelValidation labels Feb 16, 2023

raych1 merged commit c3daf5a into Azure:main Feb 16, 2023

matthchr mentioned this pull request Feb 16, 2023

Update Microsoft.Sql ARM API with "format: arm-id" where appropriate and x-ms-secret where appropriate #22677

Merged

11 tasks

jianyexi mentioned this pull request Mar 13, 2023

the change of string format to arm-id from empty should not be a breaking change Azure/openapi-diff#268

Open

matthchr deleted the feature/sql-armid branch November 11, 2024 22:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Microsoft.Sql ARM API with "format: arm-id" where appropriate and x-ms-secret where appropriate #22292

Update Microsoft.Sql ARM API with "format: arm-id" where appropriate and x-ms-secret where appropriate #22292

matthchr commented Jan 24, 2023 •

edited

Loading

openapi-workflow-bot bot commented Jan 24, 2023

openapi-pipeline-app bot commented Jan 24, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jan 24, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Jan 24, 2023 •

edited

Loading

openapi-workflow-bot bot commented Jan 24, 2023

openapi-workflow-bot bot commented Jan 24, 2023

matthchr commented Jan 24, 2023

matthchr commented Jan 24, 2023

matthchr commented Jan 24, 2023

matthchr commented Jan 25, 2023

ericshape left a comment

ericshape commented Jan 30, 2023

raych1 left a comment •

edited

Loading

raych1 commented Jan 31, 2023

raych1 commented Jan 31, 2023

matthchr commented Feb 14, 2023

matthchr commented Feb 14, 2023

raych1 commented Feb 16, 2023

ericshape left a comment •

edited

Loading

ericshape commented Feb 16, 2023

matthchr commented Feb 16, 2023

Update Microsoft.Sql ARM API with "format: arm-id" where appropriate and x-ms-secret where appropriate #22292

Update Microsoft.Sql ARM API with "format: arm-id" where appropriate and x-ms-secret where appropriate #22292

Conversation

matthchr commented Jan 24, 2023 • edited Loading

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jan 24, 2023

openapi-pipeline-app bot commented Jan 24, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jan 24, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Jan 24, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Jan 24, 2023

openapi-workflow-bot bot commented Jan 24, 2023

matthchr commented Jan 24, 2023

matthchr commented Jan 24, 2023

matthchr commented Jan 24, 2023

matthchr commented Jan 25, 2023

ericshape left a comment

Choose a reason for hiding this comment

ericshape commented Jan 30, 2023

raych1 left a comment • edited Loading

Choose a reason for hiding this comment

raych1 commented Jan 31, 2023

raych1 commented Jan 31, 2023

matthchr commented Feb 14, 2023

matthchr commented Feb 14, 2023

raych1 commented Feb 16, 2023

ericshape left a comment • edited Loading

Choose a reason for hiding this comment

ericshape commented Feb 16, 2023

matthchr commented Feb 16, 2023

matthchr commented Jan 24, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jan 24, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jan 24, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jan 24, 2023 •

edited

Loading

raych1 left a comment •

edited

Loading

ericshape left a comment •

edited

Loading