Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataProtection] Update readme.python.md for update title #22627

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

Wzb123456789
Copy link
Contributor

@Wzb123456789 Wzb123456789 commented Feb 15, 2023

@Wzb123456789 Wzb123456789 requested a review from msyyc as a code owner February 15, 2023 06:04
@openapi-workflow-bot
Copy link

Hi, @Wzb123456789 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 15, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    compared tags (via openapi-validator v2.0.0) new version base version
    default default(85862c6) default(main)
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]
    Validation passes for ServiceAPIReadinessTest.
    ️❌SwaggerAPIView: 0 Errors, 1 Warnings failed [Detail]
    Rule Message
    ⚠️ Failed to generate swagger APIView. The readme file format is invalid and the tag is not defined. Use the provided readme template for guidance readme template. For more details, please check the detail log. "How to fix":"Check the readme file and make sure the readme file format is valid and the tag is defined. Use the provided readme template"
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 15, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/dataprotection/armdataprotection - 2.0.0
    +	Const `StorageSettingStoreTypesSnapshotStore` from type alias `StorageSettingStoreTypes` has been removed
    +	Field `Identity` of struct `ResourceGuardResource` has been removed
    +	Function `*ResourceGuardsClient.Patch` parameter(s) have been changed from `(context.Context, string, string, PatchResourceRequestInput, *ResourceGuardsClientPatchOptions)` to `(context.Context, string, string, PatchResourceGuardInput, *ResourceGuardsClientPatchOptions)`
    +	Operation `*BackupVaultsClient.Delete` has been changed to LRO, use `*BackupVaultsClient.BeginDelete` instead.
    +	Struct `CloudError` has been removed
    azure-sdk-for-python-track2 - track2_azure-mgmt-dataprotection - 1.0.0b4
    +	Client name is changed from `DataProtectionClient` to `DataProtectionMgmtClient`
    +	Model ResourceGuardResource no longer has parameter identity
    +	Removed operation group BackupInstancesExtensionRoutingOperations
    +	Removed operation group DppResourceGuardProxyOperations
    +	Renamed operation BackupVaultsOperations.delete to BackupVaultsOperations.begin_delete
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from f66832a. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.4.2
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.4.2>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.4.2` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-dataprotection [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Model AzureBackupDiscreteRecoveryPoint has a new parameter expiry_time
      info	[Changelog]   - Model BackupVault has a new parameter feature_settings
      info	[Changelog]   - Model PatchBackupVaultInput has a new parameter feature_settings
      info	[Changelog]   - Model TargetDetails has a new parameter target_resource_arm_id
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Client name is changed from `DataProtectionClient` to `DataProtectionMgmtClient`
      info	[Changelog]   - Model ResourceGuardResource no longer has parameter identity
      info	[Changelog]   - Removed operation group BackupInstancesExtensionRoutingOperations
      info	[Changelog]   - Removed operation group DppResourceGuardProxyOperations
      info	[Changelog]   - Renamed operation BackupVaultsOperations.delete to BackupVaultsOperations.begin_delete
    ️⚠️ azure-sdk-for-java warning [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from f66832a. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/dataprotection/armdataprotection [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `*ResourceGuardsClient.Patch` parameter(s) have been changed from `(context.Context, string, string, PatchResourceRequestInput, *ResourceGuardsClientPatchOptions)` to `(context.Context, string, string, PatchResourceGuardInput, *ResourceGuardsClientPatchOptions)`
      info	[Changelog] - Const `StorageSettingStoreTypesSnapshotStore` from type alias `StorageSettingStoreTypes` has been removed
      info	[Changelog] - Operation `*BackupVaultsClient.Delete` has been changed to LRO, use `*BackupVaultsClient.BeginDelete` instead.
      info	[Changelog] - Struct `CloudError` has been removed
      info	[Changelog] - Field `Identity` of struct `ResourceGuardResource` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New value `SourceDataStoreTypeOperationalStore` added to type alias `SourceDataStoreType`
      info	[Changelog] - New value `StorageSettingStoreTypesOperationalStore` added to type alias `StorageSettingStoreTypes`
      info	[Changelog] - New value `StorageSettingTypesZoneRedundant` added to type alias `StorageSettingTypes`
      info	[Changelog] - New type alias `CrossSubscriptionRestoreState` with values `CrossSubscriptionRestoreStateDisabled`, `CrossSubscriptionRestoreStateEnabled`, `CrossSubscriptionRestoreStatePermanentlyDisabled`
      info	[Changelog] - New type alias `ExistingResourcePolicy` with values `ExistingResourcePolicyPatch`, `ExistingResourcePolicySkip`
      info	[Changelog] - New type alias `ImmutabilityState` with values `ImmutabilityStateDisabled`, `ImmutabilityStateLocked`, `ImmutabilityStateUnlocked`
      info	[Changelog] - New type alias `PersistentVolumeRestoreMode` with values `PersistentVolumeRestoreModeRestoreWithVolumeData`, `PersistentVolumeRestoreModeRestoreWithoutVolumeData`
      info	[Changelog] - New type alias `SoftDeleteState` with values `SoftDeleteStateAlwaysOn`, `SoftDeleteStateOff`, `SoftDeleteStateOn`
      info	[Changelog] - New function `*BackupDatasourceParameters.GetBackupDatasourceParameters() *BackupDatasourceParameters`
      info	[Changelog] - New function `*BlobBackupDatasourceParameters.GetBackupDatasourceParameters() *BackupDatasourceParameters`
      info	[Changelog] - New function `NewDeletedBackupInstancesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*DeletedBackupInstancesClient, error)`
      info	[Changelog] - New function `*DeletedBackupInstancesClient.Get(context.Context, string, string, string, *DeletedBackupInstancesClientGetOptions) (DeletedBackupInstancesClientGetResponse, error)`
      info	[Changelog] - New function `*DeletedBackupInstancesClient.NewListPager(string, string, *DeletedBackupInstancesClientListOptions) *runtime.Pager[DeletedBackupInstancesClientListResponse]`
      info	[Changelog] - New function `*DeletedBackupInstancesClient.BeginUndelete(context.Context, string, string, string, *DeletedBackupInstancesClientBeginUndeleteOptions) (*runtime.Poller[DeletedBackupInstancesClientUndeleteResponse], error)`
      info	[Changelog] - New function `*ItemPathBasedRestoreCriteria.GetItemLevelRestoreCriteria() *ItemLevelRestoreCriteria`
      info	[Changelog] - New function `*KubernetesClusterBackupDatasourceParameters.GetBackupDatasourceParameters() *BackupDatasourceParameters`
      info	[Changelog] - New function `*KubernetesClusterRestoreCriteria.GetItemLevelRestoreCriteria() *ItemLevelRestoreCriteria`
      info	[Changelog] - New struct `BlobBackupDatasourceParameters`
      info	[Changelog] - New struct `CrossSubscriptionRestoreSettings`
      info	[Changelog] - New struct `DeletedBackupInstance`
      info	[Changelog] - New struct `DeletedBackupInstanceResource`
      info	[Changelog] - New struct `DeletedBackupInstanceResourceList`
      info	[Changelog] - New struct `DeletedBackupInstancesClient`
      info	[Changelog] - New struct `DeletionInfo`
      info	[Changelog] - New struct `DppBaseTrackedResource`
      info	[Changelog] - New struct `DppProxyResource`
      info	[Changelog] - New struct `FeatureSettings`
      info	[Changelog] - New struct `ImmutabilitySettings`
      info	[Changelog] - New struct `ItemPathBasedRestoreCriteria`
      info	[Changelog] - New struct `KubernetesClusterBackupDatasourceParameters`
      info	[Changelog] - New struct `KubernetesClusterRestoreCriteria`
      info	[Changelog] - New struct `PatchResourceGuardInput`
      info	[Changelog] - New struct `SecuritySettings`
      info	[Changelog] - New struct `SoftDeleteSettings`
      info	[Changelog] - New field `ExpiryTime` in struct `AzureBackupDiscreteRecoveryPoint`
      info	[Changelog] - New field `Tags` in struct `BackupInstanceResource`
      info	[Changelog] - New field `FeatureSettings` in struct `BackupVault`
      info	[Changelog] - New field `IsVaultProtectedByResourceGuard` in struct `BackupVault`
      info	[Changelog] - New field `SecuritySettings` in struct `BackupVault`
      info	[Changelog] - New field `FeatureSettings` in struct `PatchBackupVaultInput`
      info	[Changelog] - New field `SecuritySettings` in struct `PatchBackupVaultInput`
      info	[Changelog] - New field `BackupDatasourceParametersList` in struct `PolicyParameters`
      info	[Changelog] - New field `TargetResourceArmID` in struct `TargetDetails`
      info	[Changelog]
      info	[Changelog] Total 6 breaking change(s), 71 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from f66832a. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-dataprotection [View full logs]  [Release SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from f66832a. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.dataprotection [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 15, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/dataprotection/armdataprotection https://apiview.dev/Assemblies/Review/80f7afd557824c7ba39e244731a27c6b
    Java azure-resourcemanager-dataprotection There is no API change compared with the previous version
    .Net Azure.ResourceManager.DataProtectionBackup There is no API change compared with the previous version
    JavaScript @azure/arm-dataprotection Create ApiView failed. Please ask PR assignee for help

    @msyyc msyyc assigned msyyc and unassigned xiaoxuqi-ms Feb 15, 2023
    @msyyc msyyc merged commit f66832a into main Feb 15, 2023
    @msyyc msyyc deleted the Wzb123456789-patch-5 branch February 15, 2023 06:20
    aviyerMSFT pushed a commit to aviyerMSFT/azure-rest-api-specs that referenced this pull request Mar 22, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants