fix SDK generating error for Compute #22829

grizzlytheodore · 2023-02-28T20:04:31Z

generating track 1 .net sdk from main was getting this error:
FATAL: System.InvalidOperationException: Swagger document contains two or more x-ms-enum extensions with the same name 'StorageAccountType' and different values: StandardLRS,Standard_ZRS,Premium_LRS vs. Standard_LRS,Standard_ZRS,StandardSSD_LRS,PremiumLRS

Because GalleryTargetExtendedLocation.StorageAccountType was added "StandardSSD_LRS" from #22255 while TargetRegion.StorageAccountType and GalleryArtifactPublishingProfileBase.StorageAccountType did not.

So I am renaming the enum here

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2023-02-28T20:04:35Z

Hi, @grizzlytheodore Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2023-02-28T20:04:35Z

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
gallery.json	2022-03-03(940ed5d)	2022-03-03(main)

Rule	Message
`❌` 1047 - XmsEnumChanged	The new version has a different x-ms-enum 'name' than the previous one. New: GalleryRP/stable/2022-03-03/gallery.json#L2560:9 Old: GalleryRP/stable/2022-03-03/gallery.json#L2560:9

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
package-2022-11-01	package-2022-11-01(940ed5d)	package-2022-11-01(main)
package-2022-09-04	package-2022-09-04(940ed5d)	package-2022-09-04(main)
package-2022-03-03	package-2022-03-03(940ed5d)	package-2022-03-03(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'galleryName' should be defined with a 'pattern' restriction. Location: GalleryRP/stable/2022-03-03/gallery.json#L37
`❌` ResourceNameRestriction	The resource name parameter 'galleryName' should be defined with a 'pattern' restriction. Location: GalleryRP/stable/2022-03-03/gallery.json#L37
`❌` ResourceNameRestriction	The resource name parameter 'galleryName' should be defined with a 'pattern' restriction. Location: GalleryRP/stable/2022-03-03/gallery.json#L37
`❌` CreateOperationAsyncResponseValidation	An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: GalleryRP/stable/2022-03-03/gallery.json#L38
`❌` CreateOperationAsyncResponseValidation	An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: GalleryRP/stable/2022-03-03/gallery.json#L38
`❌` CreateOperationAsyncResponseValidation	An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: GalleryRP/stable/2022-03-03/gallery.json#L38
`❌` LongRunningResponseStatusCode	A 'put' operation 'Galleries_CreateOrUpdate' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 201. Location: GalleryRP/stable/2022-03-03/gallery.json#L38
`❌` LongRunningResponseStatusCode	A 'put' operation 'Galleries_CreateOrUpdate' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 201. Location: GalleryRP/stable/2022-03-03/gallery.json#L38
`❌` LongRunningResponseStatusCode	A 'put' operation 'Galleries_CreateOrUpdate' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 201. Location: GalleryRP/stable/2022-03-03/gallery.json#L38
`❌` CreateOperationAsyncResponseValidation	Only 201 is the supported response code for PUT async response. Location: GalleryRP/stable/2022-03-03/gallery.json#L84
`❌` CreateOperationAsyncResponseValidation	Only 201 is the supported response code for PUT async response. Location: GalleryRP/stable/2022-03-03/gallery.json#L84
`❌` CreateOperationAsyncResponseValidation	Only 201 is the supported response code for PUT async response. Location: GalleryRP/stable/2022-03-03/gallery.json#L84
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: GalleryRP/stable/2022-03-03/gallery.json#L84
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: GalleryRP/stable/2022-03-03/gallery.json#L84
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: GalleryRP/stable/2022-03-03/gallery.json#L84
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property name. Location: GalleryRP/stable/2022-03-03/gallery.json#L136
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property type. Location: GalleryRP/stable/2022-03-03/gallery.json#L136
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property name. Location: GalleryRP/stable/2022-03-03/gallery.json#L136
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property type. Location: GalleryRP/stable/2022-03-03/gallery.json#L136
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property name. Location: GalleryRP/stable/2022-03-03/gallery.json#L136
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property type. Location: GalleryRP/stable/2022-03-03/gallery.json#L136
`❌` LroPatch202	The async patch operation should return 202. Location: GalleryRP/stable/2022-03-03/gallery.json#L146
`❌` LroPatch202	The async patch operation should return 202. Location: GalleryRP/stable/2022-03-03/gallery.json#L146
`❌` LroPatch202	The async patch operation should return 202. Location: GalleryRP/stable/2022-03-03/gallery.json#L146
`❌` DeleteOperationAsyncResponseValidation	An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options' Location: GalleryRP/stable/2022-03-03/gallery.json#L237
`❌` DeleteOperationAsyncResponseValidation	An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options' Location: GalleryRP/stable/2022-03-03/gallery.json#L237
`❌` DeleteOperationAsyncResponseValidation	An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options' Location: GalleryRP/stable/2022-03-03/gallery.json#L237
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: GalleryRP/stable/2022-03-03/gallery.json#L265
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: GalleryRP/stable/2022-03-03/gallery.json#L265
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: GalleryRP/stable/2022-03-03/gallery.json#L265

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2022-11-01

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️❌ModelValidation: 61 Errors, 0 Warnings failed [Detail]

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/Gallery_Create.json#L16:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/Gallery_Create.json#L29:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/Gallery_Create.json#L42:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/Gallery_Create_WithSharingProfile.json#L19:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/Gallery_Create_WithSharingProfile.json#L35:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/Gallery_Create_WithSharingProfile.json#L51:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/Gallery_Create_SoftDeletionEnabled.json#L19:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/Gallery_Create_SoftDeletionEnabled.json#L35:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/Gallery_Create_SoftDeletionEnabled.json#L51:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/CommunityGallery_Create.json#L25:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/CommunityGallery_Create.json#L47:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/CommunityGallery_Create.json#L69:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/Gallery_Get.json#L10:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/Gallery_Get_WithSelectPermissions.json#L11:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/Gallery_Get_WithExpandSharingProfileGroups.json#L11:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/CommunityGallery_Get.json#L10:15
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: GalleryRP/stable/2022-03-03/gallery.json#L261:22 ExampleUrl: 2022-03-03/examples/galleryExamples/Gallery_Delete.json
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L2260:21 ExampleUrl: 2022-03-03/examples/galleryExamples/GalleryImage_Create.json#L24:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L2260:21 ExampleUrl: 2022-03-03/examples/galleryExamples/GalleryImage_Create.json#L41:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L2260:21 ExampleUrl: 2022-03-03/examples/galleryExamples/GalleryImage_Create.json#L58:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L2260:21 ExampleUrl: 2022-03-03/examples/galleryExamples/GalleryImage_Get.json#L11:15
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: GalleryRP/stable/2022-03-03/gallery.json#L503:22 ExampleUrl: 2022-03-03/examples/galleryExamples/GalleryImage_Delete.json
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L2384:28 ExampleUrl: 2022-03-03/examples/galleryExamples/GalleryImageVersion_Create.json#L70:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L2384:28 ExampleUrl: 2022-03-03/examples/galleryExamples/GalleryImageVersion_Create.json#L154:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L2384:28 ExampleUrl: 2022-03-03/examples/galleryExamples/GalleryImageVersion_Create.json#L238:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L2384:28 ExampleUrl: 2022-03-03/examples/galleryExamples/GalleryImageVersion_Create_WithSnapshotsAsSource.json#L74:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L2384:28 ExampleUrl: 2022-03-03/examples/galleryExamples/GalleryImageVersion_Create_WithSnapshotsAsSource.json#L153:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L2384:28 ExampleUrl: 2022-03-03/examples/galleryExamples/GalleryImageVersion_Create_WithSnapshotsAsSource.json#L232:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L2384:28 ExampleUrl: 2022-03-03/examples/galleryExamples/GalleryImageVersion_Create_WithVmAsSource.json#L70:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L2384:28 ExampleUrl: 2022-03-03/examples/galleryExamples/GalleryImageVersion_Create_WithVmAsSource.json#L154:15

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-02-28T20:04:36Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/compute/armcompute - 5.0.0

+	Type of `GalleryTargetExtendedLocation.StorageAccountType` has been changed from `*StorageAccountType` to `*EdgeZoneStorageAccountType`

❌azure-sdk-for-js - @azure/arm-compute - 21.0.0

+	Type of parameter storageAccountType of interface GalleryTargetExtendedLocation is changed from StorageAccountType to EdgeZoneStorageAccountType

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs] Generate from 53bd9931fc61c38e97a7e926581149bdb286e83f. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 672 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.Compute [View full logs] [Preview SDK Changes] Breaking Change Detected

Azure.ResourceManager.Compute.1.2.0-alpha.20230228.1.nupkg

info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.Compute/Debug/netstandard2.0/Azure.ResourceManager.Compute.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj::TargetFramework=netstandard2.0]

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from 53bd9931fc61c38e97a7e926581149bdb286e83f. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.3.1 -> 9.5.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.5.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.5.1` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-compute [View full logs] [Preview SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model VirtualMachineScaleSetVMInstanceView has a new parameter computer_name
info	[Changelog]   - Model VirtualMachineScaleSetVMInstanceView has a new parameter hyper_v_generation
info	[Changelog]   - Model VirtualMachineScaleSetVMInstanceView has a new parameter os_name
info	[Changelog]   - Model VirtualMachineScaleSetVMInstanceView has a new parameter os_version

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 53bd9931fc61c38e97a7e926581149bdb286e83f. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-compute-generated [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 53bd9931fc61c38e97a7e926581149bdb286e83f. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-compute [View full logs] [Preview SDK Changes] Breaking Change Detected

azure-arm-compute-21.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Type Alias EdgeZoneStorageAccountType
info	[Changelog]   - Interface VirtualMachineScaleSetVMInstanceView has a new optional parameter computerName
info	[Changelog]   - Interface VirtualMachineScaleSetVMInstanceView has a new optional parameter hyperVGeneration
info	[Changelog]   - Interface VirtualMachineScaleSetVMInstanceView has a new optional parameter osName
info	[Changelog]   - Interface VirtualMachineScaleSetVMInstanceView has a new optional parameter osVersion
info	[Changelog]   - Added Enum KnownEdgeZoneStorageAccountType
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Type of parameter storageAccountType of interface GalleryTargetExtendedLocation is changed from StorageAccountType to EdgeZoneStorageAccountType

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 53bd9931fc61c38e97a7e926581149bdb286e83f. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/compute/armcompute [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `GalleryTargetExtendedLocation.StorageAccountType` has been changed from `*StorageAccountType` to `*EdgeZoneStorageAccountType`
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New type alias `EdgeZoneStorageAccountType` with values `EdgeZoneStorageAccountTypePremiumLRS`, `EdgeZoneStorageAccountTypeStandardLRS`, `EdgeZoneStorageAccountTypeStandardSSDLRS`, `EdgeZoneStorageAccountTypeStandardZRS`
info	[Changelog] - New field `ComputerName` in struct `VirtualMachineScaleSetVMInstanceView`
info	[Changelog] - New field `HyperVGeneration` in struct `VirtualMachineScaleSetVMInstanceView`
info	[Changelog] - New field `OSName` in struct `VirtualMachineScaleSetVMInstanceView`
info	[Changelog] - New field `OSVersion` in struct `VirtualMachineScaleSetVMInstanceView`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 6 additive change(s).

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from 53bd9931fc61c38e97a7e926581149bdb286e83f. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️compute [View full logs] [Preview Schema Changes]

️❌ azure-powershell failed [Detail]

❌Failed [Logs] Generate from 53bd9931fc61c38e97a7e926581149bdb286e83f. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

❌Az.compute [View full logs] [Preview SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-02-28T20:04:37Z

Generated ApiView

Language	Package Name	ApiView Link
swagger	Microsoft.Compute	https://apiview.dev/Assemblies/Review/706915fa42f34cef86a47f2c5c19a361
Go	sdk/resourcemanager/compute/armcompute	https://apiview.dev/Assemblies/Review/c54f0220b77549829c28c3fb839da692
Java	azure-resourcemanager-compute-generated	https://apiview.dev/Assemblies/Review/bfc4ab5733064b0bb7fb7b423dd359e6
.Net	Azure.ResourceManager.Compute	https://apiview.dev/Assemblies/Review/8a3979a59f7c48ca806f8f18a201ceb6
JavaScript	@azure/arm-compute	https://apiview.dev/Assemblies/Review/7eedaf393c894c788c6f8c17c1d6b0b4

grizzlytheodore · 2023-02-28T20:05:50Z

i dont know what it means by "Switch to "Preview" on this description"

openapi-workflow-bot · 2023-02-28T20:16:46Z

Hi @grizzlytheodore, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

openapi-workflow-bot · 2023-02-28T20:16:46Z

Hi @grizzlytheodore, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

change x-ms-enum name

940ed5d

grizzlytheodore requested review from Sandido, dkulkarni-ms, haagha, madewithsmiles, MS-syh2qs and hyonholee as code owners February 28, 2023 20:04

openapi-assignment-bot bot assigned ArcturusZhang Feb 28, 2023

ghost added the Compute label Feb 28, 2023

azure-sdk mentioned this pull request Feb 28, 2023

[AutoPR sdk/resourcemanager/compute/armcompute] fix SDK generating error for Compute azure-sdk/azure-sdk-for-go#4623

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Feb 28, 2023

AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-FixRequiredOnFailure resource-manager labels Feb 28, 2023

azure-sdk mentioned this pull request Feb 28, 2023

[AutoPR @azure/arm-compute] fix SDK generating error for Compute azure-sdk/azure-sdk-for-js#4096

Closed

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Feb 28, 2023

grizzlytheodore closed this Mar 1, 2023

grizzlytheodore deleted the feature/cplat-fixComputeSDKGen branch March 24, 2023 15:41

JenGoldstrich mentioned this pull request Apr 17, 2023

2022-03-03 Compute/GalleryRP StorageAccountType Swagger failing #23588

Closed

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix SDK generating error for Compute #22829

fix SDK generating error for Compute #22829

grizzlytheodore commented Feb 28, 2023 •

edited

Loading

openapi-workflow-bot bot commented Feb 28, 2023

openapi-pipeline-app bot commented Feb 28, 2023 •

edited

Loading

openapi-pipeline-app bot commented Feb 28, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Feb 28, 2023 •

edited

Loading

grizzlytheodore commented Feb 28, 2023

openapi-workflow-bot bot commented Feb 28, 2023

openapi-workflow-bot bot commented Feb 28, 2023

fix SDK generating error for Compute #22829

fix SDK generating error for Compute #22829

Conversation

grizzlytheodore commented Feb 28, 2023 • edited Loading

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 28, 2023

openapi-pipeline-app bot commented Feb 28, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 28, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Feb 28, 2023 • edited Loading

Generated ApiView

grizzlytheodore commented Feb 28, 2023

openapi-workflow-bot bot commented Feb 28, 2023

openapi-workflow-bot bot commented Feb 28, 2023

grizzlytheodore commented Feb 28, 2023 •

edited

Loading

openapi-pipeline-app bot commented Feb 28, 2023 •

edited

Loading

openapi-pipeline-app bot commented Feb 28, 2023 •

edited

Loading

openapi-pipeline-app bot commented Feb 28, 2023 •

edited

Loading