Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.HybridCompute to add version preview/2023-03-15-preview #22933

Conversation

dkirby017
Copy link
Member

@dkirby017 dkirby017 commented Mar 6, 2023

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?

    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
    March

  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
    March

  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @dkirby017 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 6, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 10 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    HybridCompute.json 2023-03-15-preview(08b2819) 2022-11-10(main)
    HybridCompute.json 2023-03-15-preview(08b2819) 2022-12-27-preview(main)
    privateLinkScopes.json 2023-03-15-preview(08b2819) 2022-11-10(main)
    privateLinkScopes.json 2023-03-15-preview(08b2819) 2022-12-27-preview(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Rule Message
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L54:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L54:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L110:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L107:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L166:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L160:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L213:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L204:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L351:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L339:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L418:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L403:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L500:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L482:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L573:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L552:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L629:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L605:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L694:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L667:11
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 6 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-preview-2023-03 package-preview-2023-03(08b2819) default(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    ⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'HybridIdentityMetadataModel'. Consider using the plural form of 'HybridIdentityMetadata' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L965
    ⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'HybridIdentityMetadataModel'. Consider using the plural form of 'HybridIdentityMetadata' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L1026
    ⚠️ PageableOperation Based on the response model schema, operation 'AgentVersion_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L1078
    ⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'AgentVersionModel'. Consider using the plural form of 'AgentVersion' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L1082
    ⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'AgentVersionModel'. Consider using the plural form of 'AgentVersion' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L1122
    ⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: GET Agent Versions
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L1157


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ResourceNameRestriction The resource name parameter 'extensionName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L340
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L341
    LongRunningResponseStatusCode A 'put' operation 'MachineExtensions_CreateOrUpdate' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 201.
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L341
    CreateOperationAsyncResponseValidation An async PUT operation must return 201.
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L384
    CreateOperationAsyncResponseValidation Only 201 is the supported response code for PUT async response.
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L391
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L391
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L490
    PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L678
    BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'Machine' has extra properties ['resources'].
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L1710
    ArmResourcePropertiesBag Top level property names should not be repeated inside the properties bag for ARM resource 'MachineExtension'. Properties [properties.type] conflict with ARM top level properties. Please rename these.
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L1817
    ResourceNameRestriction The resource name parameter 'scopeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/privateLinkScopes.json#L115
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/privateLinkScopes.json#L116
    LongRunningResponseStatusCode A 'delete' operation 'PrivateLinkScopes_Delete' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 204.
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/privateLinkScopes.json#L116
    ResourceNameRestriction The resource name parameter 'scopeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/privateLinkScopes.json#L311
    ResourceNameRestriction The resource name parameter 'scopeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/privateLinkScopes.json#L356
    ResourceNameRestriction The resource name parameter 'groupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/privateLinkScopes.json#L356
    ResourceNameRestriction The resource name parameter 'scopeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/privateLinkScopes.json#L401
    ResourceNameRestriction The resource name parameter 'privateEndpointConnectionName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/privateLinkScopes.json#L401
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/privateLinkScopes.json#L449
    CreateOperationAsyncResponseValidation An async PUT operation must return 201.
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/privateLinkScopes.json#L484
    CreateOperationAsyncResponseValidation Only 201 is the supported response code for PUT async response.
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/privateLinkScopes.json#L491
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/privateLinkScopes.json#L491
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/privateLinkScopes.json#L508
    ResourceNameRestriction The resource name parameter 'scopeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/privateLinkScopes.json#L575
    PathForNestedResource The path for nested resource doest not meet the valid resource pattern.
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/privateLinkScopes.json#L659
    ResourceNameRestriction The resource name parameter 'machineName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/privateLinkScopes.json#L659
    ⚠️ PutRequestResponseScheme A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Machines_CreateOrUpdate' Request Model: 'parameters[4].schema' Response Model: 'responses[200].schema'
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L38
    ⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List Machines by resource group
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L330
    ⚠️ PutRequestResponseScheme A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'MachineExtensions_CreateOrUpdate' Request Model: 'parameters[3].schema' Response Model: 'responses[200].schema'
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L341
    ⚠️ XmsLongRunningOperationOptions The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation.
    Location: Microsoft.HybridCompute/preview/2023-03-15-preview/HybridCompute.json#L341
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌~[Staging] ServiceAPIReadinessTest: 44 Errors, 0 Warnings failed [Detail]

    Tag package-preview-2023-03; Prod region: Deployed

    Test run on region: westcentralus; Operation coverage: total: 34, untested: 0, failed: 26, passed: 8

    Service API Readiness Test failed. Check pipeline artifact for detail report.

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    CLIENT_ERROR statusCode: 400,
    errorCode: undefined,
    errorMessage: undefined
    Source: runtime
    OperationId: Machines_CreateOrUpdate
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: code
    Source: response
    OperationId: Machines_CreateOrUpdate
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: message
    Source: response
    OperationId: Machines_CreateOrUpdate
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: target
    Source: response
    OperationId: Machines_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.HybridCompute/machines/machinenm57d3h' under resource group 'apiTest-Dcwazl-22933' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: Machines_Get
    CLIENT_ERROR statusCode: 404,
    errorCode: PatchResourceNotFound,
    errorMessage: The resource '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-Dcwazl-22933/providers/Microsoft.HybridCompute/machines/machinenm57d3h' was not found when evaluating policies for a PATCH operation.
    Source: runtime
    OperationId: Machines_Update
    CLIENT_ERROR statusCode: 400,
    errorCode: undefined,
    errorMessage: undefined
    Source: runtime
    OperationId: PrivateLinkScopes_CreateOrUpdate
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: code
    Source: response
    OperationId: PrivateLinkScopes_CreateOrUpdate
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: message
    Source: response
    OperationId: PrivateLinkScopes_CreateOrUpdate
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: target
    Source: response
    OperationId: PrivateLinkScopes_CreateOrUpdate
    CLIENT_ERROR statusCode: 400,
    errorCode: undefined,
    errorMessage: undefined
    Source: runtime
    OperationId: PrivateLinkScopes_GetValidationDetails
    INVALID_CONTENT_TYPE Invalid Content-Type (application/problem+json). These are supported: application/json
    Source: response
    OperationId: PrivateLinkScopes_GetValidationDetails
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: type
    Source: response
    OperationId: PrivateLinkScopes_GetValidationDetails
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: title
    Source: response
    OperationId: PrivateLinkScopes_GetValidationDetails
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: status
    Source: response
    OperationId: PrivateLinkScopes_GetValidationDetails
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: traceId
    Source: response
    OperationId: PrivateLinkScopes_GetValidationDetails
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: errors
    Source: response
    OperationId: PrivateLinkScopes_GetValidationDetails
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.HybridCompute/privateLinkScopes/scopenam4s5r91' under resource group 'apiTest-Dcwazl-22933' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: PrivateLinkScopes_Get
    CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'machinenm57d3h' not found.
    Source: runtime
    OperationId: PrivateLinkScopes_GetValidationDetailsForMachine
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.HybridCompute/privateLinkScopes/scopenam4s5r91' under resource group 'apiTest-Dcwazl-22933' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: PrivateLinkScopes_UpdateTags
    CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'machinenm57d3h' not found.
    Source: runtime
    OperationId: MachineExtensions_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'machinenm57d3h' not found.
    Source: runtime
    OperationId: MachineExtensions_List
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.HybridCompute/machines/machinenm57d3h/extensions/extensio5thlte' under resource group 'apiTest-Dcwazl-22933' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: MachineExtensions_Get
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.HybridCompute/machines/machinenm57d3h/extensions/extensio5thlte' under resource group 'apiTest-Dcwazl-22933' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: MachineExtensions_Update
    CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'scopenam4s5r91' not found.
    Source: runtime
    OperationId: PrivateEndpointConnections_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'scopenam4s5r91' not found.
    Source: runtime
    OperationId: PrivateEndpointConnections_ListByPrivateLinkScope
    CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'scopenam4s5r91' not found.
    Source: runtime
    OperationId: PrivateEndpointConnections_Get
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.HybridCompute/osType/agentVersions/read' over scope '/providers/Microsoft.HybridCompute/osType/ostypeyf6gjl' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: AgentVersion_List
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.HybridCompute/osType/agentVersions/read' over scope '/providers/Microsoft.HybridCompute/osType/ostypeyf6gjl/agentVersions/versionyrfeuj' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: AgentVersion_Get
    CLIENT_ERROR statusCode: 404,
    errorCode: undefined,
    errorMessage: undefined
    Source: runtime
    OperationId: ExtensionMetadata_List
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 6, 2023

    Swagger Generation Artifacts

    ️🔄ApiDocPreview inProgress [Detail]
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking


    azure-sdk-for-python-track2 - track2_azure-mgmt-hybridcompute - 8.0.0
    +	Model Machine no longer has parameter properties
    +	Model MachineExtension no longer has parameter properties
    +	Model MachineExtensionUpdate no longer has parameter properties
    +	Model MachineUpdate no longer has parameter properties
    azure-sdk-for-js - @azure/arm-hybridcompute - 4.0.0-beta.1
    +	Interface MachineExtensionsListNextOptionalParams no longer has parameter expand
    ️⌛ azure-sdk-for-net-track2 pending [Detail]
    ️⌛ azure-sdk-for-python-track2 pending [Detail]
    ️⌛ azure-sdk-for-java pending [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 6, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/hybridcompute/armhybridcompute https://apiview.dev/Assemblies/Review/0fa97ba27a6b4186967fd04024fb1e0b
    JavaScript @azure/arm-hybridcompute https://apiview.dev/Assemblies/Review/3fec467b3f874743a1acdaac0f71b832

    @ghost ghost added the ArcReview label Mar 6, 2023
    @openapi-workflow-bot
    Copy link

    Hi @dkirby017 and @arcboard, one or more change(s) have been detected in your Arc enabled VM's or Arc enabled Server's RPs. Please review the changes and ensure that no gaps have been introduced with respect to the ARM API modeling consistency across Azure Arc and Azure Compute. For further details, see guidelines at Consistency in ARM Modeling. To approve the change(s), set the label to ArcSignedOff. If you have any questions, please mail to arcboard@microsoft.com.

    @AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required new-api-version resource-manager labels Mar 6, 2023
    @openapi-workflow-bot
    Copy link

    Hi @dkirby017, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @dkirby017 dkirby017 marked this pull request as ready for review March 6, 2023 20:11
    @jianyunt
    Copy link
    Contributor

    Thanks @raych1 thanks @XiaofeiCao , we reviewed this PR and ArcSignedOff. Could you please merge it? thanks!


    In reply to: 1507744922

    @raych1
    Copy link
    Member

    raych1 commented Apr 17, 2023

    @XiaofeiCao , please hold off this PR merge until ArcSignedOff label is added. For the PR labelled with ArcReview, it needs Arc review board review and sign off.

    Yes, that's supposed to be if ArcReview is added.

    @XiaofeiCao
    Copy link
    Contributor

    @tadelesh Please help review Go breaking change, thanks!

    @XiaofeiCao
    Copy link
    Contributor

    @MaryGao @qiaozha Please help review js breaking change, thanks!

    @XiaofeiCao
    Copy link
    Contributor

    @msyyc Please help review python breaking change, thanks!

    @tadelesh tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Apr 17, 2023
    @tadelesh
    Copy link
    Member

    SDK breaking changes are from this PR: #20502 and have been approved.

    Copy link
    Contributor

    @jianyunt jianyunt left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    :shipit:

    @jianyunt
    Copy link
    Contributor

    @XiaofeiCao could you please let us know what else we need to do to get this PR merged?

    @XiaofeiCao XiaofeiCao merged commit c2b02df into main Apr 20, 2023
    @XiaofeiCao XiaofeiCao deleted the dkirby017-hybridcompute-Microsoft.HybridCompute-2023-03-15-preview branch April 20, 2023 01:55
    suxi-ms pushed a commit that referenced this pull request Apr 24, 2023
    …sion preview/2023-03-15-preview (#22933)
    
    * Adds base for updating Microsoft.HybridCompute from version preview/2022-12-27-preview to version 2023-03-15-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * add HybridIdentityMetadata read-only proxy resource to new api version
    
    * add kind property to machines on the new api version
    
    * update description for kind and updated examples
    
    * update desription for kind
    
    * clear kind from examples
    
    * remove readonly from kind
    
    * small change
    
    * used v3 instead of v2
    
    * added kind to machineUpdate
    
    * testing
    
    * added get agent versions api
    
    * trigger pipeline again
    
    * fixed agent list model
    
    * fixed the get latest agent version example
    
    * added ostype and changed route
    
    * experience with agent version get for latest
    
    * ran npm prettier
    
    * unified tags and changed the agent version get description
    
    * fixed prettier check
    
    * update description
    
    * quynh changes
    
    * Added missing lastAttemptDesiredVersion
    
    * Added x-ms-identifiers for AgentVersionsList
    
    * Removed kind in Machine_Update.json
    
    * ran prettier
    
    ---------
    
    Co-authored-by: dorothyhu <jinahu@microsoft.com>
    Co-authored-by: Shubham Malhotra <shmalhotra@microsoft.com>
    Co-authored-by: Donald Liu <donaliu@microsoft.com>
    JoshLove-msft pushed a commit to JoshLove-msft/azure-rest-api-specs that referenced this pull request Apr 25, 2023
    …sion preview/2023-03-15-preview (Azure#22933)
    
    * Adds base for updating Microsoft.HybridCompute from version preview/2022-12-27-preview to version 2023-03-15-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * add HybridIdentityMetadata read-only proxy resource to new api version
    
    * add kind property to machines on the new api version
    
    * update description for kind and updated examples
    
    * update desription for kind
    
    * clear kind from examples
    
    * remove readonly from kind
    
    * small change
    
    * used v3 instead of v2
    
    * added kind to machineUpdate
    
    * testing
    
    * added get agent versions api
    
    * trigger pipeline again
    
    * fixed agent list model
    
    * fixed the get latest agent version example
    
    * added ostype and changed route
    
    * experience with agent version get for latest
    
    * ran npm prettier
    
    * unified tags and changed the agent version get description
    
    * fixed prettier check
    
    * update description
    
    * quynh changes
    
    * Added missing lastAttemptDesiredVersion
    
    * Added x-ms-identifiers for AgentVersionsList
    
    * Removed kind in Machine_Update.json
    
    * ran prettier
    
    ---------
    
    Co-authored-by: dorothyhu <jinahu@microsoft.com>
    Co-authored-by: Shubham Malhotra <shmalhotra@microsoft.com>
    Co-authored-by: Donald Liu <donaliu@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript Approved-SdkBreakingChange-Python ArcReview ArcSignedOff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.