MFE April 2023 staging #23164
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2752,4 +2752,3 @@ remediatable | |
| Overprovisioning | ||
| Unprepares | ||
| Unpreparing | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -102,6 +102,10 @@ | |
| } | ||
| } | ||
| }, | ||
| "202": { | ||
| "headers": { | ||
| "Location": "example_location" | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -97,6 +97,10 @@ | |
| } | ||
| } | ||
| }, | ||
| "202": { | ||
| "headers": { | ||
| "Location": "example_location" | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "testrg123", | ||
| "registryName": "testregistry", | ||
| "api-version": "2023-04-01", | ||
| "codeName": "testContainer", | ||
| "body": { | ||
| "properties": { | ||
| "description": "string", | ||
| "tags": { | ||
| "tag1": "value1", | ||
| "tag2": "value2" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg123/providers/Microsoft.MachineLearningServices/registries/testregistry/codes/testContainer", | ||
| "name": "testContainer", | ||
| "type": "Microsoft.MachineLearningServices/registries/codes", | ||
| "properties": { | ||
| "description": "string", | ||
| "tags": { | ||
| "property1": "string", | ||
| "property2": "string" | ||
| } | ||
| }, | ||
| "systemData": { | ||
| "createdAt": "2020-12-01T12:00:00.000Z", | ||
| "createdBy": "John Smith", | ||
| "createdByType": "User", | ||
| "lastModifiedAt": "2020-12-01T12:00:00.000Z", | ||
| "lastModifiedBy": "John Smith", | ||
| "lastModifiedByType": "User" | ||
| } | ||
| } | ||
| }, | ||
| "201": { | ||
| "body": { | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg123/providers/Microsoft.MachineLearningServices/registries/testregistry/codes/testContainer", | ||
| "name": "testContainer", | ||
| "type": "Microsoft.MachineLearningServices/registries/codes", | ||
| "properties": { | ||
| "description": "string", | ||
| "tags": { | ||
| "property1": "string", | ||
| "property2": "string" | ||
| } | ||
| }, | ||
| "systemData": { | ||
| "createdAt": "2020-12-01T12:00:00.000Z", | ||
| "createdBy": "John Smith", | ||
| "createdByType": "User", | ||
| "lastModifiedAt": "2020-12-01T12:00:00.000Z", | ||
| "lastModifiedBy": "John Smith", | ||
| "lastModifiedByType": "User" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "testrg123", | ||
| "registryName": "testregistry", | ||
| "api-version": "2023-04-01", | ||
| "codeName": "testContainer" | ||
| }, | ||
| "responses": { | ||
| "200": {}, | ||
| "202": { | ||
| "headers": { | ||
| "Location": "example_location" | ||
| } | ||
| }, | ||
| "204": {} | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "testrg123", | ||
| "registryName": "testregistry", | ||
| "api-version": "2023-04-01", | ||
| "codeName": "testContainer" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg123/providers/Microsoft.MachineLearningServices/registries/testworkspace/codes/testContainer", | ||
| "name": "testContainer", | ||
| "type": "Microsoft.MachineLearningServices/registries/codes", | ||
| "properties": { | ||
| "description": "string", | ||
| "tags": { | ||
|
There was a problem hiding this comment. ok to answer this question and the question above, we have a legacy exception to use tags at the property level. But it's only for our "assets"-code/model/etc and job types There was a problem hiding this comment. ARm will not be able to use these tags I dont think policy etc will work with this scheme There was a problem hiding this comment. Please address the latest response. |
||
| "property1": "string", | ||
| "property2": "string" | ||
| } | ||
| }, | ||
| "systemData": { | ||
| "createdAt": "2020-12-01T12:00:00.000Z", | ||
| "createdBy": "John Smith", | ||
| "createdByType": "User", | ||
| "lastModifiedAt": "2020-08-01T12:00:00.000Z", | ||
| "lastModifiedBy": "John Smith", | ||
| "lastModifiedByType": "User" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is tags inside of properties? This isn't normal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please address this?