Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging new API version from private repo https://github.com/Azure/azure-rest-api-specs-pr/blob/RPSaaSMaster/specification/scvmm/resource-manager/Microsoft.ScVmm/preview/2022-05-21-preview #23277

Merged
merged 15 commits into from
Apr 20, 2023
Merged

Merging new API version from private repo https://github.com/Azure/azure-rest-api-specs-pr/blob/RPSaaSMaster/specification/scvmm/resource-manager/Microsoft.ScVmm/preview/2022-05-21-preview #23277

merged 15 commits into from
Apr 20, 2023

Conversation

miniagarwal0910
Copy link
Contributor

@miniagarwal0910 miniagarwal0910 commented Mar 24, 2023 •
edited
Loading

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

Additional Information

The first commit Adding new api version as it is from azure-rest-api-specs-pr (RPSaaSM…
is the base commit copied as it is from the private repo.

private repo for the base commit

@openapi-workflow-bot
Copy link

Hi, @miniagarwal0910 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 24, 2023 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    compared swaggers (via Oad v0.10.4)] new version base version
    scvmm.json 2022-05-21-preview(f5150be) 2020-06-05-preview(main)
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️LintDiff: 5 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2022-05-21-preview package-2022-05-21-preview(f5150be) default(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.ScVmm/preview/2022-05-21-preview/scvmm.json#L1186
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.ScVmm/preview/2022-05-21-preview/scvmm.json#L5208
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.ScVmm/preview/2022-05-21-preview/scvmm.json#L5212
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.ScVmm/preview/2022-05-21-preview/scvmm.json#L5260
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.ScVmm/preview/2022-05-21-preview/scvmm.json#L5264


    The following errors/warnings exist before current PR submission:

    Rule Message
    ❌ XmsParameterLocation The parameter 'SubscriptionIdParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
    Location: Microsoft.ScVmm/preview/2022-05-21-preview/scvmm.json#L5600
    ❌ XmsParameterLocation The parameter 'ApiVersionParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
    Location: Microsoft.ScVmm/preview/2022-05-21-preview/scvmm.json#L5615
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.ScVmm/preview/2022-05-21-preview/scvmm.json#L176
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.ScVmm/preview/2022-05-21-preview/scvmm.json#L532
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.ScVmm/preview/2022-05-21-preview/scvmm.json#L852
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.ScVmm/preview/2022-05-21-preview/scvmm.json#L1172
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.ScVmm/preview/2022-05-21-preview/scvmm.json#L1179
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.ScVmm/preview/2022-05-21-preview/scvmm.json#L1838
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.ScVmm/preview/2022-05-21-preview/scvmm.json#L2164
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.ScVmm/preview/2022-05-21-preview/scvmm.json#L4444
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ScVmm/preview/2022-05-21-preview/scvmm.json#L4587
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌~[Staging] ServiceAPIReadinessTest: 40 Errors, 0 Warnings failed [Detail]

    Tag package-2022-05-21-preview; Prod region: Not deployed; Canary region: Deployed

    Test run on region: eastus2euap; Operation coverage: total: 60, untested: 0, failed: 40, passed: 20

    Service API Readiness Test failed. Check pipeline artifact for detail report.

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ CLIENT_ERROR statusCode: 403,
    errorCode: LinkedAuthorizationFailed,
    errorMessage: The client has permission to perform action 'Microsoft.ExtendedLocation/customLocations/deploy/action' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-ojaFsd-23277/providers/Microsoft.ScVmm/virtualMachines/virtualmwgm2lf', however the linked subscription 'a5015e1c-867f-4533-8541-85cd470d0cfb' was not found.
    Source: runtime
    OperationId: VirtualMachines_CreateOrUpdate
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ScVmm/VirtualMachines/virtualmwgm2lf' under resource group 'apiTest-ojaFsd-23277' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: VirtualMachines_Get
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ScVmm/VirtualMachines/virtualmwgm2lf' under resource group 'apiTest-ojaFsd-23277' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: VirtualMachines_Update
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ScVmm/VirtualMachines/virtualmwgm2lf' under resource group 'apiTest-ojaFsd-23277' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: VirtualMachines_DeleteCheckpoint
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ScVmm/VirtualMachines/virtualmwgm2lf' under resource group 'apiTest-ojaFsd-23277' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: VirtualMachines_Restart
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ScVmm/VirtualMachines/virtualmwgm2lf' under resource group 'apiTest-ojaFsd-23277' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: VirtualMachines_CreateCheckpoint
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ScVmm/VirtualMachines/virtualmwgm2lf' under resource group 'apiTest-ojaFsd-23277' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: VirtualMachines_RestoreCheckpoint
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ScVmm/VirtualMachines/virtualmwgm2lf' under resource group 'apiTest-ojaFsd-23277' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: VirtualMachines_Stop
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ScVmm/VirtualMachines/virtualmwgm2lf' under resource group 'apiTest-ojaFsd-23277' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: VirtualMachines_Start
    ❌ CLIENT_ERROR statusCode: 403,
    errorCode: LinkedAuthorizationFailed,
    errorMessage: The client has permission to perform action 'Microsoft.ExtendedLocation/customLocations/deploy/action' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-ojaFsd-23277/providers/Microsoft.ScVmm/vmmServers/vmmserve7l7vdd', however the linked subscription 'a5015e1c-867f-4533-8541-85cd470d0cfb' was not found.
    Source: runtime
    OperationId: VmmServers_CreateOrUpdate
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ScVmm/VMMServers/vmmserve7l7vdd' under resource group 'apiTest-ojaFsd-23277' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: VmmServers_Get
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ScVmm/VMMServers/vmmserve7l7vdd' under resource group 'apiTest-ojaFsd-23277' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: VmmServers_Update
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'virtualmwgm2lf' not found.
    Source: runtime
    OperationId: MachineExtensions_CreateOrUpdate
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ScVmm/VirtualMachines/virtualmwgm2lf/Extensions/extensiovx71t9' under resource group 'apiTest-ojaFsd-23277' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: MachineExtensions_Get
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ScVmm/VirtualMachines/virtualmwgm2lf/Extensions/extensiovx71t9' under resource group 'apiTest-ojaFsd-23277' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: MachineExtensions_Update
    ❌ CLIENT_ERROR statusCode: 403,
    errorCode: LinkedAuthorizationFailed,
    errorMessage: The client has permission to perform action 'Microsoft.ExtendedLocation/customLocations/deploy/action' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-ojaFsd-23277/providers/Microsoft.ScVmm/clouds/cloudnam0ej8ug', however the linked subscription 'a5015e1c-867f-4533-8541-85cd470d0cfb' was not found.
    Source: runtime
    OperationId: Clouds_CreateOrUpdate
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ScVmm/Clouds/cloudnam0ej8ug' under resource group 'apiTest-ojaFsd-23277' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: Clouds_Get
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ScVmm/Clouds/cloudnam0ej8ug' under resource group 'apiTest-ojaFsd-23277' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: Clouds_Update
    ❌ CLIENT_ERROR statusCode: 403,
    errorCode: LinkedAuthorizationFailed,
    errorMessage: The client has permission to perform action 'Microsoft.ExtendedLocation/customLocations/deploy/action' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-ojaFsd-23277/providers/Microsoft.ScVmm/virtualMachineTemplates/virtualmm8wjlr', however the linked subscription 'a5015e1c-867f-4533-8541-85cd470d0cfb' was not found.
    Source: runtime
    OperationId: VirtualMachineTemplates_CreateOrUpdate
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ScVmm/VirtualMachineTemplates/virtualmm8wjlr' under resource group 'apiTest-ojaFsd-23277' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: VirtualMachineTemplates_Get
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ScVmm/VirtualMachineTemplates/virtualmm8wjlr' under resource group 'apiTest-ojaFsd-23277' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: VirtualMachineTemplates_Update
    ❌ CLIENT_ERROR statusCode: 403,
    errorCode: LinkedAuthorizationFailed,
    errorMessage: The client has permission to perform action 'Microsoft.ExtendedLocation/customLocations/deploy/action' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-ojaFsd-23277/providers/Microsoft.ScVmm/virtualNetworks/virtualnwtizvf', however the linked subscription 'a5015e1c-867f-4533-8541-85cd470d0cfb' was not found.
    Source: runtime
    OperationId: VirtualNetworks_CreateOrUpdate
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ScVmm/VirtualNetworks/virtualnwtizvf' under resource group 'apiTest-ojaFsd-23277' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: VirtualNetworks_Get
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ScVmm/VirtualNetworks/virtualnwtizvf' under resource group 'apiTest-ojaFsd-23277' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: VirtualNetworks_Update
    ❌ CLIENT_ERROR statusCode: 400,
    errorCode: InvalidCustomLocationId,
    errorMessage: The specified extended location name '/subscriptions/a5015e1c-867f-4533-8541-85cd470d0cfb/resourceGroups/demoRG/providers/Microsoft.Arc/customLocations/contoso' is invalid. A custom location ID must have the format of '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupsName}/providers/Microsoft.ExtendedLocation/customLocations/{name}'.
    Source: runtime
    OperationId: AvailabilitySets_CreateOrUpdate
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ScVmm/AvailabilitySets/availabivckyhb' under resource group 'apiTest-ojaFsd-23277' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: AvailabilitySets_Get
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ScVmm/AvailabilitySets/availabivckyhb' under resource group 'apiTest-ojaFsd-23277' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: AvailabilitySets_Update
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'virtualmwgm2lf' not found.
    Source: runtime
    OperationId: GuestAgents_Create
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'virtualmwgm2lf' not found.
    Source: runtime
    OperationId: GuestAgents_ListByVm
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'virtualmwgm2lf' not found.
    Source: runtime
    OperationId: GuestAgents_Get
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand] 
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 24, 2023 •
    edited
    Loading

    Swagger Generation Artifacts

    ️🔄ApiDocPreview inProgress [Detail]
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-js - @azure/arm-scvmm - Approved - 1.0.0-beta.4
    +	Interface InventoryItem no longer has parameter systemData


    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 9a8bb3f. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.5
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.5>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.5` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-scvmm [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation group GuestAgentsOperations
info	[Changelog]   - Added operation group HybridIdentityMetadatasOperations
info	[Changelog]   - Added operation group MachineExtensionsOperations
info	[Changelog]   - Model ProxyResource has a new parameter system_data
info	[Changelog]   - Model Resource has a new parameter system_data
info	[Changelog]   - Model VirtualMachine has a new parameter guest_agent_profile
info	[Changelog]   - Model VirtualMachine has a new parameter identity
info	[Changelog]   - Model VirtualMachine has a new parameter last_restored_vm_checkpoint
info	[Changelog]   - Model VirtualMachineUpdate has a new parameter identity
info	[Changelog]   - Model VirtualMachineUpdateProperties has a new parameter checkpoint_type
info	[Changelog]   - Operation VirtualMachinesOperations.begin_delete has a new optional parameter delete_from_host
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 9a8bb3f. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-scvmm [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 9a8bb3f. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/scvmm/armscvmm [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New enum type `IdentityType` with values `IdentityTypeNone`, `IdentityTypeSystemAssigned`
info	[Changelog] - New enum type `ProvisioningAction` with values `ProvisioningActionInstall`, `ProvisioningActionRepair`, `ProvisioningActionUninstall`
info	[Changelog] - New enum type `StatusLevelTypes` with values `StatusLevelTypesError`, `StatusLevelTypesInfo`, `StatusLevelTypesWarning`
info	[Changelog] - New enum type `StatusTypes` with values `StatusTypesConnected`, `StatusTypesDisconnected`, `StatusTypesError`
info	[Changelog] - New function `*ClientFactory.NewGuestAgentsClient() *GuestAgentsClient`
info	[Changelog] - New function `*ClientFactory.NewHybridIdentityMetadatasClient() *HybridIdentityMetadatasClient`
info	[Changelog] - New function `*ClientFactory.NewMachineExtensionsClient() *MachineExtensionsClient`
info	[Changelog] - New function `NewGuestAgentsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*GuestAgentsClient, error)`
info	[Changelog] - New function `*GuestAgentsClient.BeginCreate(context.Context, string, string, string, *GuestAgentsClientBeginCreateOptions) (*runtime.Poller[GuestAgentsClientCreateResponse], error)`
info	[Changelog] - New function `*GuestAgentsClient.BeginDelete(context.Context, string, string, string, *GuestAgentsClientBeginDeleteOptions) (*runtime.Poller[GuestAgentsClientDeleteResponse], error)`
info	[Changelog] - New function `*GuestAgentsClient.Get(context.Context, string, string, string, *GuestAgentsClientGetOptions) (GuestAgentsClientGetResponse, error)`
info	[Changelog] - New function `*GuestAgentsClient.NewListByVMPager(string, string, *GuestAgentsClientListByVMOptions) *runtime.Pager[GuestAgentsClientListByVMResponse]`
info	[Changelog] - New function `NewHybridIdentityMetadatasClient(string, azcore.TokenCredential, *arm.ClientOptions) (*HybridIdentityMetadatasClient, error)`
info	[Changelog] - New function `*HybridIdentityMetadatasClient.Create(context.Context, string, string, string, *HybridIdentityMetadatasClientCreateOptions) (HybridIdentityMetadatasClientCreateResponse, error)`
info	[Changelog] - New function `*HybridIdentityMetadatasClient.Delete(context.Context, string, string, string, *HybridIdentityMetadatasClientDeleteOptions) (HybridIdentityMetadatasClientDeleteResponse, error)`
info	[Changelog] - New function `*HybridIdentityMetadatasClient.Get(context.Context, string, string, string, *HybridIdentityMetadatasClientGetOptions) (HybridIdentityMetadatasClientGetResponse, error)`
info	[Changelog] - New function `*HybridIdentityMetadatasClient.NewListByVMPager(string, string, *HybridIdentityMetadatasClientListByVMOptions) *runtime.Pager[HybridIdentityMetadatasClientListByVMResponse]`
info	[Changelog] - New function `NewMachineExtensionsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*MachineExtensionsClient, error)`
info	[Changelog] - New function `*MachineExtensionsClient.BeginCreateOrUpdate(context.Context, string, string, string, MachineExtension, *MachineExtensionsClientBeginCreateOrUpdateOptions) (*runtime.Poller[MachineExtensionsClientCreateOrUpdateResponse], error)`
info	[Changelog] - New function `*MachineExtensionsClient.BeginDelete(context.Context, string, string, string, *MachineExtensionsClientBeginDeleteOptions) (*runtime.Poller[MachineExtensionsClientDeleteResponse], error)`
info	[Changelog] - New function `*MachineExtensionsClient.Get(context.Context, string, string, string, *MachineExtensionsClientGetOptions) (MachineExtensionsClientGetResponse, error)`
info	[Changelog] - New function `*MachineExtensionsClient.NewListPager(string, string, *MachineExtensionsClientListOptions) *runtime.Pager[MachineExtensionsClientListResponse]`
info	[Changelog] - New function `*MachineExtensionsClient.BeginUpdate(context.Context, string, string, string, MachineExtensionUpdate, *MachineExtensionsClientBeginUpdateOptions) (*runtime.Poller[MachineExtensionsClientUpdateResponse], error)`
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `GuestAgent`
info	[Changelog] - New struct `GuestAgentList`
info	[Changelog] - New struct `GuestAgentProfile`
info	[Changelog] - New struct `GuestAgentProperties`
info	[Changelog] - New struct `GuestCredential`
info	[Changelog] - New struct `HTTPProxyConfiguration`
info	[Changelog] - New struct `HybridIdentityMetadata`
info	[Changelog] - New struct `HybridIdentityMetadataList`
info	[Changelog] - New struct `HybridIdentityMetadataProperties`
info	[Changelog] - New struct `Identity`
info	[Changelog] - New struct `MachineExtension`
info	[Changelog] - New struct `MachineExtensionInstanceView`
info	[Changelog] - New struct `MachineExtensionInstanceViewStatus`
info	[Changelog] - New struct `MachineExtensionProperties`
info	[Changelog] - New struct `MachineExtensionPropertiesInstanceView`
info	[Changelog] - New struct `MachineExtensionUpdate`
info	[Changelog] - New struct `MachineExtensionUpdateProperties`
info	[Changelog] - New struct `MachineExtensionsListResult`
info	[Changelog] - New struct `TrackedResource`
info	[Changelog] - New field `SystemData` in struct `ProxyResource`
info	[Changelog] - New field `SystemData` in struct `Resource`
info	[Changelog] - New field `Identity` in struct `VirtualMachine`
info	[Changelog] - New field `GuestAgentProfile`, `LastRestoredVMCheckpoint` in struct `VirtualMachineProperties`
info	[Changelog] - New field `Identity` in struct `VirtualMachineUpdate`
info	[Changelog] - New field `CheckpointType` in struct `VirtualMachineUpdateProperties`
info	[Changelog] - New field `DeleteFromHost` in struct `VirtualMachinesClientBeginDeleteOptions`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 83 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 9a8bb3f. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-scvmm [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group GuestAgents
info	[Changelog]   - Added operation group HybridIdentityMetadatas
info	[Changelog]   - Added operation group MachineExtensions
info	[Changelog]   - Added Interface ErrorAdditionalInfo
info	[Changelog]   - Added Interface ErrorDetail
info	[Changelog]   - Added Interface GuestAgent
info	[Changelog]   - Added Interface GuestAgentList
info	[Changelog]   - Added Interface GuestAgentProfile
info	[Changelog]   - Added Interface GuestAgentsCreateOptionalParams
info	[Changelog]   - Added Interface GuestAgentsDeleteOptionalParams
info	[Changelog]   - Added Interface GuestAgentsGetOptionalParams
info	[Changelog]   - Added Interface GuestAgentsListByVmNextOptionalParams
info	[Changelog]   - Added Interface GuestAgentsListByVmOptionalParams
info	[Changelog]   - Added Interface GuestCredential
info	[Changelog]   - Added Interface HttpProxyConfiguration
info	[Changelog]   - Added Interface HybridIdentityMetadata
info	[Changelog]   - Added Interface HybridIdentityMetadataList
info	[Changelog]   - Added Interface HybridIdentityMetadatasCreateOptionalParams
info	[Changelog]   - Added Interface HybridIdentityMetadatasDeleteOptionalParams
info	[Changelog]   - Added Interface HybridIdentityMetadatasGetOptionalParams
info	[Changelog]   - Added Interface HybridIdentityMetadatasListByVmNextOptionalParams
info	[Changelog]   - Added Interface HybridIdentityMetadatasListByVmOptionalParams
info	[Changelog]   - Added Interface Identity
info	[Changelog]   - Added Interface MachineExtension
info	[Changelog]   - Added Interface MachineExtensionInstanceView
info	[Changelog]   - Added Interface MachineExtensionInstanceViewStatus
info	[Changelog]   - Added Interface MachineExtensionPropertiesInstanceView
info	[Changelog]   - Added Interface MachineExtensionsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface MachineExtensionsDeleteOptionalParams
info	[Changelog]   - Added Interface MachineExtensionsGetOptionalParams
info	[Changelog]   - Added Interface MachineExtensionsListNextOptionalParams
info	[Changelog]   - Added Interface MachineExtensionsListOptionalParams
info	[Changelog]   - Added Interface MachineExtensionsListResult
info	[Changelog]   - Added Interface MachineExtensionsUpdateHeaders
info	[Changelog]   - Added Interface MachineExtensionsUpdateOptionalParams
info	[Changelog]   - Added Interface MachineExtensionUpdate
info	[Changelog]   - Added Interface TrackedResource
info	[Changelog]   - Added Type Alias GuestAgentsCreateResponse
info	[Changelog]   - Added Type Alias GuestAgentsGetResponse
info	[Changelog]   - Added Type Alias GuestAgentsListByVmNextResponse
info	[Changelog]   - Added Type Alias GuestAgentsListByVmResponse
info	[Changelog]   - Added Type Alias HybridIdentityMetadatasCreateResponse
info	[Changelog]   - Added Type Alias HybridIdentityMetadatasGetResponse
info	[Changelog]   - Added Type Alias HybridIdentityMetadatasListByVmNextResponse
info	[Changelog]   - Added Type Alias HybridIdentityMetadatasListByVmResponse
info	[Changelog]   - Added Type Alias IdentityType
info	[Changelog]   - Added Type Alias MachineExtensionsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias MachineExtensionsGetResponse
info	[Changelog]   - Added Type Alias MachineExtensionsListNextResponse
info	[Changelog]   - Added Type Alias MachineExtensionsListResponse
info	[Changelog]   - Added Type Alias MachineExtensionsUpdateResponse
info	[Changelog]   - Added Type Alias ProvisioningAction
info	[Changelog]   - Added Type Alias StatusLevelTypes
info	[Changelog]   - Added Type Alias StatusTypes
info	[Changelog]   - Interface Resource has a new optional parameter systemData
info	[Changelog]   - Interface VirtualMachine has a new optional parameter guestAgentProfile
info	[Changelog]   - Interface VirtualMachine has a new optional parameter identity
info	[Changelog]   - Interface VirtualMachine has a new optional parameter lastRestoredVMCheckpoint
info	[Changelog]   - Interface VirtualMachinesDeleteOptionalParams has a new optional parameter deleteFromHost
info	[Changelog]   - Interface VirtualMachineUpdate has a new optional parameter identity
info	[Changelog]   - Interface VirtualMachineUpdateProperties has a new optional parameter checkpointType
info	[Changelog]   - Added Enum KnownIdentityType
info	[Changelog]   - Added Enum KnownProvisioningAction
info	[Changelog]   - Added Enum KnownStatusLevelTypes
info	[Changelog]   - Added Enum KnownStatusTypes
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Interface InventoryItem no longer has parameter systemData
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 9a8bb3f. SDK Automation 14.0.0 
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.101 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/scvmm/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
warn	No package detected after generation
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 9a8bb3f. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the ArcReview label Mar 24, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 24, 2023 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/scvmm/armscvmm https://apiview.dev/Assemblies/Review/10984a426ff94b57b488c6d3630f7727
    Java azure-resourcemanager-scvmm https://apiview.dev/Assemblies/Review/7d7e105e875b4e91b98e5233744785c2
    JavaScript @azure/arm-scvmm https://apiview.dev/Assemblies/Review/be3ebbb07d334c21b745719488ddd87b

    @openapi-workflow-bot
    Copy link

    Hi @miniagarwal0910 and @arcboard, one or more change(s) have been detected in your Arc enabled VM's or Arc enabled Server's RPs. Please review the changes and ensure that no gaps have been introduced with respect to the ARM API modeling consistency across Azure Arc and Azure Compute. For further details, see guidelines at Consistency in ARM Modeling. To approve the change(s), set the label to ArcSignedOff. If you have any questions, please mail to arcboard@microsoft.com.

    @azure-sdk azure-sdk mentioned this pull request Mar 24, 2023
    Closed
    @AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview CI-MissingBaseCommit new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 24, 2023
    @openapi-workflow-bot
    Copy link

    Hi, @miniagarwal0910, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    @miniagarwal0910 miniagarwal0910 changed the title Dev/miniagarwal0910/make swagger public 2022 05 21 Merging new API version from private repo https://github.com/Azure/azure-rest-api-specs-pr/blob/RPSaaSMaster/specification/scvmm/resource-manager/Microsoft.ScVmm/preview/2022-05-21-preview Mar 24, 2023
    @openapi-workflow-bot
    Copy link

    Hi, @miniagarwal0910 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @azure-sdk azure-sdk mentioned this pull request Mar 24, 2023
    Closed
    @raosuhas
    Copy link

    Hi, @miniagarwal0910, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    @miniagarwal0910 can you please follow the instructions here when creating a new api version for review ?

    @raosuhas raosuhas added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Mar 24, 2023
    @openapi-workflow-bot
    Copy link

    Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

    This was referenced Mar 28, 2023
    Closed
    Closed
    @miniagarwal0910
    Copy link
    Contributor Author

    Hi, @miniagarwal0910, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    @miniagarwal0910 can you please follow the instructions here when creating a new api version for review ?

    @raosuhas, The first commit Adding new api version as it is from azure-rest-api-specs-pr (RPSaaSM…
    is the base commit copied as it is from the private repo.

    private repo for the base commit

    @sidsinghms sidsinghms removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Apr 11, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 11, 2023
    @zizw123 zizw123 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Apr 12, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 12, 2023
    lirenhe
    lirenhe reviewed Apr 19, 2023
    View reviewed changes
    specification/scvmm/resource-manager/readme.ruby.md
    @@ -4,7 +4,7 @@ These settings apply only when `--ruby` is specified on the command line.

    ```yaml
    package-name: azure_mgmt_scvmm
    package-version: 2020-06-05-preview
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Please remove this file, ruby is no longer supported.

    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @lirenhe
    Removed readme.ruby.md.

    @lirenhe
    Copy link
    Member

    lirenhe commented Apr 19, 2023

    @qiaozha, could you help to check the JS breaking change in this PR?

    @lirenhe lirenhe merged commit 9a8bb3f into Azure:main Apr 20, 2023
    This was referenced Apr 20, 2023
    Closed
    Closed
    Closed
    Closed
    Closed
    suxi-ms pushed a commit that referenced this pull request Apr 24, 2023
    @miniagarwal0910 @suxi-ms
    Merging new API version from private repo https://github.com/Azure/az…
    f5d026e 
    …ure-rest-api-specs-pr/blob/RPSaaSMaster/specification/scvmm/resource-manager/Microsoft.ScVmm/preview/2022-05-21-preview (#23277)

* Adding new api version as it is from azure-rest-api-specs-pr (RPSaaSMaster)

* Update AutoRest files

* resolve spell-check and sdk failures

* resolve spell-check

* resolve sdk failures

* Remove extra spaces

* Remove extra spaces

* Remove lenient-model-Deduplication

* Update v1 to v3 in scvmm.json

* Add systemData in scvmm.json

* Remove SystemData

* Removing readme.ruby.md as ruby no longer supported

* Remove ruby reference
    JoshLove-msft pushed a commit to JoshLove-msft/azure-rest-api-specs that referenced this pull request Apr 25, 2023
    @miniagarwal0910 @JoshLove-msft
    Merging new API version from private repo https://github.com/Azure/az…
    11bf954 
    …ure-rest-api-specs-pr/blob/RPSaaSMaster/specification/scvmm/resource-manager/Microsoft.ScVmm/preview/2022-05-21-preview (Azure#23277)

* Adding new api version as it is from azure-rest-api-specs-pr (RPSaaSMaster)

* Update AutoRest files

* resolve spell-check and sdk failures

* resolve spell-check

* resolve sdk failures

* Remove extra spaces

* Remove extra spaces

* Remove lenient-model-Deduplication

* Update v1 to v3 in scvmm.json

* Add systemData in scvmm.json

* Remove SystemData

* Removing readme.ruby.md as ruby no longer supported

* Remove ruby reference
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @lirenhe lirenhe lirenhe approved these changes

    @msyyc msyyc Awaiting requested review from msyyc msyyc is a code owner

    @Wzb123456789 Wzb123456789 Awaiting requested review from Wzb123456789

    @ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang

    @qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

    Assignees

    @lirenhe lirenhe

    Labels
    Approved-SdkBreakingChange-JavaScript ArcReview ArcSignedOff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-JavaScript CI-MissingBaseCommit new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    7 participants
    @miniagarwal0910 @raosuhas @lirenhe @AzureRestAPISpecReview @qiaozha @sidsinghms @zizw123