merging billing fix to public repo

[banggaurav]

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

1. What's the purpose of the update?
   • new service onboarding
   • new API version
   • update existing version for new feature
   • update existing version to fix swagger quality issue in s360
   • Other, please clarify
2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

• I commit to follow the Breaking Change Policy of "no breaking changes"
• I have reviewed the documentation for the workflow.
• Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

• Change to data plane APIs
• Adding new properties
• All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

• Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

  • Adding a new service
  • Adding new API(s)
  • Adding a new API version
    -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

• Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

• If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

[openapi-workflow-bot]

Hi, @banggaurav Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

[openapi-pipeline-app]

Swagger Validation Report

️❌BreakingChange: 4 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
NewRelic.json	2022-07-01-preview(47f0b10)	2022-07-01-preview(main)
NewRelic.json	2022-07-01(47f0b10)	2022-07-01(main)

Rule	Message
❌ 1011 - AddingResponseCode	The new version adds a response code '200'. New: NewRelic.Observability/preview/2022-07-01-preview/NewRelic.json#L746:11
❌ 1011 - AddingResponseCode	The new version adds a response code '202'. New: NewRelic.Observability/preview/2022-07-01-preview/NewRelic.json#L752:11
❌ 1011 - AddingResponseCode	The new version adds a response code '200'. New: NewRelic.Observability/stable/2022-07-01/NewRelic.json#L746:11
❌ 1011 - AddingResponseCode	The new version adds a response code '202'. New: NewRelic.Observability/stable/2022-07-01/NewRelic.json#L752:11

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 2 Warnings warning [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
package-2022-07-01-preview	package-2022-07-01-preview(47f0b10)	package-2022-07-01-preview(main)
package-2022-07-01	package-2022-07-01(47f0b10)	package-2022-07-01(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
⚠️ LroExtension	Operations with a 202 response should specify x-ms-long-running-operation: true. Location: NewRelic.Observability/preview/2022-07-01-preview/NewRelic.json#L718
⚠️ LroExtension	Operations with a 202 response should specify x-ms-long-running-operation: true. Location: NewRelic.Observability/stable/2022-07-01/NewRelic.json#L718

The following errors/warnings exist before current PR submission:

Rule	Message
❌ OperationIdNounVerb	Per the Noun_Verb convention for Operation Ids, the noun 'Monitors' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: NewRelic.Observability/preview/2022-07-01-preview/NewRelic.json#L842
❌ OperationIdNounVerb	Per the Noun_Verb convention for Operation Ids, the noun 'Monitors' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: NewRelic.Observability/stable/2022-07-01/NewRelic.json#L842

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️❌CadlAPIView: 0 Errors, 1 Warnings failed [Detail]

Rule	Message
⚠️ Failed to generate cadl APIView. Please check the detail log and make sure cadl compiler version is the latest.	"How to fix":"Check the detailed log and update cadl version to latest."

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️❌CadlValidation: 1 Errors, 25 Warnings failed [Detail]

Rule	Message
❌ InConsistentSwagger	"details":"The generated swagger file 2022-07-01-preview/openapi.json from cadl specification/newrelic/NewRelic.Management is not the same as the '/mnt/vss/_work/1/azure-rest-api-specs/specification/newrelic/resource-manager/NewRelic.Observability/preview/2022-07-01-preview/NewRelic.json' in PR, please make sure the swagger is consistent with the generated swagger. You can find the difference in the pipeline log."
⚠️ @azure-tools/cadl-providerhub/no-identifier-property-in-array-item	Missing identifying properties of objects in the array item, please add @extension("x-ms-identifiers", []) to specify it. If there are no appropriate identifying properties, please add @extension("x-ms-identifiers",[]). Location: @azure-tools/cadl-azure-core/lib/models.cadl#L13
⚠️ @azure-tools/cadl-providerhub/no-identifier-property-in-array-item	Missing identifying properties of objects in the array item, please add @extension("x-ms-identifiers", []) to specify it. If there are no appropriate identifying properties, please add @extension("x-ms-identifiers",[]). Location: @azure-tools/cadl-azure-core/lib/models.cadl#L13
⚠️ @azure-tools/cadl-providerhub/no-identifier-property-in-array-item	Missing identifying properties of objects in the array item, please add @extension("x-ms-identifiers", []) to specify it. If there are no appropriate identifying properties, please add @extension("x-ms-identifiers",[]). Location: specification/newrelic/NewRelic.Management/main.cadl#L386
⚠️ @azure-tools/cadl-providerhub/documentation-different-with-node-name	The documentation should not be the same as the node name. Location: specification/newrelic/NewRelic.Management/main.cadl#L670
⚠️ @azure-tools/cadl-providerhub/no-identifier-property-in-array-item	Missing identifying properties of objects in the array item, please add @extension("x-ms-identifiers", []) to specify it. If there are no appropriate identifying properties, please add @extension("x-ms-identifiers",[]). Location: specification/newrelic/NewRelic.Management/main.cadl#L377
⚠️ @azure-tools/cadl-azure-core/casing-style	The names of Model types must use PascalCase Location: specification/newrelic/NewRelic.Management/main.cadl#L469
⚠️ @azure-tools/cadl-azure-core/casing-style	The names of Model types must use PascalCase Location: specification/newrelic/NewRelic.Management/main.cadl#L599
⚠️ @azure-tools/cadl-azure-core/casing-style	The names of Model types must use PascalCase Location: specification/newrelic/NewRelic.Management/main.cadl#L596
⚠️ @azure-tools/cadl-azure-resource-manager/arm-resource-provisioning-state	The RP-specific property model in the 'properties' property of this resource must contain a 'provisioningState property. The property type should be an enum, and it must specify known state values 'Succeeded', 'Failed', and 'Canceled'. Location: specification/newrelic/NewRelic.Management/main.cadl#L659
⚠️ @azure-tools/cadl-azure-resource-manager/arm-resource-provisioning-state	The RP-specific property model in the 'properties' property of this resource must contain a 'provisioningState property. The property type should be an enum, and it must specify known state values 'Succeeded', 'Failed', and 'Canceled'. Location: specification/newrelic/NewRelic.Management/main.cadl#L638
⚠️ @azure-tools/cadl-azure-resource-manager/arm-resource-provisioning-state	The RP-specific property model in the 'properties' property of this resource must contain a 'provisioningState property. The property type should be an enum, and it must specify known state values 'Succeeded', 'Failed', and 'Canceled'. Location: specification/newrelic/NewRelic.Management/main.cadl#L689
⚠️ @azure-tools/cadl-azure-resource-manager/arm-resource-action-no-segment	@armResourceAction should not be used with @segment. Instead, use @action(...) if you need to rename the action, or omit. Location: specification/newrelic/NewRelic.Management/main.cadl#L69
⚠️ @azure-tools/cadl-azure-resource-manager/arm-resource-operation-missing-decorator	Resource POST operation must be decorated with @armResourceAction. Location: specification/newrelic/NewRelic.Management/main.cadl#L74
⚠️ @azure-tools/cadl-azure-resource-manager/arm-resource-operation-missing-decorator	Resource POST operation must be decorated with @armResourceAction. Location: specification/newrelic/NewRelic.Management/main.cadl#L81
⚠️ @azure-tools/cadl-azure-resource-manager/arm-resource-operation-missing-decorator	Resource POST operation must be decorated with @armResourceAction. Location: specification/newrelic/NewRelic.Management/main.cadl#L89
⚠️ @azure-tools/cadl-azure-resource-manager/arm-resource-operation-missing-decorator	Resource POST operation must be decorated with @armResourceAction. Location: specification/newrelic/NewRelic.Management/main.cadl#L97
⚠️ @azure-tools/cadl-azure-resource-manager/arm-resource-operation-missing-decorator	Resource POST operation must be decorated with @armResourceAction. Location: specification/newrelic/NewRelic.Management/main.cadl#L105
⚠️ @azure-tools/cadl-azure-resource-manager/arm-resource-operation-missing-decorator	Resource POST operation must be decorated with @armResourceAction. Location: specification/newrelic/NewRelic.Management/main.cadl#L113
⚠️ @azure-tools/cadl-azure-core/casing-style	The names of Interface types must use PascalCase Location: specification/newrelic/NewRelic.Management/main.cadl#L122
⚠️ @azure-tools/cadl-azure-resource-manager/arm-resource-interface-requires-decorator	Each resource interface must have an @armResourceOperations decorator. Location: specification/newrelic/NewRelic.Management/main.cadl#L122
⚠️ @azure-tools/cadl-azure-core/casing-style	The names of Interface types must use PascalCase Location: specification/newrelic/NewRelic.Management/main.cadl#L132
⚠️ @azure-tools/cadl-azure-resource-manager/arm-resource-interface-requires-decorator	Each resource interface must have an @armResourceOperations decorator. Location: specification/newrelic/NewRelic.Management/main.cadl#L132
⚠️ @azure-tools/cadl-azure-core/casing-style	The names of Interface types must use PascalCase Location: specification/newrelic/NewRelic.Management/main.cadl#L142
⚠️ @azure-tools/cadl-azure-resource-manager/arm-resource-interface-requires-decorator	Each resource interface must have an @armResourceOperations decorator. Location: specification/newrelic/NewRelic.Management/main.cadl#L142
⚠️ MissingCadlProjectConfig	"details":"The configuration 'output-file' for '@azure-tools/cadl-autorest' is missing in the cadl-project.yaml under folder specification/newrelic/NewRelic.Management, please ensure it is added in the configuration of the emitter '@azure-tools/cadl-autorest'."

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-pipeline-app]

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account. 

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️⚠️ azure-sdk-for-python warning [Detail]

• ⚠️Warning [Logs]Release - Generate from 6b992c0. SDK Automation 14.0.0

  command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
  cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
  command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  cmderr	[automation_generate.sh]
  cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.4
  cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.4>
  cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.4` to update!
  cmderr	[automation_generate.sh] npm notice

• ️✔️track2_azure-mgmt-newrelicobservability [View full logs]  [Release SDK Changes]
  • azure_mgmt_newrelicobservability-1.0.0b1-py3-none-any.whl
  • azure-mgmt-newrelicobservability-1.0.0b1.zip

  info	[Changelog]

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

• ️✔️Succeeded [Logs]Release - Generate from 6b992c0. SDK Automation 14.0.0

  command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
  command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

• ️✔️azure-resourcemanager-newrelicobservability [View full logs]  [Release SDK Changes]
  • pom.xml
  • azure-resourcemanager-newrelicobservability-1.0.0-beta.2-sources.jar
  • azure-resourcemanager-newrelicobservability-1.0.0-beta.2.jar

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

• ️✔️Succeeded [Logs]Release - Generate from 6b992c0. SDK Automation 14.0.0

  command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
  command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

• ️✔️sdk/resourcemanager/newrelic/armnewrelicobservability [View full logs]  [Release SDK Changes]

  info	[Changelog] ### Features Added
  info	[Changelog]
  info	[Changelog] - New anonymous field `NewRelicMonitorResource` in struct `MonitorsClientSwitchBillingResponse`
  info	[Changelog] - New field `RetryAfter` in struct `MonitorsClientSwitchBillingResponse`
  info	[Changelog]
  info	[Changelog] Total 0 breaking change(s), 1 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

• ️✔️Succeeded [Logs]Release - Generate from 6b992c0. SDK Automation 14.0.0

  command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
  warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
  command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

• ️✔️@azure/arm-newrelicobservability [View full logs]  [Release SDK Changes]
  • azure-arm-newrelicobservability-1.0.0-beta.2.tgz

  info	[Changelog] **Features**
  info	[Changelog]
  info	[Changelog]   - Added Interface MonitorsSwitchBillingHeaders
  info	[Changelog]   - Added Type Alias MonitorsSwitchBillingResponse

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-pipeline-app]

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/newrelic/armnewrelicobservability	https://apiview.dev/Assemblies/Review/46505986efde4a3dac64c33d945de05c
Java	azure-resourcemanager-newrelicobservability	https://apiview.dev/Assemblies/Review/ed0daaa174f44a2c9c8d1c2bc817e05f
JavaScript	@azure/arm-newrelicobservability	https://apiview.dev/Assemblies/Review/190b0269f0a447b18c375fa0b88939d5

[openapi-workflow-bot]

Hi @banggaurav, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

[raych1]

Hi @banggaurav, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

@banggaurav , adding response code to existed version is breaking change. In addition, pls fix cadlValidation issue.

[banggaurav]

@jianyexi Can you please approve cadl validation on this?