Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.DocumentDB to add version stable/2023-04-15 #23532

Merged
merged 12 commits into from
Apr 28, 2023

Conversation

vinhms
Copy link
Contributor

@vinhms vinhms commented Apr 12, 2023

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @vinhms Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 12, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️Breaking Change(Cross-Version): 203 Warnings warning [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    cosmos-db.json 2023-04-15(ffccc1b) 2023-03-15(main)
    cosmos-db.json 2023-04-15(ffccc1b) 2023-03-01-preview(main)
    managedCassandra.json 2023-04-15(ffccc1b) 2023-03-15(main)
    managedCassandra.json 2023-04-15(ffccc1b) 2023-03-01-preview(main)
    mongorbac.json 2023-04-15(ffccc1b) 2023-03-15(main)
    mongorbac.json 2023-04-15(ffccc1b) 2023-03-01-preview(main)
    notebook.json 2023-04-15(ffccc1b) 2023-03-15(main)
    notebook.json 2023-04-15(ffccc1b) 2023-03-01-preview(main)
    privateEndpointConnection.json 2023-04-15(ffccc1b) 2023-03-15(main)
    privateEndpointConnection.json 2023-04-15(ffccc1b) 2023-03-01-preview(main)
    privateLinkResources.json 2023-04-15(ffccc1b) 2023-03-15(main)
    privateLinkResources.json 2023-04-15(ffccc1b) 2023-03-01-preview(main)
    rbac.json 2023-04-15(ffccc1b) 2023-03-15(main)
    rbac.json 2023-04-15(ffccc1b) 2023-03-01-preview(main)
    restorable.json 2023-04-15(ffccc1b) 2023-03-15(main)
    restorable.json 2023-04-15(ffccc1b) 2023-03-01-preview(main)
    services.json 2023-04-15(ffccc1b) 2023-03-15(main)
    services.json 2023-04-15(ffccc1b) 2023-03-01-preview(main)

    The following breaking changes are detected by comparison with the latest preview version:

    Only 29 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/graphs' removed or restructured?
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/cosmos-db.json#L1499:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/graphs/{graphName}' removed or restructured?
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/cosmos-db.json#L1535:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/sqlDatabases/{databaseName}/containers/{containerName}/partitionMerge' removed or restructured?
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/cosmos-db.json#L2385:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/sqlDatabases/{databaseName}/throughputSettings/default/retrieveThroughputDistribution' removed or restructured?
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/cosmos-db.json#L2673:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/sqlDatabases/{databaseName}/throughputSettings/default/redistributeThroughput' removed or restructured?
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/cosmos-db.json#L2741:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/sqlDatabases/{databaseName}/containers/{containerName}/throughputSettings/default/retrieveThroughputDistribution' removed or restructured?
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/cosmos-db.json#L2809:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/sqlDatabases/{databaseName}/containers/{containerName}/throughputSettings/default/redistributeThroughput' removed or restructured?
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/cosmos-db.json#L2880:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/mongodbDatabases/{databaseName}/throughputSettings/default/retrieveThroughputDistribution' removed or restructured?
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/cosmos-db.json#L3939:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/mongodbDatabases/{databaseName}/throughputSettings/default/redistributeThroughput' removed or restructured?
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/cosmos-db.json#L4007:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/mongodbDatabases/{databaseName}/collections/{collectionName}/throughputSettings/default/retrieveThroughputDistribution' removed or restructured?
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/cosmos-db.json#L4075:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/mongodbDatabases/{databaseName}/collections/{collectionName}/throughputSettings/default/redistributeThroughput' removed or restructured?
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/cosmos-db.json#L4146:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/mongodbDatabases/{databaseName}/collections/{collectionName}/partitionMerge' removed or restructured?
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/cosmos-db.json#L4406:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/cassandraKeyspaces/{keyspaceName}/views' removed or restructured?
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/cosmos-db.json#L6709:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/cassandraKeyspaces/{keyspaceName}/views/{viewName}' removed or restructured?
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/cosmos-db.json#L6748:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/cassandraKeyspaces/{keyspaceName}/views/{viewName}/throughputSettings/default' removed or restructured?
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/cosmos-db.json#L6898:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/cassandraKeyspaces/{keyspaceName}/views/{viewName}/throughputSettings/default/migrateToAutoscale' removed or restructured?
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/cosmos-db.json#L6997:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/cassandraKeyspaces/{keyspaceName}/views/{viewName}/throughputSettings/default/migrateToManualThroughput' removed or restructured?
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/cosmos-db.json#L7056:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/cassandraClusters/{clusterName}/backups' removed or restructured?
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/managedCassandra.json#L344:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/cassandraClusters/{clusterName}/backups/{backupId}' removed or restructured?
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/managedCassandra.json#L386:5
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'GraphResourceCreateUpdateParameters' removed or renamed?
    New: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L5823:3
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/cosmos-db.json#L7116:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'GraphResourceCreateUpdateProperties' removed or renamed?
    New: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L5823:3
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/cosmos-db.json#L7116:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'GraphResource' removed or renamed?
    New: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L5823:3
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/cosmos-db.json#L7116:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'CassandraViewCreateUpdateParameters' removed or renamed?
    New: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L5823:3
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/cosmos-db.json#L7116:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'CassandraViewCreateUpdateProperties' removed or renamed?
    New: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L5823:3
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/cosmos-db.json#L7116:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RedistributeThroughputParameters' removed or renamed?
    New: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L5823:3
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/cosmos-db.json#L7116:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RedistributeThroughputProperties' removed or renamed?
    New: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L5823:3
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/cosmos-db.json#L7116:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RedistributeThroughputPropertiesResource' removed or renamed?
    New: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L5823:3
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/cosmos-db.json#L7116:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RetrieveThroughputParameters' removed or renamed?
    New: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L5823:3
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/cosmos-db.json#L7116:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RetrieveThroughputProperties' removed or renamed?
    New: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L5823:3
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/cosmos-db.json#L7116:3
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2023-04 package-2023-04(ffccc1b) default(main)

    The following errors/warnings exist before current PR submission:

    Only 29 items are listed, please refer to log for more details.

    Rule Message
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L435
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L494
    OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.DocumentDB/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L667
    PathForNestedResource The path for nested resource doest not meet the valid resource pattern.
    Location: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L938
    PathForNestedResource The path for nested resource doest not meet the valid resource pattern.
    Location: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L980
    AllResourcesMustHaveDelete The resource ThroughputSettingsGetResults does not have a corresponding delete operation.
    Location: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L1673
    NestedResourcesMustHaveListOperation The nested resource 'ThroughputSettingsGetResults' does not have list operation, please add it.
    Location: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L6278
    IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L7978
    IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L8012
    IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L8020
    IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L8048
    IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L8059
    IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L8144
    IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L8269
    IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L8606
    IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L8657
    IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L8701
    IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L8709
    IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L8812
    IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L8837
    IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L8851
    AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.DocumentDB/stable/2023-04-15/cosmos-db.json#L8914
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.DocumentDB/stable/2023-04-15/managedCassandra.json#L150
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.DocumentDB/stable/2023-04-15/managedCassandra.json#L174
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.DocumentDB/stable/2023-04-15/managedCassandra.json#L188
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property name.
    Location: Microsoft.DocumentDB/stable/2023-04-15/managedCassandra.json#L263
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property type.
    Location: Microsoft.DocumentDB/stable/2023-04-15/managedCassandra.json#L263
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property location.
    Location: Microsoft.DocumentDB/stable/2023-04-15/managedCassandra.json#L263
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.DocumentDB/stable/2023-04-15/managedCassandra.json#L274
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ CIRCULAR_REFERENCE The JSON file has a circular reference.
    readme: specification/cosmos-db/resource-manager/readme.md
    json: Microsoft.DocumentDB/stable/2023-04-15/privateEndpointConnection.json
    ️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    API Readiness check failed. Please make sure your service is deployed. "code: InvalidResourceType,
    message: The resource type 'operations' could not be found in the namespace 'Microsoft.DocumentDB' for api version '2023-04-15'. The supported api-versions are '2014-04-01,
    2015-04-08,
    2015-11-06,
    2016-03-19,
    2016-03-31,
    2019-08-01-preview,
    2019-08-01,
    2019-12-12,
    2020-03-01,
    2020-04-01,
    2020-06-01-preview,
    2020-09-01,
    2021-01-15,
    2021-03-01-preview,
    2021-03-15,
    2021-04-01-preview,
    2021-04-15,
    2021-05-01-preview,
    2021-05-15,
    2021-06-15,
    2021-07-01-preview,
    2021-10-15,
    2021-10-15-preview,
    2021-11-15-preview,
    2022-02-15-preview,
    2022-05-15-preview,
    2022-05-15,
    2022-08-15-preview,
    2022-08-15,
    2022-11-15,
    2022-11-15-preview,
    2023-03-01-preview,
    2023-03-15,
    2023-03-15-preview'."
    ️❌~[Staging] ServiceAPIReadinessTest: 301 Errors, 0 Warnings failed [Detail]

    Tag package-2023-04; Prod region: Not deployed; Canary region: Deployed

    Test run on region: eastus2euap; Operation coverage: total: 190, untested: 0, failed: 188, passed: 2

    Service API Readiness Test failed. Check pipeline artifact for detail report.

    Only 29 items are listed, please refer to log for more details.

    Rule Message
    CLIENT_ERROR statusCode: 400,
    errorCode: NoRegisteredProviderFound,
    errorMessage: No registered resource provider found for location 'eastus2euap' and API version '2023-04-15' for type 'databaseAccounts'. The supported api-versions are '2014-04-01, 2015-04-08, 2015-11-06, 2016-03-19, 2016-03-31, 2019-08-01-preview, 2019-08-01, 2019-12-12, 2020-03-01, 2020-04-01, 2020-06-01-preview, 2020-09-01, 2021-01-15, 2021-03-01-preview, 2021-03-15, 2021-04-01-preview, 2021-04-15, 2021-05-01-preview, 2021-05-15, 2021-06-15, 2021-07-01-preview, 2021-10-15, 2021-10-15-preview, 2021-11-15-preview, 2022-02-15-preview, 2022-05-15-preview, 2022-05-15, 2022-08-15-preview, 2022-08-15, 2022-11-15, 2022-11-15-preview, 2023-03-01-preview, 2023-03-15, 2023-03-15-preview'. The supported locations are 'westcentralus, northcentralus, centralus, brazilsouth, canadacentral, westus2, eastus2, francecentral, japaneast, southeastasia, centralindia, southafricanorth, switzerlandnorth, uaenorth, ukwest, northeurope, westeurope, norwayeast, koreacentral, australiaeast, canadaeast, eastasia, germanywestcentral, uksouth, australiacentral, australiasoutheast, japanwest, koreasouth, southindia, westindia, westus, southcentralus, eastus, westus3, jioindiawest, swedencentral, qatarcentral, polandcentral, centraluseuap, eastus2euap'.
    Source: runtime
    OperationId: DatabaseAccounts_CreateOrUpdate
    INVALID_RESPONSE_CODE The swagger file does not define '400' response code
    Source: response
    OperationId: DatabaseAccounts_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: undefined,
    errorMessage: undefined
    Source: runtime
    OperationId: DatabaseAccounts_CheckNameExists
    CLIENT_ERROR statusCode: 404,
    errorCode: InvalidResourceType,
    errorMessage: The resource type 'databaseAccounts' could not be found in the namespace 'Microsoft.DocumentDB' for api version '2023-04-15'. The supported api-versions are '2014-04-01,2015-04-08,2015-11-06,2016-03-19,2016-03-31,2019-08-01-preview,2019-08-01,2019-12-12,2020-03-01,2020-04-01,2020-06-01-preview,2020-09-01,2021-01-15,2021-03-01-preview,2021-03-15,2021-04-01-preview,2021-04-15,2021-05-01-preview,2021-05-15,2021-06-15,2021-07-01-preview,2021-10-15,2021-10-15-preview,2021-11-15-preview,2022-02-15-preview,2022-05-15-preview,2022-05-15,2022-08-15-preview,2022-08-15,2022-11-15,2022-11-15-preview,2023-03-01-preview,2023-03-15,2023-03-15-preview'.
    Source: runtime
    OperationId: DatabaseAccounts_List
    INVALID_RESPONSE_CODE The swagger file does not define '404' response code
    Source: response
    OperationId: DatabaseAccounts_List
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DocumentDB/databaseAccounts/accountnjsnu4a' under resource group 'apiTest-PvznII-23532' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: DatabaseAccounts_ListUsages
    INVALID_RESPONSE_CODE The swagger file does not define '404' response code
    Source: response
    OperationId: DatabaseAccounts_ListUsages
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DocumentDB/databaseAccounts/accountnjsnu4a' under resource group 'apiTest-PvznII-23532' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: DatabaseAccounts_GetReadOnlyKeys
    INVALID_RESPONSE_CODE The swagger file does not define '404' response code
    Source: response
    OperationId: DatabaseAccounts_GetReadOnlyKeys
    CLIENT_ERROR statusCode: 404,
    errorCode: InvalidResourceType,
    errorMessage: The resource type 'databaseAccounts' could not be found in the namespace 'Microsoft.DocumentDB' for api version '2023-04-15'. The supported api-versions are '2014-04-01,2015-04-08,2015-11-06,2016-03-19,2016-03-31,2019-08-01-preview,2019-08-01,2019-12-12,2020-03-01,2020-04-01,2020-06-01-preview,2020-09-01,2021-01-15,2021-03-01-preview,2021-03-15,2021-04-01-preview,2021-04-15,2021-05-01-preview,2021-05-15,2021-06-15,2021-07-01-preview,2021-10-15,2021-10-15-preview,2021-11-15-preview,2022-02-15-preview,2022-05-15-preview,2022-05-15,2022-08-15-preview,2022-08-15,2022-11-15,2022-11-15-preview,2023-03-01-preview,2023-03-15,2023-03-15-preview'.
    Source: runtime
    OperationId: DatabaseAccounts_ListByResourceGroup
    INVALID_RESPONSE_CODE The swagger file does not define '404' response code
    Source: response
    OperationId: DatabaseAccounts_ListByResourceGroup
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DocumentDB/databaseAccounts/accountnjsnu4a' under resource group 'apiTest-PvznII-23532' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: DatabaseAccounts_ListMetricDefinitions
    INVALID_RESPONSE_CODE The swagger file does not define '404' response code
    Source: response
    OperationId: DatabaseAccounts_ListMetricDefinitions
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DocumentDB/databaseAccounts/accountnjsnu4a' under resource group 'apiTest-PvznII-23532' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: DatabaseAccounts_ListMetrics
    INVALID_RESPONSE_CODE The swagger file does not define '404' response code
    Source: response
    OperationId: DatabaseAccounts_ListMetrics
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DocumentDB/databaseAccounts/accountnjsnu4a' under resource group 'apiTest-PvznII-23532' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: DatabaseAccounts_Get
    INVALID_RESPONSE_CODE The swagger file does not define '404' response code
    Source: response
    OperationId: DatabaseAccounts_Get
    CLIENT_ERROR statusCode: 403,
    errorCode: LinkedAuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' has permission to perform action 'Microsoft.DocumentDB/databaseAccounts/write' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-PvznII-23532/providers/Microsoft.DocumentDB/databaseAccounts/accountnjsnu4a'; however, it does not have permission to perform action 'joinViaServiceEndpoint/action' on the linked scope(s) '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/rg/providers/Microsoft.Network/virtualNetworks/vnet1/subnets/subnet1' or the linked scope(s) are invalid.
    Source: runtime
    OperationId: DatabaseAccounts_Update
    INVALID_RESPONSE_CODE The swagger file does not define '403' response code
    Source: response
    OperationId: DatabaseAccounts_Update
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DocumentDB/databaseAccounts/accountnjsnu4a' under resource group 'apiTest-PvznII-23532' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: DatabaseAccounts_RegenerateKey
    INVALID_RESPONSE_CODE The swagger file does not define '404' response code
    Source: response
    OperationId: DatabaseAccounts_RegenerateKey
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DocumentDB/databaseAccounts/accountnjsnu4a' under resource group 'apiTest-PvznII-23532' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: DatabaseAccounts_OfflineRegion
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: error
    Source: response
    OperationId: DatabaseAccounts_OfflineRegion
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DocumentDB/databaseAccounts/accountnjsnu4a' under resource group 'apiTest-PvznII-23532' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: DatabaseAccounts_ListReadOnlyKeys
    INVALID_RESPONSE_CODE The swagger file does not define '404' response code
    Source: response
    OperationId: DatabaseAccounts_ListReadOnlyKeys
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DocumentDB/databaseAccounts/accountnjsnu4a' under resource group 'apiTest-PvznII-23532' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: DatabaseAccounts_OnlineRegion
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: error
    Source: response
    OperationId: DatabaseAccounts_OnlineRegion
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DocumentDB/databaseAccounts/accountnjsnu4a' under resource group 'apiTest-PvznII-23532' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: DatabaseAccounts_ListConnectionStrings
    INVALID_RESPONSE_CODE The swagger file does not define '404' response code
    Source: response
    OperationId: DatabaseAccounts_ListConnectionStrings
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 12, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking




    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from a02c83e. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-cosmosdb [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Model ContinuousModeBackupPolicy has a new parameter continuous_mode_properties
      info	[Changelog]   - Model RestorableDatabaseAccountGetResult has a new parameter oldest_restorable_time
      info	[Changelog]   - Model ThroughputSettingsGetPropertiesResource has a new parameter instant_maximum_throughput
      info	[Changelog]   - Model ThroughputSettingsGetPropertiesResource has a new parameter soft_allowed_maximum_throughput
      info	[Changelog]   - Model ThroughputSettingsResource has a new parameter instant_maximum_throughput
      info	[Changelog]   - Model ThroughputSettingsResource has a new parameter soft_allowed_maximum_throughput
    ️⚠️ azure-sdk-for-net-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from a02c83e. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      cmderr	[Automation-Sdk-Init.ps1] �[31;1mGetDotNetInstallScript: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Automation-Sdk-Init.ps1:39
      cmderr	[Automation-Sdk-Init.ps1] �[36;1mLine |
      cmderr	[Automation-Sdk-Init.ps1] �[36;1m  39 | �[0m $installScript = �[36;1mGetDotNetInstallScript�[0m
      cmderr	[Automation-Sdk-Init.ps1] �[36;1m     | �[31;1m                  ~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Automation-Sdk-Init.ps1] �[31;1m�[36;1m     | �[31;1mThe SSL connection could not be established, see inner exception.
      cmderr	[Automation-Sdk-Init.ps1] �[0m
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.CosmosDB [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from a02c83e. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/cosmos/armcosmos [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New value `PublicNetworkAccessSecuredByPerimeter` added to enum type `PublicNetworkAccess`
      info	[Changelog] - New enum type `ContinuousTier` with values `ContinuousTierContinuous30Days`, `ContinuousTierContinuous7Days`
      info	[Changelog] - New struct `ContinuousModeProperties`
      info	[Changelog] - New field `ContinuousModeProperties` in struct `ContinuousModeBackupPolicy`
      info	[Changelog] - New field `OldestRestorableTime` in struct `RestorableDatabaseAccountProperties`
      info	[Changelog] - New field `InstantMaximumThroughput`, `SoftAllowedMaximumThroughput` in struct `ThroughputSettingsGetPropertiesResource`
      info	[Changelog] - New field `InstantMaximumThroughput`, `SoftAllowedMaximumThroughput` in struct `ThroughputSettingsResource`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 10 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from a02c83e. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-cosmosdb [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added Interface ContinuousModeProperties
      info	[Changelog]   - Added Type Alias ContinuousTier
      info	[Changelog]   - Interface ContinuousModeBackupPolicy has a new optional parameter continuousModeProperties
      info	[Changelog]   - Interface RestorableDatabaseAccountGetResult has a new optional parameter oldestRestorableTime
      info	[Changelog]   - Interface ThroughputSettingsResource has a new optional parameter instantMaximumThroughput
      info	[Changelog]   - Interface ThroughputSettingsResource has a new optional parameter softAllowedMaximumThroughput
      info	[Changelog]   - Added Enum KnownContinuousTier
      info	[Changelog]   - Enum KnownPublicNetworkAccess has a new value SecuredByPerimeter
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from a02c83e. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️cosmos-db [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from a02c83e. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • Az.cosmos-db.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.cosmos-db.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 12, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/cosmos/armcosmos https://apiview.dev/Assemblies/Review/e8936c4ebfbb47cf81af8520b32fcfcd
    Java azure-resourcemanager-cosmos-generated https://apiview.dev/Assemblies/Review/199fc6eed3d74c758725de97b16e92a0
    .Net Azure.ResourceManager.CosmosDB There is no API change compared with the previous version
    JavaScript @azure/arm-cosmosdb https://apiview.dev/Assemblies/Review/aa63f133776a4ac886dbbe395d5ded0b

    @vinhms vinhms marked this pull request as ready for review April 17, 2023 17:46
    @vinhms vinhms requested a review from pjohari-ms as a code owner April 17, 2023 17:46
    @AzureRestAPISpecReview AzureRestAPISpecReview added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 17, 2023
    @openapi-workflow-bot
    Copy link

    Hi @vinhms, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @AzureRestAPISpecReview AzureRestAPISpecReview added ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test and removed CI-FixRequiredOnFailure labels Apr 18, 2023
    @lnajaroen lnajaroen force-pushed the vinhms-cosmos-db-Microsoft.DocumentDB-2023-04-15-actual branch from 50d6a2f to 9a56104 Compare April 18, 2023 16:58
    @pjohari-ms pjohari-ms added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Apr 18, 2023
    @vinhms
    Copy link
    Contributor Author

    vinhms commented Apr 18, 2023

    hi @chunyu3, can you please review this PR? Thanks.

    @pjohari-ms
    Copy link
    Member

    @chunyu3 There's a ARMReview tag already added to this PR, but there's no review as of yet. Should we ping someone for the ARM review or add a different tag?

    @sjanamma
    Copy link

    It will be great to address the linter error in the future releases.
    https://github.com/Azure/azure-rest-api-specs/pull/23532/checks?check_run_id=12848147152

    @sjanamma sjanamma added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Apr 21, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 21, 2023
    @vinhms
    Copy link
    Contributor Author

    vinhms commented Apr 21, 2023

    @chunyu3 we have got ARM sign off now. Can you help review this now? Thanks.

    @chunyu3 chunyu3 added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Apr 26, 2023
    @pjohari-ms pjohari-ms removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Apr 27, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review Cosmos DoNotMerge <valid label in PR review process> use to hold merge after approval new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    8 participants