Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service Fabric Managed Clusters - api version 2023-03-01-preview #23718

Merged
merged 3 commits into from
May 8, 2023
Merged

Service Fabric Managed Clusters - api version 2023-03-01-preview #23718

merged 3 commits into from
May 8, 2023

Conversation

a-santamaria
Copy link
Member

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @a-santamaria Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-workflow-bot openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 25, 2023
    @openapi-workflow-bot
    Copy link

    Hi, @a-santamaria your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 25, 2023 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 13 Errors, 1 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    managedapplication.json 2023-03-01-preview(a5c98c1) 2022-01-01(main)
    managedapplication.json 2023-03-01-preview(a5c98c1) 2023-02-01-preview(main)
    managedcluster.json 2023-03-01-preview(a5c98c1) 2022-01-01(main)
    managedcluster.json 2023-03-01-preview(a5c98c1) 2023-02-01-preview(main)
    nodetype.json 2023-03-01-preview(a5c98c1) 2022-01-01(main)
    nodetype.json 2023-03-01-preview(a5c98c1) 2023-02-01-preview(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Rule Message
    ❌ 1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
    New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L1070:7
    Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1006:7
    ❌ 1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
    New: Microsoft.ServiceFabric/preview/2023-03-01-preview/nodetype.json#L718:7
    Old: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L671:7
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'sku' that was not found in the old version.
    New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L1116:11
    Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1052:11
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'sku' that was not found in the old version.
    New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L150:13
    Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L150:13
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'sku' that was not found in the old version.
    New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L187:13
    Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L187:13
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'sku' that was not found in the old version.
    New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L208:13
    Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L208:13
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'sku' that was not found in the old version.
    New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L214:13
    Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L214:13
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'sku' that was not found in the old version.
    New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L265:13
    Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L265:13
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'sku' that was not found in the old version.
    New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L1056:5
    Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L995:5
    ❌ 1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
    New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L1246:11
    Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1178:11
    ❌ 1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
    New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L1352:9
    Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1261:9
    ❌ 1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
    New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L762:5
    Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L719:5
    ❌ 1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
    New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L1442:5
    Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1311:5


    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'VmSharedGalleryImageId' renamed or removed?
    New: Microsoft.ServiceFabric/preview/2023-03-01-preview/nodetype.json#L761:7
    Old: Microsoft.ServiceFabric/preview/2023-02-01-preview/nodetype.json#L758:7
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2023-03-preview package-2023-03-preview(a5c98c1) default(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L37
    ❌ ResourceNameRestriction The resource name parameter 'applicationTypeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L37
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L223
    ❌ ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L241
    ❌ ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L287
    ❌ ResourceNameRestriction The resource name parameter 'applicationTypeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L287
    ❌ CreateOperationAsyncResponseValidation An async PUT operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'azure-async-operation' on 'x-ms-long-running-operation-options'
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L335
    ❌ CreateOperationAsyncResponseValidation An async PUT operation must return 201.
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L381
    ❌ CreateOperationAsyncResponseValidation Only 201 is the supported response code for PUT async response.
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L388
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L388
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L495
    ❌ ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L513
    ❌ ResourceNameRestriction The resource name parameter 'applicationTypeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L513
    ❌ ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L562
    ❌ ResourceNameRestriction The resource name parameter 'applicationName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L562
    ❌ CreateOperationAsyncResponseValidation An async PUT operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'azure-async-operation' on 'x-ms-long-running-operation-options'
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L607
    ❌ CreateOperationAsyncResponseValidation An async PUT operation must return 201.
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L653
    ❌ CreateOperationAsyncResponseValidation Only 201 is the supported response code for PUT async response.
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L660
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L660
    ❌ PatchIdentityProperty The patch operation body parameter schema should contains property 'identity'.
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L697
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L761
    ❌ ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L779
    ❌ ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L825
    ❌ ResourceNameRestriction The resource name parameter 'applicationName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L825
    ❌ ResourceNameRestriction The resource name parameter 'serviceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L825
    ❌ CreateOperationAsyncResponseValidation An async PUT operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'azure-async-operation' on 'x-ms-long-running-operation-options'
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L873
    ❌ CreateOperationAsyncResponseValidation An async PUT operation must return 201.
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L922
    ❌ CreateOperationAsyncResponseValidation Only 201 is the supported response code for PUT async response.
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L929
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L929
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedapplication.json#L1036
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ API Readiness check failed. Please make sure your service is deployed. "code: InvalidResourceType,
    message: The resource type 'operations' could not be found in the namespace 'Microsoft.ServiceFabric' for api version '2023-03-01-preview'. The supported api-versions are '2016-03-01,
    2016-09-01,
    2017-07-01-preview,
    2017-07-01-privatepreview,
    2018-02-01,
    2018-02-01-privatepreview,
    2019-03-01-privatepreview,
    2019-03-01-preview,
    2019-03-01,
    2019-06-01-preview,
    2019-11-01-preview,
    2019-11-01-privatepreview,
    2020-01-01-preview,
    2020-02-01-preview,
    2020-02-01-privatepreview,
    2020-03-01,
    2020-12-01-preview,
    2020-12-01-privatepreview,
    2020-12-15-preview,
    2020-12-15-privatepreview,
    2021-01-01-preview,
    2021-05-01,
    2021-06-01,
    2021-07-01-preview,
    2021-11-01-preview,
    2022-01-01,
    2022-02-01-preview,
    2022-06-01-preview,
    2022-08-01-preview,
    2022-10-01-preview,
    2023-02-01-preview'."
    ️❌~[Staging] ServiceAPIReadinessTest: 44 Errors, 0 Warnings failed [Detail]

    Tag package-2023-03-preview; Prod region: Not deployed; Canary region: Deployed

    Test run on region: eastus2euap; Operation coverage: total: 45, untested: 0, failed: 44, passed: 1

    Service API Readiness Test failed. Check pipeline artifact for detail report.

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ CLIENT_ERROR statusCode: 400,
    errorCode: NoRegisteredProviderFound,
    errorMessage: No registered resource provider found for location 'eastus2euap' and API version '2023-03-01-preview' for type 'managedclusters'. The supported api-versions are '2020-01-01-preview, 2021-01-01-preview, 2021-05-01, 2021-07-01-preview, 2021-11-01-preview, 2022-01-01, 2022-02-01-preview, 2022-06-01-preview, 2022-08-01-preview, 2022-10-01-preview, 2023-02-01-preview'. The supported locations are 'westus, westus2, westcentralus, eastus, eastus2, centralus, westeurope, northeurope, ukwest, uksouth, australiaeast, australiasoutheast, northcentralus, eastasia, southeastasia, japanwest, japaneast, southindia, westindia, centralindia, brazilsouth, southcentralus, koreacentral, koreasouth, canadacentral, canadaeast, francecentral, australiacentral, southafricanorth, uaenorth, swedencentral, switzerlandnorth, germanywestcentral, norwayeast, westus3, jioindiawest, qatarcentral, polandcentral, centraluseuap, eastus2euap'.
    Source: runtime
    OperationId: ManagedClusters_CreateOrUpdate
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: InvalidResourceType,
    errorMessage: The resource type 'managedclusters' could not be found in the namespace 'Microsoft.ServiceFabric' for api version '2023-03-01-preview'. The supported api-versions are '2020-01-01-preview,2021-01-01-preview,2021-05-01,2021-07-01-preview,2021-11-01-preview,2022-01-01,2022-02-01-preview,2022-06-01-preview,2022-08-01-preview,2022-10-01-preview,2023-02-01-preview'.
    Source: runtime
    OperationId: ManagedClusters_ListBySubscription
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: InvalidResourceType,
    errorMessage: The resource type 'managedclusters' could not be found in the namespace 'Microsoft.ServiceFabric' for api version '2023-03-01-preview'. The supported api-versions are '2020-01-01-preview,2021-01-01-preview,2021-05-01,2021-07-01-preview,2021-11-01-preview,2022-01-01,2022-02-01-preview,2022-06-01-preview,2022-08-01-preview,2022-10-01-preview,2023-02-01-preview'.
    Source: runtime
    OperationId: ManagedClusters_ListByResourceGroup
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ServiceFabric/managedclusters/clusternbv2p2f' under resource group 'apiTest-ASPQwG-23718' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: ManagedClusters_Get
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ServiceFabric/managedclusters/clusternbv2p2f' under resource group 'apiTest-ASPQwG-23718' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: ManagedClusters_Update
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusternbv2p2f' not found.
    Source: runtime
    OperationId: Applications_CreateOrUpdate
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusternbv2p2f' not found.
    Source: runtime
    OperationId: Applications_List
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusternbv2p2f' not found.
    Source: runtime
    OperationId: Applications_Get
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusternbv2p2f' not found.
    Source: runtime
    OperationId: Applications_Update
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusternbv2p2f' not found.
    Source: runtime
    OperationId: ApplicationTypes_CreateOrUpdate
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusternbv2p2f' not found.
    Source: runtime
    OperationId: ApplicationTypes_List
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusternbv2p2f' not found.
    Source: runtime
    OperationId: ApplicationTypes_Get
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusternbv2p2f' not found.
    Source: runtime
    OperationId: ApplicationTypes_Update
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusternbv2p2f' not found.
    Source: runtime
    OperationId: NodeTypes_CreateOrUpdate
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusternbv2p2f' not found.
    Source: runtime
    OperationId: NodeTypes_Get
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusternbv2p2f' not found.
    Source: runtime
    OperationId: NodeTypes_ListByManagedClusters
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusternbv2p2f' not found.
    Source: runtime
    OperationId: NodeTypes_Update
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusternbv2p2f' not found.
    Source: runtime
    OperationId: NodeTypes_Reimage
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusternbv2p2f' not found.
    Source: runtime
    OperationId: NodeTypes_DeleteNode
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusternbv2p2f' not found.
    Source: runtime
    OperationId: NodeTypes_Restart
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusternbv2p2f/applicathr4jfg' not found.
    Source: runtime
    OperationId: ApplicationTypeVersions_CreateOrUpdate
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusternbv2p2f/applicathr4jfg' not found.
    Source: runtime
    OperationId: ApplicationTypeVersions_ListByApplicationTypes
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusternbv2p2f/applicathr4jfg' not found.
    Source: runtime
    OperationId: ApplicationTypeVersions_Get
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusternbv2p2f/applicathr4jfg' not found.
    Source: runtime
    OperationId: ApplicationTypeVersions_Update
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusternbv2p2f/applicatsacbqn' not found.
    Source: runtime
    OperationId: Services_CreateOrUpdate
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusternbv2p2f/applicatsacbqn' not found.
    Source: runtime
    OperationId: Services_ListByApplications
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusternbv2p2f/applicatsacbqn' not found.
    Source: runtime
    OperationId: Services_Get
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusternbv2p2f/applicatsacbqn' not found.
    Source: runtime
    OperationId: Services_Update
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: InvalidResourceType,
    errorMessage: The resource type 'operations' could not be found in the namespace 'Microsoft.ServiceFabric' for api version '2023-03-01-preview'. The supported api-versions are '2016-03-01,2016-09-01,2017-07-01-preview,2017-07-01-privatepreview,2018-02-01,2018-02-01-privatepreview,2019-03-01-privatepreview,2019-03-01-preview,2019-03-01,2019-06-01-preview,2019-11-01-preview,2019-11-01-privatepreview,2020-01-01-preview,2020-02-01-preview,2020-02-01-privatepreview,2020-03-01,2020-12-01-preview,2020-12-01-privatepreview,2020-12-15-preview,2020-12-15-privatepreview,2021-01-01-preview,2021-05-01,2021-06-01,2021-07-01-preview,2021-11-01-preview,2022-01-01,2022-02-01-preview,2022-06-01-preview,2022-08-01-preview,2022-10-01-preview,2023-02-01-preview'.
    Source: runtime
    OperationId: Operations_List
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: InvalidResourceType,
    errorMessage: The resource type 'locations/environments/managedClusterVersions' could not be found in the namespace 'Microsoft.ServiceFabric' for api version '2023-03-01-preview'. The supported api-versions are '2020-01-01-preview,2021-01-01-preview,2021-05-01,2021-07-01-preview,2021-11-01-preview,2022-01-01,2022-02-01-preview,2022-06-01-preview,2022-08-01-preview,2022-10-01-preview,2023-02-01-preview'.
    Source: runtime
    OperationId: ManagedClusterVersion_ListByEnvironment
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand] 
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 25, 2023 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-python-track2 - track2_azure-mgmt-servicefabricmanagedclusters - Approved - 2.0.0b3
    +	Parameter sku of model ManagedCluster is now required
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from da459cd. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]  notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.6
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.6>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.6` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-servicefabricmanagedclusters [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model ManagedCluster has a new parameter public_ip_prefix_id
info	[Changelog]   - Model ManagedCluster has a new parameter use_custom_vnet
info	[Changelog]   - Model ManagedCluster has a new parameter zonal_update_mode
info	[Changelog]   - Model NodeType has a new parameter enable_node_public_ip
info	[Changelog]   - Model NodeType has a new parameter nat_gateway_id
info	[Changelog]   - Model NodeType has a new parameter secure_boot_enabled
info	[Changelog]   - Model NodeType has a new parameter security_type
info	[Changelog]   - Model NodeType has a new parameter subnet_id
info	[Changelog]   - Model NodeType has a new parameter vm_image_plan
info	[Changelog]   - Model NodeType has a new parameter vm_setup_actions
info	[Changelog]   - Model NodeType has a new parameter vm_shared_gallery_image_id
info	[Changelog]   - Model NodeTypeActionParameters has a new parameter update_type
info	[Changelog]   - Model ServiceResourceProperties has a new parameter service_dns_name
info	[Changelog]   - Model StatefulServiceProperties has a new parameter service_dns_name
info	[Changelog]   - Model StatelessServiceProperties has a new parameter service_dns_name
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Parameter sku of model ManagedCluster is now required
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from da459cd. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️servicefabricmanagedclusters [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • ❌Pipeline Framework Failed [Logs]Release - Generate from da459cd. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe
    • ❌Az.servicefabricmanagedclusters.DefaultTag [View full logs]  
      error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.servicefabricmanagedclusters.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 25, 2023 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    .Net Azure.ResourceManager.ServiceFabricManagedClusters There is no API change compared with the previous version

    @AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-MissingBaseCommit new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager labels Apr 25, 2023
    @openapi-workflow-bot
    Copy link

    Hi @a-santamaria, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @openapi-workflow-bot
    Copy link

    Hi, @a-santamaria, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    This was referenced Apr 25, 2023
    Closed
    Closed
    @azure-sdk azure-sdk mentioned this pull request Apr 25, 2023
    Closed
    @a-santamaria
    Copy link
    Member Author

    Hi @a-santamaria, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    The breaking changes reported are against api version 2022-01-01 they were already introduced on a previous api version and approved.

    @raych1 raych1 requested a review from v-xuto April 26, 2023 02:06
    @v-xuto
    Copy link
    Member

    v-xuto commented Apr 26, 2023

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @v-xuto
    Copy link
    Member

    v-xuto commented Apr 26, 2023 •
    edited
    Loading

    The breaking changes reported are against api version 2022-01-01 they were already introduced on a previous api version and approved.

    @a-santamaria Can you provide relevant PR?

    @v-xuto
    Copy link
    Member

    v-xuto commented Apr 26, 2023

    @a-santamaria Please contact the ARM team to review this PR. If you don't know how to contact ARM team, you can check the third of the ARM API Review Checklist in the first comment.

    @pilor pilor added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Apr 26, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 26, 2023
    @a-santamaria
    Copy link
    Member Author

    The breaking changes reported are against api version 2022-01-01 they were already introduced on a previous api version and approved.

    @a-santamaria Can you provide relevant PR?

    @v-xuto please see table below for prs and intakes linked on each breaking change reported. Is it possible for the automation to avoid showing breaking changes that have been approved in previous apis?

    Rule Message change Api version introduced PR Intake
    ❌ 1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True'). New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L1070:7 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1006:7 mangedClusters Sku (required) 2023-02-01-preview #22752 https://msazure.visualstudio.com/One/_workitems/edit/17301430
    ❌ 1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False'). New: Microsoft.ServiceFabric/preview/2023-03-01-preview/nodetype.json#L718:7 Old: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L671:7 NodeTypeActionParameters Nodes (remover from required) 2022-10-01-preview #21033 https://msazure.visualstudio.com/One/_workitems/edit/16129392
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L1116:11 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1052:11 mangedClusters Sku (required) 2023-02-01-preview #22752 https://msazure.visualstudio.com/One/_workitems/edit/17301430
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L150:13 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L150:13 mangedClusters Sku (required) 2023-02-01-preview #22752 https://msazure.visualstudio.com/One/_workitems/edit/17301430
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L187:13 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L187:13 mangedClusters Sku (required) 2023-02-01-preview #22752 https://msazure.visualstudio.com/One/_workitems/edit/17301430
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L208:13 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L208:13 mangedClusters Sku (required) 2023-02-01-preview #22752 https://msazure.visualstudio.com/One/_workitems/edit/17301430
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L214:13 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L214:13 mangedClusters Sku (required) 2023-02-01-preview #22752 https://msazure.visualstudio.com/One/_workitems/edit/17301430
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L265:13 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L265:13 mangedClusters Sku (required) 2023-02-01-preview #22752 https://msazure.visualstudio.com/One/_workitems/edit/17301430
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L1056:5 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L995:5 mangedClusters Sku (required) 2023-02-01-preview #22752 https://msazure.visualstudio.com/One/_workitems/edit/17301430
    ❌ 1048 - AddedXmsEnum The new version adds a x-ms-enum extension. New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L1246:11 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1178:11 ManagedClusterAddOnFeature Add x-ms-enu 2022-02-01-preview #17883 We didn't need intake for this, this was the message from specs team: This change only affects SDK, and it is not included by ARM review. Therefore you do not need to let ARM review this change again. We have noticed Jeffrey about the x-ms-enum changes ahead of time, he totally agree with these incoming changes, therefore I believe we also do not need to bother Jeffrey to approve this change again.
    ❌ 1048 - AddedXmsEnum The new version adds a x-ms-enum extension. New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L1352:9 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1261:9 OsType Add x-ms-enu 2022-02-01-preview #17883 Same as above
    ❌ 1048 - AddedXmsEnum The new version adds a x-ms-enum extension. New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L762:5 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L719:5 ManagedClusterAddOnFeature Add x-ms-enu 2022-02-01-preview #17883 Same as above
    ❌ 1048 - AddedXmsEnum The new version adds a x-ms-enum extension. New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L1442:5 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1311:5 OsType Add x-ms-enu 2022-02-01-preview #17883 Same as above

    @raych1
    Copy link
    Member

    raych1 commented Apr 27, 2023

    The breaking changes reported are against api version 2022-01-01 they were already introduced on a previous api version and approved.

    @a-santamaria Can you provide relevant PR?

    @v-xuto please see table below for prs and intakes linked on each breaking change reported. Is it possible for the automation to avoid showing breaking changes that have been approved in previous apis?

    Rule Message change Api version introduced PR Intake
    ❌ 1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True'). New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L1070:7 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1006:7 mangedClusters Sku (required) 2023-02-01-preview #22752 https://msazure.visualstudio.com/One/_workitems/edit/17301430
    ❌ 1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False'). New: Microsoft.ServiceFabric/preview/2023-03-01-preview/nodetype.json#L718:7 Old: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L671:7 NodeTypeActionParameters Nodes (remover from required) 2022-10-01-preview #21033 https://msazure.visualstudio.com/One/_workitems/edit/16129392
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L1116:11 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1052:11 mangedClusters Sku (required) 2023-02-01-preview #22752 https://msazure.visualstudio.com/One/_workitems/edit/17301430
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L150:13 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L150:13 mangedClusters Sku (required) 2023-02-01-preview #22752 https://msazure.visualstudio.com/One/_workitems/edit/17301430
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L187:13 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L187:13 mangedClusters Sku (required) 2023-02-01-preview #22752 https://msazure.visualstudio.com/One/_workitems/edit/17301430
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L208:13 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L208:13 mangedClusters Sku (required) 2023-02-01-preview #22752 https://msazure.visualstudio.com/One/_workitems/edit/17301430
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L214:13 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L214:13 mangedClusters Sku (required) 2023-02-01-preview #22752 https://msazure.visualstudio.com/One/_workitems/edit/17301430
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L265:13 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L265:13 mangedClusters Sku (required) 2023-02-01-preview #22752 https://msazure.visualstudio.com/One/_workitems/edit/17301430
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L1056:5 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L995:5 mangedClusters Sku (required) 2023-02-01-preview #22752 https://msazure.visualstudio.com/One/_workitems/edit/17301430
    ❌ 1048 - AddedXmsEnum The new version adds a x-ms-enum extension. New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L1246:11 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1178:11 ManagedClusterAddOnFeature Add x-ms-enu 2022-02-01-preview #17883 We didn't need intake for this, this was the message from specs team: This change only affects SDK, and it is not included by ARM review. Therefore you do not need to let ARM review this change again. We have noticed Jeffrey about the x-ms-enum changes ahead of time, he totally agree with these incoming changes, therefore I believe we also do not need to bother Jeffrey to approve this change again.
    ❌ 1048 - AddedXmsEnum The new version adds a x-ms-enum extension. New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L1352:9 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1261:9 OsType Add x-ms-enu 2022-02-01-preview #17883 Same as above
    ❌ 1048 - AddedXmsEnum The new version adds a x-ms-enum extension. New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L762:5 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L719:5 ManagedClusterAddOnFeature Add x-ms-enu 2022-02-01-preview #17883 Same as above
    ❌ 1048 - AddedXmsEnum The new version adds a x-ms-enum extension. New: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L1442:5 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1311:5 OsType Add x-ms-enu 2022-02-01-preview #17883 Same as above

    This is current tool design. @konrad-jamrozik to comment.

    @v-xuto
    Copy link
    Member

    v-xuto commented Apr 28, 2023

    @msyyc Please help review python breaking change.

    @v-xuto
    Copy link
    Member

    v-xuto commented Apr 28, 2023

    The breaking changes reported are against api version 2022-01-01 they were already introduced on a previous api version and approved.

    @a-santamaria Can you provide the relevant PR where the breaking change of api version 2022-01-01 was approved?

    @v-xuto
    Copy link
    Member

    v-xuto commented May 4, 2023

    @msyyc Please help review python breaking change.

    @v-xuto
    Copy link
    Member

    v-xuto commented May 5, 2023

    @mikekistler Please help review the Breaking Change(Cross-Version).

    @mikekistler
    Copy link
    Member

    Breaking changes previously reviewed and approved in #22752

    @mikekistler mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 5, 2023
    @v-xuto v-xuto added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label May 6, 2023
    @chunyu3 chunyu3 merged commit da459cd into Azure:main May 8, 2023
    This was referenced May 8, 2023
    Closed
    Closed
    Closed
    This was referenced May 12, 2023
    Open
    Closed
    @v-xuto v-xuto mentioned this pull request May 16, 2023
    Closed
    11 tasks
    @mwesigwaguma mwesigwaguma mentioned this pull request Jun 13, 2023
    Merged
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @v-xuto v-xuto v-xuto approved these changes

    Assignees

    @chunyu3 chunyu3

    @v-xuto v-xuto

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates Approved-SdkBreakingChange-Python ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-MissingBaseCommit new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    8 participants
    @a-santamaria @v-xuto @raych1 @mikekistler @pilor @chunyu3 @AzureRestAPISpecReview @msyyc