MFE 2023-06-01-preview staging #24051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @erjms Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced May 18, 2023
Closed
Closed
AzureRestAPISpecReview
added
the
BreakingChangeReviewRequired
|
Hi @erjms, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
erjms
force-pushed
the
erjms-mfe-staging-2023-06-01-preview
branch
from
8db5cad to
6cd7ea8
Compare
AzureRestAPISpecReview
removed
the
BreakingChangeReviewRequired
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
|
Hi, @erjms your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
visingla-ms
reviewed
May 22, 2023
| "in": "query", | ||
| "name": "stage", | ||
| "description": "Stage for including/excluding (for example) archived entities. Takes priority over listViewType", | ||
| "type": "string" |
There was a problem hiding this comment.
This one needs to be a string. Also, it was approved as string in the latest GA (2023-04-01) for several APIs so we need it to remain as string for consistency and to avoid breaking changes.
visingla-ms
reviewed
May 22, 2023
| "in": "query", | ||
| "name": "stage", | ||
| "description": "Component stage.", | ||
| "type": "string" |
There was a problem hiding this comment.
Please see my reply here:
#24051 (comment)
visingla-ms
reviewed
May 22, 2023
| "in": "query", | ||
| "name": "stage", | ||
| "description": "data stage", | ||
| "type": "string" |
There was a problem hiding this comment.
Please see my reply here:
#24051 (comment)
visingla-ms
reviewed
May 22, 2023
| "in": "query", | ||
| "name": "stage", | ||
| "description": "Stage for including/excluding (for example) archived entities. Takes priority over listViewType", | ||
| "type": "string" |
There was a problem hiding this comment.
Please see my reply here:
#24051 (comment)
visingla-ms
reviewed
May 22, 2023
| @@ -6770,7 +6876,7 @@ | |||
| { | |||
| "in": "query", | |||
| "name": "description", | |||
| "description": "Description of the featureset.", | |||
| "description": "description.", | |||
visingla-ms
reviewed
May 22, 2023
| @@ -11405,6 +11506,16 @@ | |||
| "x-ms-discriminator-value": "AMLToken", | |||
| "additionalProperties": false | |||
| }, | |||
| "AmlTokenComputeIdentity": { | |||
There was a problem hiding this comment.
Please fix all the newly introduced definitions which are missing Title/Description, in the Linter Warnings: https://github.com/Azure/azure-rest-api-specs/pull/24051/checks?check_run_id=13666592472.
Schema should have a description or title. #Resolved
What is the base version of this new API version (base version is the version on top of which there are new changes in this new API version)? As I observed, even the first commit of new version (2023-06-01-preview) has new changes from last stable version (2023-04-01). That makes difficult to review the changes made in first commit. ARM review guidelines say: The first commit needs to be the previous api version and the new changes should only be added in the subsequent commits. This is explained in detail here (If using Open API which is recommended) https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/208/OpenAPI-Hub-Adding-new-API-version or here(For manual process) : https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/83/Manual-Process-Adding-new-API-version . Please remove the "ARMChangesRequested" label once you have fixed this issue. Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json:5 in 8f28d9b. [](commit_id = 8f28d9b, deletion_comment = False) |
visingla-ms
added
the
ARMChangesRequested
|
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove |
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
The base version is OpenAPI-Hub was used to create the staging branch: Per the documentation, we chose the option:
This PR is to merge new changes from our fork into that staging branch. |
erjms
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
visingla-ms
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
zedy-wj
added
the
Approved-OkToMerge
live1206
approved these changes
May 25, 2023
live1206
merged commit 39132a4
into
Azure:release-machinelearningservices-Microsoft.MachineLearningServices-2023-06-01-preview
11 tasks
rkmanda
pushed a commit
that referenced
this pull request
Jun 27, 2023
…to add version preview/2023-06-01-preview (#24049) * Adds base for updating Microsoft.MachineLearningServices from version preview/2023-04-01-preview to version 2023-06-01-preview * Updates readme * Updates API version in new specs and examples * MFE 2023-06-01-preview staging (#24051) * Updated mfe.json * Added package example * Updated custom-words.txt * Updated package examples * Added pattern retriction to resource name parameters * Fixed cross-api breaking changes * Fixed cross-api breaking changes * Added descriptions * Added description * Separate workspace rp swagger from mlc (#24249) * separate workspace rp swagger from mlc * add missing parameter * Updated mfe.json descriptions for put 200 responses (#24295) * update EnableNodePublicIp for computeInstance of MLC (#24231) Co-authored-by: Bingchen Li <bingchenli@microsoft.com> * Update workspaceRP swagger with automation result (#24333) * Update workspace rp swagger with automation result rename pe definition to avoid conflict fix update PE name Update connection credential hide armid fix more things Fix enum issue fix polymorphism Update examples Update body name and example fix more issue update response body Fix Revert "file change" This reverts commit 4a1fdccf6eb22e1dda82d3acce8065fae171f422. file change Update swagger fix errors update format add example for connetion list secrets api run prettier * Fixing more issue * revert custom-words * run prettier * Update securityDefinitions * Revert operation id * Update description and summary. * fix prettier issue and add description * remove redundent object definition * fixing swagger issue revert PaginationParameter * Revert back to old file with only reorder for better compare * Revert "Revert back to old file with only reorder for better compare" This reverts commit 8feb7d8. * Revert connection v2 tag issue * Add back delete op for network rule * Add back example for the removed API * Suppress header check caused by old design * fix delete rule in path * Update example error * Update delete rule api and remove suppression * Fixed merge conflicts in custom-words.txt (#24532) --------- Co-authored-by: ZhidaLiu <zhili@microsoft.com> Co-authored-by: libc16 <88697960+libc16@users.noreply.github.com> Co-authored-by: Bingchen Li <bingchenli@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
harryli0108
pushed a commit
to harryli0108/azure-rest-api-specs
that referenced
this pull request
Jul 28, 2023
…to add version preview/2023-06-01-preview (Azure#24049) * Adds base for updating Microsoft.MachineLearningServices from version preview/2023-04-01-preview to version 2023-06-01-preview * Updates readme * Updates API version in new specs and examples * MFE 2023-06-01-preview staging (Azure#24051) * Updated mfe.json * Added package example * Updated custom-words.txt * Updated package examples * Added pattern retriction to resource name parameters * Fixed cross-api breaking changes * Fixed cross-api breaking changes * Added descriptions * Added description * Separate workspace rp swagger from mlc (Azure#24249) * separate workspace rp swagger from mlc * add missing parameter * Updated mfe.json descriptions for put 200 responses (Azure#24295) * update EnableNodePublicIp for computeInstance of MLC (Azure#24231) Co-authored-by: Bingchen Li <bingchenli@microsoft.com> * Update workspaceRP swagger with automation result (Azure#24333) * Update workspace rp swagger with automation result rename pe definition to avoid conflict fix update PE name Update connection credential hide armid fix more things Fix enum issue fix polymorphism Update examples Update body name and example fix more issue update response body Fix Revert "file change" This reverts commit 4a1fdccf6eb22e1dda82d3acce8065fae171f422. file change Update swagger fix errors update format add example for connetion list secrets api run prettier * Fixing more issue * revert custom-words * run prettier * Update securityDefinitions * Revert operation id * Update description and summary. * fix prettier issue and add description * remove redundent object definition * fixing swagger issue revert PaginationParameter * Revert back to old file with only reorder for better compare * Revert "Revert back to old file with only reorder for better compare" This reverts commit 8feb7d8. * Revert connection v2 tag issue * Add back delete op for network rule * Add back example for the removed API * Suppress header check caused by old design * fix delete rule in path * Update example error * Update delete rule api and remove suppression * Fixed merge conflicts in custom-words.txt (Azure#24532) --------- Co-authored-by: ZhidaLiu <zhili@microsoft.com> Co-authored-by: libc16 <88697960+libc16@users.noreply.github.com> Co-authored-by: Bingchen Li <bingchenli@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.