rename cleaup policy type from 'Compaction' to 'Compact' #24056

kevxms · 2023-05-18T20:46:19Z

ARM API Information (Control Plane)

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

'Compact' is already implemented in the resource provider and is consistent with using verb such as type 'Delete'

openapi-workflow-bot · 2023-05-18T20:46:22Z

Hi, @kevxms Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2023-05-18T20:46:23Z

Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
eventhubs.json	2022-10-01-preview(e576ea6)	2022-10-01-preview(main)

Rule	Message
`❌` 1019 - RemovedEnumValue	The new version is removing enum value(s) 'Compaction' from the old version. New: Microsoft.EventHub/preview/2022-10-01-preview/eventhubs.json#L272:9 Old: Microsoft.EventHub/preview/2022-10-01-preview/eventhubs.json#L272:9
`❌` 1020 - AddedEnumValue	The new version is adding enum value(s) 'Compact' from the old version. New: Microsoft.EventHub/preview/2022-10-01-preview/eventhubs.json#L272:9 Old: Microsoft.EventHub/preview/2022-10-01-preview/eventhubs.json#L272:9

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.2)	new version	base version
package-2022-10-preview	package-2022-10-preview(e576ea6)	package-2022-10-preview(main)

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction. Location: Microsoft.EventHub/preview/2022-10-01-preview/eventhubs.json#L37
`❌` ResourceNameRestriction	The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction. Location: Microsoft.EventHub/preview/2022-10-01-preview/eventhubs.json#L88
`❌` ResourceNameRestriction	The resource name parameter 'eventHubName' should be defined with a 'pattern' restriction. Location: Microsoft.EventHub/preview/2022-10-01-preview/eventhubs.json#L88
`❌` RequestSchemaForTrackedResourcesMustHaveTags	A tracked resource MUST always have tags as a top level optional property. Tracked resource does not have tags in the request schema. Location: Microsoft.EventHub/preview/2022-10-01-preview/eventhubs.json#L89
`❌` PutResponseSchemaDescription	Any Put MUST contain 200 and 201 return codes. Location: Microsoft.EventHub/preview/2022-10-01-preview/eventhubs.json#L126
`❌` MissingTypeObject	The schema 'CaptureDescription' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-10-01-preview/eventhubs.json#L230
`❌` MissingTypeObject	The schema 'Eventhub' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-10-01-preview/eventhubs.json#L297
`❌` TrackedResourcePatchOperation	Tracked resource 'Eventhub' must have patch operation that at least supports the update of tags. Location: Microsoft.EventHub/preview/2022-10-01-preview/eventhubs.json#L297
`❌` MissingTypeObject	The schema 'properties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-10-01-preview/eventhubs.json#L299
`❌` MissingTypeObject	The schema 'EventHubListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-10-01-preview/eventhubs.json#L377
`❌` MissingTypeObject	The schema 'Destination' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-10-01-preview/eventhubs.json#L393
`❌` MissingTypeObject	The schema 'properties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-10-01-preview/eventhubs.json#L399
`❌` GuidUsage	Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.EventHub/preview/2022-10-01-preview/eventhubs.json#L416
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.EventHub/preview/2022-10-01-preview/eventhubs.json#L49
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.EventHub/preview/2022-10-01-preview/eventhubs.json#L100
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.EventHub/preview/2022-10-01-preview/eventhubs.json#L152
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.EventHub/preview/2022-10-01-preview/eventhubs.json#L195
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.EventHub/preview/2022-10-01-preview/eventhubs.json#L232
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.EventHub/preview/2022-10-01-preview/eventhubs.json#L262

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-05-18T20:46:23Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/eventhub/armeventhub - Approved - 1.2.0-beta.2

+	`CleanupPolicyRetentionDescriptionCompaction` from enum `CleanupPolicyRetentionDescription` has been removed

❌azure-sdk-for-js - @azure/arm-eventhub - Approved - 6.0.0-beta.1

+	Interface ConsumerGroupsListByEventHubNextOptionalParams no longer has parameter skip
+	Interface ConsumerGroupsListByEventHubNextOptionalParams no longer has parameter top
+	Interface EventHubsListByNamespaceNextOptionalParams no longer has parameter skip
+	Interface EventHubsListByNamespaceNextOptionalParams no longer has parameter top
+	Interface SchemaRegistryListByNamespaceNextOptionalParams no longer has parameter skip
+	Interface SchemaRegistryListByNamespaceNextOptionalParams no longer has parameter top

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from 83e7e59. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.EventHubs [View full logs] [Release SDK Changes]
- Azure.ResourceManager.EventHubs.1.1.0-alpha.20230605.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 83e7e59. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.7
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.7>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.7` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-eventhub [View full logs] [Release SDK Changes]
- azure-mgmt-eventhub-0.1.0.zip
- azure_mgmt_eventhub-0.1.0-py3-none-any.whl
```
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model NetworkSecurityPerimeterConfiguration has a new parameter location
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 83e7e59. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-eventhubs-generated [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 83e7e59. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/eventhub/armeventhub [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - `CleanupPolicyRetentionDescriptionCompaction` from enum `CleanupPolicyRetentionDescription` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `CleanupPolicyRetentionDescriptionCompact` added to enum type `CleanupPolicyRetentionDescription`
info	[Changelog] - New field `Location` in struct `NetworkSecurityPerimeterConfiguration`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 2 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 83e7e59. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-eventhub [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-eventhub-6.0.0-beta.1.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group ApplicationGroupOperations
info	[Changelog]   - Added operation group NetworkSecurityPerimeterConfigurationOperations
info	[Changelog]   - Added operation group NetworkSecurityPerimeterConfigurations
info	[Changelog]   - Added Interface ApplicationGroup
info	[Changelog]   - Added Interface ApplicationGroupCreateOrUpdateApplicationGroupOptionalParams
info	[Changelog]   - Added Interface ApplicationGroupDeleteOptionalParams
info	[Changelog]   - Added Interface ApplicationGroupGetOptionalParams
info	[Changelog]   - Added Interface ApplicationGroupListByNamespaceNextOptionalParams
info	[Changelog]   - Added Interface ApplicationGroupListByNamespaceOptionalParams
info	[Changelog]   - Added Interface ApplicationGroupListResult
info	[Changelog]   - Added Interface ApplicationGroupPolicy
info	[Changelog]   - Added Interface NetworkSecurityPerimeter
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfiguration
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationList
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationListOptionalParams
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationPropertiesProfile
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationPropertiesResourceAssociation
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface NspAccessRule
info	[Changelog]   - Added Interface NspAccessRuleProperties
info	[Changelog]   - Added Interface NspAccessRulePropertiesSubscriptionsItem
info	[Changelog]   - Added Interface ProvisioningIssue
info	[Changelog]   - Added Interface ProvisioningIssueProperties
info	[Changelog]   - Added Interface RetentionDescription
info	[Changelog]   - Added Interface ThrottlingPolicy
info	[Changelog]   - Added Type Alias ApplicationGroupCreateOrUpdateApplicationGroupResponse
info	[Changelog]   - Added Type Alias ApplicationGroupGetResponse
info	[Changelog]   - Added Type Alias ApplicationGroupListByNamespaceNextResponse
info	[Changelog]   - Added Type Alias ApplicationGroupListByNamespaceResponse
info	[Changelog]   - Added Type Alias ApplicationGroupPolicyType
info	[Changelog]   - Added Type Alias ApplicationGroupPolicyUnion
info	[Changelog]   - Added Type Alias CleanupPolicyRetentionDescription
info	[Changelog]   - Added Type Alias MetricId
info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationListResponse
info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationProvisioningState
info	[Changelog]   - Added Type Alias NspAccessRuleDirection
info	[Changelog]   - Added Type Alias PublicNetworkAccess
info	[Changelog]   - Added Type Alias ResourceAssociationAccessMode
info	[Changelog]   - Added Type Alias TlsVersion
info	[Changelog]   - Interface Cluster has a new optional parameter supportsScaling
info	[Changelog]   - Interface EHNamespace has a new optional parameter minimumTlsVersion
info	[Changelog]   - Interface EHNamespace has a new optional parameter publicNetworkAccess
info	[Changelog]   - Interface Eventhub has a new optional parameter retentionDescription
info	[Changelog]   - Added Enum KnownApplicationGroupPolicyType
info	[Changelog]   - Added Enum KnownCleanupPolicyRetentionDescription
info	[Changelog]   - Added Enum KnownMetricId
info	[Changelog]   - Added Enum KnownNetworkSecurityPerimeterConfigurationProvisioningState
info	[Changelog]   - Added Enum KnownNspAccessRuleDirection
info	[Changelog]   - Added Enum KnownPublicNetworkAccess
info	[Changelog]   - Added Enum KnownResourceAssociationAccessMode
info	[Changelog]   - Added Enum KnownTlsVersion
info	[Changelog]   - Enum KnownPublicNetworkAccessFlag has a new value SecuredByPerimeter
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Interface ConsumerGroupsListByEventHubNextOptionalParams no longer has parameter skip
info	[Changelog]   - Interface ConsumerGroupsListByEventHubNextOptionalParams no longer has parameter top
info	[Changelog]   - Interface EventHubsListByNamespaceNextOptionalParams no longer has parameter skip
info	[Changelog]   - Interface EventHubsListByNamespaceNextOptionalParams no longer has parameter top
info	[Changelog]   - Interface SchemaRegistryListByNamespaceNextOptionalParams no longer has parameter skip
info	[Changelog]   - Interface SchemaRegistryListByNamespaceNextOptionalParams no longer has parameter top

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 83e7e59. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️eventhub [View full logs] [Release Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from 83e7e59. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

️✔️Az.eventhub.DefaultTag [View full logs]

Az.EventHub.0.1.0.nupkg

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.eventhub.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-05-18T20:46:24Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/eventhub/armeventhub	https://apiview.dev/Assemblies/Review/4740f097581e4941ac6ebafad363eeb8
Java	azure-resourcemanager-eventhubs-generated	https://apiview.dev/Assemblies/Review/528cbf33e31a4f2caa5b89badcbcd48d
.Net	Azure.ResourceManager.EventHubs	https://apiview.dev/Assemblies/Review/6273d0d1d35343f6ad1188f80440fcd1
JavaScript	@azure/arm-eventhub	https://apiview.dev/Assemblies/Review/cf1eb6fccd6d41d5b641b493b0bb7451

openapi-workflow-bot · 2023-05-18T20:53:43Z

Hi @kevxms, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

v-jiaodi · 2023-06-01T03:17:38Z

/azp run

azure-pipelines · 2023-06-01T03:17:49Z

Azure Pipelines successfully started running 1 pipeline(s).

v-jiaodi · 2023-06-05T05:23:40Z

@qiaozha @tadelesh could you help to take a look at the SDK BreakingChange error in this PR? Thanks

'Compact' is already implemented in the resource provider and is consistent with using verb such as type 'Delete'

rename cleaup policy type from 'Compaction' to 'Compact'

e576ea6

'Compact' is already implemented in the resource provider and is consistent with using verb such as type 'Delete'

kevxms requested review from v-Ajnava, dsouzaarun and damodaravadhani as code owners May 18, 2023 20:46

openapi-assignment-bot bot assigned v-jiaodi May 18, 2023

ghost added the Event Hubs label May 18, 2023

AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager labels May 18, 2023

azure-sdk mentioned this pull request May 18, 2023

[AutoPR sdk/resourcemanager/eventhub/armeventhub] rename cleaup policy type from 'Compaction' to 'Compact' azure-sdk/azure-sdk-for-go#5768

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label May 18, 2023

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label May 18, 2023

azure-sdk mentioned this pull request May 18, 2023

[AutoPR Azure.ResourceManager.EventHubs] rename cleaup policy type from 'Compaction' to 'Compact' azure-sdk/azure-sdk-for-net#3916

Closed

openapi-workflow-bot bot added the FixS360 label May 18, 2023

azure-sdk mentioned this pull request Jun 1, 2023

[AutoPR track2_azure-mgmt-eventhub] rename cleaup policy type from 'Compaction' to 'Compact' azure-sdk/azure-sdk-for-python#3713

Closed

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jun 2, 2023

qiaozha added the Approved-SdkBreakingChange-JavaScript label Jun 5, 2023

tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Jun 5, 2023

v-jiaodi approved these changes Jun 5, 2023

View reviewed changes

v-jiaodi added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Jun 5, 2023

weidongxu-microsoft merged commit 83e7e59 into main Jun 5, 2023

weidongxu-microsoft deleted the kevxms-eventhub-Microsoft.EventHub-2022-10-01-preview branch June 5, 2023 06:37

Alancere mentioned this pull request Aug 8, 2023

Event Hub Geo DR - New API version 2023-01-01-preview #21994

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rename cleaup policy type from 'Compaction' to 'Compact' #24056

rename cleaup policy type from 'Compaction' to 'Compact' #24056

kevxms commented May 18, 2023 •

edited

Loading

openapi-workflow-bot bot commented May 18, 2023

openapi-pipeline-app bot commented May 18, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 18, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented May 18, 2023 •

edited

Loading

openapi-workflow-bot bot commented May 18, 2023

v-jiaodi commented Jun 1, 2023

azure-pipelines bot commented Jun 1, 2023

v-jiaodi commented Jun 5, 2023

rename cleaup policy type from 'Compaction' to 'Compact' #24056

rename cleaup policy type from 'Compaction' to 'Compact' #24056

Conversation

kevxms commented May 18, 2023 • edited Loading

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented May 18, 2023

openapi-pipeline-app bot commented May 18, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented May 18, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented May 18, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented May 18, 2023

v-jiaodi commented Jun 1, 2023

azure-pipelines bot commented Jun 1, 2023

v-jiaodi commented Jun 5, 2023

kevxms commented May 18, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 18, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 18, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 18, 2023 •

edited

Loading