[Compute] API Version 2023-01-02 #24364

haagha · 2023-06-08T18:02:14Z

ARM API Information (Control Plane)

ARM has already signed off on the new feature change for this API version:
Added fileFormat to GrantAccessData for DD snapshots (https://github.com/Azure/azure-rest-api-specs/pull/23528[)](https://github.com/Azure/azure-rest-api-specs/pull/24364/commits/86d06da9f84048ba3be06003163e5d2bd1e68305)

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>

* Added fileFormat to GrantAccessData * Added VHDX word to custom-words * Added examples

Description for None.

…01-02

openapi-workflow-bot · 2023-06-08T18:02:17Z

Hi, @haagha Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2023-06-08T18:02:18Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️Breaking Change(Cross-Version): 21 Warnings warning [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
disk.json	2023-01-02(3ecc2fe)	2022-07-02(main)
disk.json	2023-01-02(3ecc2fe)	2016-04-30-preview(main)
diskAccess.json	2023-01-02(3ecc2fe)	2022-07-02(main)
diskEncryptionSet.json	2023-01-02(3ecc2fe)	2022-07-02(main)
diskRPCommon.json	2023-01-02(3ecc2fe)	2022-07-02(main)
diskRestorePoint.json	2023-01-02(3ecc2fe)	2022-07-02(main)
snapshot.json	2023-01-02(3ecc2fe)	2022-07-02(main)

The following breaking changes are detected by comparison with the latest preview version:

Rule	Message
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/snapshots/{snapshotName}' removed or restructured? Old: DiskRP/preview/2016-04-30-preview/disk.json#L368:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/snapshots' removed or restructured? Old: DiskRP/preview/2016-04-30-preview/disk.json#L541:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Compute/snapshots' removed or restructured? Old: DiskRP/preview/2016-04-30-preview/disk.json#L577:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/snapshots/{snapshotName}/beginGetAccess' removed or restructured? Old: DiskRP/preview/2016-04-30-preview/disk.json#L610:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/snapshots/{snapshotName}/endGetAccess' removed or restructured? Old: DiskRP/preview/2016-04-30-preview/disk.json#L654:5
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'EncryptionSettings' removed or renamed? New: DiskRP/stable/2023-01-02/disk.json#L472:3 Old: DiskRP/preview/2016-04-30-preview/disk.json#L693:3
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'Snapshot' removed or renamed? New: DiskRP/stable/2023-01-02/disk.json#L472:3 Old: DiskRP/preview/2016-04-30-preview/disk.json#L693:3
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'SnapshotUpdate' removed or renamed? New: DiskRP/stable/2023-01-02/disk.json#L472:3 Old: DiskRP/preview/2016-04-30-preview/disk.json#L693:3
⚠️ 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'SnapshotNameParameter' removed or renamed? New: DiskRP/stable/2023-01-02/disk.json#L892:3 Old: DiskRP/preview/2016-04-30-preview/disk.json#L1201:3
⚠️ 1025 - RequiredStatusChange	The 'required' status changed from the old version('True') to the new version('False'). New: DiskRP/stable/2023-01-02/diskRPCommon.json#L375:7 Old: DiskRP/preview/2016-04-30-preview/disk.json#L992:7
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: DiskRP/stable/2023-01-02/disk.json#L180:13 Old: DiskRP/preview/2016-04-30-preview/disk.json#L108:13
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: DiskRP/stable/2023-01-02/disk.json#L514:5 Old: DiskRP/preview/2016-04-30-preview/disk.json#L755:5
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'accountType' renamed or removed? New: DiskRP/stable/2023-01-02/disk.json#L610:7 Old: DiskRP/preview/2016-04-30-preview/disk.json#L789:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'encryptionSettings' renamed or removed? New: DiskRP/stable/2023-01-02/disk.json#L610:7 Old: DiskRP/preview/2016-04-30-preview/disk.json#L789:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'ownerId' renamed or removed? New: DiskRP/stable/2023-01-02/disk.json#L610:7 Old: DiskRP/preview/2016-04-30-preview/disk.json#L789:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'accountType' renamed or removed? New: DiskRP/stable/2023-01-02/disk.json#L777:7 Old: DiskRP/preview/2016-04-30-preview/disk.json#L910:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'creationData' renamed or removed? New: DiskRP/stable/2023-01-02/disk.json#L777:7 Old: DiskRP/preview/2016-04-30-preview/disk.json#L910:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'encryptionSettings' renamed or removed? New: DiskRP/stable/2023-01-02/disk.json#L777:7 Old: DiskRP/preview/2016-04-30-preview/disk.json#L910:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'properties' renamed or removed? New: DiskRP/stable/2023-01-02/diskRPCommon.json#L576:7 Old: DiskRP/preview/2016-04-30-preview/disk.json#L1034:7
⚠️ 1047 - XmsEnumChanged	The new version has a different x-ms-enum 'modelAsString' than the previous one. New: DiskRP/stable/2023-01-02/diskRPCommon.json#L263:9 Old: DiskRP/preview/2016-04-30-preview/disk.json#L953:9
⚠️ 1047 - XmsEnumChanged	The new version has a different x-ms-enum 'modelAsString' than the previous one. New: DiskRP/stable/2023-01-02/diskRPCommon.json#L525:9 Old: DiskRP/preview/2016-04-30-preview/disk.json#L1010:9

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.3)	new version	base version
package-2023-01-02	package-2023-01-02(3ecc2fe)	default(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'diskName' should be defined with a 'pattern' restriction. Location: DiskRP/stable/2023-01-02/disk.json#L37
`❌` ProvisioningStateSpecifiedForLROPut	201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: DiskRP/stable/2023-01-02/disk.json#L38
`❌` MissingDefaultResponse	Operation is missing a default response. Location: DiskRP/stable/2023-01-02/disk.json#L67
`❌` PutResponseSchemaDescription	Any Put MUST contain 200 and 201 return codes. Location: DiskRP/stable/2023-01-02/disk.json#L67
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: DiskRP/stable/2023-01-02/disk.json#L74
`❌` MissingDefaultResponse	Operation is missing a default response. Location: DiskRP/stable/2023-01-02/disk.json#L186
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: DiskRP/stable/2023-01-02/disk.json#L193
`❌` MissingDefaultResponse	Operation is missing a default response. Location: DiskRP/stable/2023-01-02/disk.json#L254
`❌` MissingDefaultResponse	Operation is missing a default response. Location: DiskRP/stable/2023-01-02/disk.json#L288
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: DiskRP/stable/2023-01-02/disk.json#L292
`❌` MissingDefaultResponse	Operation is missing a default response. Location: DiskRP/stable/2023-01-02/disk.json#L325
`❌` MissingDefaultResponse	Operation is missing a default response. Location: DiskRP/stable/2023-01-02/disk.json#L358
`❌` ResourceNameRestriction	The resource name parameter 'diskName' should be defined with a 'pattern' restriction. Location: DiskRP/stable/2023-01-02/disk.json#L376
`❌` MissingDefaultResponse	Operation is missing a default response. Location: DiskRP/stable/2023-01-02/disk.json#L406
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: DiskRP/stable/2023-01-02/disk.json#L413
`❌` ResourceNameRestriction	The resource name parameter 'diskName' should be defined with a 'pattern' restriction. Location: DiskRP/stable/2023-01-02/disk.json#L431
`❌` LroPostReturn	200 response for a LRO POST operation must have a response schema specified. Location: DiskRP/stable/2023-01-02/disk.json#L432
`❌` MissingDefaultResponse	Operation is missing a default response. Location: DiskRP/stable/2023-01-02/disk.json#L452
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: DiskRP/stable/2023-01-02/disk.json#L456
`❌` ResourceNameRestriction	The resource name parameter 'diskAccessName' should be defined with a 'pattern' restriction. Location: DiskRP/stable/2023-01-02/diskAccess.json#L37
`❌` ProvisioningStateSpecifiedForLROPut	201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: DiskRP/stable/2023-01-02/diskAccess.json#L38
`❌` PutResponseSchemaDescription	Any Put MUST contain 200 and 201 return codes. Location: DiskRP/stable/2023-01-02/diskAccess.json#L67
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: DiskRP/stable/2023-01-02/diskAccess.json#L74
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: DiskRP/stable/2023-01-02/diskAccess.json#L83
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: DiskRP/stable/2023-01-02/diskAccess.json#L130
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: DiskRP/stable/2023-01-02/diskAccess.json#L139
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: DiskRP/stable/2023-01-02/diskAccess.json#L217
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: DiskRP/stable/2023-01-02/diskAccess.json#L226
`❌` ResourceNameRestriction	The resource name parameter 'diskAccessName' should be defined with a 'pattern' restriction. Location: DiskRP/stable/2023-01-02/diskAccess.json#L319
`❌` MissingDefaultResponse	Operation is missing a default response. Location: DiskRP/stable/2023-01-02/diskAccess.json#L340

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2023-01-02

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️❌~[Staging] ServiceAPIReadinessTest: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` Error	"\nfatal error: Failed to execute scenario: GeneratedScenario: Failed to execute step CloudServicesUpdateDomain_WalkUpdateDomain: variable.value.substring is not a function \nTypeError: variable.value.substring is not a function\n at PostmanUrl.encodeVariable (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/apiScenario/postmanCollectionRunnerClient.js:468:60)\n at arrayEach (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/node_modules/lodash/lodash.js:530:11)\n at Function.forEach (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/node_modules/lodash/lodash.js:9410:14)\n at PostmanVariableList.each (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/node_modules/postman-collection/lib/collection/property-list.js:413:11)\n at PostmanCollectionRunnerClient.sendRestCallRequest (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/apiScenario/postmanCollectionRunnerClient.js:473:36)\n at ApiScenarioRunner.executeRestCallStep (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/apiScenario/apiScenarioRunner.js:230:27)\n at ApiScenarioRunner.executeStep (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/apiScenario/apiScenarioRunner.js:89:32)\n at ApiScenarioRunner.execute (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/apiScenario/apiScenarioRunner.js:74:32)\n at async PostmanCollectionRunner.generateCollection (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/apiScenario/postmanCollectionGenerator.js:215:9)\n at async PostmanCollectionRunner.doRun (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/apiScenario/postmanCollectionGenerator.js:166:9)\n at async PostmanCollectionRunner.run (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/apiScenario/postmanCollectionGenerator.js:108:9)\n at async PostmanCollectionGenerator.run (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/apiScenario/postmanCollectionGenerator.js:424:28)\n at async /opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/commands/run-api-scenario.js:232:13\n at async Object.exports.cliSuppressExceptions (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/cliSuppressExceptions.js:9:28)\n at async Object.handler (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/commands/run-api-scenario.js:139:5) \nError: Failed to execute step CloudServicesUpdateDomain_WalkUpdateDomain: variable.value.substring is not a function \nTypeError: variable.value.substring is not a function\n at PostmanUrl.encodeVariable (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/apiScenario/postmanCollectionRunnerClient.js:468:60)\n at arrayEach (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/node_modules/lodash/lodash.js:530:11)\n at Function.forEach (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/node_modules/lodash/lodash.js:9410:14)\n at PostmanVariableList.each (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/node_modules/postman-collection/lib/collection/property-list.js:413:11)\n at PostmanCollectionRunnerClient.sendRestCallRequest (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/apiScenario/postmanCollectionRunnerClient.js:473:36)\n at ApiScenarioRunner.executeRestCallStep (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/apiScenario/apiScenarioRunner.js:230:27)\n at ApiScenarioRunner.executeStep (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/apiScenario/apiScenarioRunner.js:89:32)\n at ApiScenarioRunner.execute (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/apiScenario/apiScenarioRunner.js:74:32)\n at async PostmanCollectionRunner.generateCollection (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/apiScenario/postmanCollectionGenerator.js:215:9)\n at async PostmanCollectionRunner.doRun (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/apiScenario/postmanCollectionGenerator.js:166:9)\n at async PostmanCollectionRunner.run (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/apiScenario/postmanCollectionGenerator.js:108:9)\n at async PostmanCollectionGenerator.run (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/apiScenario/postmanCollectionGenerator.js:424:28)\n at async /opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/commands/run-api-scenario.js:232:13\n at async Object.exports.cliSuppressExceptions (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/cliSuppressExceptions.js:9:28)\n at async Object.handler (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/commands/run-api-scenario.js:139:5)\n at ApiScenarioRunner.executeStep (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/apiScenario/apiScenarioRunner.js:100:19)\n at async ApiScenarioRunner.execute (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/apiScenario/apiScenarioRunner.js:74:21)\n at async PostmanCollectionRunner.generateCollection (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/apiScenario/postmanCollectionGenerator.js:215:9)\n at async PostmanCollectionRunner.doRun (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/apiScenario/postmanCollectionGenerator.js:166:9)\n at async PostmanCollectionRunner.run (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/apiScenario/postmanCollectionGenerator.js:108:9)\n at async PostmanCollectionGenerator.run (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/apiScenario/postmanCollectionGenerator.js:424:28)\n at async /opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/commands/run-api-scenario.js:232:13\n at async Object.exports.cliSuppressExceptions (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/cliSuppressExceptions.js:9:28)\n at async Object.handler (/opt/hostedtoolcache/node/14.21.3/x64/lib/node_modules/oav/dist/lib/commands/run-api-scenario.js:139:5), \n"

️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-06-08T18:02:19Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from b1d41f8. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.Compute [View full logs] [Release SDK Changes]
- Azure.ResourceManager.Compute.1.2.0-alpha.20230628.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from b1d41f8. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.7.2
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.7.2>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.7.2` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-compute [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added model CommunityGalleryImageIdentifier
info	[Changelog]   - Added model EdgeZoneStorageAccountType

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from b1d41f8. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-compute-generated [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from b1d41f8. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-compute [View full logs] [Release SDK Changes]

azure-arm-compute-21.1.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Type Alias FileFormat
info	[Changelog]   - Interface GrantAccessData has a new optional parameter fileFormat
info	[Changelog]   - Added Enum KnownFileFormat

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from b1d41f8. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/compute/armcompute [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New enum type `FileFormat` with values `FileFormatVHD`, `FileFormatVHDX`
info	[Changelog] - New field `FileFormat` in struct `GrantAccessData`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 4 additive change(s).

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from b1d41f8. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️compute [View full logs] [Release Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from b1d41f8. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

❌Az.compute.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.compute.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-06-08T18:02:19Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/compute/armcompute	https://apiview.dev/Assemblies/Review/bffba39082fd4f418e5c24ee4bea5c47
Java	azure-resourcemanager-compute-generated	https://apiview.dev/Assemblies/Review/e6601efcaf8e4c4eb34473412867d6e0
.Net	Azure.ResourceManager.Compute	https://apiview.dev/Assemblies/Review/758c506b59c645e29bbee1b91a199068
JavaScript	@azure/arm-compute	https://apiview.dev/Assemblies/Review/608f26d8c249482c94ac94186b058e3f

openapi-workflow-bot · 2023-06-08T18:10:22Z

Hi @haagha, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

openapi-workflow-bot · 2023-06-08T18:10:22Z

Hi, @haagha, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

haagha · 2023-06-08T18:42:38Z

@Wzb123456789 The Model validation error does not make sense to me since the "Id" is already present in the example.

Wzb123456789 · 2023-06-09T06:41:31Z

Please check and approve this PR so that I can get the SDK owner to check BreakingChange.

haagha · 2023-06-09T20:41:27Z

@Wzb123456789 The Model validation error does not make sense to me since the "Id" is already present in the example.

@ms-zhenhua could you also comment on the model validation issue? Thanks.

Wzb123456789 · 2023-06-25T06:40:09Z

@ms-zhenhua Please check and approve this PR so that I can get the SDK owner to check BreakingChange.

haagha · 2023-06-27T04:26:40Z

@ms-zhenhua Please check and approve this PR so that I can get the SDK owner to check BreakingChange.

ARM has already signed off. I asked Zhenhua Hu and they had no further comments.

Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com> Co-authored-by: Theodore Chang <thchan@microsoft.com> Co-authored-by: shpimpal <34675111+shpimpal@users.noreply.github.com>

haagha and others added 7 commits March 1, 2023 12:41

first commit

b969574

modified files to 2023-01-02 version

fa7789f

fix model validations (#23156)

df14545

Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>

Added fileFormat to GrantAccessData for DD snapshots (#23528)

86d06da

* Added fileFormat to GrantAccessData * Added VHDX word to custom-words * Added examples

Update diskRPCommon.json

a6e02bc

Description for None.

Removing FileFormat enum None

cc6895d

Merge remote-tracking branch 'upstream/main' into feature/cplat-2023-…

2ef00e1

…01-02

haagha requested review from Sandido, dkulkarni-ms, madewithsmiles, MS-syh2qs, grizzlytheodore and hyonholee as code owners June 8, 2023 18:02

openapi-assignment-bot bot assigned Wzb123456789 Jun 8, 2023

ghost added the Compute label Jun 8, 2023

azure-sdk mentioned this pull request Jun 8, 2023

[AutoPR sdk/resourcemanager/compute/armcompute] [Compute] API Version 2023-01-02 azure-sdk/azure-sdk-for-go#6104

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Jun 8, 2023

AzureRestAPISpecReview added ARMReview CI-FixRequiredOnFailure CI-MissingBaseCommit new-api-version resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 8, 2023

azure-sdk mentioned this pull request Jun 8, 2023

[AutoPR @azure/arm-compute] [Compute] API Version 2023-01-02 azure-sdk/azure-sdk-for-js#5389

Closed

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Jun 8, 2023

updating compute version from 2022-11-01 to 2023-03-01 in readme.md

10b4e3c

azure-sdk mentioned this pull request Jun 8, 2023

[AutoPR track2_azure-mgmt-compute] [Compute] API Version 2023-01-02 azure-sdk/azure-sdk-for-python#3789

Closed

ms-zhenhua added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 9, 2023

haagha added 2 commits June 20, 2023 08:40

Update Disk_Create_Empty.json

21fba09

Merge branch 'main' into feature/cplat-2023-01-02

e6eebc8

AzureRestAPISpecReview added ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test and removed CI-FixRequiredOnFailure labels Jun 20, 2023

Merge branch 'main' into feature/cplat-2023-01-02

3ecc2fe

Wzb123456789 assigned rkmanda and unassigned Wzb123456789 Jun 27, 2023

ArcturusZhang approved these changes Jun 28, 2023

View reviewed changes

ArcturusZhang merged commit b1d41f8 into main Jun 28, 2023

ArcturusZhang deleted the feature/cplat-2023-01-02 branch June 28, 2023 04:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Compute] API Version 2023-01-02 #24364

[Compute] API Version 2023-01-02 #24364

haagha commented Jun 8, 2023 •

edited

Loading

openapi-workflow-bot bot commented Jun 8, 2023

openapi-pipeline-app bot commented Jun 8, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 8, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Jun 8, 2023 •

edited

Loading

openapi-workflow-bot bot commented Jun 8, 2023

openapi-workflow-bot bot commented Jun 8, 2023

haagha commented Jun 8, 2023

Wzb123456789 commented Jun 9, 2023

haagha commented Jun 9, 2023 •

edited

Loading

Wzb123456789 commented Jun 25, 2023

haagha commented Jun 27, 2023

[Compute] API Version 2023-01-02 #24364

[Compute] API Version 2023-01-02 #24364

Conversation

haagha commented Jun 8, 2023 • edited Loading

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jun 8, 2023

openapi-pipeline-app bot commented Jun 8, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jun 8, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Jun 8, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Jun 8, 2023

openapi-workflow-bot bot commented Jun 8, 2023

haagha commented Jun 8, 2023

Wzb123456789 commented Jun 9, 2023

haagha commented Jun 9, 2023 • edited Loading

Wzb123456789 commented Jun 25, 2023

haagha commented Jun 27, 2023

haagha commented Jun 8, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 8, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 8, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 8, 2023 •

edited

Loading

haagha commented Jun 9, 2023 •

edited

Loading