Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release redisenterprise-Microsoft.cache 2023-07-01 #24548

Conversation

revanthballa1188
Copy link
Contributor

@revanthballa1188 revanthballa1188 commented Jun 22, 2023

ARM (Control Plane) API Specification Update Pull Request

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

ARM API changes review

  • If you want for the ARM team to review this PR, you must add the ARMReview label.
  • The automation may automatically add the ARMReview label, if appropriate.
    If this happens, proceed according to guidance given in GitHub comments also added by the automation.

Breaking change review

If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.

Getting help

@openapi-workflow-bot
Copy link

Hi, @revanthballa1188 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 22, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️Breaking Change(Cross-Version): 19 Warnings warning [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    redisenterprise.json 2023-07-01(55aecfd) 2022-01-01(main)
    redisenterprise.json 2023-07-01(55aecfd) 2023-03-01-preview(main)

    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/locations/{location}/skus' removed or restructured?
    Old: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L1271:5
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'SkuName' removed or renamed?
    New: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L1272:3
    Old: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L1314:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'systemData' removed or renamed?
    New: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L1272:3
    Old: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L1314:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'UserAssignedIdentities' removed or renamed?
    New: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L1272:3
    Old: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L1314:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ManagedServiceIdentityType' removed or renamed?
    New: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L1272:3
    Old: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L1314:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ManagedServiceIdentity' removed or renamed?
    New: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L1272:3
    Old: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L1314:3
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L1277:9
    Old: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L1319:9
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L1852:11
    Old: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L2006:11
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'identity' renamed or removed?
    New: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L1347:7
    Old: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L1376:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'encryption' renamed or removed?
    New: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L1405:7
    Old: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L1442:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    New: common-types/resource-management/v2/privatelinks.json#L22:7
    Old: common-types/resource-management/v3/privatelinks.json#L22:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    New: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L1347:7
    Old: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L1376:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'identity' renamed or removed?
    New: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L1377:7
    Old: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L1410:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    New: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L1470:7
    Old: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L1545:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    New: common-types/resource-management/v2/privatelinks.json#L105:7
    Old: common-types/resource-management/v3/privatelinks.json#L105:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    New: common-types/resource-management/v2/types.json#L54:7
    Old: common-types/resource-management/v3/types.json#L60:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    New: common-types/resource-management/v2/types.json#L37:7
    Old: common-types/resource-management/v3/types.json#L43:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    New: common-types/resource-management/v2/types.json#L13:7
    Old: common-types/resource-management/v3/types.json#L13:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️❌LintDiff: 2 Errors, 7 Warnings failed [Detail]
    compared tags (via openapi-validator v2.1.4) new version base version
    package-2023-07 package-2023-07(55aecfd) default(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    PostOperationAsyncResponseValidation An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L716
    XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L1569
    ⚠️ RequiredReadOnlySystemData The response of operation:'RedisEnterprise_Create' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L116
    ⚠️ RequiredReadOnlySystemData The response of operation:'RedisEnterprise_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L175
    ⚠️ PageableOperation Based on the response model schema, operation 'RedisEnterprise_Get' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L278
    ⚠️ RequiredReadOnlySystemData The response of operation:'RedisEnterprise_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L278
    ⚠️ RequiredReadOnlySystemData The response of operation:'Databases_Create' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L447
    ⚠️ RequiredReadOnlySystemData The response of operation:'Databases_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L513
    ⚠️ RequiredReadOnlySystemData The response of operation:'Databases_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L573


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L115
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L220
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L264
    ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L400
    ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L446
    ResourceNameRestriction The resource name parameter 'databaseName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L446
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L562
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L654
    ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L669
    ResourceNameRestriction The resource name parameter 'databaseName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L669
    ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L715
    ResourceNameRestriction The resource name parameter 'databaseName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L715
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L765
    ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L777
    ResourceNameRestriction The resource name parameter 'databaseName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L777
    LroPostReturn 200 response for a LRO POST operation must have a response schema specified.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L778
    PostOperationAsyncResponseValidation An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L778
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L824
    ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L836
    ResourceNameRestriction The resource name parameter 'databaseName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L836
    LroPostReturn 200 response for a LRO POST operation must have a response schema specified.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L837
    PostOperationAsyncResponseValidation An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L837
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L883
    ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L895
    GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L924
    ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L940
    ResourceNameRestriction The resource name parameter 'privateEndpointConnectionName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L940
    ProvisioningStateSpecifiedForLROPut 200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L984
    PutResponseSchemaDescription Any Put MUST contain 200 and 201 return codes.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L1022
    ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L1098
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    ️️✔️Automated merging requirements met succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 22, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-js - @azure/arm-redisenterprisecache - Approved - 3.0.0
    +	Removed operation PrivateEndpointConnections.delete
    azure-sdk-for-go - sdk/resourcemanager/redisenterprise/armredisenterprise - Approved - 2.0.0
    +	Operation `*PrivateEndpointConnectionsClient.Delete` has been changed to LRO, use `*PrivateEndpointConnectionsClient.BeginDelete` instead.
    azure-sdk-for-python-track2 - track2_azure-mgmt-redisenterprise - Approved - 2.0.0
    +	Renamed operation PrivateEndpointConnectionsOperations.delete to PrivateEndpointConnectionsOperations.begin_delete
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 3784ff4. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.6.7 -> 9.8.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.8.1` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-redisenterprise [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation DatabasesOperations.begin_flush
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Renamed operation PrivateEndpointConnectionsOperations.delete to PrivateEndpointConnectionsOperations.begin_delete
    ️⚠️ azure-sdk-for-java warning [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 3784ff4. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/redisenterprise/armredisenterprise [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Operation `*PrivateEndpointConnectionsClient.Delete` has been changed to LRO, use `*PrivateEndpointConnectionsClient.BeginDelete` instead.
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New function `*DatabasesClient.BeginFlush(context.Context, string, string, string, FlushParameters, *DatabasesClientBeginFlushOptions) (*runtime.Poller[DatabasesClientFlushResponse], error)`
      info	[Changelog] - New struct `FlushParameters`
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 3 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 3784ff4. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-redisenterprisecache [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation Databases.beginFlush
      info	[Changelog]   - Added operation Databases.beginFlushAndWait
      info	[Changelog]   - Added operation PrivateEndpointConnections.beginDelete
      info	[Changelog]   - Added operation PrivateEndpointConnections.beginDeleteAndWait
      info	[Changelog]   - Added Interface DatabasesFlushHeaders
      info	[Changelog]   - Added Interface DatabasesFlushOptionalParams
      info	[Changelog]   - Added Interface FlushParameters
      info	[Changelog]   - Added Interface PrivateEndpointConnectionsDeleteHeaders
      info	[Changelog]   - Interface PrivateEndpointConnectionsDeleteOptionalParams has a new optional parameter resumeFrom
      info	[Changelog]   - Interface PrivateEndpointConnectionsDeleteOptionalParams has a new optional parameter updateIntervalInMs
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation PrivateEndpointConnections.delete
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 3784ff4. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️redisenterprise [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from 3784ff4. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • ⚠️Az.redisenterprise.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.redisenterprise.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 22, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/redisenterprise/armredisenterprise https://apiview.dev/Assemblies/Review/5c80ed50e9a04f75bb7f10e1c7007f56
    Java azure-resourcemanager-redisenterprise https://apiview.dev/Assemblies/Review/55d6a5c34c4d4c1fa9287a356156be1e
    .Net Azure.ResourceManager.RedisEnterprise https://apiview.dev/Assemblies/Review/4843fbe8cde849ddbade537ca06d4c4c
    JavaScript @azure/arm-redisenterprisecache https://apiview.dev/Assemblies/Review/21e182c260ba4622b408d3c08d6993e8

    @openapi-workflow-bot
    Copy link

    Hi @revanthballa1188! Your PR has some issues. Please fix the CI issues, if present, in following order: Avocado, SemanticValidation, ModelValidation, Breaking Change, LintDiff.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic ValidationFix-SemanticValidation-ErrorHigh
    Model ValidationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffHigh

    If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel.

    @openapi-workflow-bot
    Copy link

    Hi @revanthballa1188! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
    For more details refer to the wiki.

    Copy link
    Member

    @ms-henglu ms-henglu left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Please also check and fix the LintDiff errors.

    @ms-henglu ms-henglu added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 22, 2023
    @openapi-workflow-bot
    Copy link

    Please address or respond to feedback from the ARM API reviewer. When you are ready to continue the ARM API review, please remove the ARMChangesRequested label. This will notify the reviewer to have another look.
    If the feedback provided needs further discussion, please use this Teams channel to post your questions - https://aka.ms/azsdk/support/specreview-channel.
    Please indicate that this is an ARM-related question in the title of your post by including "[ARM Query]" in the title.

    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 22, 2023
    @v-xuto
    Copy link
    Member

    v-xuto commented Jun 25, 2023

    @revanthballa1188 Please fix CI checks errors (LintDiff, SemanticValidation, Avocado, Model validation, PrettierCheck), you can refer to this comments or https://aka.ms/ci-fix on how to fix it.

    @revanthballa1188
    Copy link
    Contributor Author

    @visingla-ms Can you please merge this,
    I see it is signed off and the JS breaking is also approved

    @revanthballa1188
    Copy link
    Contributor Author

    The lint diff errors are not part of this PR changes and have the the same in the last release as well.
    those will be fixed in the subsequent released after discussing with the team on whether they will impact customer flow or not

    @revanthballa1188
    Copy link
    Contributor Author

    @rkmanda Can you please merge this PR. I added the tag MergeRequested yesterday, but for some reason, it is not yet merged!
    I believe, it will merge twice a day right?

    @rkmanda
    Copy link
    Member

    rkmanda commented Aug 11, 2023

    Theres a required check failing. I am reaching out to the tooling team to check

    @konrad-jamrozik
    Copy link

    konrad-jamrozik commented Aug 11, 2023

    @rkmanda

    Looks like the ⁠SDK check failed with runtime exception. I am not 100% sure but I suspect that this is the root-cause of the PR missing the label CI-BreakingChange-Go. I will add this label now, which will make the automated merging requirements met check fail, as it should. I am currently working on making the merging requirements met check also recognize failures of the dependency checks.

    Update: not working as expected. Investigating.

    "default": {
    "description": "Error response describing why the operation failed.",
    "schema": {
    "$ref": "../../../../../common-types/resource-management/v3/types.json#/definitions/ErrorResponse"
    Copy link
    Contributor

    @Alancere Alancere Aug 14, 2023

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @revanthballa1188, please ref to the common-type version uniformly.
    Currently there are v2 and v3, azure-sdk-for-go appeared Duplicate Schema named 'ErrorResponse'

    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Updated to use V2

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 16, 2023

    Next Steps to Merge

    ⚠️ This is an experimental comment. It may not always be up-to-date. ⚠️

    ✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

    @openapi-pipeline-app
    Copy link

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.