Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.ContainerRegistry to add version stable/2023-07-01 #24771

Conversation

AntonioVT
Copy link
Member

@AntonioVT AntonioVT commented Jul 11, 2023

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM (Control Plane) API Specification Update Pull Request

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

ARM API changes review

  • If you want for the ARM team to review this PR, you must add the ARMReview label.
  • The automation may automatically add the ARMReview label, if appropriate.
    If this happens, proceed according to guidance given in GitHub comments also added by the automation.

Breaking change review

If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.

Getting help

@openapi-workflow-bot
Copy link

Hi, @AntonioVT! Thank you for your pull request. To help get your PR merged:

  • Ensure you reviewed the checklists in the PR description.
  • Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.
  • For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
  • @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 11, 2023

    Swagger Validation Report

    ️🔄BreakingChange inProgress [Detail]
    ️❌Breaking Change(Cross-Version): 13 Errors, 74 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    containerregistry.json 2023-07-01(05a2ef1) 2022-12-01(main)
    containerregistry.json 2023-07-01(05a2ef1) 2023-06-01-preview(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Rule Message
    1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
    New: common-types/resource-management/v5/types.json#L264:7
    Old: Microsoft.ContainerRegistry/stable/2022-12-01/containerregistry.json#L4332:7
    1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
    New: common-types/resource-management/v5/types.json#L264:7
    Old: Microsoft.ContainerRegistry/stable/2022-12-01/containerregistry.json#L4364:7
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2741:9
    Old: Microsoft.ContainerRegistry/stable/2022-12-01/containerregistry.json#L2580:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2746:9
    Old: Microsoft.ContainerRegistry/stable/2022-12-01/containerregistry.json#L2584:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2820:9
    Old: Microsoft.ContainerRegistry/stable/2022-12-01/containerregistry.json#L2729:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2825:9
    Old: Microsoft.ContainerRegistry/stable/2022-12-01/containerregistry.json#L2733:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: common-types/resource-management/v5/types.json#L265:9
    Old: Microsoft.ContainerRegistry/stable/2022-12-01/containerregistry.json#L4333:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: common-types/resource-management/v5/types.json#L270:9
    Old: Microsoft.ContainerRegistry/stable/2022-12-01/containerregistry.json#L4337:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: common-types/resource-management/v5/types.json#L275:9
    Old: Microsoft.ContainerRegistry/stable/2022-12-01/containerregistry.json#L4341:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: common-types/resource-management/v5/types.json#L265:9
    Old: Microsoft.ContainerRegistry/stable/2022-12-01/containerregistry.json#L4365:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: common-types/resource-management/v5/types.json#L270:9
    Old: Microsoft.ContainerRegistry/stable/2022-12-01/containerregistry.json#L4369:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: common-types/resource-management/v5/types.json#L275:9
    Old: Microsoft.ContainerRegistry/stable/2022-12-01/containerregistry.json#L4373:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: common-types/resource-management/v5/types.json#L280:9
    Old: Microsoft.ContainerRegistry/stable/2022-12-01/containerregistry.json#L4345:9
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: common-types/resource-management/v5/types.json#L308:9
    Old: Microsoft.ContainerRegistry/stable/2022-12-01/containerregistry.json#L4320:9
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: common-types/resource-management/v5/types.json#L283:11
    Old: Microsoft.ContainerRegistry/stable/2022-12-01/containerregistry.json#L4348:11


    The following breaking changes are detected by comparison with the latest preview version:

    Only 26 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/packages/{packageType}/archives' removed or restructured?
    Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L18:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/packages/{packageType}/archives/{archiveName}' removed or restructured?
    Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L66:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/packages/{packageType}/archives/{archiveName}/versions' removed or restructured?
    Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L294:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/packages/{packageType}/archives/{archiveName}/versions/{archiveVersionName}' removed or restructured?
    Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L345:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/connectedRegistries' removed or restructured?
    Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L797:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/connectedRegistries/{connectedRegistryName}' removed or restructured?
    Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L845:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/connectedRegistries/{connectedRegistryName}/deactivate' removed or restructured?
    Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1079:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/exportPipelines' removed or restructured?
    Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1412:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/exportPipelines/{exportPipelineName}' removed or restructured?
    Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1457:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/importPipelines' removed or restructured?
    Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1684:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/importPipelines/{importPipelineName}' removed or restructured?
    Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1729:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/pipelineRuns' removed or restructured?
    Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1968:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/pipelineRuns/{pipelineRunName}' removed or restructured?
    Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L2013:5
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'Archive' removed or renamed?
    New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3
    Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ArchiveProperties' removed or renamed?
    New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3
    Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ArchivePackageSourceProperties' removed or renamed?
    New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3
    Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ArchiveUpdateParameters' removed or renamed?
    New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3
    Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ArchiveUpdateProperties' removed or renamed?
    New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3
    Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ConnectedRegistry' removed or renamed?
    New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3
    Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ConnectedRegistryProperties' removed or renamed?
    New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3
    Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ActivationProperties' removed or renamed?
    New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3
    Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ParentProperties' removed or renamed?
    New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3
    Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'LoginServerProperties' removed or renamed?
    New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3
    Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'LoggingProperties' removed or renamed?
    New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3
    Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'SyncProperties' removed or renamed?
    New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3
    Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'TlsProperties' removed or renamed?
    New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3
    Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.4) new version base version
    package-2023-07 package-2023-07(05a2ef1) default(main)

    The following errors/warnings exist before current PR submission:

    Only 26 items are listed, please refer to log for more details.

    Rule Message
    PutResponseSchemaDescription Description of 200 response code of a PUT operation MUST include term 'update'.
    Location: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L139
    PutResponseSchemaDescription Description of 201 response code of a PUT operation MUST include term 'create'.
    Location: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L139
    PatchResponseCode LRO PATCH must have 200 and 202 return codes.
    Location: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L226
    LroPatch202 The async patch operation should return 202.
    Location: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L258
    PutResponseSchemaDescription Description of 200 response code of a PUT operation MUST include term 'update'.
    Location: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L415
    PutResponseSchemaDescription Description of 201 response code of a PUT operation MUST include term 'create'.
    Location: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L415
    PatchResponseCode LRO PATCH must have 200 and 202 return codes.
    Location: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L502
    LroPatch202 The async patch operation should return 202.
    Location: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L534
    LroPostReturn 200 response for a LRO POST operation must have a response schema specified.
    Location: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L571
    MissingDefaultResponse Operation is missing a default response.
    Location: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L600
    RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L600
    MissingDefaultResponse Operation is missing a default response.
    Location: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L642
    RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L642
    OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
    Location: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L646
    MissingDefaultResponse Operation is missing a default response.
    Location: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L684
    RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L684
    MissingDefaultResponse Operation is missing a default response.
    Location: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L723
    RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L723
    ResourceNameRestriction The resource name parameter 'privateEndpointConnectionName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L741
    MissingDefaultResponse Operation is missing a default response.
    Location: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L765
    RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L765
    MissingDefaultResponse Operation is missing a default response.
    Location: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L811
    PutResponseSchemaDescription Description of 200 response code of a PUT operation MUST include term 'update'.
    Location: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L811
    PutResponseSchemaDescription Description of 201 response code of a PUT operation MUST include term 'create'.
    Location: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L811
    RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L811
    MissingDefaultResponse Operation is missing a default response.
    Location: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L863
    ️❌Avocado: 15 Errors, 1 Warnings failed [Detail]
    Rule Message
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/listPolicies is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/containerregistry/resource-manager/readme.md
    json: Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/updatePolicies is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/containerregistry/resource-manager/readme.md
    json: Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/exportPipelines/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/containerregistry/resource-manager/readme.md
    json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/exportPipelines is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/containerregistry/resource-manager/readme.md
    json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/importPipelines/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/containerregistry/resource-manager/readme.md
    json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/importPipelines is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/containerregistry/resource-manager/readme.md
    json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/pipelineRuns/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/containerregistry/resource-manager/readme.md
    json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/pipelineRuns is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/containerregistry/resource-manager/readme.md
    json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/connectedRegistries/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/containerregistry/resource-manager/readme.md
    json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/connectedRegistries is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/containerregistry/resource-manager/readme.md
    json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/connectedRegistries/{}/deactivate is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/containerregistry/resource-manager/readme.md
    json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/packages/{}/archives is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/containerregistry/resource-manager/readme.md
    json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/packages/{}/archives/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/containerregistry/resource-manager/readme.md
    json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/packages/{}/archives/{}/versions is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/containerregistry/resource-manager/readme.md
    json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/packages/{}/archives/{}/versions/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/containerregistry/resource-manager/readme.md
    json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/containerregistry/resource-manager/readme.md
    tag: specification/containerregistry/resource-manager/readme.md#tag-package-2023-07
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    ️️✔️Automated merging requirements met succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 11, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/containerregistry/armcontainerregistry - Approved - 1.1.0-beta.4
    +	Enum `ActivationStatus` has been removed
    +	Enum `AuditLogStatus` has been removed
    +	Enum `AzureADAuthenticationAsArmPolicyStatus` has been removed
    +	Enum `CertificateType` has been removed
    +	Enum `ConnectedRegistryMode` has been removed
    +	Enum `ConnectionState` has been removed
    +	Enum `LogLevel` has been removed
    +	Enum `PipelineOptions` has been removed
    +	Enum `PipelineRunSourceType` has been removed
    +	Enum `PipelineRunTargetType` has been removed
    +	Enum `PipelineSourceType` has been removed
    +	Enum `TLSStatus` has been removed
    +	Field `AnonymousPullEnabled` of struct `RegistryPropertiesUpdateParameters` has been removed
    +	Field `AnonymousPullEnabled` of struct `RegistryProperties` has been removed
    +	Field `AzureADAuthenticationAsArmPolicy`, `SoftDeletePolicy` of struct `Policies` has been removed
    +	Function `*ClientFactory.NewConnectedRegistriesClient` has been removed
    +	Function `*ClientFactory.NewExportPipelinesClient` has been removed
    +	Function `*ClientFactory.NewImportPipelinesClient` has been removed
    +	Function `*ClientFactory.NewPipelineRunsClient` has been removed
    +	Function `*ConnectedRegistriesClient.BeginCreate` has been removed
    +	Function `*ConnectedRegistriesClient.BeginDeactivate` has been removed
    +	Function `*ConnectedRegistriesClient.BeginDelete` has been removed
    +	Function `*ConnectedRegistriesClient.BeginUpdate` has been removed
    +	Function `*ConnectedRegistriesClient.Get` has been removed
    +	Function `*ConnectedRegistriesClient.NewListPager` has been removed
    +	Function `*ExportPipelinesClient.BeginCreate` has been removed
    +	Function `*ExportPipelinesClient.BeginDelete` has been removed
    +	Function `*ExportPipelinesClient.Get` has been removed
    +	Function `*ExportPipelinesClient.NewListPager` has been removed
    +	Function `*ImportPipelinesClient.BeginCreate` has been removed
    +	Function `*ImportPipelinesClient.BeginDelete` has been removed
    +	Function `*ImportPipelinesClient.Get` has been removed
    +	Function `*ImportPipelinesClient.NewListPager` has been removed
    +	Function `*PipelineRunsClient.BeginCreate` has been removed
    +	Function `*PipelineRunsClient.BeginDelete` has been removed
    +	Function `*PipelineRunsClient.Get` has been removed
    +	Function `*PipelineRunsClient.NewListPager` has been removed
    +	Function `NewConnectedRegistriesClient` has been removed
    +	Function `NewExportPipelinesClient` has been removed
    +	Function `NewImportPipelinesClient` has been removed
    +	Function `NewPipelineRunsClient` has been removed
    +	Struct `ActivationProperties` has been removed
    +	Struct `AzureADAuthenticationAsArmPolicy` has been removed
    +	Struct `ConnectedRegistryListResult` has been removed
    +	Struct `ConnectedRegistryProperties` has been removed
    +	Struct `ConnectedRegistryUpdateParameters` has been removed
    +	Struct `ConnectedRegistryUpdateProperties` has been removed
    +	Struct `ConnectedRegistry` has been removed
    +	Struct `ExportPipelineListResult` has been removed
    +	Struct `ExportPipelineProperties` has been removed
    +	Struct `ExportPipelineTargetProperties` has been removed
    +	Struct `ExportPipeline` has been removed
    +	Struct `ImportPipelineListResult` has been removed
    +	Struct `ImportPipelineProperties` has been removed
    +	Struct `ImportPipelineSourceProperties` has been removed
    +	Struct `ImportPipeline` has been removed
    +	Struct `LoggingProperties` has been removed
    +	Struct `LoginServerProperties` has been removed
    +	Struct `ParentProperties` has been removed
    +	Struct `PipelineRunListResult` has been removed
    +	Struct `PipelineRunProperties` has been removed
    +	Struct `PipelineRunRequest` has been removed
    +	Struct `PipelineRunResponse` has been removed
    +	Struct `PipelineRunSourceProperties` has been removed
    +	Struct `PipelineRunTargetProperties` has been removed
    +	Struct `PipelineRun` has been removed
    +	Struct `PipelineSourceTriggerDescriptor` has been removed
    +	Struct `PipelineSourceTriggerProperties` has been removed
    +	Struct `PipelineTriggerDescriptor` has been removed
    +	Struct `PipelineTriggerProperties` has been removed
    +	Struct `ProgressProperties` has been removed
    +	Struct `SoftDeletePolicy` has been removed
    +	Struct `StatusDetailProperties` has been removed
    +	Struct `SyncProperties` has been removed
    +	Struct `SyncUpdateProperties` has been removed
    +	Struct `TLSCertificateProperties` has been removed
    +	Struct `TLSProperties` has been removed
    +	Type of `ErrorResponse.Error` has been changed from `*ErrorResponseBody` to `*ErrorDetail`
    azure-sdk-for-js - @azure/arm-containerregistry - Approved - 11.0.0-beta.1
    +	Type of parameter error of interface ErrorResponse is changed from ErrorResponseBody to ErrorDetail
    azure-sdk-for-python-track2 - track2_azure-mgmt-containerregistry - Approved - 10.1.0
    +	Model Policies no longer has parameter azure_ad_authentication_as_arm_policy
    +	Model Policies no longer has parameter soft_delete_policy
    +	Model Registry no longer has parameter anonymous_pull_enabled
    +	Model RegistryUpdateParameters no longer has parameter anonymous_pull_enabled
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d5631d7. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.6.7 -> 9.8.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.8.1` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-containerregistry [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Model Policies no longer has parameter azure_ad_authentication_as_arm_policy
      info	[Changelog]   - Model Policies no longer has parameter soft_delete_policy
      info	[Changelog]   - Model Registry no longer has parameter anonymous_pull_enabled
      info	[Changelog]   - Model RegistryUpdateParameters no longer has parameter anonymous_pull_enabled
    ️⚠️ azure-sdk-for-java warning [Detail]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d5631d7. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-containerregistry [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation group CacheRules
      info	[Changelog]   - Added operation group CredentialSets
      info	[Changelog]   - Added Interface AuthCredential
      info	[Changelog]   - Added Interface CacheRule
      info	[Changelog]   - Added Interface CacheRulesCreateHeaders
      info	[Changelog]   - Added Interface CacheRulesCreateOptionalParams
      info	[Changelog]   - Added Interface CacheRulesDeleteHeaders
      info	[Changelog]   - Added Interface CacheRulesDeleteOptionalParams
      info	[Changelog]   - Added Interface CacheRulesGetOptionalParams
      info	[Changelog]   - Added Interface CacheRulesListNextOptionalParams
      info	[Changelog]   - Added Interface CacheRulesListOptionalParams
      info	[Changelog]   - Added Interface CacheRulesListResult
      info	[Changelog]   - Added Interface CacheRulesUpdateHeaders
      info	[Changelog]   - Added Interface CacheRulesUpdateOptionalParams
      info	[Changelog]   - Added Interface CacheRuleUpdateParameters
      info	[Changelog]   - Added Interface CredentialHealth
      info	[Changelog]   - Added Interface CredentialSet
      info	[Changelog]   - Added Interface CredentialSetListResult
      info	[Changelog]   - Added Interface CredentialSetsCreateHeaders
      info	[Changelog]   - Added Interface CredentialSetsCreateOptionalParams
      info	[Changelog]   - Added Interface CredentialSetsDeleteHeaders
      info	[Changelog]   - Added Interface CredentialSetsDeleteOptionalParams
      info	[Changelog]   - Added Interface CredentialSetsGetOptionalParams
      info	[Changelog]   - Added Interface CredentialSetsListNextOptionalParams
      info	[Changelog]   - Added Interface CredentialSetsListOptionalParams
      info	[Changelog]   - Added Interface CredentialSetsUpdateHeaders
      info	[Changelog]   - Added Interface CredentialSetsUpdateOptionalParams
      info	[Changelog]   - Added Interface CredentialSetUpdateParameters
      info	[Changelog]   - Added Interface ErrorAdditionalInfo
      info	[Changelog]   - Added Interface ErrorDetail
      info	[Changelog]   - Added Interface ErrorResponseAutoGenerated
      info	[Changelog]   - Added Interface IdentityPropertiesAutoGenerated
      info	[Changelog]   - Added Interface UserIdentityPropertiesAutoGenerated
      info	[Changelog]   - Added Type Alias CacheRulesCreateResponse
      info	[Changelog]   - Added Type Alias CacheRulesDeleteResponse
      info	[Changelog]   - Added Type Alias CacheRulesGetResponse
      info	[Changelog]   - Added Type Alias CacheRulesListNextResponse
      info	[Changelog]   - Added Type Alias CacheRulesListResponse
      info	[Changelog]   - Added Type Alias CacheRulesUpdateResponse
      info	[Changelog]   - Added Type Alias CredentialHealthStatus
      info	[Changelog]   - Added Type Alias CredentialName
      info	[Changelog]   - Added Type Alias CredentialSetsCreateResponse
      info	[Changelog]   - Added Type Alias CredentialSetsDeleteResponse
      info	[Changelog]   - Added Type Alias CredentialSetsGetResponse
      info	[Changelog]   - Added Type Alias CredentialSetsListNextResponse
      info	[Changelog]   - Added Type Alias CredentialSetsListResponse
      info	[Changelog]   - Added Type Alias CredentialSetsUpdateResponse
      info	[Changelog]   - Added Enum KnownCredentialHealthStatus
      info	[Changelog]   - Added Enum KnownCredentialName
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Type of parameter error of interface ErrorResponse is changed from ErrorResponseBody to ErrorDetail
      info	[Changelog]   - Type of parameter identity of interface Task is changed from IdentityProperties to IdentityPropertiesAutoGenerated
      info	[Changelog]   - Type of parameter identity of interface TaskRun is changed from IdentityProperties to IdentityPropertiesAutoGenerated
      info	[Changelog]   - Type of parameter identity of interface TaskRunUpdateParameters is changed from IdentityProperties to IdentityPropertiesAutoGenerated
      info	[Changelog]   - Type of parameter identity of interface TaskUpdateParameters is changed from IdentityProperties to IdentityPropertiesAutoGenerated
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d5631d7. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️containerregistry [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from d5631d7. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • ️✔️Az.containerregistry.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.containerregistry.DefaultTag
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d5631d7. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/containerregistry/armcontainerregistry [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `ErrorResponse.Error` has been changed from `*ErrorResponseBody` to `*ErrorDetail`
      info	[Changelog] - Enum `ActivationStatus` has been removed
      info	[Changelog] - Enum `AuditLogStatus` has been removed
      info	[Changelog] - Enum `AzureADAuthenticationAsArmPolicyStatus` has been removed
      info	[Changelog] - Enum `CertificateType` has been removed
      info	[Changelog] - Enum `ConnectedRegistryMode` has been removed
      info	[Changelog] - Enum `ConnectionState` has been removed
      info	[Changelog] - Enum `LogLevel` has been removed
      info	[Changelog] - Enum `PipelineOptions` has been removed
      info	[Changelog] - Enum `PipelineRunSourceType` has been removed
      info	[Changelog] - Enum `PipelineRunTargetType` has been removed
      info	[Changelog] - Enum `PipelineSourceType` has been removed
      info	[Changelog] - Enum `TLSStatus` has been removed
      info	[Changelog] - Function `*ClientFactory.NewConnectedRegistriesClient` has been removed
      info	[Changelog] - Function `*ClientFactory.NewExportPipelinesClient` has been removed
      info	[Changelog] - Function `*ClientFactory.NewImportPipelinesClient` has been removed
      info	[Changelog] - Function `*ClientFactory.NewPipelineRunsClient` has been removed
      info	[Changelog] - Function `NewConnectedRegistriesClient` has been removed
      info	[Changelog] - Function `*ConnectedRegistriesClient.BeginCreate` has been removed
      info	[Changelog] - Function `*ConnectedRegistriesClient.BeginDeactivate` has been removed
      info	[Changelog] - Function `*ConnectedRegistriesClient.BeginDelete` has been removed
      info	[Changelog] - Function `*ConnectedRegistriesClient.Get` has been removed
      info	[Changelog] - Function `*ConnectedRegistriesClient.NewListPager` has been removed
      info	[Changelog] - Function `*ConnectedRegistriesClient.BeginUpdate` has been removed
      info	[Changelog] - Function `NewExportPipelinesClient` has been removed
      info	[Changelog] - Function `*ExportPipelinesClient.BeginCreate` has been removed
      info	[Changelog] - Function `*ExportPipelinesClient.BeginDelete` has been removed
      info	[Changelog] - Function `*ExportPipelinesClient.Get` has been removed
      info	[Changelog] - Function `*ExportPipelinesClient.NewListPager` has been removed
      info	[Changelog] - Function `NewImportPipelinesClient` has been removed
      info	[Changelog] - Function `*ImportPipelinesClient.BeginCreate` has been removed
      info	[Changelog] - Function `*ImportPipelinesClient.BeginDelete` has been removed
      info	[Changelog] - Function `*ImportPipelinesClient.Get` has been removed
      info	[Changelog] - Function `*ImportPipelinesClient.NewListPager` has been removed
      info	[Changelog] - Function `NewPipelineRunsClient` has been removed
      info	[Changelog] - Function `*PipelineRunsClient.BeginCreate` has been removed
      info	[Changelog] - Function `*PipelineRunsClient.BeginDelete` has been removed
      info	[Changelog] - Function `*PipelineRunsClient.Get` has been removed
      info	[Changelog] - Function `*PipelineRunsClient.NewListPager` has been removed
      info	[Changelog] - Struct `ActivationProperties` has been removed
      info	[Changelog] - Struct `AzureADAuthenticationAsArmPolicy` has been removed
      info	[Changelog] - Struct `ConnectedRegistry` has been removed
      info	[Changelog] - Struct `ConnectedRegistryListResult` has been removed
      info	[Changelog] - Struct `ConnectedRegistryProperties` has been removed
      info	[Changelog] - Struct `ConnectedRegistryUpdateParameters` has been removed
      info	[Changelog] - Struct `ConnectedRegistryUpdateProperties` has been removed
      info	[Changelog] - Struct `ExportPipeline` has been removed
      info	[Changelog] - Struct `ExportPipelineListResult` has been removed
      info	[Changelog] - Struct `ExportPipelineProperties` has been removed
      info	[Changelog] - Struct `ExportPipelineTargetProperties` has been removed
      info	[Changelog] - Struct `ImportPipeline` has been removed
      info	[Changelog] - Struct `ImportPipelineListResult` has been removed
      info	[Changelog] - Struct `ImportPipelineProperties` has been removed
      info	[Changelog] - Struct `ImportPipelineSourceProperties` has been removed
      info	[Changelog] - Struct `LoggingProperties` has been removed
      info	[Changelog] - Struct `LoginServerProperties` has been removed
      info	[Changelog] - Struct `ParentProperties` has been removed
      info	[Changelog] - Struct `PipelineRun` has been removed
      info	[Changelog] - Struct `PipelineRunListResult` has been removed
      info	[Changelog] - Struct `PipelineRunProperties` has been removed
      info	[Changelog] - Struct `PipelineRunRequest` has been removed
      info	[Changelog] - Struct `PipelineRunResponse` has been removed
      info	[Changelog] - Struct `PipelineRunSourceProperties` has been removed
      info	[Changelog] - Struct `PipelineRunTargetProperties` has been removed
      info	[Changelog] - Struct `PipelineSourceTriggerDescriptor` has been removed
      info	[Changelog] - Struct `PipelineSourceTriggerProperties` has been removed
      info	[Changelog] - Struct `PipelineTriggerDescriptor` has been removed
      info	[Changelog] - Struct `PipelineTriggerProperties` has been removed
      info	[Changelog] - Struct `ProgressProperties` has been removed
      info	[Changelog] - Struct `SoftDeletePolicy` has been removed
      info	[Changelog] - Struct `StatusDetailProperties` has been removed
      info	[Changelog] - Struct `SyncProperties` has been removed
      info	[Changelog] - Struct `SyncUpdateProperties` has been removed
      info	[Changelog] - Struct `TLSCertificateProperties` has been removed
      info	[Changelog] - Struct `TLSProperties` has been removed
      info	[Changelog] - Field `AzureADAuthenticationAsArmPolicy`, `SoftDeletePolicy` of struct `Policies` has been removed
      info	[Changelog] - Field `AnonymousPullEnabled` of struct `RegistryProperties` has been removed
      info	[Changelog] - Field `AnonymousPullEnabled` of struct `RegistryPropertiesUpdateParameters` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New struct `ErrorAdditionalInfo`
      info	[Changelog] - New struct `ErrorDetail`
      info	[Changelog] - New struct `ErrorResponseForContainerRegistry`
      info	[Changelog]
      info	[Changelog] Total 114 breaking change(s), 6 additive change(s).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 11, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/containerregistry/armcontainerregistry https://apiview.dev/Assemblies/Review/ad8fc6a8d96e4d598008cd905a6e4ed3
    Java azure-resourcemanager-containerregistry-generated https://apiview.dev/Assemblies/Review/b3ce38b076004d3bafe44df2f0b449d7
    JavaScript @azure/arm-containerregistry https://apiview.dev/Assemblies/Review/6e51de982a84461d8b2ca24335d374d1
    .Net Azure.ResourceManager.ContainerRegistry There is no API change compared with the previous version

    @AntonioVT
    Copy link
    Member Author

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No commit pushedDate could be found for PR 24771 in repo Azure/azure-rest-api-specs

    @openapi-workflow-bot
    Copy link

    Hi @AntonioVT! The automation detected breaking changes in this pull request. As a result, it added the BreakingChangeReviewRequired label.

    You cannot proceed with merging this PR until you complete one of the following action items:

    ACTION ITEM ALTERNATIVE A: Fix the breaking change.
    Please consult the documentation provided in the relevant validation failures.

    ACTION ITEM ALTERNATIVE B: Request approval.
    Alternatively, if you cannot fix the breaking changes, then you can request an approval for them. Please follow the process described in the High-level Breaking Change Process doc.

    ACTION ITEM ALTERNATIVE C: Report false positive.
    If you think there are no breaking changes, i.e. the validation should pass yet it fails, then proceed as explained in ACTION ITEM ALTERNATIVE B.
    This applies even if the breaking change tool fails with internal runtime error. In such case a manual breaking change review is necessary.

    @AntonioVT AntonioVT marked this pull request as ready for review July 11, 2023 22:37
    @AntonioVT AntonioVT requested review from msyyc and tadelesh as code owners July 11, 2023 23:08
    @AzureRestAPISpecReview AzureRestAPISpecReview added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview labels Jul 11, 2023
    @ms-zhenhua
    Copy link
    Contributor

          "201": {
    

    LRO-Patch should use 200 and 202


    Refers to: specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json:265 in 05a2ef1. [](commit_id = 05a2ef1, deletion_comment = False)

    @ms-zhenhua
    Copy link
    Contributor

          "201": {
    

    same as above


    Refers to: specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json:541 in 05a2ef1. [](commit_id = 05a2ef1, deletion_comment = False)

    @ms-zhenhua ms-zhenhua added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 10, 2023
    @AntonioVT
    Copy link
    Member Author

    @ms-zhenhua Regarding LRO-Patch, my understanding is that this has been resolved with WI https://msazure.visualstudio.com/AzureContainerRegistry/_workitems/edit/24778096#.

    Reference:
    #24771 (comment)
    #24771 (comment)

    @AntonioVT AntonioVT removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Aug 10, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 10, 2023
    @ms-zhenhua ms-zhenhua added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 11, 2023
    @kazrael2119
    Copy link
    Contributor

    this js sdk breaking is caused by this pr: change ErrorResponse from manually definition to common-type

    @AntonioVT
    Copy link
    Member Author

    AntonioVT commented Aug 14, 2023

    Hi @ms-zhenhua, @raych1, it seems that we have signoff from ARM and SDKs. Is there any approval left? Or is it ready to be merged?

    As a side note, we would like to start the ARM manifest rollout. Thanks for the help!

    cc @rkmanda

    @JackTn
    Copy link
    Member

    JackTn commented Aug 15, 2023

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 2 pipeline(s).

    @rkmanda rkmanda merged commit d5631d7 into main Aug 16, 2023
    @rkmanda rkmanda deleted the AntonioVT-containerregistry-Microsoft.ContainerRegistry-2023-07-01 branch August 16, 2023 21:55
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 16, 2023

    Next Steps to Merge

    ⚠️ This is an experimental comment. It may not always be up-to-date. ⚠️

    ✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-Avocado Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript Approved-SdkBreakingChange-Python ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript CI-FixRequiredOnFailure Container Registry new-api-version resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.