-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.ContainerRegistry to add version stable/2023-07-01 #24771
[Hub Generated] Review request for Microsoft.ContainerRegistry to add version stable/2023-07-01 #24771
Conversation
…e/2022-12-01 to version 2023-07-01
Hi, @AntonioVT! Thank you for your pull request. To help get your PR merged: Generated ApiView comment added to this PR. You can use ApiView to show API versions diff. |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
containerregistry.json | 2023-07-01(05a2ef1) | 2022-12-01(main) |
containerregistry.json | 2023-07-01(05a2ef1) | 2023-06-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
The following breaking changes are detected by comparison with the latest preview version:
Only 26 items are listed, please refer to log for more details.
Rule | Message |
---|---|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/packages/{packageType}/archives' removed or restructured? Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L18:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/packages/{packageType}/archives/{archiveName}' removed or restructured? Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L66:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/packages/{packageType}/archives/{archiveName}/versions' removed or restructured? Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L294:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/packages/{packageType}/archives/{archiveName}/versions/{archiveVersionName}' removed or restructured? Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L345:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/connectedRegistries' removed or restructured? Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L797:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/connectedRegistries/{connectedRegistryName}' removed or restructured? Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L845:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/connectedRegistries/{connectedRegistryName}/deactivate' removed or restructured? Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1079:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/exportPipelines' removed or restructured? Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1412:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/exportPipelines/{exportPipelineName}' removed or restructured? Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1457:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/importPipelines' removed or restructured? Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1684:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/importPipelines/{importPipelineName}' removed or restructured? Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1729:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/pipelineRuns' removed or restructured? Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1968:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/pipelineRuns/{pipelineRunName}' removed or restructured? Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L2013:5 |
|
The new version is missing a definition that was found in the old version. Was 'Archive' removed or renamed? New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3 |
|
The new version is missing a definition that was found in the old version. Was 'ArchiveProperties' removed or renamed? New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3 |
|
The new version is missing a definition that was found in the old version. Was 'ArchivePackageSourceProperties' removed or renamed? New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3 |
|
The new version is missing a definition that was found in the old version. Was 'ArchiveUpdateParameters' removed or renamed? New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3 |
|
The new version is missing a definition that was found in the old version. Was 'ArchiveUpdateProperties' removed or renamed? New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3 |
|
The new version is missing a definition that was found in the old version. Was 'ConnectedRegistry' removed or renamed? New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3 |
|
The new version is missing a definition that was found in the old version. Was 'ConnectedRegistryProperties' removed or renamed? New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3 |
|
The new version is missing a definition that was found in the old version. Was 'ActivationProperties' removed or renamed? New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3 |
|
The new version is missing a definition that was found in the old version. Was 'ParentProperties' removed or renamed? New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3 |
|
The new version is missing a definition that was found in the old version. Was 'LoginServerProperties' removed or renamed? New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3 |
|
The new version is missing a definition that was found in the old version. Was 'LoggingProperties' removed or renamed? New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3 |
|
The new version is missing a definition that was found in the old version. Was 'SyncProperties' removed or renamed? New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3 |
|
The new version is missing a definition that was found in the old version. Was 'TlsProperties' removed or renamed? New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3 |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.4) | new version | base version |
---|---|---|
package-2023-07 | package-2023-07(05a2ef1) | default(main) |
The following errors/warnings exist before current PR submission:
Only 26 items are listed, please refer to log for more details.
️❌
Avocado: 15 Errors, 1 Warnings failed [Detail]
Rule | Message |
---|---|
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/listPolicies is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/updatePolicies is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/exportPipelines/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/exportPipelines is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/importPipelines/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/importPipelines is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/pipelineRuns/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/pipelineRuns is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/connectedRegistries/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/connectedRegistries is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/connectedRegistries/{}/deactivate is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/packages/{}/archives is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/packages/{}/archives/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/packages/{}/archives/{}/versions is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/packages/{}/archives/{}/versions/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json |
The default tag contains multiple API versions swaggers. readme: specification/containerregistry/resource-manager/readme.md tag: specification/containerregistry/resource-manager/readme.md#tag-package-2023-07 |
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
/azp run unifiedPipeline |
No commit pushedDate could be found for PR 24771 in repo Azure/azure-rest-api-specs |
Hi @AntonioVT! The automation detected breaking changes in this pull request. As a result, it added the |
@ms-zhenhua Regarding LRO-Patch, my understanding is that this has been resolved with WI https://msazure.visualstudio.com/AzureContainerRegistry/_workitems/edit/24778096#. Reference: |
this js sdk breaking is caused by this pr: change ErrorResponse from manually definition to common-type |
Hi @ms-zhenhua, @raych1, it seems that we have signoff from ARM and SDKs. Is there any approval left? Or is it ready to be merged? As a side note, we would like to start the ARM manifest rollout. Thanks for the help! cc @rkmanda |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Next Steps to Merge |
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM (Control Plane) API Specification Update Pull Request
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can request review from an ARM API Review board.
ARM API changes review
ARMReview
label.ARMReview
label, if appropriate.If this happens, proceed according to guidance given in GitHub comments also added by the automation.
Breaking change review
If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.
Getting help
and https://aka.ms/ci-fix.