Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typespec-next] React to Azure/typespec-azure#3326 #25026

Merged
merged 5 commits into from
Jul 28, 2023

Conversation

mikeharder
Copy link
Member

No description provided.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 27, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
compared swaggers (via Oad v0.10.4)] new version base version
fleets.json 2022-09-02-preview(068edff) 2022-09-02-preview(main)
fleets.json 2023-03-15-preview(068edff) 2023-03-15-preview(main)
containerstorage.json 2023-03-01-preview(068edff) 2023-03-01-preview(main)
TrafficController.json 2023-05-01-preview(068edff) 2023-05-01-preview(main)
azuresphere.json 2022-09-01-preview(068edff) 2022-09-01-preview(main)
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.3) new version base version
package-2023-03-preview package-2023-03-preview(068edff) package-2023-03-preview(typespec-next)
package-2022-09-preview package-2022-09-preview(068edff) package-2022-09-preview(typespec-next)
package-2023-03-01-preview package-2023-03-01-preview(068edff) package-2023-03-01-preview(typespec-next)
package-2023-05-01-preview package-2023-05-01-preview(068edff) package-2023-05-01-preview(typespec-next)
package-2022-09-01-preview package-2022-09-01-preview(068edff) package-2022-09-01-preview(typespec-next)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
ResourceNameRestriction The resource name parameter 'imageName' should be defined with a 'pattern' restriction.
Location: Microsoft.AzureSphere/preview/2022-09-01-preview/azuresphere.json#L762
RepeatedPathInfo The 'imageName' already appears in the path, please don't repeat it in the request body.
Location: Microsoft.AzureSphere/preview/2022-09-01-preview/azuresphere.json#L839
ParametersInPost $filter is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.AzureSphere/preview/2022-09-01-preview/azuresphere.json#L971
ParametersInPost $top is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.AzureSphere/preview/2022-09-01-preview/azuresphere.json#L971
ParametersInPost $skip is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.AzureSphere/preview/2022-09-01-preview/azuresphere.json#L971
ParametersInPost $maxpagesize is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.AzureSphere/preview/2022-09-01-preview/azuresphere.json#L971
ParametersInPost $filter is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.AzureSphere/preview/2022-09-01-preview/azuresphere.json#L1033
ParametersInPost $top is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.AzureSphere/preview/2022-09-01-preview/azuresphere.json#L1033
ParametersInPost $skip is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.AzureSphere/preview/2022-09-01-preview/azuresphere.json#L1033
ParametersInPost $maxpagesize is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.AzureSphere/preview/2022-09-01-preview/azuresphere.json#L1033
ParametersInPost $filter is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.AzureSphere/preview/2022-09-01-preview/azuresphere.json#L1104
ParametersInPost $top is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.AzureSphere/preview/2022-09-01-preview/azuresphere.json#L1104
ParametersInPost $skip is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.AzureSphere/preview/2022-09-01-preview/azuresphere.json#L1104
ParametersInPost $maxpagesize is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.AzureSphere/preview/2022-09-01-preview/azuresphere.json#L1104
ParametersInPost $filter is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.AzureSphere/preview/2022-09-01-preview/azuresphere.json#L1166
ParametersInPost $top is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.AzureSphere/preview/2022-09-01-preview/azuresphere.json#L1166
ParametersInPost $skip is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.AzureSphere/preview/2022-09-01-preview/azuresphere.json#L1166
ParametersInPost $maxpagesize is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.AzureSphere/preview/2022-09-01-preview/azuresphere.json#L1166
LroPostReturn A LRO POST operation must have both 200 & 202 return codes.
Location: Microsoft.AzureSphere/preview/2022-09-01-preview/azuresphere.json#L1999
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.AzureSphere/preview/2022-09-01-preview/azuresphere.json#L2052
ResourceNameRestriction The resource name parameter 'deploymentName' should be defined with a 'pattern' restriction.
Location: Microsoft.AzureSphere/preview/2022-09-01-preview/azuresphere.json#L2219
OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'Devices' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.AzureSphere/preview/2022-09-01-preview/azuresphere.json#L2471
ConsistentPatchProperties The property 'properties.deviceGroupId' in the request body either not apppear in the resource model or has the wrong level.
Location: Microsoft.AzureSphere/preview/2022-09-01-preview/azuresphere.json#L2753
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.AzureSphere/preview/2022-09-01-preview/azuresphere.json#L2767
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.AzureSphere/preview/2022-09-01-preview/azuresphere.json#L2948
⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
Location: fleet/preview/2023-03-15-preview/fleets.json#L1664
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1416
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1445
⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
Location: Microsoft.ServiceNetworking/preview/2023-05-01-preview/TrafficController.json#L1130
⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
Location: Microsoft.ServiceNetworking/preview/2023-05-01-preview/TrafficController.json#L1241
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-workflow-bot
Copy link

Hi, @mikeharder! Thank you for your pull request. To help get your PR merged:

  • Ensure you reviewed the checklists in the PR description.
  • Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.
  • For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
  • @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 27, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking









    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    ️⚠️ azure-sdk-for-java warning [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 5ff3de02c811def22b849e39b4f565782db51541. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/containerservicefleet/armcontainerservicefleet [View full logs]  [Preview SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️sdk/resourcemanager/containerstorage/armcontainerstorage [View full logs]  [Preview SDK Changes]
      info	[Changelog] This is a new package
      info	[Changelog]
    • ️✔️sdk/resourcemanager/servicenetworking/armservicenetworking [View full logs]  [Preview SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️sdk/resourcemanager/sphere/armsphere [View full logs]  [Preview SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 5ff3de02c811def22b849e39b4f565782db51541. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
      cmderr	[automation_generate.sh] [ERROR] Cannot generate changelog because the codes of local and npm may be the same.
    • ️✔️@azure/arm-containerservicefleet [View full logs]  [Preview SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    • ️✔️@azure/arm-sphere [View full logs]  [Preview SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs] Generate from 5ff3de02c811def22b849e39b4f565782db51541. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      warn		specification/containerstorage/resource-manager/readme.md skipped due to azure-sdk-for-net-track2 not found in swagger-to-sdk
      warn		specification/servicenetworking/resource-manager/readme.md skipped due to azure-sdk-for-net-track2 not found in swagger-to-sdk
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:805
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 805 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    • Azure.ResourceManager.ContainerService [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    • ️✔️Azure.ResourceManager.Sphere [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 5ff3de02c811def22b849e39b4f565782db51541. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️containerservice [View full logs
    • ️✔️containerstorage [View full logs
    • ️✔️sphere [View full logs
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs] Generate from 5ff3de02c811def22b849e39b4f565782db51541. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      warn		specification/containerstorage/resource-manager/readme.md skipped due to azure-powershell not found in swagger-to-sdk
      warn		specification/servicenetworking/resource-manager/readme.md skipped due to azure-powershell not found in swagger-to-sdk
      warn		specification/sphere/resource-manager/readme.md skipped due to azure-powershell not found in swagger-to-sdk
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • ️✔️Az.containerservice.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.containerservice.DefaultTag
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs] Generate from 5ff3de02c811def22b849e39b4f565782db51541. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      warn		specification/containerservice/resource-manager/Microsoft.ContainerService/fleet/readme.md skipped due to azure-sdk-for-python not found in swagger-to-sdk
      warn		specification/servicenetworking/resource-manager/readme.md skipped due to azure-sdk-for-python not found in swagger-to-sdk
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.8.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.8.1` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-containerstorage [View full logs]  [Preview SDK Changes]
      info	[Changelog]   - Initial Release
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 27, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Swagger Microsoft.AzureSphere https://apiview.dev/Assemblies/Review/5dc1d4af32db456eb308510e46a9ee00
    Swagger Microsoft.ContainerService https://apiview.dev/Assemblies/Review/6ea9152d7e2b4688a8da44ff8a6bc71c
    Swagger Microsoft.ContainerStorage https://apiview.dev/Assemblies/Review/e43689feb9f840a0b5ab620c37a9d5ed
    Swagger Microsoft.ServiceNetworking https://apiview.dev/Assemblies/Review/4abd188be1964a13827f921522ceeaaf
    Go sdk/resourcemanager/containerservicefleet/armcontainerservicefleet There is no API change compared with the previous version
    Go sdk/resourcemanager/containerstorage/armcontainerstorage https://apiview.dev/Assemblies/Review/d0798683c2f34b86a6a509ca99bf4eb9
    Go sdk/resourcemanager/servicenetworking/armservicenetworking There is no API change compared with the previous version
    Go sdk/resourcemanager/sphere/armsphere There is no API change compared with the previous version
    .Net Azure.ResourceManager.Sphere There is no API change compared with the previous version
    Java azure-resourcemanager-containerservicefleet https://apiview.dev/Assemblies/Review/9fe04755b6be4a92856d156e7138ccb6
    Java azure-resourcemanager-sphere There is no API change compared with the previous version
    JavaScript @azure/arm-containerservicefleet There is no API change compared with the previous version
    JavaScript @azure/arm-sphere https://apiview.dev/Assemblies/Review/4eb08bf67e3745f984259c4cc039be43

    @mikeharder
    Copy link
    Member Author

    Converting to draft until TypeSpecValidation is passing

    @mikeharder mikeharder marked this pull request as ready for review July 28, 2023 07:21
    @mikeharder mikeharder merged commit 613140b into Azure:typespec-next Jul 28, 2023
    @mikeharder mikeharder deleted the typespec-next-react-3326 branch July 28, 2023 07:37
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    4 participants