Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NetApp] netapp microsoft.net app 2023 05 01 #25332

Merged
merged 15 commits into from
Sep 8, 2023

Conversation

audunn
Copy link
Member

@audunn audunn commented Aug 16, 2023

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Getting help

@audunn audunn requested a review from tadelesh as a code owner August 16, 2023 12:18
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 16, 2023

Next Steps to Merge

⚠️ This is an experimental comment. It may not always be up-to-date. ⚠️

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-workflow-bot
Copy link

Hi, @audunn! Thank you for your pull request. To help get your PR merged:

  • Ensure you reviewed the checklists in the PR description.
  • Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.
  • For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
  • @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 16, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 83 Errors, 36 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    netapp.json 2023-05-01(abcf51b) 2022-11-01(main)
    netapp.json 2023-05-01(abcf51b) 2022-11-01-preview(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Only 28 items are listed, please refer to log for more details.

    Rule Message
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/capacityPools/{poolName}/volumes/{volumeName}/backupStatus' removed or restructured?
    Old: Microsoft.NetApp/stable/2022-11-01/netapp.json#L2676:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/accountBackups' removed or restructured?
    Old: Microsoft.NetApp/stable/2022-11-01/netapp.json#L2768:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/accountBackups/{backupName}' removed or restructured?
    Old: Microsoft.NetApp/stable/2022-11-01/netapp.json#L2811:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/capacityPools/{poolName}/volumes/{volumeName}/backups' removed or restructured?
    Old: Microsoft.NetApp/stable/2022-11-01/netapp.json#L2902:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/capacityPools/{poolName}/volumes/{volumeName}/backups/{backupName}' removed or restructured?
    Old: Microsoft.NetApp/stable/2022-11-01/netapp.json#L2951:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/capacityPools/{poolName}/volumes/{volumeName}/backups/{backupName}/restoreFiles' removed or restructured?
    Old: Microsoft.NetApp/stable/2022-11-01/netapp.json#L4248:5
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'backup' removed or renamed?
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L3965:3
    Old: Microsoft.NetApp/stable/2022-11-01/netapp.json#L4316:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'backupPatch' removed or renamed?
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L3965:3
    Old: Microsoft.NetApp/stable/2022-11-01/netapp.json#L4316:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'backupProperties' removed or renamed?
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L3965:3
    Old: Microsoft.NetApp/stable/2022-11-01/netapp.json#L4316:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'backupRestoreFiles' removed or renamed?
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L3965:3
    Old: Microsoft.NetApp/stable/2022-11-01/netapp.json#L4316:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'BackupName' removed or renamed?
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L7718:3
    Old: Microsoft.NetApp/stable/2022-11-01/netapp.json#L8124:3
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L5474:9
    Old: Microsoft.NetApp/stable/2022-11-01/netapp.json#L5891:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L5763:9
    Old: Microsoft.NetApp/stable/2022-11-01/netapp.json#L6199:9
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'backup' renamed or removed?
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L5342:11
    Old: Microsoft.NetApp/stable/2022-11-01/netapp.json#L5714:11
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'backup' renamed or removed?
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L6005:11
    Old: Microsoft.NetApp/stable/2022-11-01/netapp.json#L6440:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L529:9
    Old: Microsoft.NetApp/stable/2022-11-01/netapp.json#L417:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L567:9
    Old: Microsoft.NetApp/stable/2022-11-01/netapp.json#L455:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L626:9
    Old: Microsoft.NetApp/stable/2022-11-01/netapp.json#L514:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L669:9
    Old: Microsoft.NetApp/stable/2022-11-01/netapp.json#L557:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L731:9
    Old: Microsoft.NetApp/stable/2022-11-01/netapp.json#L619:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L775:9
    Old: Microsoft.NetApp/stable/2022-11-01/netapp.json#L663:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L818:9
    Old: Microsoft.NetApp/stable/2022-11-01/netapp.json#L706:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L859:9
    Old: Microsoft.NetApp/stable/2022-11-01/netapp.json#L747:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L919:9
    Old: Microsoft.NetApp/stable/2022-11-01/netapp.json#L807:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L976:9
    Old: Microsoft.NetApp/stable/2022-11-01/netapp.json#L864:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L1019:9
    Old: Microsoft.NetApp/stable/2022-11-01/netapp.json#L907:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L1069:9
    Old: Microsoft.NetApp/stable/2022-11-01/netapp.json#L957:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L1113:9
    Old: Microsoft.NetApp/stable/2022-11-01/netapp.json#L1001:9


    The following breaking changes are detected by comparison with the latest preview version:

    Only 28 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/capacityPools/{poolName}/volumes/{volumeName}/latestBackupStatus/current' removed or restructured?
    Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L2676:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/accountBackups' removed or restructured?
    Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L2771:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/accountBackups/{backupName}' removed or restructured?
    Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L2821:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/backupVaults/{backupVaultName}/backups' removed or restructured?
    Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L2912:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/backupVaults/{backupVaultName}/backups/{backupName}' removed or restructured?
    Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L2968:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/backupVaults' removed or restructured?
    Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L4280:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/backupVaults/{backupVaultName}' removed or restructured?
    Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L4326:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/backupVaults/{backupVaultName}/backups/{backupName}/restoreFiles' removed or restructured?
    Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L4559:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/capacityPools/{poolName}/volumes/{volumeName}/migrateBackups' removed or restructured?
    Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L4626:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/migrateBackups' removed or restructured?
    Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L4693:5
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'backup' removed or renamed?
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L3965:3
    Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L4755:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'backupPatch' removed or renamed?
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L3965:3
    Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L4755:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'backupProperties' removed or renamed?
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L3965:3
    Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L4755:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'backupPatchProperties' removed or renamed?
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L3965:3
    Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L4755:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'backupRestoreFiles' removed or renamed?
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L3965:3
    Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L4755:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'backupVault' removed or renamed?
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L3965:3
    Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L4755:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'backupVaultPatch' removed or renamed?
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L3965:3
    Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L4755:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'backupVaultProperties' removed or renamed?
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L3965:3
    Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L4755:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'backupsMigrationRequest' removed or renamed?
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L3965:3
    Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L4755:3
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'BackupName' removed or renamed?
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L7718:3
    Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L8712:3
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'BackupVaultName' removed or renamed?
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L7718:3
    Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L8712:3
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L5274:9
    Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L6063:9
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L5400:9
    Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L6217:9
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L5403:9
    Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L6241:9
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L6061:9
    Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L6938:9
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L6064:9
    Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L6963:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L5474:9
    Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L6330:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.NetApp/stable/2023-05-01/netapp.json#L5763:9
    Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L6642:9
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.4) new version base version
    package-netapp-2023-05-01 package-netapp-2023-05-01(abcf51b) default(main)

    The following errors/warnings exist before current PR submission:

    Only 28 items are listed, please refer to log for more details.

    Rule Message
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.NetApp/stable/2023-05-01/netapp.json#L63
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.NetApp/stable/2023-05-01/netapp.json#L110
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.NetApp/stable/2023-05-01/netapp.json#L157
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.NetApp/stable/2023-05-01/netapp.json#L204
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.NetApp/stable/2023-05-01/netapp.json#L244
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.NetApp/stable/2023-05-01/netapp.json#L284
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.NetApp/stable/2023-05-01/netapp.json#L321
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.NetApp/stable/2023-05-01/netapp.json#L470
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.NetApp/stable/2023-05-01/netapp.json#L510
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.NetApp/stable/2023-05-01/netapp.json#L550
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.NetApp/stable/2023-05-01/netapp.json#L603
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.NetApp/stable/2023-05-01/netapp.json#L648
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.NetApp/stable/2023-05-01/netapp.json#L752
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.NetApp/stable/2023-05-01/netapp.json#L799
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.NetApp/stable/2023-05-01/netapp.json#L842
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.NetApp/stable/2023-05-01/netapp.json#L898
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.NetApp/stable/2023-05-01/netapp.json#L955
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.NetApp/stable/2023-05-01/netapp.json#L1000
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.NetApp/stable/2023-05-01/netapp.json#L1050
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.NetApp/stable/2023-05-01/netapp.json#L1096
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.NetApp/stable/2023-05-01/netapp.json#L1158
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.NetApp/stable/2023-05-01/netapp.json#L1276
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.NetApp/stable/2023-05-01/netapp.json#L1396
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.NetApp/stable/2023-05-01/netapp.json#L1446
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.NetApp/stable/2023-05-01/netapp.json#L1507
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.NetApp/stable/2023-05-01/netapp.json#L1636
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.NetApp/stable/2023-05-01/netapp.json#L1692
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.NetApp/stable/2023-05-01/netapp.json#L1742
    ️❌Avocado: 6 Errors, 0 Warnings failed [Detail]
    Rule Message
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.NetApp/netAppAccounts/{}/accountBackups is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/netapp/resource-manager/readme.md
    json: Microsoft.NetApp/stable/2022-11-01/netapp.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.NetApp/netAppAccounts/{}/accountBackups/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/netapp/resource-manager/readme.md
    json: Microsoft.NetApp/stable/2022-11-01/netapp.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.NetApp/netAppAccounts/{}/capacityPools/{}/volumes/{}/backups is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/netapp/resource-manager/readme.md
    json: Microsoft.NetApp/stable/2022-11-01/netapp.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.NetApp/netAppAccounts/{}/capacityPools/{}/volumes/{}/backups/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/netapp/resource-manager/readme.md
    json: Microsoft.NetApp/stable/2022-11-01/netapp.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.NetApp/netAppAccounts/{}/capacityPools/{}/volumes/{}/backupStatus is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/netapp/resource-manager/readme.md
    json: Microsoft.NetApp/stable/2022-11-01/netapp.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.NetApp/netAppAccounts/{}/capacityPools/{}/volumes/{}/backups/{}/restoreFiles is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/netapp/resource-manager/readme.md
    json: Microsoft.NetApp/stable/2022-11-01/netapp.json
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    ️️✔️Automated merging requirements met succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 16, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌SDK Breaking Change Tracking failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-net-track2 failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-java warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-resource-manager-schemas failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-powershell failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 16, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/netapp/armnetapp https://apiview.dev/Assemblies/Review/79e1196dc95f47c389e72065ccb0b75c
    Java azure-resourcemanager-netapp https://apiview.dev/Assemblies/Review/19ffff92afc94fa2866f73b125b74f3a
    JavaScript @azure/arm-netapp https://apiview.dev/Assemblies/Review/72a266e6b52649a3ba2ee05e6a8ac7a2

    @audunn
    Copy link
    Member Author

    audunn commented Aug 16, 2023

    This includes part of the Breaking changes previously reviewed and approved in https://github.com/Azure/azure-rest-api-specs-pr/pull/8331 & #24741
    The Breaking Change requred removal of volume Backup APIs from stable

    @AzureRestAPISpecReview AzureRestAPISpecReview added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-FixRequiredOnFailure CI-MissingBaseCommit new-api-version resource-manager labels Aug 16, 2023
    @openapi-pipeline-app
    Copy link

    Automatic PR validation started. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

    @openapi-workflow-bot
    Copy link

    Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    This will notify the reviewer to have another look.
    If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
    Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

    @openapi-workflow-bot
    Copy link

    Hi @audunn! The automation detected breaking changes in this pull request. As a result, it added the BreakingChangeReviewRequired label.

    You cannot proceed with merging this PR until you complete one of the following action items:

    ACTION ITEM ALTERNATIVE A: Fix the breaking change.
    Please consult the documentation provided in the relevant validation failures.

    ACTION ITEM ALTERNATIVE B: Request approval.
    Alternatively, if you cannot fix the breaking changes, then you can request an approval for them. Please follow the breaking changes process.
    This case applies even if:

    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason. Such claims must be reviewed, and the process is the same.

    @openapi-workflow-bot
    Copy link

    Hi @audunn! Your PR has some issues. Please fix the CI issues, if present, in following order: Avocado, SemanticValidation, ModelValidation, Breaking Change, LintDiff.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic ValidationFix-SemanticValidation-ErrorHigh
    Model ValidationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffHigh

    If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel.

    @openapi-workflow-bot
    Copy link

    Hi @audunn! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
    For more details refer to the wiki.

    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 5, 2023
    @audunn
    Copy link
    Member Author

    audunn commented Sep 6, 2023

    @mentat9 , @sjanamma out of curiosity if we were to add arm-id to an existing property for consitency sake, would that be a breaking change, do you know?

    @AzureRestAPISpecReview AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Sep 6, 2023
    @mentat9
    Copy link
    Member

    mentat9 commented Sep 6, 2023

    @mentat9 , @sjanamma out of curiosity if we were to add arm-id to an existing property for consitency sake, would that be a breaking change, do you know?

    @audunn - Looks like the automation answered your question by adding the BreakingChangeReviewRequired label. Note I didn't require that change for ARM signoff, but to merge, you will need to either revert it or get breaking change approval. I imagine it should pass breaking change review easily since it doesn't represent a change from your backend (IIUC).

    @Alancere Alancere added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Sep 7, 2023
    @audunn
    Copy link
    Member Author

    audunn commented Sep 7, 2023

    arm-id

    @mentat9 That seems strange, perhaps a false positive here, as we added arm-id to a new property introduced in this api-version not to an existing one. We need to look into why it flags

    @audunn
    Copy link
    Member Author

    audunn commented Sep 7, 2023

    Prettier fails , does not fail locally something with the pipeline

    prettier -c specification/netapp/resource-manager/Microsoft.NetApp/stable/2023-05-01/examples/Volumes_Update.json
    [error] Cannot find module 'prettier/plugins/estree'
    [error] Require stack:
    [error] - /mnt/vss/_work/1/azure-rest-api-specs/eng/scripts/prettier-swagger-plugin.js
    [error] - /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/prettier@2.1.2/node_modules/prettier/index.js
    [error] - /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/prettier@2.1.2/node_modules/prettier/bin-prettier.js
    
    

    @weshaggard
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 2 pipeline(s).

    @audunn
    Copy link
    Member Author

    audunn commented Sep 8, 2023

    /pr RequestMerge

    @mentat9 mentat9 self-requested a review September 8, 2023 17:30
    @mentat9 mentat9 merged commit 00d7c13 into Azure:main Sep 8, 2023
    26 of 30 checks passed
    @openapi-pipeline-app
    Copy link

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    jnlycklama pushed a commit that referenced this pull request Nov 8, 2023
    * Adds base for updating Microsoft.NetApp from version stable/2022-11-01 to version 2023-05-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Add 2023-05-01 updates
    
    * delete unused examples
    
    * lint
    
    * remove default on unitpermission add missing smbAccessBasedEnumeration to volumePatchProperties
    
    * revert change on preview apiversion
    
    * remove default on unitpermission in volumePatchProperties
    
    * Format as arm-id
    
    * Format as arm-id
    
    * Format as arm-id3
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript Approved-SdkBreakingChange-Python ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript CI-FixRequiredOnFailure CI-MissingBaseCommit new-api-version resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.