-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release securityinsights microsoft.security insights 2023 08 01 preview #25370
Release securityinsights microsoft.security insights 2023 08 01 preview #25370
Conversation
…w/2023-07-01-preview to version 2023-08-01-preview
Next Steps to Merge |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
AlertRules.json | 2023-08-01-preview(3ddcc7a) | 2023-02-01(main) |
AlertRules.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
AutomationRules.json | 2023-08-01-preview(3ddcc7a) | 2023-02-01(main) |
AutomationRules.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
BillingStatistics.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
Bookmarks.json | 2023-08-01-preview(3ddcc7a) | 2023-02-01(main) |
Bookmarks.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
ContentPackages.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
ContentProductPackages.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
ContentProductTemplates.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
ContentTemplates.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
Enrichment.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
Entities.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
EntityQueries.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
EntityQueryTemplates.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
FileImports.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
Hunts.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
Incidents.json | 2023-08-01-preview(3ddcc7a) | 2023-02-01(main) |
Incidents.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
Metadata.json | 2023-08-01-preview(3ddcc7a) | 2023-02-01(main) |
Metadata.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
OfficeConsents.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
OnboardingStates.json | 2023-08-01-preview(3ddcc7a) | 2023-02-01(main) |
OnboardingStates.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
Recommendations.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
SecurityMLAnalyticsSettings.json | 2023-08-01-preview(3ddcc7a) | 2023-02-01(main) |
SecurityMLAnalyticsSettings.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
Settings.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
SourceControls.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
ThreatIntelligence.json | 2023-08-01-preview(3ddcc7a) | 2023-02-01(main) |
ThreatIntelligence.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
TriggeredAnalyticsRuleRuns.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
Watchlists.json | 2023-08-01-preview(3ddcc7a) | 2023-02-01(main) |
Watchlists.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
WorkspaceManagerAssignments.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
WorkspaceManagerConfigurations.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
WorkspaceManagerGroups.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
WorkspaceManagerMembers.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
AlertTypes.json | 2023-08-01-preview(3ddcc7a) | 2023-02-01(main) |
AlertTypes.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
ContentCommonTypes.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
EntityTypes.json | 2023-08-01-preview(3ddcc7a) | 2023-02-01(main) |
EntityTypes.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
IncidentTypes.json | 2023-08-01-preview(3ddcc7a) | 2023-02-01(main) |
IncidentTypes.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
RelationTypes.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
ThreatIntelligenceTypes.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
dataConnectorDefinitions.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
dataConnectors.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
operations.json | 2023-08-01-preview(3ddcc7a) | 2023-02-01(main) |
operations.json | 2023-08-01-preview(3ddcc7a) | 2023-07-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.4) | new version | base version |
---|---|---|
package-preview-2023-08 | package-preview-2023-08(3ddcc7a) | default(main) |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/Bookmarks.json#L566 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/EntityQueries.json#L484 |
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/EntityQueryTemplates.json#L234 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/EntityQueryTemplates.json#L292 |
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/Incidents.json#L1245 |
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/Incidents.json#L1332 |
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/operations.json#L83 |
UniqueXmsEnumName |
Must not have duplicate name of x-ms-enum extension , make sure every x-ms-enum name unique. The duplicate x-ms-enum name: priority, path: $['RecommendationPriority'] Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/Recommendations.json#L511 |
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get a template. Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/ContentTemplates.json#L148 |
|
OperationId should contain the verb: 'dataconnectorscheckrequirements' in:'DataConnectorsCheckRequirements_Post'. Consider updating the operationId Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/dataConnectors.json#L488 |
|
OperationId should contain the verb: 'gettimeline' in:'EntitiesGetTimeline_list'. Consider updating the operationId Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/Entities.json#L243 |
|
Based on the response model schema, operation 'Entities_Queries' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/Entities.json#L281 |
|
Based on the response model schema, operation 'SentinelOnboardingStates_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/OnboardingStates.json#L178 |
|
Based on the response model schema, operation 'GetRecommendations_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/Recommendations.json#L38 |
|
Based on the response model schema, operation 'ProductSettings_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/Settings.json#L38 |
|
The resource SourceControl does not have a corresponding delete operation. Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/SourceControls.json#L343 |
|
Based on the response model schema, operation 'ThreatIntelligenceIndicatorMetrics_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/ThreatIntelligence.json#L334 |
|
OperationId should contain the verb: 'jobs' in:'WorkspaceManagerAssignmentJobs_Create'. Consider updating the operationId Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/WorkspaceManagerAssignments.json#L297 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
Please address or respond to feedback from the ARM API reviewer. |
Hi @xuhumsft! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
Breaking changes previously reviewed and approved in #23121. |
Please get the breaking changes approved https://github.com/Azure/azure-rest-api-specs/pull/25370/checks?check_run_id=15987968800 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved for merging
@xuhumsft - Your PR needs to pass checks and address the CI-BreakingChange-Python-Track2 label before merge. Add the MergeRequested label back after addressing those items. If you get stuck, you can ask for help in the API Spec Review Teams channel: https://teams.microsoft.com/l/channel/19%3a0351f5f9404446e4b4fd4eaf2c27448d%40thread.skype/API%2520Spec%2520Review?groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47. Pinned comments on that channel identify help contacts for various SDKs. |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Swagger pipeline restarted successfully, please wait for status update in this comment. |
…ew (#25370) * Adds base for updating Microsoft.SecurityInsights from version preview/2023-07-01-preview to version 2023-08-01-preview * Updates readme * Updates API version in new specs and examples
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequested
is removed from your PR. This should cause the label
WaitForARMFeedback
to be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting help
section below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReview
label.Getting help
and https://aka.ms/ci-fix.