Add 2023-09-01-preview for appplatform #25501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3-07-01-preview to version 2023-09-01-preview
Co-authored-by: Yi Li <yili7@microsoft.com>
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
|
Hi @Sneezry, this service has enabled Service API Toolset. All spec updates MUST be initiated from service ADO project repo, so that to guarantee it to be the source of truth., please review this pull request if it's intentional or reject it if it's not expected. Normally, all the specification or example changes should start with PR created in ADO. |
Swagger Generation Artifacts
|
openapi-workflow-bot
bot
added
the
DoNotMerge
Generated ApiView
|
AzureRestAPISpecReview
added
ARMChangesRequested
|
Please address or respond to feedback from the ARM API reviewer. |
|
Hi @Sneezry! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
@mentat9: the |
* add API to list all server versions * refine list supported server version API * refine description --------- Co-authored-by: Yi Li <yili7@microsoft.com>
@mentat9 : Yes, it's a fixed set of value, but new value is added frequently, we don't want to use enum as we have to change Swagger API spec every time when a new value is added. A new API supportedServerVersions is introduced to list all the supported values and customers know the value for server version. |
@mentat9 Thanks for your review. I updated its type accordingly. |
* use enum for autoSync * rename enum * rename enum
yilims
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
mentat9
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
/pr RequestMerge |
Sneezry
removed
the
DoNotMerge
rkmanda
approved these changes
Sep 12, 2023
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
openapi-pipeline-app
bot
added
the
DoNotMerge
This was referenced Sep 12, 2023
jnlycklama
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Adds base for updating Microsoft.AppPlatform from version preview/2023-07-01-preview to version 2023-09-01-preview * Updates readme * Updates API version in new specs and examples * feat: fragment support swagger change (#25314) * Add apiTryOutEnabledState properties for api portal for 2023-09-01-preview api (#25322) * support war file deployment (#25312) Co-authored-by: Yi Li <yili7@microsoft.com> * Fix exmaple for api portal api try-out feature (#25337) * Add property `autoSync` in `KeyVaultCertificateProperties` (#25331) * Add gateway apm reference (#25408) * Add expand parameter for list deployment (#25411) * Add expand parameter for list deployments API (#25471) * change order of expand (#25587) * Update readme.go.md (#25634) * Update readme.go.md * Update readme.python.md * Update readme.ruby.md * Revert api portal try out feature (#25677) Fix exmaple for api portal api try-out feature (#25337)" * add API to list all server versions (#25720) * add API to list all server versions * refine list supported server version API * refine description --------- Co-authored-by: Yi Li <yili7@microsoft.com> * use enum for autoSync (#25722) * Update appplatform.json (#25724) * certificate - rename enum (#25723) * use enum for autoSync * rename enum * rename enum --------- Co-authored-by: guitarsheng <85543793+guitarsheng@users.noreply.github.com> Co-authored-by: Mason Chen <jiec@microsoft.com> Co-authored-by: Yi Li <109205537+yilims@users.noreply.github.com> Co-authored-by: Yi Li <yili7@microsoft.com> Co-authored-by: Jeff <1830237+domainname@users.noreply.github.com> Co-authored-by: ninpan-ms <71061174+ninpan-ms@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.