Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update typescript.md #25679

Merged
merged 1 commit into from
Sep 25, 2023
Merged

update typescript.md #25679

merged 1 commit into from
Sep 25, 2023

Conversation

kazrael2119
Copy link
Contributor

@kazrael2119 kazrael2119 requested a review from qiaozha as a code owner September 6, 2023 05:52
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 6, 2023

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 6, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
compared tags (via openapi-validator v2.1.4) new version base version
default default(6b360a7) default(main)
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 6, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking


azure-sdk-for-js - @azure/arm-managedapplications - Approved - 3.0.0
+	Enum KnownProvisioningState no longer has value Created
+	Enum KnownProvisioningState no longer has value Creating
+	Enum KnownProvisioningState no longer has value Ready
+	Interface ApplicationDefinitionsCreateOrUpdateByIdOptionalParams no longer has parameter resumeFrom
+	Interface ApplicationDefinitionsCreateOrUpdateByIdOptionalParams no longer has parameter updateIntervalInMs
+	Interface ApplicationDefinitionsCreateOrUpdateOptionalParams no longer has parameter resumeFrom
+	Interface ApplicationDefinitionsCreateOrUpdateOptionalParams no longer has parameter updateIntervalInMs
+	Interface ApplicationDefinitionsDeleteByIdOptionalParams no longer has parameter resumeFrom
+	Interface ApplicationDefinitionsDeleteByIdOptionalParams no longer has parameter updateIntervalInMs
+	Interface ApplicationDefinitionsDeleteOptionalParams no longer has parameter resumeFrom
+	Interface ApplicationDefinitionsDeleteOptionalParams no longer has parameter updateIntervalInMs
+	Interface ErrorResponse no longer has parameter errorCode
+	Interface ErrorResponse no longer has parameter errorMessage
+	Interface ErrorResponse no longer has parameter httpStatus
+	Interface GenericResource no longer has parameter identity
+	Parameter name of interface ApplicationArtifact is now required
+	Parameter type of interface ApplicationArtifact is now required
+	Parameter uri of interface ApplicationArtifact is now required
+	Removed operation ApplicationDefinitions.beginCreateOrUpdate
+	Removed operation ApplicationDefinitions.beginCreateOrUpdateAndWait
+	Removed operation ApplicationDefinitions.beginCreateOrUpdateById
+	Removed operation ApplicationDefinitions.beginCreateOrUpdateByIdAndWait
+	Removed operation ApplicationDefinitions.beginDelete
+	Removed operation ApplicationDefinitions.beginDeleteAndWait
+	Removed operation ApplicationDefinitions.beginDeleteById
+	Removed operation ApplicationDefinitions.beginDeleteByIdAndWait
+	Removed operation Applications.update
+	Removed operation Applications.updateById
+	Type of parameter artifacts of interface ApplicationDefinition is changed from ApplicationArtifact[] to ApplicationDefinitionArtifact[]
+	Type of parameter authorizations of interface ApplicationDefinition is changed from ApplicationProviderAuthorization[] to ApplicationAuthorization[]
+	Type of parameter isEnabled of interface ApplicationDefinition is changed from string to boolean
+	Type of parameter name of interface ApplicationArtifact is changed from string to ApplicationArtifactName
+	Type of parameter parameters of interface ApplicationsUpdateByIdOptionalParams is changed from Application to ApplicationPatchable
+	Type of parameter type of interface Identity is changed from "SystemAssigned" to ResourceIdentityType
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 06479e8. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh]  notice
    cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.6.7 -> 10.1.0
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.1.0` to update!
    cmderr	[automation_generate.sh] npm notice
    warn	No file changes detected after generation
    warn	No package detected after generation
️⚠️ azure-sdk-for-java warning [Detail]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 06479e8. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/solutions/armmanagedapplications [View full logs]  [Release SDK Changes]
    info	[Changelog] ### Other Changes
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 06479e8. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    cmderr	[automation_generate.sh] [ERROR] Cannot generate changelog because the codes of local and npm may be the same.
  • ️✔️@azure/arm-managedapplications [View full logs]  [Release SDK Changes]
    info	[Changelog]
    error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
️❌ azure-powershell failed [Detail]
  • Pipeline Framework Failed [Logs]Release - Generate from 06479e8. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    SSL error: syscall failure: Broken pipe
    Error: SSL error: syscall failure: Broken pipe
  • ⚠️Az.solutions.DefaultTag [View full logs
    error	Fatal error: SSL error: syscall failure: Broken pipe
    error	The following packages are still pending:
    error		Az.solutions.DefaultTag
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 6, 2023

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/solutions/armmanagedapplications https://apiview.dev/Assemblies/Review/04c9590046624902ba6242f9b9dd5c5d
Java azure-resourcemanager-managedapplications There is no API change compared with the previous version
JavaScript @azure/arm-managedapplications https://apiview.dev/Assemblies/Review/275a8dad86b44b0b89908c4e674cb0f2

Copy link
Member

@rkmanda rkmanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 16, 2023
@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 16, 2023
Copy link
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems Python and Java already switch from multi-api to single one so JS would follow this same rule.

@MaryGao MaryGao merged commit 06479e8 into Azure:main Sep 25, 2023
29 of 30 checks passed
@openapi-pipeline-app
Copy link

Swagger pipeline restarted successfully, please wait for status update in this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-SdkBreakingChange-JavaScript ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-JavaScript ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants